Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: Source/WebCore/ChangeLog

Issue 7210023: Merge 88386 - 2011-06-08 John Bauman <jbauman@chromium.org> (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/782/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 2011-06-19 Mads Ager <ager@chromium.org>
2
3 Reviewed by Adam Barth.
4
5 [V8] Fix WebGL bindings for subarrays
6 https://bugs.webkit.org/show_bug.cgi?id=62864
7
8 Mark WebGL subarrays as independent of other DOM objects in the
9 V8 bindings. This allows us to clean them up independently which
10 greatly improves performance.
11
12 * bindings/v8/V8Proxy.h:
13 (WebCore::toV8Independent):
14 * bindings/v8/custom/V8ArrayBufferViewCustom.h:
15 (WebCore::constructWebGLArrayWithArrayBufferArgument):
16 (WebCore::constructWebGLArray):
17
18 2011-06-20 Yuta Kitamura <yutak@chromium.org>
19
20 Unreviewed build fix for Chromium Clang builders.
21
22 * platform/graphics/FontFallbackList.h: Declare SVGTextRunRenderingConte xt as class, not struct.
23
24 2011-06-20 MORITA Hajime <morrita@google.com>
25
26 Unreviewed GTK build fix.
27 This change touched the file to make the build happen.
28
29 * dom/EventTarget.cpp:
30
31 2011-06-20 Nikolas Zimmermann <nzimmermann@rim.com>
32
33 Reviewed by Rob Buis.
34
35 Integrate SVG Fonts within GlyphPage concept, removing the special SVG c ode paths from Font, making it possible to reuse the simple text code path for S VG Fonts
36 https://bugs.webkit.org/show_bug.cgi?id=59085
37
38 font substitution doesn't work for HTML text using SVG fonts
39 https://bugs.webkit.org/show_bug.cgi?id=17608
40
41 Selection rects are wrong for text with SVG fonts
42 https://bugs.webkit.org/show_bug.cgi?id=25460
43
44 With @font-face, SVG fonts only work as primary, non-segmented
45 https://bugs.webkit.org/show_bug.cgi?id=32227
46
47 When using SVG fonts with @font-face word-spacing and text-align: justif y are not being honored
48 https://bugs.webkit.org/show_bug.cgi?id=34236
49
50 SVG @font-face breaks text-overflow: ellipsis
51 https://bugs.webkit.org/show_bug.cgi?id=36840
52
53 REGRESSION: SVG Font selection problems
54 https://bugs.webkit.org/show_bug.cgi?id=41934
55
56 Tests: svg/custom/svg-fonts-fallback.xhtml (for bug 17608, extended the original test from Mark Ambachtsheer)
57 svg/custom/svg-fonts-segmented.xhtml (for bug 32227)
58 svg/custom/svg-fonts-word-spacing.html (for bug 34236, from Micha el Lewis)
59 svg/text/select-text-svgfont.html (for bug 25460/41934, from Emil Schutte)
60 svg/text/text-overflow-ellipsis-svgfont.html (for 36840, from Emi l Schutte)
61
62 Rewrite the SVG Fonts support to fully integrate within the GlyphPage co ncept and the "simple" code path used to render platform fonts.
63 That means the special logic for measuring text using SVG Fonts, calcula ting offset for positions, computing selection rects etc. is all gone now.
64 There's no difference anymore between using a native font or a SVG Font, in terms of these operations.
65
66 This makes text selection using SVG Fonts possible again.
67
68 * features.pri: Temporarily turn of SVG Fonts for Qt, as long as QRawFon t support is not available and the fast path is disabled.
69 * page/DOMWindow.idl: Touched file to force Qt regenerating the bindings .
70 * platform/graphics/Font.cpp: Remove SVG Font special cases, the simple code path now handles SVG Fonts as well.
71 (WebCore::Font::drawText):
72 (WebCore::Font::drawEmphasisMarks):
73 (WebCore::Font::width):
74 (WebCore::Font::selectionRectForText):
75 (WebCore::Font::offsetForPosition):
76 (WebCore::Font::codePath):
77 * platform/graphics/Font.h: Pass TextRun to drawGlyphBuffer/drawEmphasis Marks. Add new glyphDataAndPageForCharacter() method which returns a pair
78 std::pair<GlyphData, GlyphPage*>, so we know the associated GlyphPage for a certain GlyphData object, which is needed to pro perly
79 handle font fallback glyph matching for SVG Fonts..
80 (WebCore::Font::fontList): Add FontFallbackList accessor.
81 * platform/graphics/FontFallbackList.h: Add getters/setters for glyphPag eZero -- SVG Fonts support needs access to these objects from SVGTextRunRenderin gContext.
82 (WebCore::FontFallbackList::glyphPageZero):
83 (WebCore::FontFallbackList::glyphPages):
84 (WebCore::FontFallbackList::setGlyphPageZero):
85 (WebCore::FontFallbackList::setGlyphPages):
86 * platform/graphics/FontFastPath.cpp:
87 (WebCore::Font::glyphDataForCharacter): Move implementation to glyphData AndPageForCharacter(), and use that method from here.
88 (WebCore::Font::glyphDataAndPageForCharacter): Does the same as before, just returns an additional GlyphPage* pointer.
89 (WebCore::Font::getEmphasisMarkGlyphData): Remove SVG Fonts special case .
90 (WebCore::Font::drawGlyphBuffer): Ditto.
91 * platform/graphics/FontMetrics.h:
92 (WebCore::scaleEmToUnits): Refactored scaleEmToUnits free function from SimpleFontDataMac/CGWin to share with SVGFontData/SVGTextRunRenderingContext.
93 * platform/graphics/GlyphPageTreeNode.cpp:
94 (WebCore::fill): Stop skipping SVG Fonts, they now also fill the GlyphPa ge using the glyphs defined in the SVG Font.
95 * platform/graphics/SVGGlyph.h: s/isValid/isPartOfLigature/. Its usage h as been changed.
96 (WebCore::SVGGlyph::SVGGlyph):
97 (WebCore::SVGGlyph::operator==):
98 * platform/graphics/SimpleFontData.cpp: Change font size to be a float, not an int.
99 (WebCore::SimpleFontData::SimpleFontData):
100 * platform/graphics/SimpleFontData.h: Add new pure virtual methods to th e AdditionalFontData interface, to be implemented in SVGFontData.
101 (WebCore::SimpleFontData::widthForGlyph): Call widthForSVGGlyph, if we e ncounter a SVG glyph.
102 * platform/graphics/TextRun.h:
103 * platform/graphics/WidthIterator.cpp:
104 (WebCore::WidthIterator::glyphDataForCharacter):
105 (WebCore::WidthIterator::advance):
106 * platform/graphics/WidthIterator.h: Store several new members needed fo r SVG Fonts support (last processed glyph name used for kerning pair lookup)
107 and a map mapping each character of a text to its arabic-form (if needed, to perform SVG glyph selection for Arabic text).
108 (WebCore::WidthIterator::run):
109 (WebCore::WidthIterator::runWidthSoFar):
110 (WebCore::WidthIterator::lastGlyphName):
111 (WebCore::WidthIterator::setLastGlyphName):
112 (WebCore::WidthIterator::arabicForms):
113 * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Use new scal eEmToUnits free function from FontMetrics.h.
114 * platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
115 * platform/graphics/win/SimpleFontDataCGWin.cpp: Ditto.
116 * rendering/svg/SVGTextMetrics.cpp:
117 (WebCore::SVGTextMetrics::SVGTextMetrics):
118 (WebCore::constructTextRun):
119 (WebCore::SVGTextMetrics::measureCharacterRange):
120 * rendering/svg/SVGTextMetrics.h:
121 * rendering/svg/SVGTextRunRenderingContext.cpp: Remove drawTextUsingSVGF ont/floatWidthUsingSVGFont/selectionRectForTextUsingSVGFont/offsetForPositionFor TextUsingSVGFont.
122 (WebCore::firstParentRendererForNonTextNode): Don't assert node() exists , doesn't hold true for generated render objects.
123 (WebCore::renderObjectFromRun): Renamed from referencingRenderObjectFrom Run.
124 (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): Remove ex tra "extraCharsAvailable" parameter, now solves via TextRun::charactersLength().
125 (WebCore::calculateEmUnitToPixelScaleFactor): Add helper method.
126 (WebCore::SVGTextRunRenderingContext::drawSVGGlyphs): Main drawing metho d, this actually creates/renders Paths.
127 (WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Part 1/2 o f SVG Glyph selection code.
128 * rendering/svg/SVGTextRunRenderingContext.h:
129 * svg/SVGAltGlyphElement.cpp:
130 (WebCore::SVGAltGlyphElement::hasValidGlyphElement):
131 * svg/SVGAltGlyphElement.h:
132 * svg/SVGFontData.cpp:
133 (WebCore::calculateEmUnitToPixelScaleFactor): Add helper method.
134 (WebCore::SVGFontData::initializeFontData): Changed font size from int t o float.
135 (WebCore::SVGFontData::widthForSVGGlyph): Lookup a SVGGlyph from a Glyph using the glyph table in SVGFontElement and calculate its width.
136 (WebCore::SVGFontData::applySVGGlyphSelection): Part 2/2 of SVG Glyph se lection code.
137 (WebCore::SVGFontData::fillSVGGlyphPage): Fill GlyphPage using glyphs de fined in the SVG Font.
138 * svg/SVGFontData.h:
139 * svg/SVGFontElement.cpp:
140 (WebCore::SVGFontElement::registerLigaturesInGlyphCache): Enable ligatur e registration for the use within GlyphPage.
141 (WebCore::SVGFontElement::ensureGlyphCache):
142 * svg/SVGGlyphMap.h:
143 (WebCore::SVGGlyphMap::addGlyphByUnicodeString): Remove setting isValid, it's not needed anymore and gone.
144 * svg/svgtags.in: Surround vkern in ENABLE_SVG_FONTS block.
145
146 2011-06-19 MORITA Hajime <morrita@google.com>
147
148 Reviewed by Dimitri Glazkov.
149
150 The internals object should have createShadowContentElement()
151 https://bugs.webkit.org/show_bug.cgi?id=62432
152
153 This change:
154 - added Internals::createShadowContentElement(), which creates,
155 ShadowContentElement instance which includes all host children,
156 - added Internals::elementRenderTreeAsText() to help content layout test ing, and
157 - Unabstracted ShadowContentElement by giving a default shouldInclude() implementation.
158
159 Test: fast/dom/shadow/create-content-element.html
160
161 * WebCore.exp.in:
162 * dom/ShadowContentElement.cpp:
163 (WebCore::ShadowContentElement::create): Added.
164 (WebCore::ShadowContentElement::ShadowContentElement):
165 (WebCore::ShadowContentElement::~ShadowContentElement):
166 (WebCore::ShadowContentElement::shouldInclude): Gave a default implement ation which always returns true.
167 * dom/ShadowContentElement.h:
168 * html/HTMLSummaryElement.cpp:
169 (WebCore::SummaryContentElement::SummaryContentElement):
170 * rendering/RenderTreeAsText.cpp:
171 (WebCore::externalRepresentation): Factored out for supportin per-elemen t render tree dump.
172 * rendering/RenderTreeAsText.h:
173 * testing/Internals.cpp:
174 (WebCore::Internals::createShadowContentElement): Added.
175 (WebCore::Internals::elementRenderTreeAsText): dded.
176 * testing/Internals.h:
177 * testing/Internals.idl:
178
179 2011-06-19 Keishi Hattori <keishi@webkit.org>
180
181 Reviewed by Kent Tamura.
182
183 Clicking indeterminate checkbox should flip checkedness state
184 https://bugs.webkit.org/show_bug.cgi?id=62262
185
186 Test: fast/forms/checkbox-click-indeterminate.html
187
188 * html/CheckboxInputType.cpp:
189 (WebCore::CheckboxInputType::willDispatchClick): Changed to flip checked flag when indeterminate.
190
191 2011-06-19 Adam Bergkvist <adam.bergkvist@ericsson.com>
192
193 Reviewed by Martin Robinson.
194
195 [GTK] Enable Media Stream feature and make it default on
196 https://bugs.webkit.org/show_bug.cgi?id=60394
197
198 * GNUmakefile.am:
199
200 2011-06-19 Una Sabovic <una.sabovic@palm.com>
201
202 Reviewed by Darin Adler.
203
204 Optimization: avoid call to clearRect() when bgColor is valid when paint ing the root background in RenderBoxModelObject::paintFillLayerExtended
205 https://bugs.webkit.org/show_bug.cgi?id=62908
206
207 When root layers base color is fully transparent backgroundRect was clea red before bgColor is applied.
208 Instead of clearing the rect we apply CompositeCopy operation when paint ing the background color.
209
210 No new tests. This is an optimization, it doesn't change any existing fu nctionality.
211
212 * platform/graphics/GraphicsContext.cpp:
213 (WebCore::GraphicsContext::fillRect):
214 * platform/graphics/GraphicsContext.h:
215 * rendering/RenderBoxModelObject.cpp:
216 (WebCore::RenderBoxModelObject::paintFillLayerExtended):
217
218 2011-06-19 Dirk Schulze <krit@webkit.org>
219
220 Reviewed by Nikolas Zimmermann.
221
222 SVGAnimatorFactory does not support SVGNumber
223 https://bugs.webkit.org/show_bug.cgi?id=62938
224
225 Follow up of "SVGAnimation should use direct unit animation for SVGLengt h": https://bugs.webkit.org/show_bug.cgi?id=61368
226 This patch continues the conversion to the new concept of SVGAnimatorFac tory with SVGNumber. With the new animator for the
227 With the new animator for SVGNumber we also support the scientific notat ion, and everything else that's supported by
228 the SVGNumber parsing, removing the SVGAnimate* specific number parsing functionality.
229
230 Moving the content of SVGAnimatedType header into its own cpp.
231
232 Changed behavior of parseNumberFromString(). It checks if the String sim ply consits of a number now. parseNumberFromString()
233 is using genericParseNumber() for parsing numbers. But this method just stops at the first char that does not belong to a number and
234 returns true. I added a check if the current char pointer is at the last char of the String and return false if not.
235
236 Tests: svg/animations/svgnumber-animation-1.html
237 svg/animations/svgnumber-animation-2.html
238 svg/animations/svgnumber-animation-3.html
239
240 * CMakeLists.txt: Added new files to build system.
241 * GNUmakefile.list.am: Ditto.
242 * WebCore.gypi: Ditto.
243 * WebCore.pro: Ditto.
244 * WebCore.xcodeproj/project.pbxproj: Ditto.
245 * svg/SVGAllInOne.cpp: Ditto.
246 * svg/SVGAnimateElement.cpp: Use SVGAnimatedNumberAnimator for animation s of SVGNumbers.
247 (WebCore::SVGAnimateElement::SVGAnimateElement):
248 (WebCore::SVGAnimateElement::calculateAnimatedValue):
249 (WebCore::SVGAnimateElement::calculateFromAndToValues):
250 (WebCore::SVGAnimateElement::calculateFromAndByValues):
251 (WebCore::SVGAnimateElement::resetToBaseValue):
252 (WebCore::SVGAnimateElement::applyResultsToTarget):
253 (WebCore::SVGAnimateElement::calculateDistance):
254 * svg/SVGAnimateElement.h: Remove floats for value storage. This is done by SVGAnimatedTypes now.
255 * svg/SVGAnimatedNumber.cpp: Added. Animator for SVGNumbers.
256 (WebCore::SVGAnimatedNumberAnimator::SVGAnimatedNumberAnimator):
257 (WebCore::SVGAnimatedNumberAnimator::constructFromString):
258 (WebCore::SVGAnimatedNumberAnimator::calculateFromAndToValues):
259 (WebCore::SVGAnimatedNumberAnimator::calculateFromAndByValues):
260 (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):
261 (WebCore::SVGAnimatedNumberAnimator::calculateDistance):
262 * svg/SVGAnimatedNumber.h:
263 (WebCore::SVGAnimatedNumberAnimator::~SVGAnimatedNumberAnimator):
264 * svg/SVGAnimatedType.cpp: Added. Moved content from header to cpp.
265 (WebCore::SVGAnimatedType::SVGAnimatedType):
266 (WebCore::SVGAnimatedType::~SVGAnimatedType):
267 (WebCore::SVGAnimatedType::createAngle):
268 (WebCore::SVGAnimatedType::createLength):
269 (WebCore::SVGAnimatedType::createNumber):
270 (WebCore::SVGAnimatedType::angle):
271 (WebCore::SVGAnimatedType::length):
272 (WebCore::SVGAnimatedType::number):
273 (WebCore::SVGAnimatedType::valueAsString):
274 (WebCore::SVGAnimatedType::setValueAsString):
275 * svg/SVGAnimatedType.h: Removed method create(). Allways call type spec ific create funtcions.
276 * svg/SVGAnimatorFactory.h:
277 (WebCore::SVGAnimatorFactory::create):
278 * svg/SVGParserUtilities.cpp:
279 (WebCore::parseNumberFromString): Check if String simply consits of a nu mber. Return false otherwise.
280
281 2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
282
283 Reviewed by Darin Adler.
284
285 Separate concerns of loading file icons and choosing files.
286 https://bugs.webkit.org/show_bug.cgi?id=62931
287
288 Loading an icon and choosing files have similar async nature, but comple tely different
289 lifetimes: FileChooser should only exist when we are actually attempting to choose a file,
290 not anytime we need to render an input with a proper icon.
291
292 This patch introduces FileIconLoader, a separate abstraction for loading an icon, and removes
293 any notion of an icon from the FileChooser.
294
295 Also, the loaded icon is now stored on the RenderFileUploadControl, whic h better matches its
296 purpose.
297
298 Refactoring, covered by existing tests.
299
300 * CMakeLists.txt: Added FileIconLoader to build system.
301 * GNUmakefile.list.am: Ditto.
302 * WebCore.exp.in: Updated.
303 * WebCore.gypi: Added FileIconLoader to build system.
304 * WebCore.pro: Ditto.
305 * WebCore.vcproj/WebCore.vcproj: Ditto.
306 * WebCore.xcodeproj/project.pbxproj: Ditto.
307 * loader/EmptyClients.h: Updated.
308 (WebCore::EmptyChromeClient::loadIconForFiles): Renamed function to bett er reflect what it does.
309 * page/Chrome.cpp:
310 (WebCore::Chrome::loadIconForFiles): Ditto.
311 * page/Chrome.h: Ditto.
312 * page/ChromeClient.h: Ditto.
313 * platform/FileChooser.cpp:
314 (WebCore::FileChooser::FileChooser): Removed now-unnecessary bool.
315 (WebCore::FileChooser::create): Removed the tangled web.
316 (WebCore::FileChooser::clear): Removed icon-related code.
317 (WebCore::FileChooser::chooseFiles): Ditto.
318 * platform/FileChooser.h:
319 * platform/FileIconLoader.cpp: Copied from Source/WebCore/platform/FileC hooser.cpp.
320 (WebCore::FileIconLoaderClient::~FileIconLoaderClient): Added.
321 (WebCore::FileIconLoader::create): Added.
322 (WebCore::FileIconLoader::disconnectClient): Added.
323 (WebCore::FileIconLoader::notifyFinished): Added.
324 (WebCore::FileIconLoader::FileIconLoader): Added.
325 * platform/FileIconLoader.h: Copied from Source/WebCore/platform/FileCho oser.cpp.
326 * rendering/RenderFileUploadControl.cpp:
327 (WebCore::RenderFileUploadControl::RenderFileUploadControl): Added new m ember initializations.
328 (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Added File IconLoader disconnect.s
329 (WebCore::RenderFileUploadControl::requestIcon): Added a helper.
330 (WebCore::RenderFileUploadControl::valueChanged): Changed to request an icon load.
331 (WebCore::RenderFileUploadControl::updateRendering): Added implementatio n of FileIconLoaderClient func.
332 (WebCore::RenderFileUploadControl::updateFromElement): Added clearing of icon.
333 (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use new member directly.
334 (WebCore::RenderFileUploadControl::paintObject): Ditto.
335 (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
336 * rendering/RenderFileUploadControl.h: Updated decls.
337
338 2011-06-19 Michael Saboff <msaboff@apple.com>
339
340 Reviewed by Darin Adler.
341
342 Add notify handler to trigger MemoryPressureHandler in all builds
343 https://bugs.webkit.org/show_bug.cgi?id=62679
344
345 Removed SIGUSR2 trigger and added a notify trigger for the
346 MemoryPressureHandler. The notify trigger is enabled for all builds.
347
348 No test added as only added new memory pressure trigger.
349
350 * platform/mac/MemoryPressureHandlerMac.mm:
351 (WebCore::MemoryPressureHandler::install):
352
353 2011-06-19 Robert Hogan <robert@webkit.org>
354
355 Reviewed by Alexey Proskuryakov.
356
357 [Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
358 https://bugs.webkit.org/show_bug.cgi?id=62514
359
360 * platform/network/qt/ResourceHandleQt.cpp:
361 (WebCore::WebCoreSynchronousLoader::willSendRequest):
362
363 2011-06-18 Yufeng Shen <miletus@chromium.org>
364
365 Reviewed by Darin Fisher.
366
367 Adding "force" filed to Touch Event
368 https://bugs.webkit.org/show_bug.cgi?id=62766
369
370 * dom/Document.cpp:
371 (WebCore::Document::createTouch):
372 * dom/Document.h:
373 * dom/Document.idl:
374 * dom/Touch.cpp:
375 (WebCore::Touch::Touch):
376 * dom/Touch.h:
377 (WebCore::Touch::create):
378 (WebCore::Touch::webkitForce):
379 * dom/Touch.idl:
380 * page/EventHandler.cpp:
381 (WebCore::EventHandler::handleTouchEvent):
382 * platform/PlatformTouchPoint.h:
383 (WebCore::PlatformTouchPoint::force):
384
385 2011-06-18 Jer Noble <jer.noble@apple.com>
386
387 Reviewed by Darin Adler.
388
389 Rename Document::setContainsFullScreenElementRecursively
390 https://bugs.webkit.org/show_bug.cgi?id=62528
391
392 No new tests; no net change in functionality, so this is covered by exis ting tests.
393
394 The name of setContainsFullScreenElementRecursively is confusing, since it doesn't actually use
395 recursion, and it walks the ancestor tree instead of the descendent tree (as recursive might
396 otherwise imply). Move the function into Element, turn it into a member function, and change
397 the behavior so that the function operates on the called object's parent s (as opposed to the
398 object itself).
399
400 * dom/Element.h:
401 * dom/Element.cpp:
402 (WebCore::parentCrossingFrameBoundaries): Added.
403 (WebCore::Element::setContainsFullScreenElementOnAncestorsCrossingFrameB oundaries): Renamed and
404 moved from Document.
405 (WebCore::Element::willRemove): Use the newly renamed function.
406 (WebCore::Element::insertedIntoTree): Ditto.
407 * dom/Document.h:
408 * dom/Document.cpp:
409 (WebCore::Document::webkitWillEnterFullScreenForElement): Ditto.
410 (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
411 (WebCore::Document::fullScreenElementRemoved): Ditto.
412
413 2011-06-18 Alice Boxhall <aboxhall@chromium.org>
414
415 Reviewed by Chris Fleizach.
416
417 Accessibility description for an element should make use of aria-labelle dby.
418 https://bugs.webkit.org/show_bug.cgi?id=61995
419
420 Tests: accessibility/aria-labelledby-overrides-aria-label.html
421
422 * accessibility/AccessibilityRenderObject.cpp:
423 (WebCore::AccessibilityRenderObject::title): Don't return value from ari a-labelledby.
424 (WebCore::AccessibilityRenderObject::ariaAccessibilityDescription): Retu rn value from aria-labelledby in preference to value from aria-label.
425
426 2011-06-18 Christoph Mende <mende.christoph@gmail.com>
427
428 Reviewed by Darin Adler.
429
430 compilation fails with libpng-1.5
431 https://bugs.webkit.org/show_bug.cgi?id=61738
432
433 * platform/image-encoders/skia/PNGImageEncoder.cpp:
434 (WebCore::writeOutput): Use getter function instead of direct access
435
436 2011-06-18 Jeremy Moskovich <jeremy@chromium.org>
437
438 Reviewed by Eric Seidel.
439
440 Set text-align:-webkit-match-parent for li elements in the default style sheet.
441 https://bugs.webkit.org/show_bug.cgi?id=57232
442
443 Test: fast/css/list-item-text-align.html
444
445 * css/html.css:
446 (li): Specify text-align:-webkit-match-parent .
447
448 2011-06-18 Holger Hans Peter Freyther <holger@moiji-mobile.com>
449
450 Reviewed by Brent Fulgham.
451
452 [misc] JSC/wtf/text/*.h should not be included via #include ""
453 https://bugs.webkit.org/show_bug.cgi?id=60836
454
455 Adam Barth pointed out that one should not include files from
456 JavaScriptCore/wtf/text using #include "File.h". This change
457 is addressing it.
458
459 * CMakeListsEfl.txt: Remove JavaScriptCore/wtf/text.
460 * CMakeListsWinCE.txt: Remove JavaScriptCore/wtf/text.
461 * platform/graphics/freetype/FontCacheFreeType.cpp: Change CString.h inc lude.
462 * platform/graphics/pango/FontCachePango.cpp: Change CString.h include.
463 * platform/graphics/wx/FontPlatformData.h: Change StringImpl.h include.
464 * platform/network/soup/ResourceHandleSoup.cpp: Change CString.h include .
465 * platform/network/soup/SocketStreamHandleSoup.cpp: Change CString.h inc lude.
466
467 2011-06-18 Sam Weinig <sam@webkit.org>
468
469 Reviewed by Darin Adler.
470
471 REGRESSION (r63854-63958): placeholder not shown for number inputs
472 https://bugs.webkit.org/show_bug.cgi?id=61095
473
474 Refactor HTMLInputElement supportsPlaceholder support to delegate to the
475 InputType. Make BaseTextInputType and NumberInputType return true, match ing
476 the current HTML5 spec.
477
478 * html/BaseTextInputType.cpp:
479 (WebCore::BaseTextInputType::supportsPlaceholder):
480 * html/BaseTextInputType.h:
481 Add override implementation of supportsPlaceholder that returns true.
482
483 * html/HTMLInputElement.cpp:
484 (WebCore::HTMLInputElement::supportsPlaceholder):
485 Delegate to the InputType.
486
487 * html/InputType.cpp:
488 (WebCore::InputType::supportsPlaceholder):
489 * html/InputType.h:
490 Add base implementation of supportsPlaceholder that returns false.
491
492 * html/NumberInputType.cpp:
493 (WebCore::NumberInputType::supportsPlaceholder):
494 * html/NumberInputType.h:
495 Add override implementation of supportsPlaceholder that returns true.
496
497 2011-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
498
499 Unreviewed, rolling out r89154.
500 http://trac.webkit.org/changeset/89154
501 https://bugs.webkit.org/show_bug.cgi?id=62926
502
503 It broke debug build on Qt (Requested by Ossy_weekend on
504 #webkit).
505
506 * platform/network/qt/ResourceHandleQt.cpp:
507
508 2011-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
509
510 Unreviewed, rolling out r89189.
511 http://trac.webkit.org/changeset/89189
512 https://bugs.webkit.org/show_bug.cgi?id=62925
513
514 It broke Qt build (Requested by Ossy_weekend on #webkit).
515
516 * bindings/scripts/test/TestInterface.idl:
517 * bindings/scripts/test/TestSerializedScriptValueInterface.idl:
518 * css/CSSCharsetRule.idl:
519 * css/CSSFontFaceRule.idl:
520 * css/CSSImportRule.idl:
521 * css/CSSPageRule.idl:
522 * css/CSSRule.idl:
523 * css/CSSStyleRule.idl:
524 * css/CSSUnknownRule.idl:
525 * css/CSSValue.idl:
526 * css/Counter.idl:
527 * css/RGBColor.idl:
528 * css/Rect.idl:
529 * css/StyleSheet.idl:
530 * css/WebKitCSSKeyframeRule.idl:
531 * css/WebKitCSSTransformValue.idl:
532 * dom/Attr.idl:
533 * dom/CDATASection.idl:
534 * dom/ClientRect.idl:
535 * dom/Comment.idl:
536 * dom/DOMCoreException.idl:
537 * dom/DOMStringMap.idl:
538 * dom/DocumentType.idl:
539 * dom/Entity.idl:
540 * dom/EntityReference.idl:
541 * dom/EventException.idl:
542 * dom/GeneratedStream.idl:
543 * dom/MessageChannel.idl:
544 * dom/NodeIterator.idl:
545 * dom/Notation.idl:
546 * dom/ProcessingInstruction.idl:
547 * dom/RangeException.idl:
548 * dom/Touch.idl:
549 * dom/TreeWalker.idl:
550 * fileapi/DOMFileSystem.idl:
551 * fileapi/DOMFileSystemSync.idl:
552 * fileapi/DirectoryReaderSync.idl:
553 * fileapi/File.idl:
554 * fileapi/FileEntrySync.idl:
555 * fileapi/FileError.idl:
556 * fileapi/FileException.idl:
557 * fileapi/Metadata.idl:
558 * fileapi/OperationNotAllowedException.idl:
559 * fileapi/WebKitFlags.idl:
560 * html/DOMSettableTokenList.idl:
561 * html/HTMLAppletElement.idl:
562 * html/HTMLAreaElement.idl:
563 * html/HTMLBRElement.idl:
564 * html/HTMLBaseElement.idl:
565 * html/HTMLBaseFontElement.idl:
566 * html/HTMLBlockquoteElement.idl:
567 * html/HTMLBodyElement.idl:
568 * html/HTMLDListElement.idl:
569 * html/HTMLDataListElement.idl:
570 * html/HTMLDetailsElement.idl:
571 * html/HTMLDirectoryElement.idl:
572 * html/HTMLEmbedElement.idl:
573 * html/HTMLFontElement.idl:
574 * html/HTMLFormElement.idl:
575 * html/HTMLFrameElement.idl:
576 * html/HTMLFrameSetElement.idl:
577 * html/HTMLHRElement.idl:
578 * html/HTMLHeadElement.idl:
579 * html/HTMLHeadingElement.idl:
580 * html/HTMLHtmlElement.idl:
581 * html/HTMLIFrameElement.idl:
582 * html/HTMLImageElement.idl:
583 * html/HTMLIsIndexElement.idl:
584 * html/HTMLLIElement.idl:
585 * html/HTMLLabelElement.idl:
586 * html/HTMLLegendElement.idl:
587 * html/HTMLLinkElement.idl:
588 * html/HTMLMapElement.idl:
589 * html/HTMLMarqueeElement.idl:
590 * html/HTMLMenuElement.idl:
591 * html/HTMLMetaElement.idl:
592 * html/HTMLMeterElement.idl:
593 * html/HTMLModElement.idl:
594 * html/HTMLOListElement.idl:
595 * html/HTMLOptGroupElement.idl:
596 * html/HTMLOptionElement.idl:
597 * html/HTMLParagraphElement.idl:
598 * html/HTMLParamElement.idl:
599 * html/HTMLPreElement.idl:
600 * html/HTMLProgressElement.idl:
601 * html/HTMLQuoteElement.idl:
602 * html/HTMLScriptElement.idl:
603 * html/HTMLSourceElement.idl:
604 * html/HTMLStyleElement.idl:
605 * html/HTMLTableCaptionElement.idl:
606 * html/HTMLTableCellElement.idl:
607 * html/HTMLTableColElement.idl:
608 * html/HTMLTitleElement.idl:
609 * html/HTMLTrackElement.idl:
610 * html/HTMLUListElement.idl:
611 * html/ImageData.idl:
612 * html/MediaError.idl:
613 * html/SpellcheckRange.idl:
614 * html/TextMetrics.idl:
615 * html/ValidityState.idl:
616 * html/VoidCallback.idl:
617 * html/canvas/ArrayBuffer.idl:
618 * html/canvas/ArrayBufferView.idl:
619 * html/canvas/CanvasPattern.idl:
620 * html/canvas/CanvasPixelArray.idl:
621 * html/canvas/CanvasRenderingContext.idl:
622 * html/canvas/DataView.idl:
623 * html/canvas/OESStandardDerivatives.idl:
624 * html/canvas/OESTextureFloat.idl:
625 * html/canvas/WebGLActiveInfo.idl:
626 * html/canvas/WebGLBuffer.idl:
627 * html/canvas/WebGLContextAttributes.idl:
628 * html/canvas/WebGLFramebuffer.idl:
629 * html/canvas/WebGLProgram.idl:
630 * html/canvas/WebGLRenderbuffer.idl:
631 * html/canvas/WebGLShader.idl:
632 * html/canvas/WebGLTexture.idl:
633 * html/canvas/WebGLUniformLocation.idl:
634 * html/canvas/WebGLVertexArrayObjectOES.idl:
635 * html/canvas/WebKitLoseContext.idl:
636 * inspector/ScriptProfile.idl:
637 * inspector/ScriptProfileNode.idl:
638 * page/AbstractView.idl:
639 * page/BarInfo.idl:
640 * page/Coordinates.idl:
641 * page/Geoposition.idl:
642 * page/MemoryInfo.idl:
643 * page/NavigatorUserMediaError.idl:
644 * page/Performance.idl:
645 * page/PerformanceNavigation.idl:
646 * page/PerformanceTiming.idl:
647 * page/PositionError.idl:
648 * page/Screen.idl:
649 * page/SpeechInputEvent.idl:
650 * page/SpeechInputResult.idl:
651 * page/WebKitAnimation.idl:
652 * page/WebKitPoint.idl:
653 * page/WorkerNavigator.idl:
654 * plugins/DOMMimeType.idl:
655 * storage/Database.idl:
656 * storage/DatabaseSync.idl:
657 * storage/IDBAny.idl:
658 * storage/IDBCursorWithValue.idl:
659 * storage/IDBDatabaseError.idl:
660 * storage/IDBDatabaseException.idl:
661 * storage/IDBKey.idl:
662 * storage/IDBVersionChangeEvent.idl:
663 * storage/IDBVersionChangeRequest.idl:
664 * storage/SQLError.idl:
665 * storage/SQLException.idl:
666 * storage/SQLResultSet.idl:
667 * svg/SVGAElement.idl:
668 * svg/SVGAltGlyphElement.idl:
669 * svg/SVGAngle.idl:
670 * svg/SVGAnimateColorElement.idl:
671 * svg/SVGAnimateElement.idl:
672 * svg/SVGAnimateMotionElement.idl:
673 * svg/SVGAnimateTransformElement.idl:
674 * svg/SVGAnimatedAngle.idl:
675 * svg/SVGAnimatedBoolean.idl:
676 * svg/SVGAnimatedEnumeration.idl:
677 * svg/SVGAnimatedInteger.idl:
678 * svg/SVGAnimatedLength.idl:
679 * svg/SVGAnimatedLengthList.idl:
680 * svg/SVGAnimatedNumber.idl:
681 * svg/SVGAnimatedNumberList.idl:
682 * svg/SVGAnimatedPreserveAspectRatio.idl:
683 * svg/SVGAnimatedRect.idl:
684 * svg/SVGAnimatedString.idl:
685 * svg/SVGAnimatedTransformList.idl:
686 * svg/SVGCircleElement.idl:
687 * svg/SVGClipPathElement.idl:
688 * svg/SVGColor.idl:
689 * svg/SVGComponentTransferFunctionElement.idl:
690 * svg/SVGCursorElement.idl:
691 * svg/SVGDefsElement.idl:
692 * svg/SVGDescElement.idl:
693 * svg/SVGElement.idl:
694 * svg/SVGEllipseElement.idl:
695 * svg/SVGExternalResourcesRequired.idl:
696 * svg/SVGFEBlendElement.idl:
697 * svg/SVGFEColorMatrixElement.idl:
698 * svg/SVGFEComponentTransferElement.idl:
699 * svg/SVGFECompositeElement.idl:
700 * svg/SVGFEConvolveMatrixElement.idl:
701 * svg/SVGFEDiffuseLightingElement.idl:
702 * svg/SVGFEDisplacementMapElement.idl:
703 * svg/SVGFEDistantLightElement.idl:
704 * svg/SVGFEFloodElement.idl:
705 * svg/SVGFEFuncAElement.idl:
706 * svg/SVGFEFuncBElement.idl:
707 * svg/SVGFEFuncGElement.idl:
708 * svg/SVGFEFuncRElement.idl:
709 * svg/SVGFEImageElement.idl:
710 * svg/SVGFEMergeElement.idl:
711 * svg/SVGFEMergeNodeElement.idl:
712 * svg/SVGFEOffsetElement.idl:
713 * svg/SVGFEPointLightElement.idl:
714 * svg/SVGFESpecularLightingElement.idl:
715 * svg/SVGFESpotLightElement.idl:
716 * svg/SVGFETileElement.idl:
717 * svg/SVGFETurbulenceElement.idl:
718 * svg/SVGFilterPrimitiveStandardAttributes.idl:
719 * svg/SVGFitToViewBox.idl:
720 * svg/SVGFontElement.idl:
721 * svg/SVGFontFaceElement.idl:
722 * svg/SVGFontFaceFormatElement.idl:
723 * svg/SVGFontFaceNameElement.idl:
724 * svg/SVGFontFaceSrcElement.idl:
725 * svg/SVGFontFaceUriElement.idl:
726 * svg/SVGForeignObjectElement.idl:
727 * svg/SVGGElement.idl:
728 * svg/SVGGlyphElement.idl:
729 * svg/SVGGradientElement.idl:
730 * svg/SVGHKernElement.idl:
731 * svg/SVGImageElement.idl:
732 * svg/SVGLangSpace.idl:
733 * svg/SVGLength.idl:
734 * svg/SVGLengthList.idl:
735 * svg/SVGLineElement.idl:
736 * svg/SVGLinearGradientElement.idl:
737 * svg/SVGMPathElement.idl:
738 * svg/SVGMaskElement.idl:
739 * svg/SVGMatrix.idl:
740 * svg/SVGMetadataElement.idl:
741 * svg/SVGMissingGlyphElement.idl:
742 * svg/SVGNumber.idl:
743 * svg/SVGNumberList.idl:
744 * svg/SVGPaint.idl:
745 * svg/SVGPathSeg.idl:
746 * svg/SVGPathSegArcAbs.idl:
747 * svg/SVGPathSegArcRel.idl:
748 * svg/SVGPathSegClosePath.idl:
749 * svg/SVGPathSegCurvetoCubicAbs.idl:
750 * svg/SVGPathSegCurvetoCubicRel.idl:
751 * svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
752 * svg/SVGPathSegCurvetoCubicSmoothRel.idl:
753 * svg/SVGPathSegCurvetoQuadraticAbs.idl:
754 * svg/SVGPathSegCurvetoQuadraticRel.idl:
755 * svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
756 * svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
757 * svg/SVGPathSegLinetoAbs.idl:
758 * svg/SVGPathSegLinetoHorizontalAbs.idl:
759 * svg/SVGPathSegLinetoHorizontalRel.idl:
760 * svg/SVGPathSegLinetoRel.idl:
761 * svg/SVGPathSegLinetoVerticalAbs.idl:
762 * svg/SVGPathSegLinetoVerticalRel.idl:
763 * svg/SVGPathSegList.idl:
764 * svg/SVGPathSegMovetoAbs.idl:
765 * svg/SVGPathSegMovetoRel.idl:
766 * svg/SVGPatternElement.idl:
767 * svg/SVGPoint.idl:
768 * svg/SVGPointList.idl:
769 * svg/SVGPolygonElement.idl:
770 * svg/SVGPolylineElement.idl:
771 * svg/SVGPreserveAspectRatio.idl:
772 * svg/SVGRadialGradientElement.idl:
773 * svg/SVGRect.idl:
774 * svg/SVGRectElement.idl:
775 * svg/SVGRenderingIntent.idl:
776 * svg/SVGScriptElement.idl:
777 * svg/SVGSetElement.idl:
778 * svg/SVGStopElement.idl:
779 * svg/SVGStringList.idl:
780 * svg/SVGSwitchElement.idl:
781 * svg/SVGSymbolElement.idl:
782 * svg/SVGTRefElement.idl:
783 * svg/SVGTSpanElement.idl:
784 * svg/SVGTextElement.idl:
785 * svg/SVGTextPathElement.idl:
786 * svg/SVGTextPositioningElement.idl:
787 * svg/SVGTitleElement.idl:
788 * svg/SVGTransform.idl:
789 * svg/SVGTransformList.idl:
790 * svg/SVGTransformable.idl:
791 * svg/SVGURIReference.idl:
792 * svg/SVGUnitTypes.idl:
793 * svg/SVGUseElement.idl:
794 * svg/SVGVKernElement.idl:
795 * svg/SVGViewElement.idl:
796 * svg/SVGViewSpec.idl:
797 * svg/SVGZoomAndPan.idl:
798 * svg/SVGZoomEvent.idl:
799 * testing/Internals.idl:
800 * webaudio/AudioChannelMerger.idl:
801 * webaudio/AudioChannelSplitter.idl:
802 * webaudio/AudioDestinationNode.idl:
803 * webaudio/AudioGain.idl:
804 * webaudio/AudioGainNode.idl:
805 * webaudio/AudioProcessingEvent.idl:
806 * webaudio/AudioSourceNode.idl:
807 * webaudio/BiquadFilterNode.idl:
808 * webaudio/ConvolverNode.idl:
809 * webaudio/DelayNode.idl:
810 * webaudio/DynamicsCompressorNode.idl:
811 * webaudio/HighPass2FilterNode.idl:
812 * webaudio/JavaScriptAudioNode.idl:
813 * webaudio/LowPass2FilterNode.idl:
814 * webaudio/OfflineAudioCompletionEvent.idl:
815 * workers/SharedWorker.idl:
816 * workers/SharedWorkerContext.idl:
817 * workers/WorkerLocation.idl:
818 * xml/XMLHttpRequestException.idl:
819 * xml/XMLHttpRequestProgressEvent.idl:
820 * xml/XPathException.idl:
821
822 2011-06-17 Mark Pilgrim <pilgrim@chromium.org>
823
824 Reviewed by Darin Adler.
825
826 Remove LegacyDefaultOptionalArguments flag from IDL files where it would not change behavior
827 https://bugs.webkit.org/show_bug.cgi?id=62904
828
829 After bug 62750, there are many IDL files that contain the new
830 LegacyDefaultOptionalArguments flag that don't actually need it.
831 Some examples:
832
833 - the IDL file contains no functions
834 - the IDL file contains only functions with no arguments
835 - the IDL file contains functions, *all* of which use the
836 [RequiresAllArguments=raise] extended attribute
837
838 This patch simplifies such IDL files by removing the
839 LegacyDefaultOptionalArguments flag and (if needed) removing the
840 [RequiresAllArguments=raise] extended attribute from each function
841 declaration. This patch does not make any required arguments optional
842 or any optional arguments required. It changes no behavior at all.
843
844 No new tests needed, all existing tests pass.
845
846 * bindings/scripts/test/TestInterface.idl:
847 * bindings/scripts/test/TestSerializedScriptValueInterface.idl:
848 * css/CSSCharsetRule.idl:
849 * css/CSSFontFaceRule.idl:
850 * css/CSSImportRule.idl:
851 * css/CSSPageRule.idl:
852 * css/CSSRule.idl:
853 * css/CSSStyleRule.idl:
854 * css/CSSUnknownRule.idl:
855 * css/CSSValue.idl:
856 * css/Counter.idl:
857 * css/RGBColor.idl:
858 * css/Rect.idl:
859 * css/StyleSheet.idl:
860 * css/WebKitCSSKeyframeRule.idl:
861 * css/WebKitCSSTransformValue.idl:
862 * dom/Attr.idl:
863 * dom/CDATASection.idl:
864 * dom/ClientRect.idl:
865 * dom/Comment.idl:
866 * dom/DOMCoreException.idl:
867 * dom/DOMStringMap.idl:
868 * dom/DocumentType.idl:
869 * dom/Entity.idl:
870 * dom/EntityReference.idl:
871 * dom/EventException.idl:
872 * dom/GeneratedStream.idl:
873 * dom/MessageChannel.idl:
874 * dom/NodeIterator.idl:
875 * dom/Notation.idl:
876 * dom/ProcessingInstruction.idl:
877 * dom/RangeException.idl:
878 * dom/Touch.idl:
879 * dom/TreeWalker.idl:
880 * fileapi/DOMFileSystem.idl:
881 * fileapi/DOMFileSystemSync.idl:
882 * fileapi/DirectoryReaderSync.idl:
883 * fileapi/File.idl:
884 * fileapi/FileEntrySync.idl:
885 * fileapi/FileError.idl:
886 * fileapi/FileException.idl:
887 * fileapi/Metadata.idl:
888 * fileapi/OperationNotAllowedException.idl:
889 * fileapi/WebKitFlags.idl:
890 * html/DOMSettableTokenList.idl:
891 * html/HTMLAppletElement.idl:
892 * html/HTMLAreaElement.idl:
893 * html/HTMLBRElement.idl:
894 * html/HTMLBaseElement.idl:
895 * html/HTMLBaseFontElement.idl:
896 * html/HTMLBlockquoteElement.idl:
897 * html/HTMLBodyElement.idl:
898 * html/HTMLDListElement.idl:
899 * html/HTMLDataListElement.idl:
900 * html/HTMLDetailsElement.idl:
901 * html/HTMLDirectoryElement.idl:
902 * html/HTMLEmbedElement.idl:
903 * html/HTMLFontElement.idl:
904 * html/HTMLFormElement.idl:
905 * html/HTMLFrameElement.idl:
906 * html/HTMLFrameSetElement.idl:
907 * html/HTMLHRElement.idl:
908 * html/HTMLHeadElement.idl:
909 * html/HTMLHeadingElement.idl:
910 * html/HTMLHtmlElement.idl:
911 * html/HTMLIFrameElement.idl:
912 * html/HTMLImageElement.idl:
913 * html/HTMLIsIndexElement.idl:
914 * html/HTMLLIElement.idl:
915 * html/HTMLLabelElement.idl:
916 * html/HTMLLegendElement.idl:
917 * html/HTMLLinkElement.idl:
918 * html/HTMLMapElement.idl:
919 * html/HTMLMarqueeElement.idl:
920 * html/HTMLMenuElement.idl:
921 * html/HTMLMetaElement.idl:
922 * html/HTMLMeterElement.idl:
923 * html/HTMLModElement.idl:
924 * html/HTMLOListElement.idl:
925 * html/HTMLOptGroupElement.idl:
926 * html/HTMLOptionElement.idl:
927 * html/HTMLParagraphElement.idl:
928 * html/HTMLParamElement.idl:
929 * html/HTMLPreElement.idl:
930 * html/HTMLProgressElement.idl:
931 * html/HTMLQuoteElement.idl:
932 * html/HTMLScriptElement.idl:
933 * html/HTMLSourceElement.idl:
934 * html/HTMLStyleElement.idl:
935 * html/HTMLTableCaptionElement.idl:
936 * html/HTMLTableCellElement.idl:
937 * html/HTMLTableColElement.idl:
938 * html/HTMLTitleElement.idl:
939 * html/HTMLTrackElement.idl:
940 * html/HTMLUListElement.idl:
941 * html/ImageData.idl:
942 * html/MediaError.idl:
943 * html/SpellcheckRange.idl:
944 * html/TextMetrics.idl:
945 * html/ValidityState.idl:
946 * html/VoidCallback.idl:
947 * html/canvas/ArrayBuffer.idl:
948 * html/canvas/ArrayBufferView.idl:
949 * html/canvas/CanvasPattern.idl:
950 * html/canvas/CanvasPixelArray.idl:
951 * html/canvas/CanvasRenderingContext.idl:
952 * html/canvas/DataView.idl:
953 * html/canvas/OESStandardDerivatives.idl:
954 * html/canvas/OESTextureFloat.idl:
955 * html/canvas/WebGLActiveInfo.idl:
956 * html/canvas/WebGLBuffer.idl:
957 * html/canvas/WebGLContextAttributes.idl:
958 * html/canvas/WebGLFramebuffer.idl:
959 * html/canvas/WebGLProgram.idl:
960 * html/canvas/WebGLRenderbuffer.idl:
961 * html/canvas/WebGLShader.idl:
962 * html/canvas/WebGLTexture.idl:
963 * html/canvas/WebGLUniformLocation.idl:
964 * html/canvas/WebGLVertexArrayObjectOES.idl:
965 * html/canvas/WebKitLoseContext.idl:
966 * inspector/ScriptProfile.idl:
967 * inspector/ScriptProfileNode.idl:
968 * page/AbstractView.idl:
969 * page/BarInfo.idl:
970 * page/Coordinates.idl:
971 * page/Geoposition.idl:
972 * page/MemoryInfo.idl:
973 * page/NavigatorUserMediaError.idl:
974 * page/Performance.idl:
975 * page/PerformanceNavigation.idl:
976 * page/PerformanceTiming.idl:
977 * page/PositionError.idl:
978 * page/Screen.idl:
979 * page/SpeechInputEvent.idl:
980 * page/SpeechInputResult.idl:
981 * page/WebKitAnimation.idl:
982 * page/WebKitPoint.idl:
983 * page/WorkerNavigator.idl:
984 * plugins/DOMMimeType.idl:
985 * storage/Database.idl:
986 * storage/DatabaseSync.idl:
987 * storage/IDBAny.idl:
988 * storage/IDBCursorWithValue.idl:
989 * storage/IDBDatabaseError.idl:
990 * storage/IDBDatabaseException.idl:
991 * storage/IDBKey.idl:
992 * storage/IDBVersionChangeEvent.idl:
993 * storage/IDBVersionChangeRequest.idl:
994 * storage/SQLError.idl:
995 * storage/SQLException.idl:
996 * storage/SQLResultSet.idl:
997 * svg/SVGAElement.idl:
998 * svg/SVGAltGlyphElement.idl:
999 * svg/SVGAngle.idl:
1000 * svg/SVGAnimateColorElement.idl:
1001 * svg/SVGAnimateElement.idl:
1002 * svg/SVGAnimateMotionElement.idl:
1003 * svg/SVGAnimateTransformElement.idl:
1004 * svg/SVGAnimatedAngle.idl:
1005 * svg/SVGAnimatedBoolean.idl:
1006 * svg/SVGAnimatedEnumeration.idl:
1007 * svg/SVGAnimatedInteger.idl:
1008 * svg/SVGAnimatedLength.idl:
1009 * svg/SVGAnimatedLengthList.idl:
1010 * svg/SVGAnimatedNumber.idl:
1011 * svg/SVGAnimatedNumberList.idl:
1012 * svg/SVGAnimatedPreserveAspectRatio.idl:
1013 * svg/SVGAnimatedRect.idl:
1014 * svg/SVGAnimatedString.idl:
1015 * svg/SVGAnimatedTransformList.idl:
1016 * svg/SVGCircleElement.idl:
1017 * svg/SVGClipPathElement.idl:
1018 * svg/SVGColor.idl:
1019 * svg/SVGComponentTransferFunctionElement.idl:
1020 * svg/SVGCursorElement.idl:
1021 * svg/SVGDefsElement.idl:
1022 * svg/SVGDescElement.idl:
1023 * svg/SVGElement.idl:
1024 * svg/SVGEllipseElement.idl:
1025 * svg/SVGExternalResourcesRequired.idl:
1026 * svg/SVGFEBlendElement.idl:
1027 * svg/SVGFEColorMatrixElement.idl:
1028 * svg/SVGFEComponentTransferElement.idl:
1029 * svg/SVGFECompositeElement.idl:
1030 * svg/SVGFEConvolveMatrixElement.idl:
1031 * svg/SVGFEDiffuseLightingElement.idl:
1032 * svg/SVGFEDisplacementMapElement.idl:
1033 * svg/SVGFEDistantLightElement.idl:
1034 * svg/SVGFEFloodElement.idl:
1035 * svg/SVGFEFuncAElement.idl:
1036 * svg/SVGFEFuncBElement.idl:
1037 * svg/SVGFEFuncGElement.idl:
1038 * svg/SVGFEFuncRElement.idl:
1039 * svg/SVGFEImageElement.idl:
1040 * svg/SVGFEMergeElement.idl:
1041 * svg/SVGFEMergeNodeElement.idl:
1042 * svg/SVGFEOffsetElement.idl:
1043 * svg/SVGFEPointLightElement.idl:
1044 * svg/SVGFESpecularLightingElement.idl:
1045 * svg/SVGFESpotLightElement.idl:
1046 * svg/SVGFETileElement.idl:
1047 * svg/SVGFETurbulenceElement.idl:
1048 * svg/SVGFilterPrimitiveStandardAttributes.idl:
1049 * svg/SVGFitToViewBox.idl:
1050 * svg/SVGFontElement.idl:
1051 * svg/SVGFontFaceElement.idl:
1052 * svg/SVGFontFaceFormatElement.idl:
1053 * svg/SVGFontFaceNameElement.idl:
1054 * svg/SVGFontFaceSrcElement.idl:
1055 * svg/SVGFontFaceUriElement.idl:
1056 * svg/SVGForeignObjectElement.idl:
1057 * svg/SVGGElement.idl:
1058 * svg/SVGGlyphElement.idl:
1059 * svg/SVGGradientElement.idl:
1060 * svg/SVGHKernElement.idl:
1061 * svg/SVGImageElement.idl:
1062 * svg/SVGLangSpace.idl:
1063 * svg/SVGLength.idl:
1064 * svg/SVGLengthList.idl:
1065 * svg/SVGLineElement.idl:
1066 * svg/SVGLinearGradientElement.idl:
1067 * svg/SVGMPathElement.idl:
1068 * svg/SVGMaskElement.idl:
1069 * svg/SVGMatrix.idl:
1070 * svg/SVGMetadataElement.idl:
1071 * svg/SVGMissingGlyphElement.idl:
1072 * svg/SVGNumber.idl:
1073 * svg/SVGNumberList.idl:
1074 * svg/SVGPaint.idl:
1075 * svg/SVGPathSeg.idl:
1076 * svg/SVGPathSegArcAbs.idl:
1077 * svg/SVGPathSegArcRel.idl:
1078 * svg/SVGPathSegClosePath.idl:
1079 * svg/SVGPathSegCurvetoCubicAbs.idl:
1080 * svg/SVGPathSegCurvetoCubicRel.idl:
1081 * svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
1082 * svg/SVGPathSegCurvetoCubicSmoothRel.idl:
1083 * svg/SVGPathSegCurvetoQuadraticAbs.idl:
1084 * svg/SVGPathSegCurvetoQuadraticRel.idl:
1085 * svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
1086 * svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
1087 * svg/SVGPathSegLinetoAbs.idl:
1088 * svg/SVGPathSegLinetoHorizontalAbs.idl:
1089 * svg/SVGPathSegLinetoHorizontalRel.idl:
1090 * svg/SVGPathSegLinetoRel.idl:
1091 * svg/SVGPathSegLinetoVerticalAbs.idl:
1092 * svg/SVGPathSegLinetoVerticalRel.idl:
1093 * svg/SVGPathSegList.idl:
1094 * svg/SVGPathSegMovetoAbs.idl:
1095 * svg/SVGPathSegMovetoRel.idl:
1096 * svg/SVGPatternElement.idl:
1097 * svg/SVGPoint.idl:
1098 * svg/SVGPointList.idl:
1099 * svg/SVGPolygonElement.idl:
1100 * svg/SVGPolylineElement.idl:
1101 * svg/SVGPreserveAspectRatio.idl:
1102 * svg/SVGRadialGradientElement.idl:
1103 * svg/SVGRect.idl:
1104 * svg/SVGRectElement.idl:
1105 * svg/SVGRenderingIntent.idl:
1106 * svg/SVGScriptElement.idl:
1107 * svg/SVGSetElement.idl:
1108 * svg/SVGStopElement.idl:
1109 * svg/SVGStringList.idl:
1110 * svg/SVGSwitchElement.idl:
1111 * svg/SVGSymbolElement.idl:
1112 * svg/SVGTRefElement.idl:
1113 * svg/SVGTSpanElement.idl:
1114 * svg/SVGTextElement.idl:
1115 * svg/SVGTextPathElement.idl:
1116 * svg/SVGTextPositioningElement.idl:
1117 * svg/SVGTitleElement.idl:
1118 * svg/SVGTransform.idl:
1119 * svg/SVGTransformList.idl:
1120 * svg/SVGTransformable.idl:
1121 * svg/SVGURIReference.idl:
1122 * svg/SVGUnitTypes.idl:
1123 * svg/SVGUseElement.idl:
1124 * svg/SVGVKernElement.idl:
1125 * svg/SVGViewElement.idl:
1126 * svg/SVGViewSpec.idl:
1127 * svg/SVGZoomAndPan.idl:
1128 * svg/SVGZoomEvent.idl:
1129 * testing/Internals.idl:
1130 * webaudio/AudioChannelMerger.idl:
1131 * webaudio/AudioChannelSplitter.idl:
1132 * webaudio/AudioDestinationNode.idl:
1133 * webaudio/AudioGain.idl:
1134 * webaudio/AudioGainNode.idl:
1135 * webaudio/AudioProcessingEvent.idl:
1136 * webaudio/AudioSourceNode.idl:
1137 * webaudio/BiquadFilterNode.idl:
1138 * webaudio/ConvolverNode.idl:
1139 * webaudio/DelayNode.idl:
1140 * webaudio/DynamicsCompressorNode.idl:
1141 * webaudio/HighPass2FilterNode.idl:
1142 * webaudio/JavaScriptAudioNode.idl:
1143 * webaudio/LowPass2FilterNode.idl:
1144 * webaudio/OfflineAudioCompletionEvent.idl:
1145 * workers/SharedWorker.idl:
1146 * workers/SharedWorkerContext.idl:
1147 * workers/WorkerLocation.idl:
1148 * xml/XMLHttpRequestException.idl:
1149 * xml/XMLHttpRequestProgressEvent.idl:
1150 * xml/XPathException.idl:
1151
1152 2011-06-17 Dirk Schulze <krit@webkit.org>
1153
1154 Reviewed by Rob Buis.
1155
1156 SVGAnimation should use direct unit animation for SVGAngle
1157 https://bugs.webkit.org/show_bug.cgi?id=62807
1158
1159 Follow up of "SVGAnimation should use direct unit animation for SVGLengt h": https://bugs.webkit.org/show_bug.cgi?id=61368
1160 This patch continues the conversion to the new concept of SVGAnimatorFac tory with SVGAngle. We can animate the SVG primitive datatype SVGAngle
1161 with different unit types now.
1162 Removed number and unit parser from SVGAnimateElement. This is not neede d anymore.
1163
1164 Tests: svg/animations/svgangle-animation-deg-to-grad.html
1165 svg/animations/svgangle-animation-deg-to-rad.html
1166 svg/animations/svgangle-animation-grad-to-deg.html
1167 svg/animations/svgangle-animation-grad-to-rad.html
1168 svg/animations/svgangle-animation-rad-to-deg.html
1169 svg/animations/svgangle-animation-rad-to-grad.html
1170
1171 * CMakeLists.txt: Added SVGAnimatedAngle.cpp.
1172 * GNUmakefile.list.am: Ditto.
1173 * WebCore.gypi: Ditto.
1174 * WebCore.pro: Ditto.
1175 * WebCore.xcodeproj/project.pbxproj: Ditto.
1176 * svg/SVGAllInOne.cpp: Ditto.
1177 * svg/SVGAnimateElement.cpp: Make use of SVGAnimator for AnimatedAngle.
1178 (WebCore::SVGAnimateElement::SVGAnimateElement):
1179 (WebCore::SVGAnimateElement::determineAnimatedAttributeType): Ditto.
1180 (WebCore::SVGAnimateElement::calculateAnimatedValue): Ditto.
1181 (WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto.
1182 (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto.
1183 (WebCore::SVGAnimateElement::resetToBaseValue): Ditto.
1184 (WebCore::SVGAnimateElement::applyResultsToTarget): Ditto.
1185 (WebCore::SVGAnimateElement::calculateDistance): Ditto.
1186 * svg/SVGAnimateElement.h:
1187 * svg/SVGAnimatedAngle.cpp: Added. Added SVGAnimatedAngleAnimator for an imation of SVGAngles.
1188 (WebCore::SVGAnimatedAngleAnimator::SVGAnimatedAngleAnimator):
1189 (WebCore::sharedSVGAngle):
1190 (WebCore::SVGAnimatedAngleAnimator::constructFromString):
1191 (WebCore::SVGAnimatedAngleAnimator::calculateFromAndToValues):
1192 (WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
1193 (WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
1194 (WebCore::SVGAnimatedAngleAnimator::calculateDistance):
1195 * svg/SVGAnimatedAngle.h:
1196 (WebCore::SVGAnimatedAngleAnimator::~SVGAnimatedAngleAnimator):
1197 * svg/SVGAnimatedLength.cpp:
1198 (WebCore::sharedSVGLength): Use an ExceptionCode for SVGLength::setValue AsString.
1199 * svg/SVGAnimatedType.h:
1200 (WebCore::SVGAnimatedType::create):
1201 (WebCore::SVGAnimatedType::createAngle):
1202 (WebCore::SVGAnimatedType::createLength):
1203 (WebCore::SVGAnimatedType::~SVGAnimatedType):
1204 (WebCore::SVGAnimatedType::angle):
1205 (WebCore::SVGAnimatedType::valueAsString):
1206 (WebCore::SVGAnimatedType::setValueAsString):
1207 (WebCore::SVGAnimatedType::SVGAnimatedType):
1208 * svg/SVGAnimatorFactory.h:
1209 (WebCore::SVGAnimatorFactory::create):
1210 * svg/SVGLength.cpp:
1211 (WebCore::SVGLength::setValueAsString): Added an ExceptionCode for consi stency reasons and as preparation for future error handling.
1212 * svg/SVGLength.h:
1213 * svg/SVGParserUtilities.cpp:
1214 (WebCore::parseNumberFromString): Added number parser for String objects .
1215 * svg/SVGParserUtilities.h:
1216
1217 2011-06-17 Anna Cavender <annacc@chromium.org>
1218
1219 Reviewed by Eric Carlson.
1220
1221 Adding initial interfaces and stubs for track
1222 https://bugs.webkit.org/show_bug.cgi?id=60379
1223
1224 This marks the first patch of a series to implement out-of-band
1225 <track> support in WebKit. This patch adds some of the core header files
1226 and their corresponding stub .cpp files.
1227
1228 No new tests because feature is hidden behind VIDEO_TRACK feature
1229 define, which is turned off.
1230
1231 * CMakeLists.txt:
1232 * WebCore.gyp/WebCore.gyp:
1233 * WebCore.gypi:
1234 * WebCore.pri:
1235 * WebCore.pro:
1236 * WebCore.xcodeproj/project.pbxproj:
1237 * html/CueIndex.cpp: Added.
1238 * html/CueIndex.h: Added.
1239 * html/LoadableTextTrack.cpp: Added.
1240 * html/LoadableTextTrack.h: Added.
1241 * html/LoadableTextTrackImpl.cpp: Added.
1242 * html/LoadableTextTrackImpl.h: Added.
1243 * html/MutableTextTrack.cpp: Added.
1244 * html/MutableTextTrack.h: Added.
1245 * html/MutableTextTrackImpl.cpp: Added.
1246 * html/MutableTextTrackImpl.h: Added.
1247 * html/TextTrack.cpp: Added.
1248 * html/TextTrack.h: Added.
1249 * html/TextTrackCue.cpp: Added.
1250 * html/TextTrackCue.h: Added.
1251 * html/TextTrackCueList.cpp: Added.
1252 * html/TextTrackCueList.h: Added.
1253 * html/TextTrackPrivate.h: Added.
1254 * loader/CueLoader.cpp: Added.
1255 * loader/CueLoader.h: Added.
1256 * platform/track/CueParser.cpp: Added.
1257 * platform/track/CueParser.h: Added.
1258 * platform/track/CueParserPrivate.h: Added.
1259
1260 2011-06-17 Dmitry Lomov <dslomov@google.com>
1261
1262 Reviewed by Adam Barth.
1263
1264 https://bugs.webkit.org/show_bug.cgi?id=62653
1265 [V8][Chromium] Make StringCache in V8 bindings per-isolate
1266 This moves StringCache into V8BindingPerIsolateData.
1267
1268 * bindings/v8/V8Binding.cpp:
1269 (WebCore::cachedStringCallback):
1270 (WebCore::StringCache::remove):
1271 (WebCore::StringCache::v8ExternalStringSlow):
1272 * bindings/v8/V8Binding.h:
1273 (WebCore::StringCache::StringCache):
1274 (WebCore::StringCache::v8ExternalString):
1275 (WebCore::StringCache::clearOnGC):
1276 (WebCore::V8BindingPerIsolateData::stringCache):
1277 (WebCore::v8ExternalString):
1278 * bindings/v8/V8GCController.cpp:
1279 (WebCore::V8GCController::gcPrologue):
1280
1281 2011-06-17 Julien Chaffraix <jchaffraix@webkit.org>
1282
1283 Reviewed by Darin Adler.
1284
1285 Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttribute s.isEmpty())
1286 https://bugs.webkit.org/show_bug.cgi?id=62884
1287
1288 Test: svg/custom/assert-empty-layout-attributes.svg
1289
1290 * rendering/svg/SVGRootInlineBox.cpp:
1291 (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Added a early return here.
1292 It is not needed to do the text layout algorithm if you don't have any l ayout information as
1293 your size is (0, 0) anyway.
1294
1295 2011-06-17 Alexey Proskuryakov <ap@apple.com>
1296
1297 Reviewed by Dan Bernstein.
1298
1299 https://bugs.webkit.org/show_bug.cgi?id=62913
1300 Use ICU search collator when available
1301
1302 <rdar://problem/8830218> Search on a webpage in Safari conflates some Cz ech characters
1303 <rdar://problem/8468873> Safari search doesn't strip Hamza
1304
1305 This changes behaviors that depend on system language, and isn't practic ally testable.
1306
1307 * editing/TextIterator.cpp: (WebCore::createSearcher): Ask ICU for searc h collator, if available.
1308
1309 2011-06-17 Sheriff Bot <webkit.review.bot@gmail.com>
1310
1311 Unreviewed, rolling out r89143.
1312 http://trac.webkit.org/changeset/89143
1313 https://bugs.webkit.org/show_bug.cgi?id=62912
1314
1315 Possible Chromeos test breakage (Requested by senorblanco on
1316 #webkit).
1317
1318 * platform/KURLGoogle.cpp:
1319 (WebCore::encodeWithURLEscapeSequences):
1320
1321 2011-06-17 Jer Noble <jer.noble@apple.com>
1322
1323 Reviewed by Ada Chan.
1324
1325 Playing video from the manifest crashes on Windows
1326 https://bugs.webkit.org/show_bug.cgi?id=62901
1327
1328 No new tests. This will be covered by existing App Cache tests.
1329
1330 Two related fixes. 1) Null-check the CFStringRef and CFURLRef created i n QTMovie::load() before
1331 passing them to CFRelease(). 2) Use CFURL to create an appropriate file -URL on windows in
1332 createFileURLForApplicationCacheResource.
1333
1334 * html/HTMLMediaElement.cpp:
1335 (WebCore::createFileURLForApplicationCacheResource):
1336 * platform/graphics/win/QTMovie.cpp:
1337 (QTMovie::load):
1338
1339 2011-06-17 Abhishek Arya <inferno@chromium.org>
1340
1341 Reviewed by Dave Hyatt.
1342
1343 When we lose ability to propagate floats, need to find topmost
1344 parent with that overhanging float, and then iterate over its
1345 sibling blocks to remove the float.
1346 https://bugs.webkit.org/show_bug.cgi?id=62875
1347
1348 Test: fast/block/float/float-not-removed-from-next-sibling5.html
1349
1350 * rendering/RenderBlock.cpp:
1351 (WebCore::RenderBlock::styleDidChange):
1352 (WebCore::RenderBlock::hasOverhangingFloat):
1353 * rendering/RenderBlock.h:
1354
1355 2011-06-17 Vsevolod Vlasov <vsevik@chromium.org>
1356
1357 Reviewed by Pavel Feldman.
1358
1359 Web Inspector: Network panel does not show main resource content for ifr ames deleted from the document
1360 https://bugs.webkit.org/show_bug.cgi?id=62810
1361
1362 Test: http/tests/inspector/network/network-iframe-load-and-delete.html
1363
1364 * inspector/InspectorInstrumentation.cpp:
1365 (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
1366 (WebCore::InspectorInstrumentation::didFailLoadingImpl):
1367 * inspector/InspectorInstrumentation.h:
1368 (WebCore::InspectorInstrumentation::didFinishLoading):
1369 (WebCore::InspectorInstrumentation::didFailLoading):
1370 * inspector/InspectorPageAgent.cpp:
1371 (WebCore::cachedResourceContent):
1372 (WebCore::mainResourceContent):
1373 (WebCore::InspectorPageAgent::sharedBufferContent):
1374 (WebCore::InspectorPageAgent::resourceContent):
1375 (WebCore::InspectorPageAgent::getResourceContent):
1376 (WebCore::InspectorPageAgent::searchInResources):
1377 * inspector/InspectorPageAgent.h:
1378 * inspector/InspectorResourceAgent.cpp:
1379 (WebCore::InspectorResourceAgent::didReceiveResponse):
1380 (WebCore::InspectorResourceAgent::didFinishLoading):
1381 (WebCore::InspectorResourceAgent::didFailLoading):
1382 (WebCore::InspectorResourceAgent::didReceiveXHRResponse):
1383 (WebCore::InspectorResourceAgent::getResourceContent):
1384 * inspector/InspectorResourceAgent.h:
1385 * inspector/InspectorStyleSheet.cpp:
1386 (WebCore::InspectorStyleSheet::resourceStyleSheetText):
1387 * inspector/NetworkResourcesData.cpp:
1388 (WebCore::NetworkResourcesData::ResourceData::ResourceData):
1389 (WebCore::NetworkResourcesData::setResourceType):
1390 (WebCore::NetworkResourcesData::resourceType):
1391 (WebCore::NetworkResourcesData::addResourceSharedBuffer):
1392 * inspector/NetworkResourcesData.h:
1393 (WebCore::NetworkResourcesData::ResourceData::type):
1394 (WebCore::NetworkResourcesData::ResourceData::setType):
1395 (WebCore::NetworkResourcesData::ResourceData::buffer):
1396 (WebCore::NetworkResourcesData::ResourceData::setBuffer):
1397 (WebCore::NetworkResourcesData::ResourceData::textEncodingName):
1398 (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
1399 * loader/ResourceLoadNotifier.cpp:
1400 (WebCore::ResourceLoadNotifier::didFailToLoad):
1401 (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
1402 * loader/appcache/ApplicationCacheGroup.cpp:
1403 (WebCore::ApplicationCacheGroup::didFinishLoading):
1404 (WebCore::ApplicationCacheGroup::didFail):
1405
1406 2011-06-17 Darin Adler <darin@apple.com>
1407
1408 Fix clang build.
1409
1410 * loader/LinkLoader.h: Use struct, not class, to forward-declare struct.
1411
1412 2011-06-17 Chris Evans <cevans@chromium.org>
1413
1414 Reviewed by Adam Barth.
1415
1416 Detect mixed-scripting involving https -> http redirects
1417 https://bugs.webkit.org/show_bug.cgi?id=62846
1418
1419 Test: http/tests/security/mixedContent/redirect-https-to-http-script-in- iframe.html
1420
1421 * loader/cache/CachedResourceLoader.cpp:
1422 (WebCore::CachedResourceLoader::checkInsecureContent):
1423 (WebCore::CachedResourceLoader::canRequest): break out insecure content logic.
1424 * loader/cache/CachedResourceLoader.h:
1425 * loader/cache/CachedResourceRequest.cpp:
1426 (WebCore::CachedResourceRequest::willSendRequest): check the redirect ta rget for possible insecure content issues.
1427
1428 2011-06-12 Robert Hogan <robert@webkit.org>
1429
1430 Reviewed by Alexey Proskuryakov.
1431
1432 [Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
1433 https://bugs.webkit.org/show_bug.cgi?id=62514
1434
1435 * platform/network/qt/ResourceHandleQt.cpp:
1436 (WebCore::WebCoreSynchronousLoader::willSendRequest):
1437
1438 2011-06-17 Mark Pilgrim <pilgrim@chromium.org>
1439
1440 Reviewed by Adam Barth.
1441
1442 Change IDL code generator to require all arguments by default
1443 https://bugs.webkit.org/show_bug.cgi?id=62750
1444
1445 As per discussion on public-webapps, WebIDL is changing the default
1446 behavior to require all function arguments by default and raise an
1447 exception when an argument is missing. (This behavior is currently
1448 opt-in in WebKit's IDL system, on a function-by-function basis, with
1449 the "RequiresAllArguments=Raise" flag.) To order to match WebIDL as
1450 closely as possible, this patch adds an interface-level
1451 "LegacyDefaultOptionalArguments" flag and sets it on all existing IDL
1452 files (500+), then changes the code generator Perl scripts to behave
1453 the old way in the presence of the flag.
1454
1455 No new tests required, all existing tests still pass.
1456
1457 * bindings/scripts/CodeGeneratorJS.pm:
1458 * bindings/scripts/CodeGeneratorV8.pm:
1459 * bindings/scripts/test/TestCallback.idl:
1460 * bindings/scripts/test/TestInterface.idl:
1461 * bindings/scripts/test/TestMediaQueryListListener.idl:
1462 * bindings/scripts/test/TestObj.idl:
1463 * bindings/scripts/test/TestSerializedScriptValueInterface.idl:
1464 * css/CSSCharsetRule.idl:
1465 * css/CSSFontFaceRule.idl:
1466 * css/CSSImportRule.idl:
1467 * css/CSSMediaRule.idl:
1468 * css/CSSPageRule.idl:
1469 * css/CSSPrimitiveValue.idl:
1470 * css/CSSRule.idl:
1471 * css/CSSRuleList.idl:
1472 * css/CSSStyleDeclaration.idl:
1473 * css/CSSStyleRule.idl:
1474 * css/CSSStyleSheet.idl:
1475 * css/CSSUnknownRule.idl:
1476 * css/CSSValue.idl:
1477 * css/CSSValueList.idl:
1478 * css/Counter.idl:
1479 * css/MediaList.idl:
1480 * css/MediaQueryList.idl:
1481 * css/MediaQueryListListener.idl:
1482 * css/RGBColor.idl:
1483 * css/Rect.idl:
1484 * css/StyleMedia.idl:
1485 * css/StyleSheet.idl:
1486 * css/StyleSheetList.idl:
1487 * css/WebKitCSSKeyframeRule.idl:
1488 * css/WebKitCSSKeyframesRule.idl:
1489 * css/WebKitCSSMatrix.idl:
1490 * css/WebKitCSSTransformValue.idl:
1491 * dom/Attr.idl:
1492 * dom/BeforeLoadEvent.idl:
1493 * dom/BeforeProcessEvent.idl:
1494 * dom/CDATASection.idl:
1495 * dom/CharacterData.idl:
1496 * dom/ClientRect.idl:
1497 * dom/ClientRectList.idl:
1498 * dom/Clipboard.idl:
1499 * dom/Comment.idl:
1500 * dom/CompositionEvent.idl:
1501 * dom/CustomEvent.idl:
1502 * dom/DOMCoreException.idl:
1503 * dom/DOMImplementation.idl:
1504 * dom/DOMStringList.idl:
1505 * dom/DOMStringMap.idl:
1506 * dom/DataTransferItem.idl:
1507 * dom/DataTransferItems.idl:
1508 * dom/DeviceMotionEvent.idl:
1509 * dom/DeviceOrientationEvent.idl:
1510 * dom/Document.idl:
1511 * dom/DocumentFragment.idl:
1512 * dom/DocumentType.idl:
1513 * dom/Element.idl:
1514 * dom/Entity.idl:
1515 * dom/EntityReference.idl:
1516 * dom/ErrorEvent.idl:
1517 * dom/Event.idl:
1518 * dom/EventException.idl:
1519 * dom/EventListener.idl:
1520 * dom/EventTarget.idl:
1521 * dom/ExclusiveTrackList.idl:
1522 * dom/GeneratedStream.idl:
1523 * dom/HashChangeEvent.idl:
1524 * dom/KeyboardEvent.idl:
1525 * dom/MessageChannel.idl:
1526 * dom/MessageEvent.idl:
1527 * dom/MessagePort.idl:
1528 * dom/MouseEvent.idl:
1529 * dom/MultipleTrackList.idl:
1530 * dom/MutationEvent.idl:
1531 * dom/NamedNodeMap.idl:
1532 * dom/Node.idl:
1533 * dom/NodeFilter.idl:
1534 * dom/NodeIterator.idl:
1535 * dom/NodeList.idl:
1536 * dom/Notation.idl:
1537 * dom/OverflowEvent.idl:
1538 * dom/PageTransitionEvent.idl:
1539 * dom/PopStateEvent.idl:
1540 * dom/ProcessingInstruction.idl:
1541 * dom/ProgressEvent.idl:
1542 * dom/Range.idl:
1543 * dom/RangeException.idl:
1544 * dom/RequestAnimationFrameCallback.idl:
1545 * dom/Stream.idl:
1546 * dom/StreamEvent.idl:
1547 * dom/StreamList.idl:
1548 * dom/StringCallback.idl:
1549 * dom/Text.idl:
1550 * dom/TextEvent.idl:
1551 * dom/Touch.idl:
1552 * dom/TouchEvent.idl:
1553 * dom/TouchList.idl:
1554 * dom/TrackList.idl:
1555 * dom/TreeWalker.idl:
1556 * dom/UIEvent.idl:
1557 * dom/WebKitAnimationEvent.idl:
1558 * dom/WebKitTransitionEvent.idl:
1559 * dom/WheelEvent.idl:
1560 * fileapi/Blob.idl:
1561 * fileapi/DOMFileSystem.idl:
1562 * fileapi/DOMFileSystemSync.idl:
1563 * fileapi/DirectoryEntry.idl:
1564 * fileapi/DirectoryEntrySync.idl:
1565 * fileapi/DirectoryReader.idl:
1566 * fileapi/DirectoryReaderSync.idl:
1567 * fileapi/EntriesCallback.idl:
1568 * fileapi/Entry.idl:
1569 * fileapi/EntryArray.idl:
1570 * fileapi/EntryArraySync.idl:
1571 * fileapi/EntryCallback.idl:
1572 * fileapi/EntrySync.idl:
1573 * fileapi/ErrorCallback.idl:
1574 * fileapi/File.idl:
1575 * fileapi/FileCallback.idl:
1576 * fileapi/FileEntry.idl:
1577 * fileapi/FileEntrySync.idl:
1578 * fileapi/FileError.idl:
1579 * fileapi/FileException.idl:
1580 * fileapi/FileList.idl:
1581 * fileapi/FileReader.idl:
1582 * fileapi/FileReaderSync.idl:
1583 * fileapi/FileSystemCallback.idl:
1584 * fileapi/FileWriter.idl:
1585 * fileapi/FileWriterCallback.idl:
1586 * fileapi/FileWriterSync.idl:
1587 * fileapi/Metadata.idl:
1588 * fileapi/MetadataCallback.idl:
1589 * fileapi/OperationNotAllowedException.idl:
1590 * fileapi/WebKitBlobBuilder.idl:
1591 * fileapi/WebKitFlags.idl:
1592 * html/DOMFormData.idl:
1593 * html/DOMSettableTokenList.idl:
1594 * html/DOMTokenList.idl:
1595 * html/DOMURL.idl:
1596 * html/HTMLAllCollection.idl:
1597 * html/HTMLAnchorElement.idl:
1598 * html/HTMLAppletElement.idl:
1599 * html/HTMLAreaElement.idl:
1600 * html/HTMLAudioElement.idl:
1601 * html/HTMLBRElement.idl:
1602 * html/HTMLBaseElement.idl:
1603 * html/HTMLBaseFontElement.idl:
1604 * html/HTMLBlockquoteElement.idl:
1605 * html/HTMLBodyElement.idl:
1606 * html/HTMLButtonElement.idl:
1607 * html/HTMLCanvasElement.idl:
1608 * html/HTMLCollection.idl:
1609 * html/HTMLDListElement.idl:
1610 * html/HTMLDataListElement.idl:
1611 * html/HTMLDetailsElement.idl:
1612 * html/HTMLDirectoryElement.idl:
1613 * html/HTMLDivElement.idl:
1614 * html/HTMLDocument.idl:
1615 * html/HTMLElement.idl:
1616 * html/HTMLEmbedElement.idl:
1617 * html/HTMLFieldSetElement.idl:
1618 * html/HTMLFontElement.idl:
1619 * html/HTMLFormElement.idl:
1620 * html/HTMLFrameElement.idl:
1621 * html/HTMLFrameSetElement.idl:
1622 * html/HTMLHRElement.idl:
1623 * html/HTMLHeadElement.idl:
1624 * html/HTMLHeadingElement.idl:
1625 * html/HTMLHtmlElement.idl:
1626 * html/HTMLIFrameElement.idl:
1627 * html/HTMLImageElement.idl:
1628 * html/HTMLInputElement.idl:
1629 * html/HTMLIsIndexElement.idl:
1630 * html/HTMLKeygenElement.idl:
1631 * html/HTMLLIElement.idl:
1632 * html/HTMLLabelElement.idl:
1633 * html/HTMLLegendElement.idl:
1634 * html/HTMLLinkElement.idl:
1635 * html/HTMLMapElement.idl:
1636 * html/HTMLMarqueeElement.idl:
1637 * html/HTMLMediaElement.idl:
1638 * html/HTMLMenuElement.idl:
1639 * html/HTMLMetaElement.idl:
1640 * html/HTMLMeterElement.idl:
1641 * html/HTMLModElement.idl:
1642 * html/HTMLOListElement.idl:
1643 * html/HTMLObjectElement.idl:
1644 * html/HTMLOptGroupElement.idl:
1645 * html/HTMLOptionElement.idl:
1646 * html/HTMLOptionsCollection.idl:
1647 * html/HTMLOutputElement.idl:
1648 * html/HTMLParagraphElement.idl:
1649 * html/HTMLParamElement.idl:
1650 * html/HTMLPreElement.idl:
1651 * html/HTMLProgressElement.idl:
1652 * html/HTMLQuoteElement.idl:
1653 * html/HTMLScriptElement.idl:
1654 * html/HTMLSelectElement.idl:
1655 * html/HTMLSourceElement.idl:
1656 * html/HTMLStyleElement.idl:
1657 * html/HTMLTableCaptionElement.idl:
1658 * html/HTMLTableCellElement.idl:
1659 * html/HTMLTableColElement.idl:
1660 * html/HTMLTableElement.idl:
1661 * html/HTMLTableRowElement.idl:
1662 * html/HTMLTableSectionElement.idl:
1663 * html/HTMLTextAreaElement.idl:
1664 * html/HTMLTitleElement.idl:
1665 * html/HTMLTrackElement.idl:
1666 * html/HTMLUListElement.idl:
1667 * html/HTMLVideoElement.idl:
1668 * html/ImageData.idl:
1669 * html/MediaError.idl:
1670 * html/SpellcheckRange.idl:
1671 * html/SpellcheckRangeList.idl:
1672 * html/TextMetrics.idl:
1673 * html/TimeRanges.idl:
1674 * html/ValidityState.idl:
1675 * html/VoidCallback.idl:
1676 * html/canvas/ArrayBuffer.idl:
1677 * html/canvas/ArrayBufferView.idl:
1678 * html/canvas/CanvasGradient.idl:
1679 * html/canvas/CanvasPattern.idl:
1680 * html/canvas/CanvasPixelArray.idl:
1681 * html/canvas/CanvasRenderingContext.idl:
1682 * html/canvas/CanvasRenderingContext2D.idl:
1683 * html/canvas/DataView.idl:
1684 * html/canvas/Float32Array.idl:
1685 * html/canvas/Float64Array.idl:
1686 * html/canvas/Int16Array.idl:
1687 * html/canvas/Int32Array.idl:
1688 * html/canvas/Int8Array.idl:
1689 * html/canvas/OESStandardDerivatives.idl:
1690 * html/canvas/OESTextureFloat.idl:
1691 * html/canvas/OESVertexArrayObject.idl:
1692 * html/canvas/Uint16Array.idl:
1693 * html/canvas/Uint32Array.idl:
1694 * html/canvas/Uint8Array.idl:
1695 * html/canvas/WebGLActiveInfo.idl:
1696 * html/canvas/WebGLBuffer.idl:
1697 * html/canvas/WebGLContextAttributes.idl:
1698 * html/canvas/WebGLContextEvent.idl:
1699 * html/canvas/WebGLFramebuffer.idl:
1700 * html/canvas/WebGLProgram.idl:
1701 * html/canvas/WebGLRenderbuffer.idl:
1702 * html/canvas/WebGLRenderingContext.idl:
1703 * html/canvas/WebGLShader.idl:
1704 * html/canvas/WebGLTexture.idl:
1705 * html/canvas/WebGLUniformLocation.idl:
1706 * html/canvas/WebGLVertexArrayObjectOES.idl:
1707 * html/canvas/WebKitLoseContext.idl:
1708 * inspector/InjectedScriptHost.idl:
1709 * inspector/InspectorFrontendHost.idl:
1710 * inspector/JavaScriptCallFrame.idl:
1711 * inspector/ScriptProfile.idl:
1712 * inspector/ScriptProfileNode.idl:
1713 * loader/appcache/DOMApplicationCache.idl:
1714 * notifications/Notification.idl:
1715 * notifications/NotificationCenter.idl:
1716 * page/AbstractView.idl:
1717 * page/BarInfo.idl:
1718 * page/Console.idl:
1719 * page/Coordinates.idl:
1720 * page/Crypto.idl:
1721 * page/DOMSelection.idl:
1722 * page/DOMWindow.idl:
1723 * page/EventSource.idl:
1724 * page/Geolocation.idl:
1725 * page/Geoposition.idl:
1726 * page/History.idl:
1727 * page/Location.idl:
1728 * page/MemoryInfo.idl:
1729 * page/Navigator.idl:
1730 * page/NavigatorUserMediaError.idl:
1731 * page/NavigatorUserMediaErrorCallback.idl:
1732 * page/NavigatorUserMediaSuccessCallback.idl:
1733 * page/Performance.idl:
1734 * page/PerformanceNavigation.idl:
1735 * page/PerformanceTiming.idl:
1736 * page/PositionCallback.idl:
1737 * page/PositionError.idl:
1738 * page/PositionErrorCallback.idl:
1739 * page/Screen.idl:
1740 * page/SpeechInputEvent.idl:
1741 * page/SpeechInputResult.idl:
1742 * page/SpeechInputResultList.idl:
1743 * page/WebKitAnimation.idl:
1744 * page/WebKitAnimationList.idl:
1745 * page/WebKitPoint.idl:
1746 * page/WorkerNavigator.idl:
1747 * plugins/DOMMimeType.idl:
1748 * plugins/DOMMimeTypeArray.idl:
1749 * plugins/DOMPlugin.idl:
1750 * plugins/DOMPluginArray.idl:
1751 * storage/Database.idl:
1752 * storage/DatabaseCallback.idl:
1753 * storage/DatabaseSync.idl:
1754 * storage/IDBAny.idl:
1755 * storage/IDBCursor.idl:
1756 * storage/IDBCursorWithValue.idl:
1757 * storage/IDBDatabase.idl:
1758 * storage/IDBDatabaseError.idl:
1759 * storage/IDBDatabaseException.idl:
1760 * storage/IDBFactory.idl:
1761 * storage/IDBIndex.idl:
1762 * storage/IDBKey.idl:
1763 * storage/IDBKeyRange.idl:
1764 * storage/IDBObjectStore.idl:
1765 * storage/IDBRequest.idl:
1766 * storage/IDBTransaction.idl:
1767 * storage/IDBVersionChangeEvent.idl:
1768 * storage/IDBVersionChangeRequest.idl:
1769 * storage/SQLError.idl:
1770 * storage/SQLException.idl:
1771 * storage/SQLResultSet.idl:
1772 * storage/SQLResultSetRowList.idl:
1773 * storage/SQLStatementCallback.idl:
1774 * storage/SQLStatementErrorCallback.idl:
1775 * storage/SQLTransaction.idl:
1776 * storage/SQLTransactionCallback.idl:
1777 * storage/SQLTransactionErrorCallback.idl:
1778 * storage/SQLTransactionSync.idl:
1779 * storage/SQLTransactionSyncCallback.idl:
1780 * storage/Storage.idl:
1781 * storage/StorageEvent.idl:
1782 * storage/StorageInfo.idl:
1783 * storage/StorageInfoErrorCallback.idl:
1784 * storage/StorageInfoQuotaCallback.idl:
1785 * storage/StorageInfoUsageCallback.idl:
1786 * svg/ElementTimeControl.idl:
1787 * svg/SVGAElement.idl:
1788 * svg/SVGAltGlyphElement.idl:
1789 * svg/SVGAngle.idl:
1790 * svg/SVGAnimateColorElement.idl:
1791 * svg/SVGAnimateElement.idl:
1792 * svg/SVGAnimateMotionElement.idl:
1793 * svg/SVGAnimateTransformElement.idl:
1794 * svg/SVGAnimatedAngle.idl:
1795 * svg/SVGAnimatedBoolean.idl:
1796 * svg/SVGAnimatedEnumeration.idl:
1797 * svg/SVGAnimatedInteger.idl:
1798 * svg/SVGAnimatedLength.idl:
1799 * svg/SVGAnimatedLengthList.idl:
1800 * svg/SVGAnimatedNumber.idl:
1801 * svg/SVGAnimatedNumberList.idl:
1802 * svg/SVGAnimatedPreserveAspectRatio.idl:
1803 * svg/SVGAnimatedRect.idl:
1804 * svg/SVGAnimatedString.idl:
1805 * svg/SVGAnimatedTransformList.idl:
1806 * svg/SVGAnimationElement.idl:
1807 * svg/SVGCircleElement.idl:
1808 * svg/SVGClipPathElement.idl:
1809 * svg/SVGColor.idl:
1810 * svg/SVGComponentTransferFunctionElement.idl:
1811 * svg/SVGCursorElement.idl:
1812 * svg/SVGDefsElement.idl:
1813 * svg/SVGDescElement.idl:
1814 * svg/SVGDocument.idl:
1815 * svg/SVGElement.idl:
1816 * svg/SVGElementInstance.idl:
1817 * svg/SVGElementInstanceList.idl:
1818 * svg/SVGEllipseElement.idl:
1819 * svg/SVGException.idl:
1820 * svg/SVGExternalResourcesRequired.idl:
1821 * svg/SVGFEBlendElement.idl:
1822 * svg/SVGFEColorMatrixElement.idl:
1823 * svg/SVGFEComponentTransferElement.idl:
1824 * svg/SVGFECompositeElement.idl:
1825 * svg/SVGFEConvolveMatrixElement.idl:
1826 * svg/SVGFEDiffuseLightingElement.idl:
1827 * svg/SVGFEDisplacementMapElement.idl:
1828 * svg/SVGFEDistantLightElement.idl:
1829 * svg/SVGFEDropShadowElement.idl:
1830 * svg/SVGFEFloodElement.idl:
1831 * svg/SVGFEFuncAElement.idl:
1832 * svg/SVGFEFuncBElement.idl:
1833 * svg/SVGFEFuncGElement.idl:
1834 * svg/SVGFEFuncRElement.idl:
1835 * svg/SVGFEGaussianBlurElement.idl:
1836 * svg/SVGFEImageElement.idl:
1837 * svg/SVGFEMergeElement.idl:
1838 * svg/SVGFEMergeNodeElement.idl:
1839 * svg/SVGFEMorphologyElement.idl:
1840 * svg/SVGFEOffsetElement.idl:
1841 * svg/SVGFEPointLightElement.idl:
1842 * svg/SVGFESpecularLightingElement.idl:
1843 * svg/SVGFESpotLightElement.idl:
1844 * svg/SVGFETileElement.idl:
1845 * svg/SVGFETurbulenceElement.idl:
1846 * svg/SVGFilterElement.idl:
1847 * svg/SVGFilterPrimitiveStandardAttributes.idl:
1848 * svg/SVGFitToViewBox.idl:
1849 * svg/SVGFontElement.idl:
1850 * svg/SVGFontFaceElement.idl:
1851 * svg/SVGFontFaceFormatElement.idl:
1852 * svg/SVGFontFaceNameElement.idl:
1853 * svg/SVGFontFaceSrcElement.idl:
1854 * svg/SVGFontFaceUriElement.idl:
1855 * svg/SVGForeignObjectElement.idl:
1856 * svg/SVGGElement.idl:
1857 * svg/SVGGlyphElement.idl:
1858 * svg/SVGGradientElement.idl:
1859 * svg/SVGHKernElement.idl:
1860 * svg/SVGImageElement.idl:
1861 * svg/SVGLangSpace.idl:
1862 * svg/SVGLength.idl:
1863 * svg/SVGLengthList.idl:
1864 * svg/SVGLineElement.idl:
1865 * svg/SVGLinearGradientElement.idl:
1866 * svg/SVGLocatable.idl:
1867 * svg/SVGMPathElement.idl:
1868 * svg/SVGMarkerElement.idl:
1869 * svg/SVGMaskElement.idl:
1870 * svg/SVGMatrix.idl:
1871 * svg/SVGMetadataElement.idl:
1872 * svg/SVGMissingGlyphElement.idl:
1873 * svg/SVGNumber.idl:
1874 * svg/SVGNumberList.idl:
1875 * svg/SVGPaint.idl:
1876 * svg/SVGPathElement.idl:
1877 * svg/SVGPathSeg.idl:
1878 * svg/SVGPathSegArcAbs.idl:
1879 * svg/SVGPathSegArcRel.idl:
1880 * svg/SVGPathSegClosePath.idl:
1881 * svg/SVGPathSegCurvetoCubicAbs.idl:
1882 * svg/SVGPathSegCurvetoCubicRel.idl:
1883 * svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
1884 * svg/SVGPathSegCurvetoCubicSmoothRel.idl:
1885 * svg/SVGPathSegCurvetoQuadraticAbs.idl:
1886 * svg/SVGPathSegCurvetoQuadraticRel.idl:
1887 * svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
1888 * svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
1889 * svg/SVGPathSegLinetoAbs.idl:
1890 * svg/SVGPathSegLinetoHorizontalAbs.idl:
1891 * svg/SVGPathSegLinetoHorizontalRel.idl:
1892 * svg/SVGPathSegLinetoRel.idl:
1893 * svg/SVGPathSegLinetoVerticalAbs.idl:
1894 * svg/SVGPathSegLinetoVerticalRel.idl:
1895 * svg/SVGPathSegList.idl:
1896 * svg/SVGPathSegMovetoAbs.idl:
1897 * svg/SVGPathSegMovetoRel.idl:
1898 * svg/SVGPatternElement.idl:
1899 * svg/SVGPoint.idl:
1900 * svg/SVGPointList.idl:
1901 * svg/SVGPolygonElement.idl:
1902 * svg/SVGPolylineElement.idl:
1903 * svg/SVGPreserveAspectRatio.idl:
1904 * svg/SVGRadialGradientElement.idl:
1905 * svg/SVGRect.idl:
1906 * svg/SVGRectElement.idl:
1907 * svg/SVGRenderingIntent.idl:
1908 * svg/SVGSVGElement.idl:
1909 * svg/SVGScriptElement.idl:
1910 * svg/SVGSetElement.idl:
1911 * svg/SVGStopElement.idl:
1912 * svg/SVGStringList.idl:
1913 * svg/SVGStylable.idl:
1914 * svg/SVGStyleElement.idl:
1915 * svg/SVGSwitchElement.idl:
1916 * svg/SVGSymbolElement.idl:
1917 * svg/SVGTRefElement.idl:
1918 * svg/SVGTSpanElement.idl:
1919 * svg/SVGTests.idl:
1920 * svg/SVGTextContentElement.idl:
1921 * svg/SVGTextElement.idl:
1922 * svg/SVGTextPathElement.idl:
1923 * svg/SVGTextPositioningElement.idl:
1924 * svg/SVGTitleElement.idl:
1925 * svg/SVGTransform.idl:
1926 * svg/SVGTransformList.idl:
1927 * svg/SVGTransformable.idl:
1928 * svg/SVGURIReference.idl:
1929 * svg/SVGUnitTypes.idl:
1930 * svg/SVGUseElement.idl:
1931 * svg/SVGVKernElement.idl:
1932 * svg/SVGViewElement.idl:
1933 * svg/SVGViewSpec.idl:
1934 * svg/SVGZoomAndPan.idl:
1935 * svg/SVGZoomEvent.idl:
1936 * testing/Internals.idl:
1937 * webaudio/AudioBuffer.idl:
1938 * webaudio/AudioBufferSourceNode.idl:
1939 * webaudio/AudioChannelMerger.idl:
1940 * webaudio/AudioChannelSplitter.idl:
1941 * webaudio/AudioContext.idl:
1942 * webaudio/AudioDestinationNode.idl:
1943 * webaudio/AudioGain.idl:
1944 * webaudio/AudioGainNode.idl:
1945 * webaudio/AudioListener.idl:
1946 * webaudio/AudioNode.idl:
1947 * webaudio/AudioPannerNode.idl:
1948 * webaudio/AudioParam.idl:
1949 * webaudio/AudioProcessingEvent.idl:
1950 * webaudio/AudioSourceNode.idl:
1951 * webaudio/BiquadFilterNode.idl:
1952 * webaudio/ConvolverNode.idl:
1953 * webaudio/DelayNode.idl:
1954 * webaudio/DynamicsCompressorNode.idl:
1955 * webaudio/HighPass2FilterNode.idl:
1956 * webaudio/JavaScriptAudioNode.idl:
1957 * webaudio/LowPass2FilterNode.idl:
1958 * webaudio/OfflineAudioCompletionEvent.idl:
1959 * webaudio/RealtimeAnalyserNode.idl:
1960 * websockets/CloseEvent.idl:
1961 * websockets/WebSocket.idl:
1962 * workers/AbstractWorker.idl:
1963 * workers/DedicatedWorkerContext.idl:
1964 * workers/SharedWorker.idl:
1965 * workers/SharedWorkerContext.idl:
1966 * workers/Worker.idl:
1967 * workers/WorkerContext.idl:
1968 * workers/WorkerLocation.idl:
1969 * xml/DOMParser.idl:
1970 * xml/XMLHttpRequest.idl:
1971 * xml/XMLHttpRequestException.idl:
1972 * xml/XMLHttpRequestProgressEvent.idl:
1973 * xml/XMLHttpRequestUpload.idl:
1974 * xml/XMLSerializer.idl:
1975 * xml/XPathEvaluator.idl:
1976 * xml/XPathException.idl:
1977 * xml/XPathExpression.idl:
1978 * xml/XPathNSResolver.idl:
1979 * xml/XPathResult.idl:
1980 * xml/XSLTProcessor.idl:
1981
1982 2011-06-17 Cary Clark <caryclark@google.com>
1983
1984 Reviewed by Mihai Parparita.
1985
1986 Exclude isCALayerContext check if building Chrome to use Skia on Mac.
1987 https://bugs.webkit.org/show_bug.cgi?id=62859
1988
1989 No new tests. This change does not affect existing functionality.
1990
1991 * platform/chromium/ScrollbarThemeChromiumMac.mm:
1992 (WebCore::ScrollbarThemeChromiumMac::paint):
1993 Add a conditional to always set drawing into layer to false if
1994 Skia is the WebKit rendering engine. Once USE(SKIA) is enabled,
1995 this condition can be removed.
1996
1997 2011-06-17 Gavin Peters <gavinp@chromium.org>
1998
1999 Reviewed by Adam Barth.
2000
2001 refactor HTMLLinkElement to allow Link header implementation
2002 https://bugs.webkit.org/show_bug.cgi?id=51941
2003
2004 This change moves the LinkRelAttribute helper struct into its own
2005 file in html/, since the LinkRelAttribute is used by the LinkLoader,
2006 and leaving it in HTMLLinkElement would have been too circular for
2007 my tastes.
2008
2009 The new LinkLoader class contains the loader code for icons, dns
2010 prefetching and prefetch/prerender/subresource into a common
2011 LinkLoader. This is a step in getting the Link header working in
2012 WebKit, as discussed in webkit-dev For more information, see
2013 thread "beforeload & link
2014 (esp rel prefetch)".
2015
2016 No new tests, since this is a refactoring.
2017
2018 * CMakeLists.txt:
2019 * GNUmakefile.list.am:
2020 * WebCore.gypi:
2021 * WebCore.pro:
2022 * WebCore.vcproj/WebCore.vcproj:
2023 * WebCore.xcodeproj/project.pbxproj:
2024 * html/HTMLLinkElement.cpp:
2025 (WebCore::HTMLLinkElement::HTMLLinkElement):
2026 (WebCore::HTMLLinkElement::~HTMLLinkElement):
2027 (WebCore::HTMLLinkElement::parseMappedAttribute):
2028 (WebCore::HTMLLinkElement::shouldLoadLink):
2029 (WebCore::HTMLLinkElement::process):
2030 (WebCore::HTMLLinkElement::linkLoaded):
2031 (WebCore::HTMLLinkElement::linkLoadingErrored):
2032 * html/HTMLLinkElement.h:
2033 * html/LinkRelAttribute.cpp: Added.
2034 (WebCore::LinkRelAttribute::LinkRelAttribute):
2035 * html/LinkRelAttribute.h: Added.
2036 * html/parser/HTMLPreloadScanner.cpp:
2037 (WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
2038 * loader/LinkLoader.cpp: Added.
2039 (WebCore::LinkLoader::LinkLoader):
2040 (WebCore::LinkLoader::~LinkLoader):
2041 (WebCore::LinkLoader::linkLoadedTimerFired):
2042 (WebCore::LinkLoader::notifyFinished):
2043 (WebCore::LinkLoader::loadLink):
2044 * loader/LinkLoader.h: Added.
2045 * loader/LinkLoaderClient.h: Added.
2046 (WebCore::LinkLoaderClient::~LinkLoaderClient):
2047
2048 2011-06-17 Annie Sullivan <sullivan@chromium.org>
2049
2050 Reviewed by Ryosuke Niwa.
2051
2052 div can be a child of span on InsertParagraph
2053 https://bugs.webkit.org/show_bug.cgi?id=62687
2054
2055 Handle the special case where the insertion point is the first position in the enclosing block node.
2056 The div for the new paragraph should be inserted as a child of the enclo sing block node, otherwise
2057 it could be inserted as a child of a span or other inline element.
2058
2059 * editing/InsertParagraphSeparatorCommand.cpp:
2060 (WebCore::InsertParagraphSeparatorCommand::doApply):
2061
2062 2011-06-17 Eric Uhrhane <ericu@chromium.org>
2063
2064 Reviewed by Adam Barth.
2065
2066 [filesystem/Chromium] Filesystem paths need proper URL escaping
2067 https://bugs.webkit.org/show_bug.cgi?id=62811
2068
2069 Fix http://code.google.com/p/chromium/issues/detail?id=78860 by making
2070 KURLChromium.cpp's escaping code actually work.
2071
2072 Make encodeWithURLEscapeSequences call into googleurl to do proper
2073 escaping. Tested in WebKit/chromium/tests/KURLTest.cpp.
2074 * platform/KURLGoogle.cpp:
2075 (WebCore::encodeWithURLEscapeSequences):
2076
2077 2011-06-17 Julien Chaffraix <jchaffraix@google.com>
2078
2079 Reviewed by Darin Adler.
2080
2081 Avoid extra work in RenderStyle::visitedDependentColor
2082 https://bugs.webkit.org/show_bug.cgi?id=62868
2083
2084 Refactoring only, no new test required.
2085
2086 The code used to cache the result of borderStyleForColorProperty. Howeve r
2087 the value was either overwritten inside colorIncludingFallback or there was
2088 not border. Thus I removed borderStyleForColorProperty and inlined the l ogic in
2089 colorIncludingFallback.
2090
2091 This shows some nice performance improvements on the bug page (table of 22k rows with a link
2092 for each row). Using pprof, the time spend in RenderStyle::visitedDepend entColor is reduced
2093 by ~10%, mostly due to removing the call to borderStyleForColorProperty.
2094
2095 * rendering/style/RenderStyle.cpp:
2096 (WebCore::RenderStyle::colorIncludingFallback): We now calculate the bor derStyle
2097 inside this function (which was already the case I just made it explicit ). Also
2098 simplified the final 'if' as the border will be set only for the right C SS border
2099 properties.
2100
2101 (WebCore::RenderStyle::visitedDependentColor): Removed the |borderStyle| variable
2102 as it was never read.
2103
2104 * rendering/style/RenderStyle.h: Removed the parameter.
2105
2106 2011-06-16 Pavel Podivilov <podivilov@chromium.org>
2107
2108 Reviewed by Yury Semikhatsky.
2109
2110 Web Inspector: breakpointsWithoutSourceFile values should be a maps, not arrays.
2111 https://bugs.webkit.org/show_bug.cgi?id=62714
2112
2113 * inspector/front-end/DebuggerPresentationModel.js:
2114 (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
2115 (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
2116 (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpointsFro mSettings):
2117 (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
2118 (WebInspector.DebuggerPresentationModel.prototype._reset):
2119 * inspector/front-end/Settings.js:
2120 (WebInspector.Settings):
2121 (WebInspector.Settings.prototype._set):
2122
2123 2011-06-17 Joone Hur <joone.hur@collabora.co.uk>
2124
2125 Reviewed by Martin Robinson.
2126
2127 [GTK] Replace GdkRectangle by cairo_rectangle_int_t
2128 https://bugs.webkit.org/show_bug.cgi?id=60687
2129
2130 Replace GdkRectangle by cairo_rectangle_int_t.
2131
2132 * GNUmakefile.list.am: Added IntRectCairo.cpp instead of IntRectGtk.cpp
2133 * platform/graphics/IntRect.h: IntRect class can be instantiated through the given cairo_rectangle_int_t
2134 instead of GdkRectangle.
2135 * platform/graphics/cairo/IntRectCairo.cpp: Add the constructor and oper ator for handling cairo_rectangle_int_t.
2136 (WebCore::IntRect::IntRect):
2137 (WebCore::IntRect::operator cairo_rectangle_int_t):
2138 * platform/graphics/gtk/IntRectGtk.cpp: Include this file only for Gtk+2 .
2139 * platform/gtk/GtkPluginWidget.cpp: Replace GdkRectangle by cairo_rectan gle_int_t.
2140 (WebCore::GtkPluginWidget::invalidateRect):
2141
2142 2011-06-17 Alexander Pavlov <apavlov@chromium.org>
2143
2144 Reviewed by David Hyatt.
2145
2146 Web Inspector: support for emulating element's pseudo class state in sty leRulesForElement()
2147 https://bugs.webkit.org/show_bug.cgi?id=61070
2148
2149 This patch is a slight rework of a solution by Alexander Udalov.
2150 It is supposed to help implement a feature in Web Inspector to examine
2151 style rules matched for different states of a given element.
2152 Web Inspector is supposed to pass a mask of ForcePseudoClassFlags to
2153 styleRulesForElement(), so that it will filter only the rules whose stat e
2154 (a set of pseudo classes in their selectors) matches a given
2155 mask, ignoring the state of the element itself.
2156 DoNotForcePseudoClassMask is the default behaviour; it always examines
2157 the state of a given element to make a match.
2158
2159 Tests will be provided in a subsequent Web Inspector change employing th is functionality.
2160
2161 * css/CSSStyleSelector.cpp:
2162 (WebCore::CSSStyleSelector::initForStyleResolve):
2163 (WebCore::CSSStyleSelector::styleRulesForElement):
2164 (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
2165 (WebCore::CSSStyleSelector::checkSelector):
2166 (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
2167 (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
2168 * css/CSSStyleSelector.h:
2169
2170 2011-06-17 Yury Semikhatsky <yurys@chromium.org>
2171
2172 Reviewed by Pavel Feldman.
2173
2174 Web Inspector: support preview mode for live edit changes
2175 https://bugs.webkit.org/show_bug.cgi?id=62851
2176
2177 Debugger.editScriptSource command now supports preview flag.
2178
2179 * bindings/js/ScriptDebugServer.cpp:
2180 (WebCore::ScriptDebugServer::editScriptSource):
2181 * bindings/js/ScriptDebugServer.h:
2182 * bindings/v8/ScriptDebugServer.cpp:
2183 (WebCore::ScriptDebugServer::editScriptSource):
2184 * bindings/v8/ScriptDebugServer.h:
2185 * inspector/Inspector.json:
2186 * inspector/InspectorDebuggerAgent.cpp:
2187 (WebCore::InspectorDebuggerAgent::editScriptSource):
2188 * inspector/InspectorDebuggerAgent.h:
2189
2190 2011-06-09 Hans Wennborg <hans@chromium.org>
2191
2192 Reviewed by Tony Gentilcore.
2193
2194 IndexedDB: backingStoreMap is per backing store, not per database
2195 https://bugs.webkit.org/show_bug.cgi?id=62382
2196
2197 IDBFactoryBackendImpl::m_backingStoreMap should contain an entry per
2198 backing store, not per database. Otherwise, we might accidentally open
2199 the same backing store more than once, which is dangerous.
2200
2201 Also tweak the code that chooses backing store type. It should be
2202 simple: we default to SQLite; if LevelDB is specifically requested, we
2203 use that. If LevelDB is requested and there is a SQLite database, we
2204 migrate.
2205
2206 No new tests, just cleaning up the code.
2207
2208 * storage/IDBFactoryBackendImpl.cpp:
2209 (WebCore::IDBFactoryBackendImpl::addIDBBackingStore):
2210 (WebCore::IDBFactoryBackendImpl::removeIDBBackingStore):
2211 (WebCore::IDBFactoryBackendImpl::open):
2212 (WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):
2213 * storage/IDBFactoryBackendImpl.h:
2214
2215 2011-06-17 Andrey Adaikin <aandrey@google.com>
2216
2217 Reviewed by Pavel Feldman.
2218
2219 Web Inspector: Source code which includes non-Latin character does not c orrespond to line number field on Inspector
2220 https://bugs.webkit.org/show_bug.cgi?id=62845
2221
2222 * inspector/front-end/TextViewer.js:
2223 (WebInspector.TextViewer.prototype._syncLineHeight):
2224 (WebInspector.TextEditorGutterPanel):
2225 (WebInspector.TextEditorGutterChunk.prototype.set expanded):
2226
2227 2011-06-16 Yury Semikhatsky <yurys@chromium.org>
2228
2229 Reviewed by Pavel Feldman.
2230
2231 Web Inspector: return description of the changes applied in response to editScriptSource command
2232 https://bugs.webkit.org/show_bug.cgi?id=62801
2233
2234 Return description of the changes made in response to Debugger.editScrip tSource command.
2235
2236 * bindings/js/ScriptDebugServer.cpp:
2237 (WebCore::ScriptDebugServer::editScriptSource):
2238 * bindings/js/ScriptDebugServer.h:
2239 * bindings/v8/DebuggerScript.js:
2240 ():
2241 * bindings/v8/ScriptDebugServer.cpp:
2242 (WebCore::ScriptDebugServer::editScriptSource):
2243 * bindings/v8/ScriptDebugServer.h:
2244 * inspector/Inspector.json:
2245
2246 2011-06-16 Gabor Loki <loki@webkit.org>
2247
2248 [Qt] Unreviewed, build fix after r89118.
2249
2250 * dom/XMLDocumentParserQt.cpp:
2251 (WebCore::XMLDocumentParser::initializeParserContext):
2252
2253 2011-06-16 Yuta Kitamura <yutak@chromium.org>
2254
2255 Unreviewed, rolling out r89073.
2256 http://trac.webkit.org/changeset/89073
2257 https://bugs.webkit.org/show_bug.cgi?id=62783
2258
2259 Broke Chromium Clang build.
2260
2261 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
2262 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
2263 (wkScrollbarPainterPaint):
2264 * platform/chromium/ScrollbarThemeChromiumMac.h:
2265 * platform/chromium/ScrollbarThemeChromiumMac.mm:
2266 (WebCore::ScrollbarThemeChromiumMac::paint):
2267
2268 2011-06-16 Jeffrey Pfau <jpfau@apple.com>
2269
2270 Reviewed by Alexey Proskuryakov.
2271
2272 Using null bytes when setting innerHTML in XTHML results in assertion an d a crash due to null-pointer dereference
2273 https://bugs.webkit.org/show_bug.cgi?id=61053
2274
2275 XML parsing in-memory XML chunks now passes around a string object inste ad of a C string, ensuring null characters are properly handled.
2276
2277 Tests: fast/parser/xhtml-innerhtml-null-byte-first.xhtml
2278 fast/parser/xhtml-innerhtml-null-byte.xhtml
2279
2280 * dom/XMLDocumentParser.h:
2281 * dom/XMLDocumentParserLibxml2.cpp:
2282 (WebCore::XMLParserContext::createMemoryParser):
2283 (WebCore::XMLDocumentParser::initializeParserContext):
2284 (WebCore::XMLDocumentParser::appendFragmentSource):
2285
2286 2011-06-16 Robin Dunn <robin@alldunn.com>
2287
2288 Reviewed by Kevin Ollivier.
2289
2290 [wx] Account for differing byte order when decoding images in the PPC bu ild.
2291
2292 https://bugs.webkit.org/show_bug.cgi?id=62830
2293
2294 * platform/image-decoders/wx/ImageDecoderWx.cpp:
2295 (WebCore::ImageFrame::asNewNativeImage):
2296
2297 2011-06-16 Darin Adler <darin@apple.com>
2298
2299 Reviewed by Dan Bernstein.
2300
2301 REGRESSION (r89035): HTMLTableRowsCollection constructor crashes; depend s on compiler order of evaluation
2302 https://bugs.webkit.org/show_bug.cgi?id=62836
2303
2304 Covered by existing tests on platforms where it occurs.
2305
2306 * html/HTMLTableRowsCollection.cpp:
2307 (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Add a call to get()
2308 to prevent the passing behavior of PassRefPtr from kicking in and changi ng the
2309 table pointer to 0, possibly before it is dereferenced.
2310
2311 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
2312
2313 Unreviewed, rolling out r89055.
2314 http://trac.webkit.org/changeset/89055
2315 https://bugs.webkit.org/show_bug.cgi?id=62835
2316
2317 Caused failures on all ports except GTK (Requested by
2318 mrobinson on #webkit).
2319
2320 * platform/network/soup/ResourceHandleSoup.cpp:
2321 (WebCore::statusWillBeHandledBySoup):
2322 (WebCore::soupErrorShouldCauseLoadFailure):
2323 (WebCore::convertSoupErrorToResourceError):
2324 (WebCore::sendRequestCallback):
2325
2326 2011-06-16 Ryosuke Niwa <rniwa@webkit.org>
2327
2328 Reviewed by Darin Adler.
2329
2330 Support logical line movement in vertical writing mode
2331 https://bugs.webkit.org/show_bug.cgi?id=62743
2332
2333 Fixed the bug by making xOffsetForVerticalNavigation (now called lineDir ectionPointForVerticalNavigation)
2334 aware of writing modes. Also extracted absoluteLineDirectionPointToLocal PointInBlock from previousLinePosition
2335 and nextLinePosition to convert a line direction point to a physical poi nt relative to a root inline box.
2336
2337 Tests: editing/selection/vertical-lr-ltr-extend-line-backward-br.html
2338 editing/selection/vertical-lr-ltr-extend-line-forward-br.html
2339 editing/selection/vertical-rl-ltr-extend-line-backward-br.html
2340 editing/selection/vertical-rl-ltr-extend-line-backward-p.html
2341 editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html
2342 editing/selection/vertical-rl-ltr-extend-line-forward-br.html
2343 editing/selection/vertical-rl-ltr-extend-line-forward-p.html
2344 editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html
2345 editing/selection/vertical-rl-rtl-extend-line-backward-br.html
2346 editing/selection/vertical-rl-rtl-extend-line-backward-p.html
2347 editing/selection/vertical-rl-rtl-extend-line-forward-br.html
2348 editing/selection/vertical-rl-rtl-extend-line-forward-p.html
2349
2350 * editing/FrameSelection.cpp:
2351 (WebCore::FrameSelection::modifyExtendingForward): Calls lineDirectionPo intForBlockDirectionNavigation.
2352 (WebCore::FrameSelection::modifyMovingForward): Ditto.
2353 (WebCore::FrameSelection::modifyExtendingBackward): Ditto.
2354 (WebCore::FrameSelection::modifyMovingBackward): Ditto.
2355 (WebCore::FrameSelection::modify): Ditto.
2356 (WebCore::FrameSelection::lineDirectionPointForBlockDirectionNavigation) : Renamed from
2357 xPosForVerticalArrowNavigation; calls VisiblePosition::lineDirectionPoin tForVerticalNavigation.
2358 * editing/FrameSelection.h:
2359 * editing/VisiblePosition.cpp:
2360 (WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation ): Renamed from
2361 xOffsetForVerticalNavigation. Returns line direction point instead of vi sual x coordinate.
2362 * editing/VisiblePosition.h:
2363 * editing/visible_units.cpp:
2364 (WebCore::absoluteLineDirectionPointToLocalPointInBlock): Extracted from previousLinePosition and
2365 nextLinePosition. Takes care or writing modes.
2366 (WebCore::previousLinePosition): Calls absoluteLineDirectionPointToLocal PointInBlock.
2367 (WebCore::nextLinePosition): Ditto.
2368 * editing/visible_units.h:
2369 * rendering/RootInlineBox.cpp:
2370 (WebCore::RootInlineBox::closestLeafChildForPoint): Added; takes a physi cal point and calls
2371 closestLeafChildForLogicalLeftPosition with logical x.
2372 * rendering/RootInlineBox.h:
2373
2374 2011-06-16 Nate Chapin <japhet@chromium.org>
2375
2376 Reviewed by Alexey Proskuryakov.
2377
2378 Set the referrer on a ResourceRequest from a WorkerThreadableLoader
2379 as soon as the request reaches the main thread and remove the
2380 optionalOutgoingReferrer parameter from some functions.
2381 https://bugs.webkit.org/show_bug.cgi?id=62806
2382
2383 * loader/DocumentThreadableLoader.cpp:
2384 (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
2385 (WebCore::DocumentThreadableLoader::create):
2386 (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
2387 (WebCore::DocumentThreadableLoader::loadRequest):
2388 * loader/DocumentThreadableLoader.h:
2389 * loader/ResourceLoadScheduler.cpp:
2390 (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad):
2391 * loader/ResourceLoadScheduler.h:
2392 * loader/SubresourceLoader.cpp:
2393 (WebCore::SubresourceLoader::create):
2394 * loader/SubresourceLoader.h:
2395 * loader/WorkerThreadableLoader.cpp:
2396 (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoad er):
2397
2398 2011-06-16 Eric Seidel <eric@webkit.org>
2399
2400 Reviewed by Adam Barth.
2401
2402 FrameLoader doesn't need completeURL or baseURL
2403 https://bugs.webkit.org/show_bug.cgi?id=62818
2404
2405 No functional change, thus no tests.
2406
2407 * html/HTMLPlugInImageElement.cpp:
2408 (WebCore::HTMLPlugInImageElement::isImageType):
2409 (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
2410 * inspector/InspectorPageAgent.cpp:
2411 (WebCore::InspectorPageAgent::open):
2412 * loader/FrameLoader.cpp:
2413 * loader/FrameLoader.h:
2414 * loader/NavigationScheduler.cpp:
2415 (WebCore::NavigationScheduler::scheduleLocationChange):
2416 * page/History.cpp:
2417 (WebCore::History::urlForState):
2418
2419 2011-06-16 Dawit Alemayehu <adawit@kde.org>
2420
2421 Reviewed by Antonio Gomes.
2422
2423 Support for gnash flash player plugin in QtWebKit
2424
2425 [Qt] Support for the gnash flash player plugin
2426 https://bugs.webkit.org/show_bug.cgi?id=62283
2427
2428 No new tests needed. Existing nsplugin tests are sufficient.
2429
2430 * plugins/qt/PluginPackageQt.cpp:
2431 (WebCore::PluginPackage::load):
2432
2433 2011-06-16 Sailesh Agrawal <sail@chromium.org>
2434
2435 Reviewed by Mihai Parparita.
2436
2437 [Chromium] Draw search tickmarks on overlay scrollbars
2438 https://bugs.webkit.org/show_bug.cgi?id=62783
2439
2440 This change adds search tickmark support for overlay scrollbars. Tickmar ks are only drawn when the scroll track is visible.
2441
2442 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:Split the scr ollbar drawing code into a track and knob version.
2443 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
2444 (wkScrollbarPainterPaint):
2445 (wkScrollbarPainterPaintTrack):
2446 (wkScrollbarPainterPaintKnob):
2447 * platform/chromium/ScrollbarThemeChromiumMac.h:
2448 * platform/chromium/ScrollbarThemeChromiumMac.mm:Factor out the paint ti ckmark code and call it from the overlay scrollbar drawing code.
2449 (WebCore::ScrollbarThemeChromiumMac::paint):
2450 (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
2451
2452 2011-06-16 Geoffrey Garen <ggaren@apple.com>
2453
2454 Reviewed by Oliver Hunt.
2455
2456 Introduced SlotVisitor into the project
2457 https://bugs.webkit.org/show_bug.cgi?id=62820
2458
2459 This resolves a class vs typedef forward declaration issue, and gives al l
2460 exported symbols the correct names.
2461
2462 * dom/EventListener.h:
2463 * dom/Node.h:
2464 * dom/NodeFilterCondition.h:
2465
2466 2011-06-16 Abhishek Arya <inferno@chromium.org>
2467
2468 Reviewed by Adam Barth.
2469
2470 RefPtr frame since it can get removed in
2471 FrameLoader::finishedParsing.
2472 https://bugs.webkit.org/show_bug.cgi?id=62812
2473
2474 Tests: already tested by fast/parser/document-write-into-initial-documen t.html.
2475
2476 * dom/Document.cpp:
2477 (WebCore::Document::finishedParsing):
2478
2479 2011-06-16 Sailesh Agrawal <sail@chromium.org>
2480
2481 Reviewed by Mihai Parparita.
2482
2483 [Chromium] Update forked ScrollAnimatorChromiumMac.mm/h
2484 https://bugs.webkit.org/show_bug.cgi?id=62779
2485
2486 Updated ScrollAnimatorChromiumMac.mm/h with the latest code in WebCore/p latform/mac/ScrollAnimatorMac.mm/h
2487
2488 * platform/chromium/ScrollAnimatorChromiumMac.h:
2489 (WebCore::ScrollAnimatorChromiumMac::setNeedsScrollerStyleUpdate):
2490 (WebCore::ScrollAnimatorChromiumMac::needsScrollerStyleUpdate):
2491 * platform/chromium/ScrollAnimatorChromiumMac.mm:
2492 (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
2493 (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyl eForNewRecommendedScrollerStyle:]):
2494 (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
2495 (WebCore::ScrollAnimatorChromiumMac::scroll):
2496 (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPointForScrollAnim ation):
2497 (WebCore::isScrollingLeftAndShouldNotRubberBand):
2498 (WebCore::isScrollingRightAndShouldNotRubberBand):
2499 (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
2500 (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
2501 (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture):
2502 (WebCore::ScrollAnimatorChromiumMac::snapRubberBand):
2503 (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired):
2504 (WebCore::ScrollAnimatorChromiumMac::setIsActive):
2505 (WebCore::ScrollAnimatorChromiumMac::updateScrollerStyle):
2506 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
2507 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
2508 (wkScrollbarPainterControllerStyle):
2509
2510 2011-06-16 Sailesh Agrawal <sail@chromium.org>
2511
2512 Reviewed by Mihai Parparita.
2513
2514 [Chromium] Overlay scrollbars leave glitches on web content
2515 https://bugs.webkit.org/show_bug.cgi?id=62383
2516
2517 Enable overlay scrollbars on Chromium Mac.
2518
2519 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
2520 (preferredScrollerStyle):
2521
2522 2011-06-16 una sabovic <una.sabovic@palm.com>
2523
2524 Reviewed by Simon Fraser.
2525
2526 Optimization: do a single fillRect when painting the root background in RenderBoxModelObject::paintFillLayerExtended
2527 https://bugs.webkit.org/show_bug.cgi?id=62593
2528
2529 When painting the root background, instead of doing two fillRects blend the base with background color and do a single fillRect.
2530
2531 No new tests. This is an optimization and it doesn't change any existing functionality.
2532
2533 * rendering/RenderBoxModelObject.cpp:
2534 (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2535
2536 2011-06-16 Ryosuke Niwa <rniwa@webkit.org>
2537
2538 Reviewed by Eric Seidel.
2539
2540 Consider padding and border when looking for the next/previous line posi tion
2541 https://bugs.webkit.org/show_bug.cgi?id=55481
2542
2543 The bug was caused by previousLinePosition and nextLinePosition passing y coordinate
2544 above the line in some cases. Fixed the bug by passing the larger of sel ectionTop and logicalTop.
2545
2546 This patch is based on a patch originally written by Mario Sanchez Prada <msanchez@igalia.com>.
2547
2548 Test: editing/selection/move-vertically-with-paddings-borders.html
2549
2550 * editing/visible_units.cpp:
2551 (WebCore::previousLinePosition):
2552 (WebCore::nextLinePosition):
2553 * rendering/RootInlineBox.h:
2554 (WebCore::RootInlineBox::blockDirectionPointInLine):
2555
2556 2011-06-16 Keunsoon Lee <keunsoon.lee@samsung.com>
2557
2558 Reviewed by Martin Robinson.
2559
2560 [SOUP] Abnormal operation if server sends 5xx status code without HTTP b ody
2561 https://bugs.webkit.org/show_bug.cgi?id=60875
2562
2563 Handle status code 4xx and 5xx after receiving HTTP body
2564
2565 Webkit soup port premises that server always sends error page
2566 in case server sends error code, 4xx and 5xx.
2567 But, sometimes there is no HTTP body for error page.
2568 In that case, Webkit does nothing or tries to download the HTTP response
2569 according to received MIME Type even if there is no HTTP body. (abnormal operation)
2570
2571 With this modification,
2572 Browser will show received error page if server sends error page.
2573 Or it will show its own error page from each port if server sends nothin g.
2574
2575 Modified algorithm
2576 1) libsoup sends status code 4xx or 5xx (client error or server error)
2577 2) Webkit soup port orders to accumulate HTTP body chunks to libsoup.
2578 3) Webkit soup port ignores gotHeadersCallback, contentSniffedCallback a nd gotChunkCallback.
2579 4) Webkit soup port checks there is HTTP body or not on sendRequestCallb ack and;
2580 4-1) if there is HTTP body, calls didReceiveResponse()
2581 4-2) if there is no HTTP body, calls didFail() - prevent the abnorm al operation
2582
2583 Test: http/tests/loading/status-code-error-without-response-body.html
2584
2585 * platform/network/soup/ResourceHandleSoup.cpp:
2586 (WebCore::statusWillBeHandledBySoup):
2587 Add a new condition, SOUP_STATUS_IS_CLIENT_ERROR() and SOUP_STATUS_I S_SERVER_ERROR()
2588 (WebCore::soupErrorAndHaveNotReceivedBody):
2589 Add a new helper function, it checks received body is exist if soup sends error code
2590 (WebCore::soupErrorShouldCauseLoadFailure):
2591 Add a new condition, soupErrorAndHaveNotReceivedBody()
2592 (WebCore::convertSoupErrorToResourceError):
2593 Add a new condition, soupErrorAndHaveNotReceivedBody()
2594 (WebCore::sendRequestCallback):
2595 Check handle->client() again, because didReceiveResponse() can make i t zero
2596
2597 2011-06-16 Vsevolod Vlasov <vsevik@chromium.org>
2598
2599 Reviewed by Pavel Feldman.
2600
2601 Web Inspector: Network panel shows incorrect query parameters when url h as fragment.
2602 https://bugs.webkit.org/show_bug.cgi?id=62723
2603
2604 * English.lproj/localizedStrings.js:
2605 * inspector/front-end/HAREntry.js:
2606 (WebInspector.HAREntry.prototype._buildRequest):
2607 (WebInspector.HAREntry.prototype._buildRequestURL):
2608 * inspector/front-end/Resource.js:
2609 (WebInspector.Resource.prototype.set url):
2610 (WebInspector.Resource.prototype.get queryParameters):
2611 * inspector/front-end/ResourceHeadersView.js:
2612 (WebInspector.ResourceHeadersView):
2613 (WebInspector.ResourceHeadersView.prototype._refreshUrlFragment):
2614
2615 2011-06-16 Dimitri Glazkov <dglazkov@chromium.org>
2616
2617 Clang fix after r89039.
2618
2619 * rendering/RenderThemeMac.h: Removed spurious constipation.
2620 * rendering/RenderThemeMac.mm:
2621 (WebCore::RenderThemeMac::fileListNameForWidth): Ditto.
2622
2623 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
2624
2625 Unreviewed, rolling out r89026.
2626 http://trac.webkit.org/changeset/89026
2627 https://bugs.webkit.org/show_bug.cgi?id=62804
2628
2629 These patches were likely correct. I'll investigate the
2630 browser_test failures. (Requested by abarth on #webkit).
2631
2632 * WebCore.exp.in:
2633 * bindings/js/ScheduledAction.cpp:
2634 (WebCore::ScheduledAction::execute):
2635 * bindings/js/ScriptController.cpp:
2636 (WebCore::ScriptController::ScriptController):
2637 (WebCore::ScriptController::processingUserGesture):
2638 * bindings/js/ScriptController.h:
2639 * bindings/v8/ScriptController.cpp:
2640 (WebCore::ScriptController::ScriptController):
2641 (WebCore::ScriptController::processingUserGesture):
2642 * bindings/v8/ScriptController.h:
2643 * dom/Event.cpp:
2644 * dom/Event.h:
2645 * dom/UserGestureIndicator.cpp:
2646 (WebCore::isDefinite):
2647 (WebCore::UserGestureIndicator::UserGestureIndicator):
2648 (WebCore::UserGestureIndicator::~UserGestureIndicator):
2649 * dom/UserGestureIndicator.h:
2650 (WebCore::UserGestureIndicator::processingUserGesture):
2651 * html/HTMLMediaElement.cpp:
2652 (WebCore::HTMLMediaElement::removedFromDocument):
2653 (WebCore::HTMLMediaElement::load):
2654 (WebCore::HTMLMediaElement::play):
2655 (WebCore::HTMLMediaElement::pause):
2656 (WebCore::HTMLMediaElement::beginScrubbing):
2657 (WebCore::HTMLMediaElement::resume):
2658 * html/HTMLMediaElement.h:
2659 * html/HTMLMediaElement.idl:
2660 * html/HTMLVideoElement.cpp:
2661 (WebCore::HTMLVideoElement::webkitEnterFullscreen):
2662 * html/HTMLVideoElement.h:
2663 (WebCore::HTMLVideoElement::webkitEnterFullScreen):
2664 * html/HTMLVideoElement.idl:
2665 * html/MediaDocument.cpp:
2666 (WebCore::MediaDocument::defaultEventHandler):
2667 * html/shadow/MediaControlElements.cpp:
2668 (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
2669 * html/shadow/TextControlInnerElements.cpp:
2670 (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
2671
2672 2011-06-16 Dimitri Glazkov <dglazkov@chromium.org>
2673
2674 [Qt] Build fix after r89039.
2675
2676 * WebCore.pro: Added StringTruncator to build system.
2677 * platform/qt/RenderThemeQt.cpp: Reverted previous change.
2678
2679 2011-06-16 Dimitri Glazkov <dglazkov@chromium.org>
2680
2681 [Qt] Build fix after r89039.
2682
2683 * platform/qt/RenderThemeQt.cpp: Added StringTruncator include.
2684
2685 2011-06-16 Dimitri Glazkov <dglazkov@chromium.org>
2686
2687 [Qt] Build fix after r89039.
2688
2689 * platform/qt/RenderThemeQt.h: Renamed local variable f to font.
2690
2691 2011-06-16 Dimitri Glazkov <dglazkov@chromium.org>
2692
2693 [Qt] Build fix after r89039.
2694
2695 * platform/qt/RenderThemeQt.h: Move decl out of ENABLE(VIDEO) ifdef.
2696
2697 2011-06-15 Dimitri Glazkov <dglazkov@chromium.org>
2698
2699 Reviewed by Kent Tamura.
2700
2701 Move FileChooser::basenameForWidth to RenderTheme::fileListNameForWidth, eliminate gnarly FileChooserFoo proliferation.
2702 https://bugs.webkit.org/show_bug.cgi?id=62748
2703
2704 Refactoring, covered by existing tests.
2705
2706 * CMakeListsEfl.txt: Removed FileChooserFoo from build system.
2707 * CMakeListsWinCE.txt: Ditto.
2708 * GNUmakefile.list.am: Ditto.
2709 * WebCore.gypi: Ditto.
2710 * WebCore.order: Ditto.
2711 * WebCore.pro: Ditto.
2712 * WebCore.vcproj/WebCore.vcproj: Ditto.
2713 * WebCore.xcodeproj/project.pbxproj: Ditto.
2714 * platform/FileChooser.h: Removed baseNameForWidth decl.
2715 * platform/FileSystem.h: Removed now-unnecessary Chromium-specific cruft .
2716 * platform/android/FileChooserAndroid.cpp: Removed.
2717 * platform/brew/FileChooserBrew.cpp: Removed.
2718 * platform/chromium/FileChooserChromium.cpp: Removed.
2719 * platform/chromium/FileSystemChromiumLinux.cpp: Removed now-unnecessary code.
2720 * platform/chromium/FileSystemChromiumMac.mm: Ditto.
2721 * platform/chromium/FileSystemChromiumWin.cpp: Ditto.
2722 * platform/efl/FileChooserEfl.cpp: Removed.
2723 * platform/gtk/FileChooserGtk.cpp: Removed.
2724 * platform/gtk/RenderThemeGtk.cpp:
2725 (WebCore::stringByAdoptingFileSystemRepresentation): Moved from FileChoo serGtk.
2726 (WebCore::RenderThemeGtk::fileListNameForWidth): Ditto.
2727 * platform/gtk/RenderThemeGtk.h: Added decl.
2728 * platform/haiku/FileChooserHaiku.cpp: Removed.
2729 * platform/mac/FileChooserMac.mm: Removed.
2730 * platform/qt/FileChooserQt.cpp: Removed.
2731 * platform/qt/RenderThemeQt.cpp:
2732 (WebCore::RenderThemeQt::RenderThemeQt): Moved from FileChooserQt.
2733 (WebCore::RenderThemeQt::fileListNameForWidth): Ditto.
2734 * platform/qt/RenderThemeQt.h: Adde decl.
2735 * platform/win/FileChooserWin.cpp: Removed.
2736 * platform/wx/FileChooserWx.cpp: Removed.
2737 * rendering/RenderFileUploadControl.cpp:
2738 (WebCore::RenderFileUploadControl::fileTextValue): Changed to use Render Theme.
2739 * rendering/RenderTheme.cpp:
2740 (WebCore::RenderTheme::fileListNameForWidth): Added default impl.
2741 * rendering/RenderTheme.h: Added decl.
2742 * rendering/RenderThemeMac.h: Ditto.
2743 * rendering/RenderThemeMac.mm:
2744 (WebCore::RenderThemeMac::fileListNameForWidth): Added default Mac impl.
2745
2746 2011-06-16 Vsevolod Vlasov <vsevik@chromium.org>
2747
2748 Reviewed by Pavel Feldman.
2749
2750 Web Inspector: Cache XHR content in backend, do not use initialContentSe t for XHRs.
2751 https://bugs.webkit.org/show_bug.cgi?id=61205
2752
2753 Added inspector backend cache for XHR content.
2754
2755 Tests: http/tests/inspector/network/network-xhr-async.html
2756 http/tests/inspector/network/network-xhr-sync.html
2757
2758 * CMakeLists.txt:
2759 * GNUmakefile.list.am:
2760 * WebCore.gypi:
2761 * WebCore.pro:
2762 * WebCore.vcproj/WebCore.vcproj:
2763 * WebCore.xcodeproj/project.pbxproj:
2764 * fileapi/FileReaderLoader.cpp:
2765 (WebCore::FileReaderLoader::didReceiveResponse):
2766 * fileapi/FileReaderLoader.h:
2767 * inspector/Inspector.json:
2768 * inspector/InspectorInstrumentation.cpp:
2769 (WebCore::InspectorInstrumentation::didReceiveXHRResponseImpl):
2770 (WebCore::InspectorInstrumentation::willLoadXHRSynchronouslyImpl):
2771 (WebCore::InspectorInstrumentation::didLoadXHRSynchronouslyImpl):
2772 (WebCore::InspectorInstrumentation::didCommitLoadImpl):
2773 * inspector/InspectorInstrumentation.h:
2774 (WebCore::InspectorInstrumentation::didReceiveXHRResponse):
2775 (WebCore::InspectorInstrumentation::willLoadXHRSynchronously):
2776 (WebCore::InspectorInstrumentation::didLoadXHRSynchronously):
2777 * inspector/InspectorResourceAgent.cpp:
2778 (WebCore::InspectorResourceAgent::willSendRequest):
2779 (WebCore::InspectorResourceAgent::didReceiveResponse):
2780 (WebCore::InspectorResourceAgent::setInitialXHRContent):
2781 (WebCore::InspectorResourceAgent::didReceiveXHRResponse):
2782 (WebCore::InspectorResourceAgent::willLoadXHRSynchronously):
2783 (WebCore::InspectorResourceAgent::didLoadXHRSynchronously):
2784 (WebCore::InspectorResourceAgent::getResourceContent):
2785 (WebCore::InspectorResourceAgent::mainFrameNavigated):
2786 (WebCore::InspectorResourceAgent::InspectorResourceAgent):
2787 * inspector/InspectorResourceAgent.h:
2788 * inspector/NetworkResourcesData.cpp: Added.
2789 (WebCore::NetworkResourcesData::ResourceData::ResourceData):
2790 (WebCore::NetworkResourcesData::ResourceData::content):
2791 (WebCore::NetworkResourcesData::ResourceData::appendContent):
2792 (WebCore::NetworkResourcesData::ResourceData::purgeContent):
2793 (WebCore::NetworkResourcesData::NetworkResourcesData):
2794 (WebCore::NetworkResourcesData::~NetworkResourcesData):
2795 (WebCore::NetworkResourcesData::resourceCreated):
2796 (WebCore::NetworkResourcesData::responseReceived):
2797 (WebCore::NetworkResourcesData::didReceiveXHRResponse):
2798 (WebCore::NetworkResourcesData::addResourceContent):
2799 (WebCore::NetworkResourcesData::isXHR):
2800 (WebCore::NetworkResourcesData::data):
2801 (WebCore::NetworkResourcesData::clear):
2802 (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
2803 (WebCore::NetworkResourcesData::ensureFreeSpace):
2804 * inspector/NetworkResourcesData.h: Added.
2805 (WebCore::NetworkResourcesData::ResourceData::identifier):
2806 (WebCore::NetworkResourcesData::ResourceData::loaderId):
2807 (WebCore::NetworkResourcesData::ResourceData::frameId):
2808 (WebCore::NetworkResourcesData::ResourceData::setFrameId):
2809 (WebCore::NetworkResourcesData::ResourceData::url):
2810 (WebCore::NetworkResourcesData::ResourceData::setUrl):
2811 (WebCore::NetworkResourcesData::ResourceData::isXHR):
2812 (WebCore::NetworkResourcesData::ResourceData::setIsXHR):
2813 (WebCore::NetworkResourcesData::ResourceData::hasContent):
2814 (WebCore::NetworkResourcesData::ResourceData::isContentPurged):
2815 (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged):
2816 * inspector/front-end/NetworkManager.js:
2817 (WebInspector.NetworkManager.prototype.requestContent):
2818 (WebInspector.NetworkDispatcher.prototype._appendRedirect):
2819 * inspector/front-end/NetworkPanel.js:
2820 (WebInspector.NetworkPanel.prototype._appendResource):
2821 (WebInspector.NetworkPanel.prototype._frameNavigated):
2822 * loader/DocumentThreadableLoader.cpp:
2823 (WebCore::DocumentThreadableLoader::didReceiveResponse):
2824 (WebCore::DocumentThreadableLoader::receivedCancellation):
2825 (WebCore::DocumentThreadableLoader::loadRequest):
2826 * loader/DocumentThreadableLoader.h:
2827 * loader/ThreadableLoaderClient.h:
2828 (WebCore::ThreadableLoaderClient::didReceiveResponse):
2829 (WebCore::ThreadableLoaderClient::didReceiveAuthenticationCancellation):
2830 * loader/ThreadableLoaderClientWrapper.h:
2831 (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse):
2832 (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancell ation):
2833 * loader/WorkerThreadableLoader.cpp:
2834 (WebCore::workerContextDidReceiveResponse):
2835 (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
2836 (WebCore::workerContextDidReceiveAuthenticationCancellation):
2837 (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthentica tionCancellation):
2838 * loader/WorkerThreadableLoader.h:
2839 * notifications/Notification.cpp:
2840 (WebCore::Notification::didReceiveResponse):
2841 (WebCore::Notification::didReceiveAuthenticationCancellation):
2842 * notifications/Notification.h:
2843 * page/EventSource.cpp:
2844 (WebCore::EventSource::didReceiveResponse):
2845 * page/EventSource.h:
2846 * workers/WorkerScriptLoader.cpp:
2847 (WebCore::WorkerScriptLoader::didReceiveResponse):
2848 (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation):
2849 * workers/WorkerScriptLoader.h:
2850 * xml/XMLHttpRequest.cpp:
2851 (WebCore::XMLHttpRequest::createRequest):
2852 (WebCore::XMLHttpRequest::didReceiveResponse):
2853 (WebCore::XMLHttpRequest::didReceiveAuthenticationCancellation):
2854 * xml/XMLHttpRequest.h:
2855
2856 2011-06-16 Julien Chaffraix <jchaffraix@webkit.org>
2857
2858 Reviewed by Darin Adler.
2859
2860 HTMLTable should cache its 'rows' collection results
2861 https://bugs.webkit.org/show_bug.cgi?id=62800
2862
2863 Test: perf/table-rows-length-caching.html
2864
2865 Currently all our HTMLCollection's are recreated on call. This means tha t
2866 we don't cache the information about the collection between calls to, fo r
2867 example, table.rows.
2868
2869 This change adds a CollectionCache to HTMLTableElement. It is similar to what
2870 is done for HTMLFormElement.
2871
2872 * html/HTMLTableElement.cpp:
2873 (WebCore::HTMLTableElement::collectionCache): This method does
2874 lazy initialization of the table's collectionCache.
2875 * html/HTMLTableElement.h: Added a new member and the previous
2876 method.
2877
2878 * html/HTMLTableRowsCollection.cpp:
2879 (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Pass
2880 the HTMLTableElement's CollectionCache so that we reuse the cached
2881 results.
2882
2883 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
2884
2885 Unreviewed, rolling out r89025.
2886 http://trac.webkit.org/changeset/89025
2887 https://bugs.webkit.org/show_bug.cgi?id=62799
2888
2889 "Some layout tests fail" (Requested by yurys on #webkit).
2890
2891 * CMakeLists.txt:
2892 * GNUmakefile.list.am:
2893 * WebCore.gypi:
2894 * WebCore.pro:
2895 * WebCore.vcproj/WebCore.vcproj:
2896 * WebCore.xcodeproj/project.pbxproj:
2897 * fileapi/FileReaderLoader.cpp:
2898 (WebCore::FileReaderLoader::didReceiveResponse):
2899 * fileapi/FileReaderLoader.h:
2900 * inspector/Inspector.json:
2901 * inspector/InspectorInstrumentation.cpp:
2902 (WebCore::InspectorInstrumentation::didCommitLoadImpl):
2903 * inspector/InspectorInstrumentation.h:
2904 * inspector/InspectorResourceAgent.cpp:
2905 (WebCore::InspectorResourceAgent::willSendRequest):
2906 (WebCore::InspectorResourceAgent::didReceiveResponse):
2907 (WebCore::InspectorResourceAgent::setInitialXHRContent):
2908 (WebCore::InspectorResourceAgent::InspectorResourceAgent):
2909 * inspector/InspectorResourceAgent.h:
2910 * inspector/NetworkResourcesData.cpp: Removed.
2911 * inspector/NetworkResourcesData.h: Removed.
2912 * inspector/front-end/NetworkManager.js:
2913 (WebInspector.NetworkManager.prototype.requestContent):
2914 (WebInspector.NetworkDispatcher.prototype._appendRedirect):
2915 * inspector/front-end/NetworkPanel.js:
2916 (WebInspector.NetworkPanel.prototype._appendResource):
2917 (WebInspector.NetworkPanel.prototype._frameNavigated):
2918 * loader/DocumentThreadableLoader.cpp:
2919 (WebCore::DocumentThreadableLoader::didReceiveResponse):
2920 (WebCore::DocumentThreadableLoader::receivedCancellation):
2921 (WebCore::DocumentThreadableLoader::loadRequest):
2922 * loader/DocumentThreadableLoader.h:
2923 * loader/ThreadableLoaderClient.h:
2924 (WebCore::ThreadableLoaderClient::didReceiveResponse):
2925 (WebCore::ThreadableLoaderClient::didReceiveAuthenticationCancellation):
2926 * loader/ThreadableLoaderClientWrapper.h:
2927 (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse):
2928 (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancell ation):
2929 * loader/WorkerThreadableLoader.cpp:
2930 (WebCore::workerContextDidReceiveResponse):
2931 (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
2932 (WebCore::workerContextDidReceiveAuthenticationCancellation):
2933 (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthentica tionCancellation):
2934 * loader/WorkerThreadableLoader.h:
2935 * notifications/Notification.cpp:
2936 (WebCore::Notification::didReceiveResponse):
2937 (WebCore::Notification::didReceiveAuthenticationCancellation):
2938 * notifications/Notification.h:
2939 * page/EventSource.cpp:
2940 (WebCore::EventSource::didReceiveResponse):
2941 * page/EventSource.h:
2942 * workers/WorkerScriptLoader.cpp:
2943 (WebCore::WorkerScriptLoader::didReceiveResponse):
2944 (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation):
2945 * workers/WorkerScriptLoader.h:
2946 * xml/XMLHttpRequest.cpp:
2947 (WebCore::XMLHttpRequest::createRequest):
2948 (WebCore::XMLHttpRequest::didReceiveResponse):
2949 (WebCore::XMLHttpRequest::didReceiveAuthenticationCancellation):
2950 * xml/XMLHttpRequest.h:
2951
2952 2011-06-16 Vitaly Repeshko <vitalyr@chromium.org>
2953
2954 Unreviewed.
2955
2956 Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
2957 https://bugs.webkit.org/show_bug.cgi?id=62796
2958
2959 The patches broke chromium browser tests.
2960
2961 * WebCore.exp.in:
2962 * bindings/js/ScheduledAction.cpp:
2963 (WebCore::ScheduledAction::execute):
2964 * bindings/js/ScriptController.cpp:
2965 (WebCore::ScriptController::ScriptController):
2966 (WebCore::ScriptController::processingUserGesture):
2967 (WebCore::ScriptController::isJavaScriptAnchorNavigation):
2968 * bindings/js/ScriptController.h:
2969 (WebCore::ScriptController::setProcessingTimerCallback):
2970 * bindings/v8/ScriptController.cpp:
2971 (WebCore::ScriptController::ScriptController):
2972 (WebCore::ScriptController::processingUserGesture):
2973 * bindings/v8/ScriptController.h:
2974 (WebCore::ScriptController::setProcessingTimerCallback):
2975 * dom/Event.cpp:
2976 (WebCore::Event::fromUserGesture):
2977 * dom/Event.h:
2978 * dom/UserGestureIndicator.cpp:
2979 (WebCore::UserGestureIndicator::UserGestureIndicator):
2980 (WebCore::UserGestureIndicator::~UserGestureIndicator):
2981 * dom/UserGestureIndicator.h:
2982 (WebCore::UserGestureIndicator::processingUserGesture):
2983 (WebCore::UserGestureIndicator::getUserGestureState):
2984 * html/HTMLMediaElement.cpp:
2985 (WebCore::HTMLMediaElement::removedFromDocument):
2986 (WebCore::HTMLMediaElement::load):
2987 (WebCore::HTMLMediaElement::play):
2988 (WebCore::HTMLMediaElement::pause):
2989 (WebCore::HTMLMediaElement::beginScrubbing):
2990 (WebCore::HTMLMediaElement::resume):
2991 (WebCore::HTMLMediaElement::processingUserGesture):
2992 * html/HTMLMediaElement.h:
2993 * html/HTMLMediaElement.idl:
2994 * html/HTMLVideoElement.cpp:
2995 (WebCore::HTMLVideoElement::webkitEnterFullscreen):
2996 * html/HTMLVideoElement.h:
2997 (WebCore::HTMLVideoElement::webkitEnterFullScreen):
2998 * html/HTMLVideoElement.idl:
2999 * html/MediaDocument.cpp:
3000 (WebCore::MediaDocument::defaultEventHandler):
3001 * html/shadow/MediaControlElements.cpp:
3002 (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
3003 * html/shadow/TextControlInnerElements.cpp:
3004 (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
3005
3006 2011-06-16 Vsevolod Vlasov <vsevik@chromium.org>
3007
3008 Reviewed by Yury Semikhatsky.
3009
3010 Web Inspector: Cache XHR content in backend, do not use initialContentSe t for XHRs.
3011 https://bugs.webkit.org/show_bug.cgi?id=61205
3012
3013 Added inspector backend cache for XHR content.
3014
3015 Tests: http/tests/inspector/network/network-xhr-async.html
3016 http/tests/inspector/network/network-xhr-sync.html
3017
3018 * CMakeLists.txt:
3019 * GNUmakefile.list.am:
3020 * WebCore.gypi:
3021 * WebCore.pro:
3022 * WebCore.vcproj/WebCore.vcproj:
3023 * WebCore.xcodeproj/project.pbxproj:
3024 * fileapi/FileReaderLoader.cpp:
3025 (WebCore::FileReaderLoader::didReceiveResponse):
3026 * fileapi/FileReaderLoader.h:
3027 * inspector/Inspector.json:
3028 * inspector/InspectorInstrumentation.cpp:
3029 (WebCore::InspectorInstrumentation::didReceiveXHRResponseImpl):
3030 (WebCore::InspectorInstrumentation::willLoadXHRSynchronouslyImpl):
3031 (WebCore::InspectorInstrumentation::didLoadXHRSynchronouslyImpl):
3032 (WebCore::InspectorInstrumentation::didCommitLoadImpl):
3033 * inspector/InspectorInstrumentation.h:
3034 (WebCore::InspectorInstrumentation::didReceiveXHRResponse):
3035 (WebCore::InspectorInstrumentation::willLoadXHRSynchronously):
3036 (WebCore::InspectorInstrumentation::didLoadXHRSynchronously):
3037 * inspector/InspectorResourceAgent.cpp:
3038 (WebCore::InspectorResourceAgent::willSendRequest):
3039 (WebCore::InspectorResourceAgent::didReceiveResponse):
3040 (WebCore::InspectorResourceAgent::setInitialXHRContent):
3041 (WebCore::InspectorResourceAgent::didReceiveXHRResponse):
3042 (WebCore::InspectorResourceAgent::willLoadXHRSynchronously):
3043 (WebCore::InspectorResourceAgent::didLoadXHRSynchronously):
3044 (WebCore::InspectorResourceAgent::getResourceContent):
3045 (WebCore::InspectorResourceAgent::mainFrameNavigated):
3046 (WebCore::InspectorResourceAgent::InspectorResourceAgent):
3047 * inspector/InspectorResourceAgent.h:
3048 * inspector/NetworkResourcesData.cpp: Added.
3049 (WebCore::NetworkResourcesData::ResourceData::ResourceData):
3050 (WebCore::NetworkResourcesData::ResourceData::content):
3051 (WebCore::NetworkResourcesData::ResourceData::appendContent):
3052 (WebCore::NetworkResourcesData::ResourceData::purgeContent):
3053 (WebCore::NetworkResourcesData::NetworkResourcesData):
3054 (WebCore::NetworkResourcesData::~NetworkResourcesData):
3055 (WebCore::NetworkResourcesData::resourceCreated):
3056 (WebCore::NetworkResourcesData::responseReceived):
3057 (WebCore::NetworkResourcesData::didReceiveXHRResponse):
3058 (WebCore::NetworkResourcesData::addResourceContent):
3059 (WebCore::NetworkResourcesData::isXHR):
3060 (WebCore::NetworkResourcesData::data):
3061 (WebCore::NetworkResourcesData::clear):
3062 (WebCore::NetworkResourcesData::ensureFreeSpace):
3063 * inspector/NetworkResourcesData.h: Added.
3064 (WebCore::NetworkResourcesData::ResourceData::identifier):
3065 (WebCore::NetworkResourcesData::ResourceData::loaderId):
3066 (WebCore::NetworkResourcesData::ResourceData::frameId):
3067 (WebCore::NetworkResourcesData::ResourceData::setFrameId):
3068 (WebCore::NetworkResourcesData::ResourceData::url):
3069 (WebCore::NetworkResourcesData::ResourceData::setUrl):
3070 (WebCore::NetworkResourcesData::ResourceData::isXHR):
3071 (WebCore::NetworkResourcesData::ResourceData::setIsXHR):
3072 (WebCore::NetworkResourcesData::ResourceData::hasContent):
3073 (WebCore::NetworkResourcesData::ResourceData::isContentPurged):
3074 (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged):
3075 * inspector/front-end/NetworkManager.js:
3076 (WebInspector.NetworkManager.prototype.requestContent):
3077 (WebInspector.NetworkDispatcher.prototype._appendRedirect):
3078 * inspector/front-end/NetworkPanel.js:
3079 (WebInspector.NetworkPanel.prototype._appendResource):
3080 (WebInspector.NetworkPanel.prototype._frameNavigated):
3081 * loader/DocumentThreadableLoader.cpp:
3082 (WebCore::DocumentThreadableLoader::didReceiveResponse):
3083 (WebCore::DocumentThreadableLoader::receivedCancellation):
3084 (WebCore::DocumentThreadableLoader::loadRequest):
3085 * loader/DocumentThreadableLoader.h:
3086 * loader/ThreadableLoaderClient.h:
3087 (WebCore::ThreadableLoaderClient::didReceiveResponse):
3088 (WebCore::ThreadableLoaderClient::didReceiveAuthenticationCancellation):
3089 * loader/ThreadableLoaderClientWrapper.h:
3090 (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse):
3091 (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancell ation):
3092 * loader/WorkerThreadableLoader.cpp:
3093 (WebCore::workerContextDidReceiveResponse):
3094 (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
3095 (WebCore::workerContextDidReceiveAuthenticationCancellation):
3096 (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthentica tionCancellation):
3097 * loader/WorkerThreadableLoader.h:
3098 * notifications/Notification.cpp:
3099 (WebCore::Notification::didReceiveResponse):
3100 (WebCore::Notification::didReceiveAuthenticationCancellation):
3101 * notifications/Notification.h:
3102 * page/EventSource.cpp:
3103 (WebCore::EventSource::didReceiveResponse):
3104 * page/EventSource.h:
3105 * workers/WorkerScriptLoader.cpp:
3106 (WebCore::WorkerScriptLoader::didReceiveResponse):
3107 (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation):
3108 * workers/WorkerScriptLoader.h:
3109 * xml/XMLHttpRequest.cpp:
3110 (WebCore::XMLHttpRequest::createRequest):
3111 (WebCore::XMLHttpRequest::didReceiveResponse):
3112 (WebCore::XMLHttpRequest::didReceiveAuthenticationCancellation):
3113 * xml/XMLHttpRequest.h:
3114
3115 2011-06-16 Hayato Ito <hayato@chromium.org>
3116
3117 Reviewed by Hajime Morita.
3118
3119 Show child elements of a shadow host in Node::showTreeForThisAcrossFrame .
3120 https://bugs.webkit.org/show_bug.cgi?id=62782
3121
3122 To make an implementation simple, get rid of traverseNextNodeAcrossFrame
3123 and traverse each Node recursively.
3124
3125 No new tests since the function is only available in debug builds.
3126
3127 * dom/Node.cpp:
3128 (WebCore::showSubTreeAcrossFrame):
3129 (WebCore::Node::showTreeForThisAcrossFrame):
3130
3131 2011-06-16 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3132
3133 Reviewed by Kent Tamura.
3134
3135 [EFL] Move Initialization of defaultFontSize to top of file.
3136 https://bugs.webkit.org/show_bug.cgi?id=62787
3137
3138 * platform/efl/RenderThemeEfl.cpp: Move Initialize code of defaultFontSi ze to top.
3139
3140 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
3141
3142 Unreviewed, rolling out r88796.
3143 http://trac.webkit.org/changeset/88796
3144 https://bugs.webkit.org/show_bug.cgi?id=62790
3145
3146 It made fast/dom/nodesFromRect-basic.html time out on Qt,
3147 64-bit, debug mode (Requested by Ossy on #webkit).
3148
3149 * bridge/qt/qt_runtime.cpp:
3150 (JSC::Bindings::convertValueToQVariant):
3151
3152 2011-06-16 Adam Barth <abarth@webkit.org>
3153
3154 Reviewed by Eric Seidel.
3155
3156 Remove HTMLVideoElement::processingUserGesture
3157 https://bugs.webkit.org/show_bug.cgi?id=62784
3158
3159 HTMLMediaElement shouldn't have its own notion of the user gesture
3160 state. It should just use the normal user gesture state. Also,
3161 there's no point in having the bindings send the user gesture state in
3162 a boolean parameter.
3163
3164 * WebCore.exp.in:
3165 * html/HTMLMediaElement.cpp:
3166 (WebCore::HTMLMediaElement::removedFromDocument):
3167 (WebCore::HTMLMediaElement::load):
3168 (WebCore::HTMLMediaElement::play):
3169 (WebCore::HTMLMediaElement::pause):
3170 (WebCore::HTMLMediaElement::beginScrubbing):
3171 (WebCore::HTMLMediaElement::resume):
3172 * html/HTMLMediaElement.h:
3173 * html/HTMLMediaElement.idl:
3174 * html/HTMLVideoElement.cpp:
3175 (WebCore::HTMLVideoElement::webkitEnterFullscreen):
3176 * html/HTMLVideoElement.h:
3177 (WebCore::HTMLVideoElement::webkitEnterFullScreen):
3178 * html/HTMLVideoElement.idl:
3179 * html/MediaDocument.cpp:
3180 (WebCore::MediaDocument::defaultEventHandler):
3181 * html/shadow/MediaControlElements.cpp:
3182 (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
3183
3184 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
3185
3186 Unreviewed, rolling out r89011.
3187 http://trac.webkit.org/changeset/89011
3188 https://bugs.webkit.org/show_bug.cgi?id=62789
3189
3190 Broke mac build (Requested by vitalyr_ on #webkit).
3191
3192 * platform/chromium/ScrollAnimatorChromiumMac.h:
3193 * platform/chromium/ScrollAnimatorChromiumMac.mm:
3194 (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
3195 (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyl eForNewRecommendedScrollerStyle:]):
3196 (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
3197 (WebCore::ScrollAnimatorChromiumMac::scroll):
3198 (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
3199 (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
3200 (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture):
3201 (WebCore::ScrollAnimatorChromiumMac::snapRubberBand):
3202 (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired):
3203 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
3204 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
3205
3206 2011-06-16 Sailesh Agrawal <sail@chromium.org>
3207
3208 Reviewed by James Robinson.
3209
3210 [Chromium] Update forked ScrollAnimatorChromiumMac.mm/h
3211 https://bugs.webkit.org/show_bug.cgi?id=62779
3212
3213 Updated ScrollAnimatorChromiumMac.mm/h with the latest code in WebCore/p latform/mac/ScrollAnimatorMac.mm/h
3214
3215 * platform/chromium/ScrollAnimatorChromiumMac.h:
3216 (WebCore::ScrollAnimatorChromiumMac::setNeedsScrollerStyleUpdate):
3217 (WebCore::ScrollAnimatorChromiumMac::needsScrollerStyleUpdate):
3218 * platform/chromium/ScrollAnimatorChromiumMac.mm:
3219 (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
3220 (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyl eForNewRecommendedScrollerStyle:]):
3221 (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
3222 (WebCore::ScrollAnimatorChromiumMac::scroll):
3223 (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPointForScrollAnim ation):
3224 (WebCore::isScrollingLeftAndShouldNotRubberBand):
3225 (WebCore::isScrollingRightAndShouldNotRubberBand):
3226 (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
3227 (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
3228 (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture):
3229 (WebCore::ScrollAnimatorChromiumMac::snapRubberBand):
3230 (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired):
3231 (WebCore::ScrollAnimatorChromiumMac::setIsActive):
3232 (WebCore::ScrollAnimatorChromiumMac::updateScrollerStyle):
3233 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
3234 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
3235 (wkScrollbarPainterControllerStyle):
3236
3237 2011-06-15 Mikhail Naganov <mnaganov@chromium.org>
3238
3239 Reviewed by Pavel Feldman.
3240
3241 WebInspector [Chromium]: Make heap snapshots UI more responsive.
3242 https://bugs.webkit.org/show_bug.cgi?id=62360
3243
3244 Two changes have been made:
3245 - when we request elements, sort array only partially;
3246 - when populating children, do it in batches;
3247
3248 * WebCore.gypi:
3249 * WebCore.vcproj/WebCore.vcproj:
3250 * inspector/front-end/DetailedHeapshotGridNodes.js:
3251 (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerial ize):
3252 (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRe trieved):
3253 (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
3254 * inspector/front-end/HeapSnapshot.js:
3255 (WebInspector.HeapSnapshotFilteredOrderedIterator):
3256 (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNex tItems):
3257 (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewin d):
3258 (WebInspector.HeapSnapshotEdgesProvider.prototype.sort):
3259 (WebInspector.HeapSnapshotNodesProvider.prototype.sort):
3260 * inspector/front-end/HeapSnapshotWorker.js:
3261 * inspector/front-end/PartialQuickSort.js: Added.
3262 * inspector/front-end/WebKit.qrc:
3263 * inspector/front-end/inspector.html:
3264
3265 2011-06-15 Adam Barth <abarth@webkit.org>
3266
3267 Reviewed by Eric Seidel.
3268
3269 Remove Event::fromUserGesture
3270 https://bugs.webkit.org/show_bug.cgi?id=62778
3271
3272 This function is a remnant from the old user-gesture design. The list
3273 of events here is redundant with our selection of call sites for
3274 setting the user gesture indicator.
3275
3276 As part of this patch, I've also cleaned up the implementation of
3277 UserGestureIndicator itself to always be definite about whether we're
3278 processing a user gesture. We now start out in a definite state (no
3279 user gesture) and inductively state in a definite state.
3280
3281 * WebCore.exp.in:
3282 * bindings/js/ScriptController.cpp:
3283 (WebCore::ScriptController::processingUserGesture):
3284 * bindings/v8/ScriptController.cpp:
3285 (WebCore::ScriptController::processingUserGesture):
3286 * dom/Event.cpp:
3287 * dom/Event.h:
3288 * dom/UserGestureIndicator.cpp:
3289 (WebCore::isDefinite):
3290 (WebCore::UserGestureIndicator::UserGestureIndicator):
3291 (WebCore::UserGestureIndicator::~UserGestureIndicator):
3292 * dom/UserGestureIndicator.h:
3293 (WebCore::UserGestureIndicator::processingUserGesture):
3294 * html/MediaDocument.cpp:
3295 (WebCore::MediaDocument::defaultEventHandler):
3296 * html/shadow/MediaControlElements.cpp:
3297 (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
3298 * html/shadow/TextControlInnerElements.cpp:
3299 (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
3300
3301 2011-06-08 Keishi Hattori <keishi@webkit.org>
3302
3303 Reviewed by Kent Tamura.
3304
3305 Fix range element not updating when value attribute is set with JS
3306 https://bugs.webkit.org/show_bug.cgi?id=61857
3307
3308 Test: fast/forms/range-set-attribute.html
3309
3310 * html/RangeInputType.cpp:
3311 (WebCore::RangeInputType::minOrMaxAttributeChanged): Changed to only san itize the value when the dirty value flag is true.
3312
3313 2011-06-15 Adam Barth <abarth@webkit.org>
3314
3315 Unreviewed. (Technically I should get this reviewed, but I
3316 accidentally committed part of this patch in my previous commit,
3317 causing a build break.)
3318
3319 Remove ScriptController::m_processingTimerCallback
3320 https://bugs.webkit.org/show_bug.cgi?id=62776
3321
3322 This variable is unused. (It used to be used in a user gesture detectio n hack.)
3323
3324 * bindings/js/ScheduledAction.cpp:
3325 (WebCore::ScheduledAction::execute):
3326 * bindings/js/ScriptController.cpp:
3327 (WebCore::ScriptController::ScriptController):
3328 * bindings/js/ScriptController.h:
3329 * bindings/v8/ScriptController.cpp:
3330 (WebCore::ScriptController::ScriptController):
3331 * bindings/v8/ScriptController.h:
3332
3333 2011-06-15 Kent Tamura <tkent@chromium.org>
3334
3335 Reviewed by Dimitri Glazkov.
3336
3337 [Chromium][Qt] Some slider clicking tests fail.
3338 https://bugs.webkit.org/show_bug.cgi?id=62683
3339
3340 When we pressed a mouse button on a slider thumb,
3341 SliderThumbElement::startDragging() were called twice.
3342 - From SliderThumbElement::defaultEventHandler(), and
3343 - from RangeInputType::handleMouseDownEvent()
3344 The latter is not needed. We should call setDefaultHandled() correctly.
3345
3346 * html/RangeInputType.cpp:
3347 (WebCore::RangeInputType::handleMouseDownEvent): Calls setDefaultHandled ()
3348 * html/shadow/SliderThumbElement.cpp:
3349 (WebCore::SliderThumbElement::setPositionFromPoint): Remove FIXME commen ts.
3350 (WebCore::SliderThumbElement::defaultEventHandler): Calls setDefaultHand led()
3351
3352 2011-06-15 Adam Barth <abarth@webkit.org>
3353
3354 Reviewed by Anders Carlsson.
3355
3356 Remove ScriptController::isJavaScriptAnchorNavigation
3357 https://bugs.webkit.org/show_bug.cgi?id=62775
3358
3359 This function no longer plays a role in the user gesture code now that
3360 we're not encoding the user gesture state into the ScriptSourceCode
3361 URL.
3362
3363 * bindings/js/ScriptController.cpp:
3364 (WebCore::ScriptController::processingUserGesture):
3365 * bindings/js/ScriptController.h:
3366 * bindings/v8/ScriptController.cpp:
3367 (WebCore::ScriptController::processingUserGesture):
3368
3369 2011-06-15 Adam Barth <abarth@webkit.org>
3370
3371 Reviewed by Eric Seidel.
3372
3373 Remove ScriptController::setAllowPopupsFromPlugin
3374 https://bugs.webkit.org/show_bug.cgi?id=62706
3375
3376 This API is just a poor man's UserGestureIndicator. We should use the
3377 real deal.
3378
3379 * bindings/js/ScriptController.cpp:
3380 (WebCore::ScriptController::ScriptController):
3381 (WebCore::ScriptController::processingUserGesture):
3382 * bindings/js/ScriptController.h:
3383 * bindings/v8/NPV8Object.cpp:
3384 (_NPN_EvaluateHelper):
3385 * bindings/v8/ScriptController.cpp:
3386 (WebCore::ScriptController::ScriptController):
3387 (WebCore::ScriptController::processingUserGesture):
3388 * bindings/v8/ScriptController.h:
3389
3390 2011-06-15 Adam Barth <abarth@webkit.org>
3391
3392 Reviewed by Eric Seidel.
3393
3394 Remove forceUserGesture bool in favor of UserGestureIndicator
3395 https://bugs.webkit.org/show_bug.cgi?id=62702
3396
3397 This patch is an intermediate step towards removing the
3398 forceUserGesture bool. In this patch, we use the user gesture
3399 indicator to store the gesture state instead of encoding it in the URL
3400 of the script source code. In a future patch, we'll push the indicator
3401 higher up the stack, closer to the reason for setting it.
3402
3403 * bindings/ScriptControllerBase.cpp:
3404 (WebCore::ScriptController::executeScript):
3405 (WebCore::ScriptController::executeIfJavaScriptURL):
3406 * bindings/js/ScriptController.cpp:
3407 (WebCore::ScriptController::executeScriptInWorld):
3408
3409 2011-06-15 Rob Buis <rbuis@rim.com>
3410
3411 Reviewed by Darin Adler.
3412
3413 Try to use fastGetAttribute where possible
3414 https://bugs.webkit.org/show_bug.cgi?id=62747
3415
3416 Use the fast versions of get/hasAttribute where we can.
3417
3418 No new tests since this is a simple cleanup.
3419
3420 * svg/SVGAElement.cpp:
3421 (WebCore::SVGAElement::title):
3422 (WebCore::SVGAElement::defaultEventHandler):
3423 * svg/SVGAltGlyphElement.cpp:
3424 (WebCore::SVGAltGlyphElement::glyphRef):
3425 (WebCore::SVGAltGlyphElement::format):
3426 (WebCore::SVGAltGlyphElement::glyphElement):
3427 * svg/SVGAnimateMotionElement.cpp:
3428 (WebCore::SVGAnimateMotionElement::rotateMode):
3429 (WebCore::SVGAnimateMotionElement::animationPath):
3430 * svg/SVGAnimationElement.cpp:
3431 (WebCore::SVGAnimationElement::animationMode):
3432 (WebCore::SVGAnimationElement::calcMode):
3433 (WebCore::SVGAnimationElement::attributeType):
3434 (WebCore::SVGAnimationElement::toValue):
3435 (WebCore::SVGAnimationElement::byValue):
3436 (WebCore::SVGAnimationElement::fromValue):
3437 (WebCore::SVGAnimationElement::isAdditive):
3438 (WebCore::SVGAnimationElement::isAccumulated):
3439 (WebCore::SVGAnimationElement::startedActiveInterval):
3440 * svg/SVGElement.cpp:
3441 (WebCore::SVGElement::xmlbase):
3442 * svg/SVGFontElement.cpp:
3443 (WebCore::SVGFontElement::ensureGlyphCache):
3444 * svg/SVGFontFaceElement.cpp:
3445 (WebCore::SVGFontFaceElement::unitsPerEm):
3446 (WebCore::SVGFontFaceElement::xHeight):
3447 (WebCore::SVGFontFaceElement::horizontalOriginX):
3448 (WebCore::SVGFontFaceElement::horizontalOriginY):
3449 (WebCore::SVGFontFaceElement::horizontalAdvanceX):
3450 (WebCore::SVGFontFaceElement::verticalOriginX):
3451 (WebCore::SVGFontFaceElement::verticalOriginY):
3452 (WebCore::SVGFontFaceElement::verticalAdvanceY):
3453 (WebCore::SVGFontFaceElement::ascent):
3454 (WebCore::SVGFontFaceElement::descent):
3455 * svg/SVGFontFaceNameElement.cpp:
3456 (WebCore::SVGFontFaceNameElement::srcValue):
3457 * svg/SVGFontFaceUriElement.cpp:
3458 (WebCore::SVGFontFaceUriElement::srcValue):
3459 (WebCore::SVGFontFaceUriElement::loadFont):
3460 * svg/SVGGlyphElement.cpp:
3461 (WebCore::parseSVGGlyphAttribute):
3462 (WebCore::SVGGlyphElement::buildGenericGlyphIdentifier):
3463 (WebCore::SVGGlyphElement::buildGlyphIdentifier):
3464 * svg/SVGHKernElement.cpp:
3465 (WebCore::SVGHKernElement::buildHorizontalKerningPair):
3466 * svg/SVGSVGElement.cpp:
3467 (WebCore::SVGSVGElement::contentScriptType):
3468 (WebCore::SVGSVGElement::contentStyleType):
3469 * svg/SVGStyleElement.cpp:
3470 (WebCore::SVGStyleElement::type):
3471 (WebCore::SVGStyleElement::media):
3472 (WebCore::SVGStyleElement::title):
3473 * svg/SVGVKernElement.cpp:
3474 (WebCore::SVGVKernElement::buildVerticalKerningPair):
3475 * svg/animation/SVGSMILElement.cpp:
3476 (WebCore::SVGSMILElement::insertedIntoDocument):
3477 (WebCore::SVGSMILElement::parseMappedAttribute):
3478 (WebCore::SVGSMILElement::restart):
3479 (WebCore::SVGSMILElement::fill):
3480 (WebCore::SVGSMILElement::xlinkHref):
3481 (WebCore::SVGSMILElement::dur):
3482 (WebCore::SVGSMILElement::repeatDur):
3483 (WebCore::SVGSMILElement::repeatCount):
3484 (WebCore::SVGSMILElement::maxValue):
3485 (WebCore::SVGSMILElement::minValue):
3486
3487 2011-06-15 Abhishek Arya <inferno@chromium.org>
3488
3489 Reviewed by Antti Koivisto.
3490
3491 Revert speculative fix in r84151. It caused some issues with
3492 stylesheet lifetimes.
3493 https://bugs.webkit.org/show_bug.cgi?id=62586
3494
3495 Tests: fast/dom/body-clone-link-decl-parent-crash.html
3496 fast/dom/styled-clone-inline-style-decl-parent-crash.html
3497 fast/dom/styled-not-in-document-clone-inline-style-decl-parent-cr ash.html
3498
3499 * dom/Document.cpp:
3500 (WebCore::Document::removedLastRef):
3501
3502 2011-06-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3503
3504 Reviewed by Kent Tamura.
3505
3506 [EFL] Implement animationXXX functions for Progress Tag
3507 https://bugs.webkit.org/show_bug.cgi?id=62713
3508
3509 Progress tag need to implement acnimationXXX functions in order to show animation of
3510 progress tag. Because, RenderProgress decides to show update progress ba r's animation
3511 according to the functions.
3512
3513 * platform/efl/RenderThemeEfl.cpp:
3514 (WebCore::RenderThemeEfl::animationRepeatIntervalForProgressBar):
3515 (WebCore::RenderThemeEfl::animationDurationForProgressBar):
3516 * platform/efl/RenderThemeEfl.h:
3517
3518 2011-06-15 Sam Weinig <sam@webkit.org>
3519
3520 Reviewed by Alexey Proskuryakov.
3521
3522 Frequent crashes due to null frame below ApplicationCacheHost::scheduleL oadFallbackResourceFromApplicationCache
3523 https://bugs.webkit.org/show_bug.cgi?id=62764
3524
3525 This is an non-reproducible high volume crash, so no test :(.
3526
3527 * loader/DocumentLoader.cpp:
3528 (WebCore::DocumentLoader::detachFromFrame):
3529 Be conservative and stop loading when we detach a document loader from a frame.
3530
3531 2011-06-15 Beth Dakin <bdakin@apple.com>
3532
3533 Reviewed by Simon Fraser.
3534
3535 https://bugs.webkit.org/show_bug.cgi?id=62746
3536 Crash possible when switching scrollbar appearance preference on Mac
3537 -and corresponding-
3538 <rdar://problem/9323983>
3539
3540 This crash happens because the current mechanism that is intended to fla g
3541 ScrollAnimators as being in the page cache or not does not work correctl y.
3542 Long-term the fix for this is to move the ScrollableArea HashSet to a mo re
3543 appropriate place. In the meantime, this patch addresses the crash by ge tting
3544 rid of the m_isActive bool on ScrollAnimator that was intended to repres ent
3545 whether or not the ScrollableArea is in the page cache. Instead, Scrolla bleArea
3546 implementations now have their own functions to compute whether they are in
3547 active pages. ScrollAnimator::setIsActive() needs to be kept around even though
3548 there is no bool to flip anymore because scrollbars may need to be prope rly
3549 updated if the appearance was switched while the document was in the pag e cache.
3550
3551 No longer call FrameView::setAnimatorsAreActive() from
3552 Document::setIsInPageCache(), instead call it in
3553 Document::documentDidBecomeActive()
3554 * dom/Document.cpp:
3555 (WebCore::Document::setInPageCache):
3556 (WebCore::Document::documentDidBecomeActive):
3557
3558 ScrollableAreas can now assess whether or not they are on active pages ( ie, not
3559 in the page cache).
3560 * platform/ScrollableArea.h:
3561 (WebCore::ScrollableArea::isOnActivePage):
3562 * rendering/RenderLayer.cpp:
3563 (WebCore::RenderLayer::isOnActivePage):
3564 * rendering/RenderLayer.h:
3565 * rendering/RenderListBox.cpp:
3566 (WebCore::RenderListBox::isOnActivePage):
3567 * rendering/RenderListBox.h:
3568
3569 A FrameView cannot access its Document when it's in the page cache, so i t
3570 usually determines whether it's in the page cache by checking if its fra me
3571 points to a FrameView other than itself.
3572 * page/FrameView.cpp:
3573 (WebCore::FrameView::isOnActivePage):
3574
3575 Make sure ScrollableAreas are on active pages before setting them as
3576 active. This will not be necessary when the HashSet become a per-web pag e
3577 HashSet.
3578 (WebCore::FrameView::setAnimatorsAreActive):
3579 * page/FrameView.h:
3580
3581 ScrollAnimator no longer tracks the m_isActive bool.
3582 * platform/ScrollAnimator.cpp:
3583 (WebCore::ScrollAnimator::ScrollAnimator):
3584 * platform/ScrollAnimator.h:
3585 (WebCore::ScrollAnimator::setIsActive):
3586
3587 setIsActive() now exclusively calls updateScrollStyle() if there is a pe nding
3588 need to do so.
3589 * platform/mac/ScrollAnimatorMac.h:
3590 * platform/mac/ScrollAnimatorMac.mm:
3591 (WebCore::ScrollAnimatorMac::setIsActive):
3592
3593 Return early if the ScrollableArea is in the page cache.
3594 (WebCore::ScrollAnimatorMac::updateScrollerStyle):
3595
3596 2011-06-15 Simon Fraser <simon.fraser@apple.com>
3597
3598 Reviewed by Dan Bernstein.
3599
3600 Have Document keep track of whether scroll listeners are registered
3601 https://bugs.webkit.org/show_bug.cgi?id=62757
3602
3603 To avoid extra work dispatching scroll events when there are no listener s,
3604 have Document keep track of whether any scroll listeners are registered,
3605 just like it does for some other event types.
3606
3607 * dom/Document.cpp:
3608 (WebCore::Document::addListenerTypeIfNeeded):
3609 * dom/Document.h:
3610 * dom/EventQueue.cpp:
3611 (WebCore::EventQueue::enqueueOrDispatchScrollEvent):
3612
3613 2011-06-15 Dimitri Glazkov <dglazkov@chromium.org>
3614
3615 Reviewed by Adam Barth.
3616
3617 Clarify FileChooser creation code.
3618 https://bugs.webkit.org/show_bug.cgi?id=62756
3619
3620 initialize() method is only used once and that is not obvious, so just f old it into the create method.
3621
3622 Refactoring, no change in behavior.
3623
3624 * platform/FileChooser.cpp:
3625 (WebCore::FileChooser::create): Folded initialize() code there.
3626 * platform/FileChooser.h: Removed decl.
3627
3628 2011-06-15 Eric Carlson <eric.carlson@apple.com>
3629
3630 Reviewed by Alexey Proskuryakov.
3631
3632 MediaPlayerPrivate should not know about application cache
3633 https://bugs.webkit.org/show_bug.cgi?id=62648
3634
3635 Test: http/tests/appcache/video.html
3636
3637 * html/HTMLMediaElement.cpp:
3638 (WebCore::createFileURLForApplicationCacheResource): Create a url for a file
3639 in the application cache folder.
3640 (WebCore::HTMLMediaElement::loadResource): Change url to point to file i n the application
3641 cache if necessary.
3642 (WebCore::HTMLMediaElement::mediaLoadingFailed): Split failure logic out of setNetworkState
3643 so it can be called when asked to load a file that is not in the app lication cache.
3644 (WebCore::HTMLMediaElement::setNetworkState): Move failure logic out to mediaLoadingFailed.
3645 * html/HTMLMediaElement.h:
3646
3647 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
3648 (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Remove app cache logic.
3649 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
3650
3651 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
3652 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Ditto.
3653
3654 * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
3655 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
3656 (WebCore::MediaPlayerPrivateQTKit::loadInternal): Ditto.
3657
3658 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3659 (WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal): Ditto .
3660
3661 2011-06-15 Mark Pilgrim <pilgrim@chromium.org>
3662
3663 Reviewed by Tony Chang.
3664
3665 IndexedDB: indexedDB.open() name argument is required
3666 https://bugs.webkit.org/show_bug.cgi?id=62398
3667
3668 Test: storage/indexeddb/database-name-undefined.html
3669
3670 * storage/IDBFactory.idl: use appropriate IDL magic to force undefined v alues to null, so we handle missing arguments as well as null arguments
3671
3672 2011-06-15 Tony Chang <tony@chromium.org>
3673
3674 Reviewed by Ojan Vafai.
3675
3676 Rename RenderFlexibleBox to RenderDeprecatedFlexibleBox
3677 https://bugs.webkit.org/show_bug.cgi?id=62670
3678
3679 * CMakeLists.txt:
3680 * GNUmakefile.list.am:
3681 * WebCore.gypi:
3682 * WebCore.order:
3683 * WebCore.pro:
3684 * WebCore.vcproj/WebCore.vcproj:
3685 * WebCore.xcodeproj/project.pbxproj:
3686 * html/shadow/MediaControlElements.cpp:
3687 (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
3688 (WebCore::RenderMediaControlTimeDisplay::layout):
3689 * html/shadow/SliderThumbElement.cpp:
3690 (WebCore::RenderSliderContainer::RenderSliderContainer):
3691 (WebCore::RenderSliderContainer::layout):
3692 * rendering/RenderBlock.cpp:
3693 (WebCore::RenderBlock::createAnonymousBlock):
3694 * rendering/RenderBox.cpp:
3695 * rendering/RenderButton.cpp:
3696 (WebCore::RenderButton::RenderButton):
3697 (WebCore::RenderButton::addChild):
3698 (WebCore::RenderButton::removeChild):
3699 * rendering/RenderButton.h:
3700 * rendering/RenderDeprecatedFlexibleBox.cpp:
3701 (WebCore::FlexBoxIterator::FlexBoxIterator):
3702 (WebCore::FlexBoxIterator::reset):
3703 (WebCore::FlexBoxIterator::first):
3704 (WebCore::FlexBoxIterator::next):
3705 (WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
3706 (WebCore::RenderDeprecatedFlexibleBox::~RenderDeprecatedFlexibleBox):
3707 (WebCore::marginWidthForChild):
3708 (WebCore::RenderDeprecatedFlexibleBox::calcHorizontalPrefWidths):
3709 (WebCore::RenderDeprecatedFlexibleBox::calcVerticalPrefWidths):
3710 (WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
3711 (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
3712 (WebCore::gatherFlexChildrenInfo):
3713 (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
3714 (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
3715 (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
3716 (WebCore::RenderDeprecatedFlexibleBox::placeChild):
3717 (WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
3718 (WebCore::RenderDeprecatedFlexibleBox::renderName):
3719 * rendering/RenderDeprecatedFlexibleBox.h:
3720 (WebCore::RenderDeprecatedFlexibleBox::avoidsFloats):
3721 (WebCore::RenderDeprecatedFlexibleBox::isFlexibleBox):
3722 (WebCore::RenderDeprecatedFlexibleBox::isFlexingChildren):
3723 (WebCore::RenderDeprecatedFlexibleBox::isStretchingChildren):
3724 (WebCore::RenderDeprecatedFlexibleBox::hasMultipleLines):
3725 (WebCore::RenderDeprecatedFlexibleBox::isVertical):
3726 (WebCore::RenderDeprecatedFlexibleBox::isHorizontal):
3727 * rendering/RenderDetails.h: Removed the header since it wasn't actually
3728 needed. Looks like a copy/paste error from RenderButton.h.
3729 * rendering/RenderFullScreen.cpp:
3730 (RenderFullScreen::RenderFullScreen):
3731 (RenderFullScreen::destroy):
3732 * rendering/RenderFullScreen.h:
3733 * rendering/RenderMenuList.cpp:
3734 (WebCore::RenderMenuList::RenderMenuList):
3735 (WebCore::RenderMenuList::createInnerBlock):
3736 (WebCore::RenderMenuList::removeChild):
3737 * rendering/RenderMenuList.h:
3738 * rendering/RenderObject.cpp:
3739 (WebCore::RenderObject::createObject):
3740 * rendering/RenderingAllInOne.cpp:
3741
3742 2011-06-15 Alexander Pavlov <apavlov@chromium.org>
3743
3744 Reviewed by Pavel Feldman.
3745
3746 Web Inspector: Serious performance regression during continuous focused element style updates
3747 https://bugs.webkit.org/show_bug.cgi?id=61038
3748
3749 Inline style invalidation events are coalesced in the backend and sent o ver the wire on timer.
3750
3751 * inspector/Inspector.json:
3752 * inspector/InspectorDOMAgent.cpp:
3753 (WebCore::RevalidateStyleAttributeTask::onTimer):
3754 (WebCore::InspectorDOMAgent::getAttributes):
3755 (WebCore::InspectorDOMAgent::didModifyDOMAttr):
3756 (WebCore::InspectorDOMAgent::styleAttributeInvalidated):
3757 * inspector/InspectorDOMAgent.h:
3758 * inspector/InspectorStyleSheet.cpp:
3759 (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
3760 (WebCore::InspectorStyleSheetForInlineStyle::text):
3761 (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
3762 (WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady):
3763 (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
3764 * inspector/InspectorStyleSheet.h:
3765 * inspector/front-end/DOMAgent.js:
3766 (WebInspector.DOMAgent):
3767 (WebInspector.DOMAgent.prototype._attributesUpdated):
3768 (WebInspector.DOMAgent.prototype._loadNodeAttributesSoon):
3769 (WebInspector.DOMAgent.prototype._loadNodeAttributes):
3770 (WebInspector.DOMDispatcher.prototype.attributesUpdated):
3771 (WebInspector.DOMDispatcher.prototype.inlineStyleInvalidated):
3772
3773 2011-06-15 Jer Noble <jer.noble@apple.com>
3774
3775 Reviewed by Timothy Hatcher.
3776
3777 Full-screen live streams have status text in wrong location
3778 https://bugs.webkit.org/show_bug.cgi?id=62733
3779
3780 Fix a misspelling in the user-agent stylesheet for full-screen mode.
3781
3782 * css/fullscreenQuickTime.css:
3783 (video:-webkit-full-screen::-webkit-media-controls-status-display):
3784
3785 2011-06-14 Jer Noble <jer.noble@apple.com>
3786
3787 Reviewed by Eric Carlson.
3788
3789 (AVFoundation) Apple event video appears as live stream and is not seeka ble
3790 https://bugs.webkit.org/show_bug.cgi?id=62694
3791
3792 No new tests; There are no media-player port specific tests yet.
3793
3794 Work around a bug in apple.com live stream javascript controller library . When an AVAsset returns an indefinite time
3795 for its duration, return 0 if the asset has no tracks, and infinity othe rwise. This keeps the apple.com controller
3796 from identifying the stored stream as a live stream.
3797
3798 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
3799 (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
3800
3801 2011-06-15 Andrey Kosyakov <caseq@chromium.org>
3802
3803 Unreviewed, rolled out r88937 (broke build on mac)
3804
3805 * CMakeLists.txt:
3806 * GNUmakefile.list.am:
3807 * WebCore.gypi:
3808 * WebCore.pro:
3809 * WebCore.vcproj/WebCore.vcproj:
3810 * WebCore.xcodeproj/project.pbxproj:
3811 * fileapi/FileReaderLoader.cpp:
3812 (WebCore::FileReaderLoader::didReceiveResponse):
3813 * fileapi/FileReaderLoader.h:
3814 * inspector/Inspector.json:
3815 * inspector/InspectorInstrumentation.cpp:
3816 (WebCore::InspectorInstrumentation::didCommitLoadImpl):
3817 * inspector/InspectorInstrumentation.h:
3818 * inspector/InspectorResourceAgent.cpp:
3819 (WebCore::InspectorResourceAgent::willSendRequest):
3820 (WebCore::InspectorResourceAgent::didReceiveResponse):
3821 (WebCore::InspectorResourceAgent::setInitialXHRContent):
3822 (WebCore::InspectorResourceAgent::InspectorResourceAgent):
3823 * inspector/InspectorResourceAgent.h:
3824 * inspector/NetworkResourcesData.cpp: Removed.
3825 * inspector/NetworkResourcesData.h: Removed.
3826 * inspector/front-end/NetworkManager.js:
3827 (WebInspector.NetworkManager.prototype.requestContent):
3828 (WebInspector.NetworkDispatcher.prototype._appendRedirect):
3829 * inspector/front-end/NetworkPanel.js:
3830 (WebInspector.NetworkPanel.prototype._appendResource):
3831 (WebInspector.NetworkPanel.prototype._frameNavigated):
3832 * loader/DocumentThreadableLoader.cpp:
3833 (WebCore::DocumentThreadableLoader::didReceiveResponse):
3834 (WebCore::DocumentThreadableLoader::receivedCancellation):
3835 (WebCore::DocumentThreadableLoader::loadRequest):
3836 * loader/DocumentThreadableLoader.h:
3837 * loader/ThreadableLoaderClientWrapper.h:
3838 (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse):
3839 (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancell ation):
3840 * loader/WorkerThreadableLoader.cpp:
3841 (WebCore::workerContextDidReceiveResponse):
3842 (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
3843 (WebCore::workerContextDidReceiveAuthenticationCancellation):
3844 (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthentica tionCancellation):
3845 * loader/WorkerThreadableLoader.h:
3846 * notifications/Notification.cpp:
3847 (WebCore::Notification::didReceiveResponse):
3848 (WebCore::Notification::didReceiveAuthenticationCancellation):
3849 * notifications/Notification.h:
3850 * page/EventSource.cpp:
3851 (WebCore::EventSource::didReceiveResponse):
3852 * page/EventSource.h:
3853 * xml/XMLHttpRequest.cpp:
3854 (WebCore::XMLHttpRequest::createRequest):
3855 (WebCore::XMLHttpRequest::didReceiveResponse):
3856 (WebCore::XMLHttpRequest::didReceiveAuthenticationCancellation):
3857 * xml/XMLHttpRequest.h:
3858
3859 2011-06-15 Pavel Feldman <pfeldman@google.com>
3860
3861 Reviewed by Yury Semikhatsky.
3862
3863 Web Inspector: introduce context menu on ImageView with Copy and Open in new tab actions.
3864 https://bugs.webkit.org/show_bug.cgi?id=62727
3865
3866 * English.lproj/localizedStrings.js:
3867 * inspector/front-end/ImageView.js:
3868 (WebInspector.ImageView.prototype._base64ToSize):
3869 (WebInspector.ImageView.prototype._contextMenu):
3870 (WebInspector.ImageView.prototype._copyImageURL):
3871 (WebInspector.ImageView.prototype._openInNewTab):
3872
3873 2011-06-15 Andrey Kosyakov <caseq@chromium.org>
3874
3875 Reviewed by Pavel Feldman.
3876
3877 Web Inspector: provide unique identifiers for frames
3878 https://bugs.webkit.org/show_bug.cgi?id=62721
3879
3880 * inspector/InspectorInstrumentation.cpp:
3881 (WebCore::InspectorInstrumentation::frameDestroyedImpl):
3882 * inspector/InspectorInstrumentation.h:
3883 (WebCore::InspectorInstrumentation::frameDestroyed):
3884 * inspector/InspectorPageAgent.cpp:
3885 (WebCore::InspectorPageAgent::frameForId):
3886 (WebCore::InspectorPageAgent::frameId):
3887 (WebCore::InspectorPageAgent::frameDestroyed):
3888 * inspector/InspectorPageAgent.h:
3889 * page/Frame.cpp:
3890 (WebCore::Frame::~Frame):
3891
3892 2011-06-15 Andrey Kosyakov <caseq@chromium.org>
3893
3894 Unreviewed build fix: comment unused parameter names.
3895
3896 * loader/ThreadableLoaderClient.h:
3897 (WebCore::ThreadableLoaderClient::didReceiveResponse):
3898 (WebCore::ThreadableLoaderClient::didReceiveAuthenticationCancellation):
3899
3900 2011-06-15 Pavel Podivilov <podivilov@chromium.org>
3901
3902 Reviewed by Yury Semikhatsky.
3903
3904 Web Inspector: script select can be too wide.
3905 https://bugs.webkit.org/show_bug.cgi?id=62701
3906
3907 * inspector/front-end/ScriptsPanel.js:
3908 (WebInspector.ScriptsPanel.prototype._displayNameForScriptURL):
3909 (WebInspector.ScriptsPanel.prototype._createSourceFrame):
3910 (WebInspector.SourceFrameDelegateForScriptsPanel):
3911 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFile Name):
3912 * inspector/front-end/SourceFile.js:
3913
3914 2011-06-15 Noel Gordon <noel.gordon@gmail.com>
3915
3916 Reviewed by Eric Seidel.
3917
3918 Draw CSS outline style for render widgets: iframe, embed, object, applet .
3919 https://bugs.webkit.org/show_bug.cgi?id=57439
3920
3921 Draw CSS outlines for render widgets: iframe, embed, object, applet. The se elements can
3922 be focused (via clicks or tabIndex) but should not have a visible focus ring by default.
3923
3924 Tests: fast/replaced/no-focus-ring-embed.html
3925 fast/replaced/no-focus-ring-iframe.html
3926 fast/replaced/no-focus-ring-object.html
3927 fast/replaced/outline-replaced-elements.html
3928
3929 * css/html.css:
3930 (applet:focus, embed:focus, iframe:focus, object:focus): Default to no f ocus ring.
3931 * rendering/RenderWidget.cpp:
3932 (WebCore::RenderWidget::paint): Paint the render widget CSS outline styl e.
3933
3934 2011-06-15 Steve Block <steveblock@google.com>
3935
3936 Reviewed by Tony Gentilcore.
3937
3938 V8PerformanceCustom.cpp lacks WEB_TIMING guards
3939 https://bugs.webkit.org/show_bug.cgi?id=62689
3940
3941 No new tests, build fix only.
3942
3943 * bindings/v8/custom/V8PerformanceCustom.cpp:
3944
3945 2011-06-15 Sheriff Bot <webkit.review.bot@gmail.com>
3946
3947 Unreviewed, rolling out r88916.
3948 http://trac.webkit.org/changeset/88916
3949 https://bugs.webkit.org/show_bug.cgi?id=62728
3950
3951 Broke a bunch of layout tests on chromium (Requested by
3952 podivilov on #webkit).
3953
3954 * inspector/front-end/ScriptsPanel.js:
3955 (WebInspector.ScriptsPanel.prototype._createSourceFrame):
3956 (WebInspector.SourceFrameDelegateForScriptsPanel):
3957 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFile Name):
3958 * inspector/front-end/SourceFile.js:
3959 (WebInspector.SourceFile.prototype.get displayName):
3960
3961 2011-06-15 Pavel Podivilov <podivilov@chromium.org>
3962
3963 Reviewed by Yury Semikhatsky.
3964
3965 Web Inspector: script links are displayed with original line number in p retty-print mode.
3966 https://bugs.webkit.org/show_bug.cgi?id=62282
3967
3968 * inspector/front-end/DebuggerPresentationModel.js:
3969 (WebInspector.DebuggerPresentationModel):
3970 (WebInspector.DebuggerPresentationModel.prototype.registerAnchor):
3971 (WebInspector.DebuggerPresentationModel.prototype._updateAnchor.didGetUI Location):
3972 (WebInspector.DebuggerPresentationModel.prototype._updateAnchor):
3973 (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
3974 (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
3975 * inspector/front-end/NetworkPanel.js:
3976 (WebInspector.NetworkPanel.prototype.showAnchorLocation):
3977 (WebInspector.NetworkPanel.prototype._showResource):
3978 * inspector/front-end/Panel.js:
3979 (WebInspector.Panel.prototype.createAnchor):
3980 (WebInspector.Panel.prototype.formatAnchorText):
3981 * inspector/front-end/ResourcesPanel.js:
3982 (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
3983 * inspector/front-end/ScriptsPanel.js:
3984 (WebInspector.ScriptsPanel.prototype.createAnchor.):
3985 (WebInspector.ScriptsPanel.prototype.createAnchor):
3986 (WebInspector.ScriptsPanel.prototype.showAnchorLocation.didGetUILocation ):
3987 (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
3988 * inspector/front-end/inspector.js:
3989 (WebInspector._showAnchorLocation):
3990 (WebInspector.linkifyResourceAsNode):
3991
3992 2011-06-14 Hans Wennborg <hans@chromium.org>
3993
3994 Reviewed by Tony Gentilcore.
3995
3996 IndexedDB: Use fileExists() first when checking if SQLite db exists
3997 https://bugs.webkit.org/show_bug.cgi?id=62638
3998
3999 In IDBSQLiteBackingStore::backingStoreExists(), which is used to check
4000 if a SQLite database exists and should be considered for migration,
4001 check if the file exists first.
4002
4003 Trying to open a SQLite database for a non-existing file prints a
4004 noisy error message in debug builds.
4005
4006 No new functionality, no new tests.
4007
4008 * storage/IDBSQLiteBackingStore.cpp:
4009 (WebCore::IDBSQLiteBackingStore::backingStoreExists):
4010
4011 2011-06-14 Alexander Pavlov <apavlov@chromium.org>
4012
4013 Reviewed by Yury Semikhatsky.
4014
4015 Web Inspector: "data" URLs not detected in CSS url(...) values properly
4016 https://bugs.webkit.org/show_bug.cgi?id=62643
4017
4018 * inspector/front-end/inspector.js:
4019 (WebInspector.completeURL):
4020
4021 2011-06-15 Pavel Feldman <pfeldman@google.com>
4022
4023 Reviewed by Yury Semikhatsky.
4024
4025 Web Inspector: [REGRESSION] errors in watches and in console are not ren dered in red.
4026 https://bugs.webkit.org/show_bug.cgi?id=62708
4027
4028 Test: inspector/debugger/error-in-watch-expressions.html
4029
4030 * inspector/front-end/RemoteObject.js:
4031 * inspector/front-end/WatchExpressionsSidebarPane.js:
4032 (WebInspector.WatchExpressionsSection.prototype.update.appendResult):
4033 (WebInspector.WatchExpressionsSection.prototype.update):
4034 (WebInspector.WatchExpressionTreeElement.prototype.update):
4035 * inspector/front-end/inspector.css:
4036 (.console-error-level .console-message-text, .console-error-level .secti on .header .title):
4037 (.console-formatted-object, .console-formatted-node):
4038
4039 2011-06-15 Carlos Garcia Campos <cgarcia@igalia.com>
4040
4041 Unreviewed. Remove unneeded constructor declaration added by mistake in r88800.
4042
4043 * platform/gtk/GtkAuthenticationDialog.h:
4044
4045 2011-06-15 Pavel Podivilov <podivilov@chromium.org>
4046
4047 Reviewed by Yury Semikhatsky.
4048
4049 Web Inspector: script select can be too wide.
4050 https://bugs.webkit.org/show_bug.cgi?id=62701
4051
4052 * inspector/front-end/ScriptsPanel.js:
4053 (WebInspector.ScriptsPanel.prototype._displayNameForScriptURL):
4054 (WebInspector.ScriptsPanel.prototype._createSourceFrame):
4055 (WebInspector.SourceFrameDelegateForScriptsPanel):
4056 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFile Name):
4057 * inspector/front-end/SourceFile.js:
4058
4059 2011-06-15 Nikolas Zimmermann <nzimmermann@rim.com>
4060
4061 Reviewed by David Hyatt.
4062
4063 CSS 2.1: Support replaced elements with relative intrinsic sizes
4064 https://bugs.webkit.org/show_bug.cgi?id=15849
4065
4066 CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
4067 https://bugs.webkit.org/show_bug.cgi?id=53099
4068
4069 Generalize the recently added SVG specific host <-> embedded document si ze-negotiation used
4070 to support embedding SVGs with intrinsic ratio/size via <iframe>/<object >/<embed> from
4071 RenderPart right into RenderReplaced. It will be used to share the size- negotiation logic
4072 with RenderImage, which still has its own way to negotiate with the embe dded SVG to figure
4073 out its size (and it's broken in several ways).
4074
4075 This fully implements intrinsic size/ratio support for replaced elements , as specified in:
4076 http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width
4077 http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-height
4078
4079 RenderImage has not yet been converted to use the new size negotiation l ogic, this is just
4080 the ground work. As soon as this is done all ways of embedding SVG is un ified in a single
4081 way: the same size negotiation logic used for object/embed/iframe/img fo r SVG documents.
4082
4083 To use it for non-SVG target documents, it's just a matter of implementi ng
4084 "RenderBox* embeddedContentBox()" which needs to return the root rendere r of the embedded document.
4085 For SVG it's the embedded document RenderSVGRoot renderer, associated wi th the outermost <svg> element.
4086 It's easy to implement this for embedded MathML documents or PDF documen ts now, if needed.
4087
4088 Imported all CSS 2.1 tests named *replaced* and *intrinsic* tests, excep t the still failing background-intrinsic-*
4089 which embed SVGs through background-image or <img>, which still use the old size-negotiation logic.
4090
4091 Tests: css2.1/20110323/* (203 tests + support files)
4092 svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm (same as repl aced-intrinsic-ratio-001.htm, but zooms in a few times, to see whether all boxes react properly)
4093 http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.h tm (same as replaced-intrinsic-ratio-001.htm, but with delayed loading of the SV G to test late-size-negotiation)
4094
4095 This fixes:
4096 css2.1/20110323/replaced-intrinsic-ratio-001.htm
4097 css2.1/20110323/replaced-intrinsic-003.htm
4098 css2.1/20110323/block-replaced-height-007.htm
4099 css2.1/20110323/float-replaced-height-007.htm
4100 css2.1/20110323/inline-block-replaced-height-007.htm
4101 css2.1/20110323/inline-replaced-height-007.htm
4102
4103 We're now the first to properly handle replaced-intrinsic-ratio-001.htm out of Opera/FF/IE9 :-)
4104 This is an important piece of embedding SVGs though, so glad that we fin ally have it.
4105
4106 * rendering/RenderBlock.cpp:
4107 (WebCore::RenderBlock::layoutBlockChildren): Use new helper needsPreferr edWidthsRecalculation() to figure out whether pref widths need to be calculated.
4108 (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
4109 * rendering/RenderBlockLineLayout.cpp:
4110 (WebCore::RenderBlock::layoutInlineChildren): Ditto.
4111 * rendering/RenderBox.cpp:
4112 (WebCore::RenderBox::needsPreferredWidthsRecalculation): Refactored and extended from RenderBlock*. We have to recalculate pref widths upon layout
4113 if we embed a d ocument with an intrinsic ratio/size, extensively covered by
4114 svg/zoom/page/z oom-replaced-intrinsic-ratio-001.htm
4115 * rendering/RenderBox.h:
4116 (WebCore::RenderBox::computeIntrinsicRatioInformation): New virtual func tion, only implemented in RenderPart so far. This generalizes the existing metho d from RenderPart.
4117 * rendering/RenderPart.cpp:
4118 (WebCore::RenderPart::needsPreferredWidthsRecalculation): Always recompu te pref widths of we have an embeddedContentBox() - it may depend on our size.
4119 (WebCore::RenderPart::embeddedContentBox): Return the RenderSVGRoot box of the embedded SVG document, if we're embedded through object/embed/iframe (soo n img as well).
4120 * rendering/RenderPart.h:
4121 * rendering/RenderReplaced.cpp:
4122 (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): New helper func tion, that either returns a fixed intrinsic size (set by a class inheriting from us) or the embedded target document size.
4123 (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto.
4124 (WebCore::RenderReplaced::computeReplacedLogicalWidth): Full implementat ion of: 10.3.2 Inline, replaced elements: http://www.w3.org/TR/CSS21/visudet.htm l#inline-replaced-width.
4125 (WebCore::RenderReplaced::computeReplacedLogicalHeight): Full implementa tion of: 10.6.2 Inline, replaced elements: http://www.w3.org/TR/CSS21/visudet.ht ml#inline-replaced-height
4126 * rendering/RenderReplaced.h:
4127 (WebCore::RenderReplaced::embeddedContentBox):
4128 * rendering/svg/RenderSVGRoot.cpp:
4129 (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Fix problem when zooming replaced-intrinsic-ratio-001.htm: if ownerWidth is auto, don't apply sty le()->effectiveZoom() twice.
4130 (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto for ownerH eight auto.
4131 * rendering/svg/RenderSVGRoot.h: Mark 'computeIntrinsicRatioInformation' virtual.
4132
4133 2011-06-09 MORITA Hajime <morrita@google.com>
4134
4135 Reviewed by Dimitri Glazkov.
4136
4137 ShadowContentElement should detach its inclusions before attaching them.
4138 https://bugs.webkit.org/show_bug.cgi?id=62428
4139
4140 - On ShadowContentElement::attach(), changed inclusion attach scheme
4141 from per-node reattach() to detach()-all-and-attach()-them. This
4142 eliminates attach() order problems which ShadowContentElement
4143 possibly has.
4144 - Changed ShadowContentElement to have m_inclusions as a member variable ,
4145 which will be used by upcoming changes.
4146 - Moved attach() code from ShadowContentSelector to ShadowContentElement
4147 because the element now owns the inclusion list.
4148
4149 No new tests. No visible behavioral change yet.
4150
4151 * dom/ShadowContentElement.cpp:
4152 (WebCore::ShadowContentElement::attach):
4153 (WebCore::ShadowContentElement::detach): Added.
4154 * dom/ShadowContentElement.h:
4155 (WebCore::ShadowContentElement::inclusionAt): Added.
4156 (WebCore::ShadowContentElement::inclusionCount): Added.
4157 (WebCore::toShadowContentElement):
4158 * dom/ShadowContentSelector.cpp: Removed attachChildrenFor()
4159 (WebCore::ShadowContentSelector::selectInclusion): Extracted from attach ChildrenFor()
4160 (WebCore::ShadowContentSelector::willAttachContentFor): Extracted from a ttachChildrenFor()
4161 (WebCore::ShadowContentSelector::didAttachContent): Extracted from attac hChildrenFor()
4162 (WebCore::ShadowContentSelector::activeElement):
4163 * dom/ShadowContentSelector.h:
4164
4165 2011-06-14 David Kilzer <ddkilzer@apple.com>
4166
4167 <http://webkit.org/b/62677> Part 2/2: Remove duplicate header entries in WebCore project file
4168
4169 Reviewed by Darin Adler.
4170
4171 Most of the DOMSVG*.h headers were added in late 2006, and then
4172 duplicated by late 2007. They've been in the tree a long time.
4173
4174 * WebCore.xcodeproj/project.pbxproj: Let Xcode 4 remove
4175 duplicate header entries.
4176
4177 2011-06-14 David Kilzer <ddkilzer@apple.com>
4178
4179 <http://webkit.org/b/62677> Part 1/2: Remove duplicate header entries in WebCore project file
4180
4181 Reviewed by Darin Adler.
4182
4183 These headers were added as duplicates in r83256:
4184
4185 DefaultAudioDestinationNode.h
4186 JSOfflineAudioCompletionEvent.h
4187 OfflineAudioCompletionEvent.h
4188 OfflineAudioDestinationNode.h
4189
4190 The following duplicates were introduced in r84053 (after having
4191 been originally added in r83729):
4192
4193 StorageInfo.h
4194 StorageInfoErrorCallback.h
4195 StorageInfoQuotaCallback.h
4196 StorageInfoUsageCallback.h
4197
4198 * WebCore.xcodeproj/project.pbxproj: Remove duplicates using
4199 'uniq' since sort-Xcode-project-file did most of the work.
4200
4201 2011-06-14 Kent Tamura <tkent@chromium.org>
4202
4203 Reviewed by Hajime Morita.
4204
4205 REGRESSION(r88757): [Chromium] Vertical position of media slider thumb i s wrong.
4206 https://bugs.webkit.org/show_bug.cgi?id=62685
4207
4208 No new tests. Covered by existing tests.
4209
4210 * rendering/RenderSlider.cpp:
4211 (WebCore::RenderSlider::layout): Center the thumb position.
4212 * rendering/RenderSlider.h:
4213
4214 2011-06-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>
4215
4216 Reviewed by Kent Tamura.
4217
4218 [EFL] Change color initialization with clear color constant
4219 https://bugs.webkit.org/show_bug.cgi?id=62691
4220
4221 Some color values are initialized by rbg value. Color constant value is more clear than
4222 rgb value.
4223
4224 * platform/efl/RenderThemeEfl.cpp:
4225 (WebCore::RenderThemeEfl::RenderThemeEfl):
4226
4227 2011-06-14 Julien Chaffraix <jchaffraix@webkit.org>
4228
4229 Reviewed by James Robinson.
4230
4231 Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destinat ion-in.html
4232 https://bugs.webkit.org/show_bug.cgi?id=48293
4233
4234 And
4235
4236 Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.desti nation-in.html
4237 https://bugs.webkit.org/show_bug.cgi?id=48303
4238
4239 * html/canvas/CanvasRenderingContext2D.cpp:
4240 (WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere): Added CompositeDestinationIn
4241 as this is the only one that needs a specific treatment.
4242
4243 2011-06-14 Naoki Takano <takano.naoki@gmail.com>
4244
4245 Reviewed by Kent Tamura.
4246
4247 [Chromium] Forward modifiers + up/down key events to text field when aut ofill popup window is shown.
4248 https://bugs.webkit.org/show_bug.cgi?id=62350
4249 http://code.google.com/p/chromium/issues/detail?id=61349
4250
4251 Manual test: autofill-popup-shiftupdown.html
4252
4253 * manual-tests/chromium/autofill-popup-shiftupdown.hml: Added to check m odifier + up/down key is working correctly for text area in autofill popup is sh own.
4254 * platform/chromium/PopupMenuChromium.cpp:
4255 (WebCore::PopupListBox::handleKeyEvent): Check modifier key and menu sty le to decide if the event should be forwarded or not.
4256
4257 2011-06-14 Annie Sullivan <sullivan@chromium.org>
4258
4259 Reviewed by Ryosuke Niwa.
4260
4261 Span ID duplicated when pressing enter at beginning of span
4262 https://bugs.webkit.org/show_bug.cgi?id=62621
4263
4264 Strip id from cloned span, so that it is not duplicated.
4265
4266 Test: editing/inserting/return-key-span-start.html
4267
4268 * editing/InsertParagraphSeparatorCommand.cpp:
4269 (WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
4270
4271 2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
4272
4273 Reviewed by David Hyatt.
4274
4275 Trailing tabs in a textarea become unselectable under certain conditions
4276 https://bugs.webkit.org/show_bug.cgi?id=54598
4277
4278 The bug was caused by WebKit's erroneously collapsing leading whitespace when white-space is
4279 set to pre-wrap. Per CSS 2.1 spec section 16.1.1, leading whitespace sho uld not be removed
4280 in this case.
4281
4282 See also: http://www.w3.org/TR/CSS2/text.html#white-space-model
4283
4284 Fixed the bug by adding an extra argument to shouldCollapseWhiteSpace, i ndicating whether
4285 whitespace is leading or trailing. It defaults to leading because 16.1.1 does not allow allow
4286 collapsing of whitespace anywhere but at the end of each line.
4287
4288 Test: fast/text/pre-wrap-trailing-tab.html
4289
4290 * rendering/RenderBlockLineLayout.cpp:
4291 (WebCore::shouldCollapseWhiteSpace): Added WhitespacePosition as an argu ment. Returns false
4292 when whitespacePosition is not TrailingWhitespace even if white-space is pre-wrap.
4293 (WebCore::requiresLineBox): Takes WhitespacePosition as an argument and passes it to
4294 shouldCollapseWhiteSpace.
4295 (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Calls requires LineBox.
4296 (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace): Ditto.
4297 (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): Ditto.
4298
4299 2011-06-14 Beth Dakin <bdakin@apple.com>
4300
4301 Reviewed by Dan Bernstein.
4302
4303 https://bugs.webkit.org/show_bug.cgi?id=62678
4304 When the window is small enough, the scrollbars are misplaced with paint ing
4305 artifacts, after changing the scrollbar appearance
4306 -and corresponding-
4307 <rdar://problem/9414015>
4308
4309 Get rid of the FrameView implementation of scrollbarStyleChanged(). Its approach
4310 is just not good.
4311 * page/FrameView.cpp:
4312 * page/FrameView.h:
4313
4314 Implement scrollbarStyleChanged() on ScrollView instead. And just call
4315 updatedScrollbars().
4316 * platform/ScrollView.cpp:
4317 (WebCore::ScrollView::scrollbarStyleChanged):
4318 * platform/ScrollView.h:
4319
4320 Invalidate the old scrollbar before changing it to the new scrollbar. Th is way
4321 when the scrollbar gets smaller, the older, larger pieces still repaint properly.
4322 * platform/mac/ScrollAnimatorMac.mm:
4323 (WebCore::ScrollAnimatorMac::updateScrollerStyle):
4324
4325 2011-06-14 Michael Saboff <msaboff@apple.com>
4326
4327 Reviewed by Joseph Pecoraro.
4328
4329 Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE
4330 https://bugs.webkit.org/show_bug.cgi?id=62649
4331
4332 Take 2.
4333 The #ifdef DISPATCH_VM_PRESSURE doesn't work. Combined the code
4334 inside this #ifdef with the prior #ifndef DISPATCH_SOURCE_TYPE_VM.
4335
4336 No functional changes, fixing build issue therefore no tests.
4337
4338 * platform/mac/MemoryPressureHandlerMac.mm:
4339
4340 2011-06-14 Jeffrey Pfau <jpfau@apple.com>
4341
4342 Reviewed by David Hyatt.
4343
4344 Null dereference in WebCore::RenderBlock::splitFlow regarding use of mul ticol, inline-block, and spanning elements
4345 https://bugs.webkit.org/show_bug.cgi?id=60028
4346
4347 Ensure that the parent block of a spanning element, if it is not itself
4348 a multicol element, is not inline.
4349
4350 Test: fast/multicol/span/span-as-nested-inline-block-child.html
4351
4352 * rendering/RenderBlock.cpp:
4353 (WebCore::RenderBlock::columnsBlockForSpanningElement):
4354
4355 2011-06-14 Jer Noble <jer.noble@apple.com>
4356
4357 Reviewed by Eric Carlson.
4358
4359 REGRESSION: Drawing video into canvas gets about one frame every 5 secon ds (AVFoundation)
4360 https://bugs.webkit.org/show_bug.cgi?id=62655
4361
4362 No new tests; we don't have any media-engine specific tests.
4363
4364 AVAssetImageGenerator will, by default, return the nearest keyframe. To get the generator to return
4365 the image from the current time instead of the nearest keyframe, set the requested time tolerance to
4366 zero (which defaults to infinity).
4367
4368 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
4369 (WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer ):
4370
4371 2011-06-14 Eric Uhrhane <ericu@chromium.org>
4372
4373 Reviewed by Darin Fisher.
4374
4375 Clean up filesystem base path code.
4376 https://bugs.webkit.org/show_bug.cgi?id=60218
4377
4378 Change a bunch of url-held-in-a-string parameters into real KURLS and
4379 WebURLs.
4380
4381 No new tests--no change in functionality.
4382
4383 * fileapi/DOMFileSystem.cpp:
4384 (WebCore::DOMFileSystem::createWriter):
4385 (WebCore::DOMFileSystem::createFile):
4386 * fileapi/DOMFileSystemBase.cpp:
4387 (WebCore::DOMFileSystemBase::getMetadata):
4388 (WebCore::DOMFileSystemBase::move):
4389 (WebCore::DOMFileSystemBase::copy):
4390 (WebCore::DOMFileSystemBase::remove):
4391 (WebCore::DOMFileSystemBase::removeRecursively):
4392 (WebCore::DOMFileSystemBase::getParent):
4393 (WebCore::DOMFileSystemBase::getFile):
4394 (WebCore::DOMFileSystemBase::getDirectory):
4395 (WebCore::DOMFileSystemBase::readDirectory):
4396 * fileapi/DOMFileSystemSync.cpp:
4397 (WebCore::DOMFileSystemSync::createFile):
4398 (WebCore::DOMFileSystemSync::createWriter):
4399 * platform/AsyncFileSystem.cpp:
4400 (WebCore::AsyncFileSystem::openFileSystem):
4401 * platform/AsyncFileSystem.h:
4402 (WebCore::AsyncFileSystem::AsyncFileSystem):
4403
4404 2011-06-14 James Robinson <jamesr@chromium.org>
4405
4406 Reviewed by Stephen White.
4407
4408 [chromium] Compositor shader initialization is inefficient
4409 https://bugs.webkit.org/show_bug.cgi?id=62618
4410
4411 This fixes several issues causing slowdowns in compositor shader initial ization, mostly due to lack of
4412 parallelism:
4413
4414 - Avoid initializing all programs eagerly. We only use two programs on e very page, the other programs depend on
4415 content and are constructed on demand.
4416
4417 - Defer querying uniform locations until draw time. For the eagerly con structed programs (render surface +
4418 tiler) this means that the GPU process has a chance to compile the shade r while the renderer is busy
4419 painting+uploading instead of blocking on shader compilation in order to get uniform locations.
4420
4421 - Calls to query COMPILE_STATUS/LINK_STATUS moved behind #ifndef NDEBUG guards since these should never fail in
4422 release builds and force synchronous compilation/linking.
4423
4424 This also adds a number of TRACE_EVENT()s to make analysing the performa nce of this bit of code easier.
4425
4426 * platform/graphics/chromium/LayerRendererChromium.cpp:
4427 (WebCore::LayerRendererChromium::updateLayers):
4428 (WebCore::LayerRendererChromium::initializeSharedObjects):
4429 (WebCore::LayerRendererChromium::borderProgram):
4430 (WebCore::LayerRendererChromium::headsUpDisplayProgram):
4431 (WebCore::LayerRendererChromium::renderSurfaceProgram):
4432 (WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
4433 (WebCore::LayerRendererChromium::tilerProgram):
4434 (WebCore::LayerRendererChromium::canvasLayerProgram):
4435 (WebCore::LayerRendererChromium::pluginLayerProgram):
4436 (WebCore::LayerRendererChromium::videoLayerRGBAProgram):
4437 (WebCore::LayerRendererChromium::videoLayerYUVProgram):
4438 * platform/graphics/chromium/LayerRendererChromium.h:
4439 * platform/graphics/chromium/LayerTextureSubImage.cpp:
4440 (WebCore::LayerTextureSubImage::uploadWithTexSubImage):
4441 (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
4442 * platform/graphics/chromium/ProgramBinding.cpp:
4443 (WebCore::ProgramBindingBase::init):
4444 (WebCore::ProgramBindingBase::loadShader):
4445 (WebCore::ProgramBindingBase::createShaderProgram):
4446 * platform/graphics/chromium/ProgramBinding.h:
4447 (WebCore::ProgramBinding::ProgramBinding):
4448 (WebCore::ProgramBinding::initialize):
4449 * platform/graphics/chromium/ShaderChromium.cpp:
4450 (WebCore::VertexShaderPosTex::init):
4451 (WebCore::VertexShaderPosTexYUVStretch::init):
4452 (WebCore::VertexShaderPos::init):
4453 (WebCore::VertexShaderPosTexTransform::init):
4454 (WebCore::FragmentTexAlphaBinding::init):
4455 (WebCore::FragmentShaderRGBATexAlphaMask::init):
4456 (WebCore::FragmentShaderYUVVideo::init):
4457 (WebCore::FragmentShaderColor::init):
4458 * platform/graphics/chromium/ShaderChromium.h:
4459
4460 2011-06-14 Stephanie Lewis <slewis@apple.com>
4461
4462 Rubber stamped by Oliver Hunt.
4463
4464 <rdar://problem/9511169>
4465 Update order files.
4466
4467 Build system change, no change in functionality so no new tests.
4468
4469 * WebCore.order:
4470
4471 2011-06-14 Chris Fleizach <cfleizach@apple.com>
4472
4473 Reviewed by David Kilzer.
4474
4475 VoiceOver cannot navigate the iTunes album view table
4476 https://bugs.webkit.org/show_bug.cgi?id=62335
4477
4478 This is a regression from https://bugs.webkit.org/show_bug.cgi?id=57463.
4479 Part of that patch made a change so that an ARIA table will only look at it's children and grandchildren
4480 for possible rows. That however, doesn't allow arbitrary hierarchies to work with ARIA, like in iTunes album view.
4481
4482 Test: platform/mac/accessibility/aria-grid-with-strange-hierarchy.html
4483
4484 * accessibility/AccessibilityARIAGrid.cpp:
4485 (WebCore::AccessibilityARIAGrid::addChild):
4486 (WebCore::AccessibilityARIAGrid::addChildren):
4487 * accessibility/AccessibilityARIAGrid.h:
4488
4489 2011-06-14 Sheriff Bot <webkit.review.bot@gmail.com>
4490
4491 Unreviewed, rolling out r88823.
4492 http://trac.webkit.org/changeset/88823
4493 https://bugs.webkit.org/show_bug.cgi?id=62652
4494
4495 Broke the Lion build (Requested by estes on #webkit).
4496
4497 * platform/mac/MemoryPressureHandlerMac.mm:
4498
4499 2011-06-14 Michael Saboff <msaboff@apple.com>
4500
4501 Reviewed by Joseph Pecoraro.
4502
4503 Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE
4504 https://bugs.webkit.org/show_bug.cgi?id=62649
4505
4506 The #ifdef DISPATCH_VM_PRESSURE actually needs to be #ifndef
4507 to handle when DISPATCH_VM_PRESSURE is NOT defined in the
4508 system header files.
4509
4510 No functional changes, fixing build issue therefore no tests.
4511
4512 * platform/mac/MemoryPressureHandlerMac.mm:
4513
4514 2011-06-13 Adrienne Walker <enne@google.com>
4515
4516 Reviewed by James Robinson.
4517
4518 [chromium] Disable drawing for huge mask layers
4519 https://bugs.webkit.org/show_bug.cgi?id=62607
4520
4521 Because masks have a different layer size than the layer they are
4522 masking, they are untiled. If they are too large to be contained
4523 within a single texture, then they should just be disabled.
4524
4525 Test: platform/chromium/compositing/huge-mask-layer.html
4526
4527 * platform/graphics/chromium/ContentLayerChromium.cpp:
4528 (WebCore::ContentLayerChromium::drawsContent):
4529 (WebCore::ContentLayerChromium::paintContentsIfDirty):
4530 * platform/graphics/chromium/LayerTilerChromium.h:
4531 (WebCore::LayerTilerChromium::getSingleTexture):
4532 (WebCore::LayerTilerChromium::numTiles):
4533
4534 2011-06-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
4535
4536 Reviewed by Laszlo Gombos.
4537
4538 [Qt] [Symbian] GraphicsLayer: support plugins on symbian
4539 https://bugs.webkit.org/show_bug.cgi?id=57418
4540
4541 Implement graphics layer for plugins on Symbian.
4542
4543 * plugins/PluginView.h:
4544 * plugins/qt/PluginViewQt.cpp:
4545 (WebCore::PluginView::shouldUseAcceleratedCompositing):
4546 (WebCore::PluginView::platformStart):
4547 * plugins/symbian/PluginViewSymbian.cpp:
4548 (WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
4549 (WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
4550 (WebCore::PluginGraphicsLayerQt::paint):
4551 (WebCore::PluginView::shouldUseAcceleratedCompositing):
4552 (WebCore::PluginView::paint):
4553 (WebCore::PluginView::invalidateRect):
4554 (WebCore::PluginView::platformStart):
4555 (WebCore::PluginView::platformLayer):
4556
4557 2011-06-14 Sreeram Ramachandran <sreeram@chromium.org>
4558
4559 Reviewed by Pavel Feldman.
4560
4561 Web Inspector: Allow the console to persist on page refresh or navigatio n
4562 https://bugs.webkit.org/show_bug.cgi?id=53359
4563
4564 Adds a context menu checkbox to preserve the console log across
4565 navigations. However, the underlying messages and objects are actually
4566 deleted from the backend, so they are not expandable; their continued
4567 display in the console frontend is merely cosmetic.
4568
4569 Test: inspector/console/console-preserve-log.html
4570
4571 * English.lproj/localizedStrings.js:
4572 * inspector/front-end/ConsoleView.js:
4573 (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dis patcher.messagesCleared):
4574 (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
4575 (WebInspector.ConsoleView.prototype.requestClearMessages):
4576 (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXH RItemAction):
4577 (WebInspector.ConsoleView.prototype._handleContextMenuEvent.preserveLogI temAction):
4578 (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
4579 * inspector/front-end/Settings.js:
4580 (WebInspector.Settings):
4581 * inspector/front-end/inspector.js:
4582 (WebInspector.reset):
4583
4584 2011-06-14 Pavel Podivilov <podivilov@chromium.org>
4585
4586 Reviewed by Pavel Feldman.
4587
4588 Web Inspector: add tooltip to file select options in scripts panel.
4589 https://bugs.webkit.org/show_bug.cgi?id=62537
4590
4591 * inspector/front-end/ScriptsPanel.js:
4592 (WebInspector.ScriptsPanel):
4593 (WebInspector.ScriptsPanel.prototype._sourceFileAdded):
4594 (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.compare):
4595 (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
4596 (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLoca tion):
4597 (WebInspector.ScriptsPanel.prototype._callFrameSelected):
4598
4599 2011-06-14 Luke Macpherson <macpherson@chromium.org>
4600
4601 Reviewed by Eric Seidel.
4602
4603 Implement CSS border radius properies in CSSStyleApplyProperty
4604 https://bugs.webkit.org/show_bug.cgi?id=62265
4605
4606 No new tests / refactoring only.
4607
4608 * css/CSSStyleApplyProperty.cpp:
4609 Implement new class to culculate border radius, initialize for appropria te properties.
4610 (WebCore::ApplyPropertyBorderRadius::ApplyPropertyBorderRadius):
4611 (WebCore::ApplyPropertyBorderRadius::applyValue):
4612 (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
4613 * css/CSSStyleSelector.cpp:
4614 Remove old implementations.
4615 (WebCore::CSSStyleSelector::applyProperty):
4616 * page/animation/AnimationBase.cpp:
4617 Pass LengthSize by value.
4618 (WebCore::AnimationBase::ensurePropertyMap):
4619 * rendering/style/RenderStyle.h:
4620 Pass LengthSize by value consistently.
4621
4622 2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>
4623
4624 Reviewed by Martin Robinson.
4625
4626 [GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScre enPoint()
4627 https://bugs.webkit.org/show_bug.cgi?id=62626
4628
4629 The method actually converts coordinates, the rectangle size is
4630 not affected, so it can be modified to return a point
4631 instead. Fix also a bug in the implementation, it was translating
4632 the coordinates twice returning the wrong position when the given
4633 rectangle was not at 0,0.
4634
4635 * platform/gtk/GtkUtilities.cpp:
4636 (WebCore::convertWidgetPointToScreenPoint):
4637 * platform/gtk/GtkUtilities.h:
4638 * platform/gtk/PopupMenuGtk.cpp:
4639 (WebCore::PopupMenuGtk::show): Use
4640 convertWidgetPointToScreenPoint().
4641
4642 2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>
4643
4644 Reviewed by Martin Robinson.
4645
4646 [GTK] Support authentication dialogs in WebKit2
4647 https://bugs.webkit.org/show_bug.cgi?id=62366
4648
4649 Add a new class to show an authentication dialog that is used by
4650 both WebKit1 and WebKit2.
4651
4652 * GNUmakefile.list.am: Add new files to compilation.
4653 * platform/gtk/GtkAuthenticationDialog.cpp: Added.
4654 (WebCore::addEntryToTable):
4655 (WebCore::sessionCanSavePasswords):
4656 (WebCore::GtkAuthenticationDialog::~GtkAuthenticationDialog):
4657 (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
4658 (WebCore::getSavedLogin):
4659 (WebCore::GtkAuthenticationDialog::show):
4660 (WebCore::GtkAuthenticationDialog::destroy):
4661 (WebCore::GtkAuthenticationDialog::savePasswordCallback):
4662 (WebCore::GtkAuthenticationDialog::savePassword):
4663 (WebCore::GtkAuthenticationDialog::authenticate):
4664 (WebCore::GtkAuthenticationDialog::authenticationDialogResponseCallback) :
4665 * platform/gtk/GtkAuthenticationDialog.h: Added.
4666
4667 2011-06-14 Tommy Widenflycht <tommyw@google.com>
4668
4669 Reviewed by Tony Gentilcore.
4670
4671 Media Stream PeerConnection API: adding the StreamList and supporting cl asses.
4672 https://bugs.webkit.org/show_bug.cgi?id=61539
4673
4674 * dom/StreamContainer.h: Added.
4675 (WebCore::StreamContainer::create):
4676 (WebCore::StreamContainer::~StreamContainer):
4677 (WebCore::StreamContainer::length):
4678 (WebCore::StreamContainer::item):
4679 (WebCore::StreamContainer::add):
4680 (WebCore::StreamContainer::remove):
4681 (WebCore::StreamContainer::contains):
4682 (WebCore::StreamContainer::get):
4683 (WebCore::StreamContainer::StreamContainer):
4684 * dom/StreamList.cpp: Added.
4685 (WebCore::StreamList::create):
4686 (WebCore::StreamList::StreamList):
4687 (WebCore::StreamList::~StreamList):
4688 (WebCore::StreamList::length):
4689 (WebCore::StreamList::item):
4690 * dom/StreamList.h: Added.
4691 * dom/StreamList.idl: Added.
4692
4693 2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
4694
4695 Reviewed by Andreas Kling.
4696
4697 [Qt] tst_QWebFrame::overloadedSlots() fails
4698 https://bugs.webkit.org/show_bug.cgi?id=37319
4699
4700 Increase the likeness that JSElements are converted to QWebElements. Whe n hinted
4701 with QWebElement metatype, we qualify the conversion from JSElement as a "perfect
4702 match".
4703
4704 The test was failing because the wrong slot was called, since the QWebEl ement
4705 match was taken as equal to the others and not chosen when the metacall happened.
4706
4707 We also remove the implicit conversion between JSDocument (which is not an
4708 element) to QWebElement. The conversion only worked for calling slots, w hile
4709 without hint it returned a QVariantMap (as can be seen in domCycles test ). It was
4710 added for supporting DRT, but since this change we can use it as QVarian tMap and
4711 get the value for "documentElement".
4712
4713 This patch is based on Noam Rosenthal original patch in the same bug.
4714
4715 * bridge/qt/qt_runtime.cpp:
4716 (JSC::Bindings::hintForRealType):
4717 Extracted function to choose the metatype hint based on the JSValue type . Add
4718 QWebElement metatype as a hint for JSElement objects, this way if no hin t is
4719 provided, JSElement objects will always be converted to QWebElements.
4720
4721 (JSC::Bindings::convertValueToQVariant):
4722 Use previous function. Identify the conversion between JSElement to QWeb Element
4723 as a "perfect match" (dist = 0). And remove the implicit conversion when the hint
4724 is QWebElement metatype and we have a JSDocument. Changed from JSHTMLEl ement to
4725 JSElement to cover the 'documentElement'.
4726
4727 2011-06-14 Andreas Kling <kling@webkit.org>
4728
4729 Reviewed by Benjamin Poulain.
4730
4731 Remove some unnecessary includes.
4732
4733 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
4734
4735 2011-06-14 Yael Aharon <yael.aharon@nokia.com>
4736
4737 Reviewed by Kent Tamura.
4738
4739 <progress> should support :indeterminate pseudo-class
4740 https://bugs.webkit.org/show_bug.cgi?id=62430
4741
4742 Add support for :indeterminate pseudo class for progress element.
4743
4744 Tests: fast/dom/HTMLProgressElement/indeterminate-progress-001.html
4745 fast/dom/HTMLProgressElement/indeterminate-progress-002.html
4746
4747 * css/CSSStyleSelector.cpp:
4748 (WebCore::CSSStyleSelector::canShareStyleWithControl):
4749 (WebCore::CSSStyleSelector::canShareStyleWithElement):
4750 (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
4751 * html/HTMLProgressElement.cpp:
4752 (WebCore::HTMLProgressElement::isDeterminate):
4753 (WebCore::HTMLProgressElement::didElementStateChange):
4754 * html/HTMLProgressElement.h:
4755
4756 2011-06-14 Pavel Feldman <pfeldman@google.com>
4757
4758 Reviewed by Yury Semikhatsky.
4759
4760 Web Inspector: use ew-resize instead of col-resize for non-columns.
4761 https://bugs.webkit.org/show_bug.cgi?id=62640
4762
4763 * inspector/front-end/ElementsPanel.js:
4764 (WebInspector.ElementsPanel.prototype.rightSidebarResizerDragStart):
4765 * inspector/front-end/Panel.js:
4766 (WebInspector.Panel.prototype._startSidebarDragging):
4767 * inspector/front-end/ScriptsPanel.js:
4768 (WebInspector.ScriptsPanel.prototype._startSidebarResizeDrag):
4769 * inspector/front-end/TimelineOverviewPane.js:
4770 (WebInspector.TimelineOverviewPane.prototype._resizeWindow):
4771 (WebInspector.TimelineOverviewPane.prototype._dragWindow):
4772 * inspector/front-end/inspector.css:
4773 (body.attached #toolbar):
4774 (body.drawer-visible #main-status-bar):
4775 (#scripts-sidebar-resizer-widget):
4776 (.sidebar-resizer-vertical):
4777 (.timeline-window-resizer):
4778
4779 2011-06-14 Pavel Feldman <pfeldman@google.com>
4780
4781 Reviewed by Yury Semikhatsky.
4782
4783 Web Inspector: reload from within inspector window does not work while d ebugger is paused.
4784 https://bugs.webkit.org/show_bug.cgi?id=62631
4785
4786 Test: inspector/debugger/debugger-reload-on-pause.html
4787
4788 * loader/FrameLoader.cpp:
4789 (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
4790
4791 2011-06-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>
4792
4793 Reviewed by Kent Tamura.
4794
4795 [EFL] Support for painting thumb of media slider
4796 https://bugs.webkit.org/show_bug.cgi?id=62174
4797
4798 Replace RenderObject parameter with RenderStyle's in adjustSliderThumbSi ze.
4799 Because, parameter of the function was changed. And, add constant variab le to
4800 paintMediaSliderThumb().
4801
4802 * platform/efl/RenderThemeEfl.cpp:
4803 (WebCore::RenderThemeEfl::RenderThemeEfl):
4804 (WebCore::RenderThemeEfl::adjustSliderThumbSize):
4805 (WebCore::RenderThemeEfl::paintMediaSliderThumb):
4806 * platform/efl/RenderThemeEfl.h:
4807
4808 2011-06-14 Kent Tamura <tkent@chromium.org>
4809
4810 [Qt] Attempt to fix a build break by r88757.
4811 https://bugs.webkit.org/show_bug.cgi?id=52920
4812
4813 * platform/qt/RenderThemeQt.cpp:
4814 (WebCore::RenderThemeQt::paintSliderTrack):
4815
4816 2011-06-13 Kent Tamura <tkent@chromium.org>
4817
4818 [EFL] The second try to fix a build break.
4819
4820 * platform/efl/RenderThemeEfl.cpp:
4821 (WebCore::RenderThemeEfl::paintThemePart):
4822
4823 2011-06-13 Kent Tamura <tkent@chromium.org>
4824
4825 [EFL] Fix a typo.
4826
4827 * platform/efl/RenderThemeEfl.cpp:
4828 (WebCore::RenderThemeEfl::paintThemePart):
4829
4830 2011-06-13 Kent Tamura <tkent@chromium.org>
4831
4832 [EFL] Try to fix a build break by r88757.
4833
4834 * platform/efl/RenderThemeEfl.cpp:
4835 (WebCore::RenderThemeEfl::paintThemePart):
4836
4837 2011-06-10 Kent Tamura <tkent@chromium.org>
4838
4839 Reviewed by Dimitri Glazkov.
4840
4841 Use CSS machinery to position slider thumb.
4842 https://bugs.webkit.org/show_bug.cgi?id=52920
4843
4844 Remove RenderSlider::layout().
4845 In order to remove it, we introduce new three shadow nodes:
4846 - A flex box container occupying the whole box
4847 - A flex box item representing a movable area of the thumb
4848 - A flex box item limiting the movable area of the thumb
4849 The thumb position is specified by percentage position in the second ele ment.
4850
4851 This change also fixes Bug 60353.
4852
4853 Tests: fast/forms/input-appearance-range.html
4854 fast/forms/validation-message-on-range.html
4855
4856 * accessibility/AccessibilitySlider.cpp:
4857 (WebCore::AccessibilitySliderThumb::elementRect):
4858 Use Node::getRect() for the thumb element.
4859 * css/html.css: Add new style definitions for the new node layout.
4860 (input[type="range"]::-webkit-slider-container):
4861 (input[type="range"]::-webkit-slider-runnable-track):
4862 (input[type="range"]::-webkit-slider-thumb):
4863 * html/RangeInputType.cpp:
4864 (WebCore::RangeInputType::handleMouseDownEvent):
4865 Accepts events on shadow nodes, use sliderThumbElementOf().
4866 (WebCore::RangeInputType::createShadowSubtree):
4867 Creates new nodes layout.
4868 (WebCore::RangeInputType::valueChanged): Use sliderThumbElementOf().
4869 * html/RangeInputType.h: Remove shadowSliderThumb().
4870 * html/shadow/SliderThumbElement.cpp:
4871 (WebCore::sliderPosition): Moved from RenderSlider.cpp.
4872 (WebCore::hasVerticalAppearance): New utility function.
4873 (WebCore::sliderThumbElementOf): New utility function.
4874 (WebCore::RenderSliderThumb::layout):
4875 Sets CSS top/left values.
4876 (WebCore::RenderSliderContainer::RenderSliderContainer):
4877 (WebCore::RenderSliderContainer::layout):
4878 Add some adjustment code.
4879 - Setting box-orient
4880 - Adjust heights of some nodes. It is required to pass existing tests.
4881 (WebCore::SliderThumbElement::setPositionFromValue):
4882 Update comments.
4883 (WebCore::SliderThumbElement::setPositionFromPoint):
4884 Calculate the current position from absolute positions.
4885 (WebCore::SliderThumbElement::hostInput):
4886 Removed unnecessary variable.
4887 (WebCore::TrackLimiterElement::TrackLimiterElement):
4888 (WebCore::TrackLimiterElement::create): Adjust style.
4889 (WebCore::TrackLimiterElement::createRenderer):
4890 This node uses RenderSliderThumb.
4891 (WebCore::TrackLimiterElement::shadowPseudoId):
4892 This node also uses -webkit-slider-thumb.
4893 (WebCore::SliderContainerElement::SliderContainerElement):
4894 (WebCore::SliderContainerElement::create):
4895 (WebCore::SliderContainerElement::createRenderer):
4896 Uses RenderSliderContainer.
4897 (WebCore::SliderContainerElement::shadowPseudoId):
4898 * html/shadow/SliderThumbElement.h:
4899 Make hostInput() public, add declarations of TrackLimiterElement
4900 and SliderContainerElement.
4901 * rendering/RenderSlider.cpp:
4902 (WebCore::RenderSlider::RenderSlider): Added an assertion.
4903 (WebCore::RenderSlider::inDragMode): Uses sliderThumbElementOf().
4904 * rendering/RenderSlider.h: Remove declarations of removed functions.
4905 * rendering/RenderTheme.cpp:
4906 (WebCore::RenderTheme::adjustSliderThumbStyle):
4907 Calls adjustSliderThumbSize().
4908
4909 2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
4910
4911 Reviewed by Martin Robinson.
4912
4913 [GTK] Add configure option to enable/disable register protocol handler
4914 https://bugs.webkit.org/show_bug.cgi?id=62534
4915
4916 * GNUmakefile.am: Add ENABLE_REGISTER_PROTOCOL_HANDLER.
4917
4918 2011-06-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
4919
4920 Reviewed by Kent Tamura.
4921
4922 [EFL] Support for painting thumb of media slider
4923 https://bugs.webkit.org/show_bug.cgi?id=62174
4924
4925 Implement paintMediaSliderThumb() function to show thumb of media slider .
4926 adjustSliderThumbSize() should be implemented in order to call paintMedi aSliderThumb().
4927
4928 * platform/efl/RenderThemeEfl.cpp:
4929 (WebCore::RenderThemeEfl::RenderThemeEfl):
4930 (WebCore::RenderThemeEfl::adjustSliderThumbSize):
4931 (WebCore::RenderThemeEfl::paintMediaSliderTrack):
4932 (WebCore::RenderThemeEfl::paintMediaSliderThumb):
4933 (WebCore::RenderThemeEfl::paintMediaCurrentTime):
4934 * platform/efl/RenderThemeEfl.h:
4935
4936 2011-06-13 Keishi Hattori <keishi@webkit.org>
4937
4938 Sort WebCore.xcodeproj
4939 Accomplished using sort-Xcode-project-file.
4940
4941 * WebCore.xcodeproj/project.pbxproj:
4942
4943 2011-06-13 James Simonsen <simonjam@chromium.org>
4944
4945 Reviewed by James Robinson.
4946
4947 [Chromium] Implement monotonicallyIncreasingClock()
4948 https://bugs.webkit.org/show_bug.cgi?id=62162
4949
4950 * platform/chromium/PlatformBridge.h:
4951 * platform/chromium/SystemTimeChromium.cpp:
4952 (WebCore::monotonicallyIncreasingTime): Use Chrome's implementation.
4953
4954 2011-06-13 Steve Block <steveblock@google.com>
4955
4956 Reviewed by Darin Adler.
4957
4958 Remove Android defines from WebCore/config.h
4959 https://bugs.webkit.org/show_bug.cgi?id=62602
4960
4961 No new tests, build cleanup only.
4962
4963 * config.h:
4964
4965 2011-06-13 Adam Barth <abarth@webkit.org>
4966
4967 Reviewed by David Levin.
4968
4969 Remove redundant "true" parameter to scheduleLocationChange
4970 https://bugs.webkit.org/show_bug.cgi?id=62612
4971
4972 This parameter defaults to true anyway.
4973
4974 * loader/appcache/ApplicationCacheGroup.cpp:
4975 (WebCore::ApplicationCacheGroup::selectCache):
4976
4977 2011-06-13 Kentaro Hara <haraken@google.com>
4978
4979 Reviewed by Alexey Proskuryakov.
4980
4981 Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
4982 https://bugs.webkit.org/show_bug.cgi?id=61256
4983
4984 In order to prevent rounding error caused by expanding/shrinking a page
4985 using different calculation here and there, I added a common calculation
4986 method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
4987 keeping the ratio of width and height of the original page.
4988 PrintContext::computePageRects() and PrintContext::begin()
4989 use resizePageRectsKeepingRatio() to expand/shrink a page.
4990
4991 Test: printing/page-count-with-one-word.html
4992
4993 * WebCore.exp.in:
4994 * page/Frame.cpp:
4995 (WebCore::Frame::resizePageRectsKeepingRatio):
4996 * page/Frame.h:
4997 * page/PrintContext.cpp:
4998 (WebCore::PrintContext::computePageRects):
4999 (WebCore::PrintContext::begin):
5000
5001 2011-06-13 Adam Barth <abarth@webkit.org>
5002
5003 Reviewed by Darin Adler.
5004
5005 anyPageIsProcessingUserGesture is not longer needed because user gesture state is static
5006 https://bugs.webkit.org/show_bug.cgi?id=62601
5007
5008 Previously, our user-gesture state was per-frame. Code needed to check
5009 the "global" user gesture state called anyPageIsProcessingUserGesture()
5010 to iterate through all the frames and look for one that was processing
5011 a user gesture. Since we changed the user gesture state to be static,
5012 iterating over every frame in existence isn't needed.
5013
5014 This patch also cleans up a couple other user-gesture callsites I saw
5015 while I was in this code. Code should just call
5016 ScriptController::processingUserGesture directly instead of
5017 trampolining through other functions.
5018
5019 * bindings/ScriptControllerBase.cpp:
5020 (WebCore::ScriptController::executeScript):
5021 * bindings/generic/BindingSecurity.h:
5022 (WebCore::::allowPopUp):
5023 * bindings/js/JSDOMBinding.cpp:
5024 * bindings/js/JSDOMBinding.h:
5025 * bindings/js/JSDocumentCustom.cpp:
5026 (WebCore::JSDocument::setLocation):
5027 * bindings/js/ScriptController.cpp:
5028 * bindings/js/ScriptController.h:
5029 * bindings/scripts/CodeGeneratorJS.pm:
5030 * bindings/scripts/CodeGeneratorV8.pm:
5031 * bindings/v8/ScriptController.cpp:
5032 * bindings/v8/ScriptController.h:
5033 (WebCore::ScriptController::setProcessingTimerCallback):
5034 * bindings/v8/V8Utilities.cpp:
5035 * bindings/v8/V8Utilities.h:
5036 * bindings/v8/specialization/V8BindingState.cpp:
5037 * bindings/v8/specialization/V8BindingState.h:
5038 * html/HTMLFormElement.cpp:
5039 (WebCore::HTMLFormElement::submitFromJavaScript):
5040 (WebCore::HTMLFormElement::submit):
5041 * page/DOMWindow.cpp:
5042 (WebCore::DOMWindow::setLocation):
5043 (WebCore::DOMWindow::createWindow):
5044 (WebCore::DOMWindow::open):
5045
5046 2011-06-13 Jeffrey Pfau <jpfau@apple.com>
5047
5048 Reviewed by Darin Adler.
5049
5050 Crash in WebCore::RenderMathMLUnderOver::layout()
5051 https://bugs.webkit.org/show_bug.cgi?id=57900
5052
5053 Add more null checks so that removing children in MathML elements does n ot cause crashes.
5054 Note that this only half fixes the third repro in the Bugzilla bug, as a nother bug will
5055 still crash that repro.
5056
5057 Test: mathml/munderover-remove-children.html
5058
5059 * rendering/mathml/RenderMathMLSubSup.cpp:
5060 (WebCore::RenderMathMLSubSup::stretchToHeight):
5061 * rendering/mathml/RenderMathMLUnderOver.cpp:
5062 (WebCore::RenderMathMLUnderOver::layout):
5063 (WebCore::RenderMathMLUnderOver::nonOperatorHeight):
5064
5065 2011-06-13 Dmitry Lomov <dslomov@google.com>
5066
5067 Reviewed by Adam Barth.
5068
5069 https://bugs.webkit.org/show_bug.cgi?id=62345
5070 Use per-isolate embedder data instead of statics for caches in bindings.
5071 This is a prerequisite for more than one v8 isolate per process.
5072
5073 * bindings/scripts/CodeGeneratorV8.pm:
5074 * bindings/v8/IDBBindingUtilities.cpp:
5075 (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
5076 (WebCore::injectIDBKeyIntoSerializedValue):
5077 * bindings/v8/V8Binding.cpp:
5078 (WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
5079 (WebCore::V8BindingPerIsolateData::~V8BindingPerIsolateData):
5080 (WebCore::V8BindingPerIsolateData::create):
5081 (WebCore::V8BindingPerIsolateData::ensureInitialized):
5082 (WebCore::V8BindingPerIsolateData::dispose):
5083 (WebCore::getToStringName):
5084 (WebCore::getToStringTemplate):
5085 * bindings/v8/V8Binding.h:
5086 (WebCore::V8BindingPerIsolateData::get):
5087 (WebCore::V8BindingPerIsolateData::current):
5088 (WebCore::V8BindingPerIsolateData::rawTemplateMap):
5089 (WebCore::V8BindingPerIsolateData::templateMap):
5090 (WebCore::V8BindingPerIsolateData::toStringName):
5091 (WebCore::V8BindingPerIsolateData::toStringTemplate):
5092 * bindings/v8/V8DOMWindowShell.cpp:
5093 (WebCore::V8DOMWindowShell::initContextIfNeeded):
5094 * bindings/v8/V8Utilities.cpp:
5095 (WebCore::V8LocalContext::V8LocalContext):
5096 (WebCore::V8LocalContext::~V8LocalContext):
5097 * bindings/v8/V8Utilities.h:
5098 * bindings/v8/WorkerContextExecutionProxy.cpp:
5099 (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
5100
5101 2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
5102
5103 Reviewed by Adam Barth.
5104
5105 Simplify logic in ProgressTracker::progressCompleted()
5106 https://bugs.webkit.org/show_bug.cgi?id=62598
5107
5108 Testing for "m_numProgressTrackedFrames != 0" is unnecessary because it is
5109 always true, otherwise we would entered in the first part of the conditi onal.
5110
5111 * loader/ProgressTracker.cpp:
5112 (WebCore::ProgressTracker::progressCompleted):
5113
5114 2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>
5115
5116 Unreviewed, rolling out r88704.
5117 http://trac.webkit.org/changeset/88704
5118 https://bugs.webkit.org/show_bug.cgi?id=62466
5119
5120 Caused layout test failures on Chromium Mac.
5121
5122 * platform/chromium/ClipboardChromium.cpp:
5123 (WebCore::ClipboardChromium::declareAndWriteDragImage):
5124
5125 2011-06-13 Morgan Winer <mwiner@apple.com>
5126
5127 Reviewed by Enrica Casucci.
5128
5129 Frame::visiblePositionForPoint returns null position if the point is ove r an imagemap.
5130 https://bugs.webkit.org/show_bug.cgi?id=62562
5131 <rdar://problem/9313885>
5132
5133 The innerNode() of an imageMap is an area, and doesn't have a renderer a nd
5134 therefore can't report a position.
5135 Every result's innerNonSharedNode() should be the same as the innerNode( ),
5136 except for imageMaps, which will have the actual image as its innerNonSh aredNode(),
5137 and will therefore have a renderer and can report a position.
5138
5139 There are no layout tests for this, since it can be tested only at API l evel.
5140
5141 * page/Frame.cpp:
5142 (WebCore::Frame::visiblePositionForPoint): Changing innerNode() to inner NonSharedNode().
5143
5144 2011-06-13 Lucas De Marchi <lucas.demarchi@profusion.mobi>
5145
5146 Reviewed by Eric Seidel.
5147
5148 [CMAKE] Conditionally generate DerivedSources
5149 https://bugs.webkit.org/show_bug.cgi?id=62277
5150
5151 Speedup build by not generating DerivedSources of features that are
5152 disabled. This was already been done for some features like ENABLE_SVG
5153 and now it's extended the following features: ENABLE_DATABASE,
5154 ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
5155 ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
5156 ENABLE_DATA_TRANSFER_ITEMS.
5157
5158 No change in functionality so no new tests.
5159
5160 * CMakeLists.txt: move .idl files to be conditionally generated.
5161
5162 2011-06-13 Leandro Pereira <leandro@profusion.mobi>
5163
5164 Reviewed by Eric Seidel.
5165
5166 [CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms
5167 without plugin support
5168 https://bugs.webkit.org/show_bug.cgi?id=62394
5169
5170 No behaviour changes, so no new tests.
5171
5172 * CMakeLists.txt: Remove references to Plugin{Package,View}.cpp and
5173 Plugin{Package,View}None.cpp and move them to CMakeListWinCE and
5174 CMakeListsEfl, respectively.
5175 * CMakeListsEfl.txt:
5176 * CMakeListsWinCE.txt:
5177
5178 2011-06-13 Andrey Kosyakov <caseq@chromium.org>
5179
5180 Reviewed by Eric Seidel.
5181
5182 Web Inspector: [refactoring] remove dead code from NetworkPanel
5183 https://bugs.webkit.org/show_bug.cgi?id=62481
5184
5185 * inspector/front-end/NetworkPanel.js:
5186
5187 2011-06-13 Daniel Cheng <dcheng@chromium.org>
5188
5189 Reviewed by Eric Seidel.
5190
5191 [chromium] Dragging images to Mail.app results in broken attachments
5192 https://bugs.webkit.org/show_bug.cgi?id=62466
5193
5194 No new tests.
5195
5196 * platform/chromium/ClipboardChromium.cpp:
5197 (WebCore::ClipboardChromium::declareAndWriteDragImage):
5198
5199 2011-06-13 Adrienne Walker <enne@google.com>
5200
5201 Reviewed by Simon Fraser.
5202
5203 Overlap test needs to consider children of composited layers
5204 https://bugs.webkit.org/show_bug.cgi?id=62465
5205
5206 Any child layer with a compositing ancestor will be put into a
5207 composited layer even though they themselves don't need compositing.
5208 As layer bounds aren't hierarchical, these layer bounds themselves
5209 need to be put into the overlap map because the composited layer
5210 itself is not sufficient.
5211
5212 Test: compositing/layer-creation/overlap-animated-layer.html
5213
5214 * rendering/RenderLayerCompositor.cpp:
5215 (WebCore::RenderLayerCompositor::computeCompositingRequirements):
5216
5217 2011-06-13 Xan Lopez <xlopez@igalia.com>
5218
5219 Unreviewed build fix.
5220
5221 Touch this to try to fix the build...
5222
5223 * platform/gtk/WidgetGtk.cpp:
5224 (WebCore::Widget::~Widget):
5225
5226 2011-06-13 Xan Lopez <xlopez@igalia.com>
5227
5228 Try to fix GTK+ build.
5229
5230 * GNUmakefile.list.am: remove CredentialStorage.cpp
5231
5232 2011-06-13 Stephen White <senorblanco@chromium.org>
5233
5234 Reviewed by James Robinson.
5235
5236 Improve GPU canvas startup time on the SkiaGPU path.
5237 https://bugs.webkit.org/show_bug.cgi?id=62594
5238
5239 Fixed by skipping creation of shaders used only by the legacy path.
5240
5241 Covered by existing canvas tests.
5242
5243 * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
5244 (WebCore::SharedGraphicsContext3D::create):
5245
5246 2011-06-13 Michael Saboff <msaboff@apple.com>
5247
5248 Reviewed by Oliver Hunt.
5249
5250 Additional FontCache::FontCachePurgePreventer instances needed
5251 https://bugs.webkit.org/show_bug.cgi?id=62498
5252
5253 Added some needed and speculative FontCachePurgePreventer objects.
5254 Built and ran Safari with debug version of webkit that purges all
5255 purgeable fonts in FontCache::purgeInactiveFontDataIfNeeded in order
5256 to find system fallback fonts access via code paths that aren't
5257 protected with FontCachePurgePreventer objects. Also examined
5258 platform specific code that calls either Font::drawText() or
5259 Canvas::drawText(). For those methods that may be called from currently
5260 unprotected paths, added FontCachePurgePreventer objects.
5261
5262 No new functionality so no new tests.
5263
5264 * inspector/DOMNodeHighlighter.cpp:
5265 * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
5266 (PlatformCALayerWinInternal::displayCallback):
5267 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
5268 (WebCore::CCHeadsUpDisplay::drawHudContents):
5269 * platform/mac/DragImageMac.mm:
5270 (WebCore::widthWithFont):
5271 (WebCore::drawAtPoint):
5272 * rendering/RenderMenuList.cpp:
5273 (WebCore::RenderMenuList::updateOptionsWidth):
5274
5275 2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
5276
5277 Reviewed by Dan Bernstein.
5278
5279 REGRESSION (r81518): Crash in makeRange() when invoking the dictionary p anel over a file input
5280 https://bugs.webkit.org/show_bug.cgi?id=62544
5281
5282 Fixed the crash by adding null pointer checks.
5283
5284 No new tests since there's no way to open dictionary panel.
5285
5286 * dom/Position.cpp:
5287 (WebCore::Position::parentAnchoredEquivalent):
5288 * editing/VisiblePosition.cpp:
5289 (WebCore::makeRange):
5290 * page/Frame.cpp:
5291 (WebCore::Frame::rangeForPoint):
5292
5293 2011-06-13 Adam Barth <abarth@webkit.org>
5294
5295 Reviewed by Nate Chapin.
5296
5297 Factor IconController out of FrameLoader
5298 https://bugs.webkit.org/show_bug.cgi?id=62509
5299
5300 This new class contains all the icon-related logic from FrameLoader.
5301 The icon-related logic and state has almost zero interaction with the
5302 rest of FrameLoader and is better handled as a separate concern.
5303
5304 * CMakeLists.txt:
5305 * GNUmakefile.list.am:
5306 * WebCore.gypi:
5307 * WebCore.pro:
5308 * WebCore.vcproj/WebCore.vcproj:
5309 * WebCore.xcodeproj/project.pbxproj:
5310 * dom/Document.cpp:
5311 (WebCore::Document::implicitClose):
5312 (WebCore::Document::setIconURL):
5313 * inspector/InspectorResourceAgent.cpp:
5314 (WebCore::InspectorResourceAgent::didReceiveResponse):
5315 * loader/DocumentLoader.cpp:
5316 (WebCore::DocumentLoader::iconLoadDecisionAvailable):
5317 (WebCore::DocumentLoader::continueIconLoadWithDecision):
5318 * loader/FrameLoader.cpp:
5319 (WebCore::FrameLoader::FrameLoader):
5320 (WebCore::FrameLoader::stop):
5321 * loader/FrameLoader.h:
5322 (WebCore::FrameLoader::icon):
5323 * loader/icon/IconLoader.cpp:
5324 (WebCore::IconLoader::startLoading):
5325 (WebCore::IconLoader::finishLoading):
5326 * loader/icon/IconLoader.h:
5327
5328 2011-06-13 Nate Chapin <japhet@chromium.org>
5329
5330 Reviewed by Darin Fisher.
5331
5332 [V8] Cache V8NPObjects so that we don't create multiple
5333 NPObjects for the same v8::Object.
5334 https://bugs.webkit.org/show_bug.cgi?id=61482
5335
5336 Test: plugins/npruntime/embed-property-equality.html
5337
5338 * bindings/v8/NPV8Object.cpp:
5339 (WebCore::freeV8NPObject):
5340 (WebCore::npCreateV8ScriptObject):
5341
5342 2011-06-13 Xan Lopez <xlopez@igalia.com>
5343
5344 Reviewed by Martin Robinson.
5345
5346 Distcheck fixes.
5347
5348 * GNUmakefile.am:
5349 * GNUmakefile.list.am:
5350
5351 2011-06-13 Dirk Schulze <krit@webkit.org>
5352
5353 Reviewed build fix of mac.
5354
5355 SVGAnimation should use direct unit animation for SVGLength
5356 https://bugs.webkit.org/show_bug.cgi?id=61368
5357
5358 Forgot to add SVGAnimatedLength.cpp.
5359
5360 * WebCore.xcodeproj/project.pbxproj:
5361
5362 2011-06-13 Dirk Schulze <krit@webkit.org>
5363
5364 Reviewed by Nikolas Zimmermann.
5365
5366 SVGAnimation should use direct unit animation for SVGLength
5367 https://bugs.webkit.org/show_bug.cgi?id=61368
5368
5369 When running SMIL animations within SVG, we unnecessarily transform the underlying SVG primitive datatype to strings, number+units, and back. As first step the target element
5370 gets asked for its current value. This value gets transformed to a strin g. In SVGAnimateElement we try to parse this string again and
5371 split it into a number and its unit. In the further steps we just animat e the number. This number gets transformed back to a string
5372 together with the parsed unit. The string gets passed back to the target element, which is responsible for parsing the passed string back
5373 to a value as a SVG primitive datatype (like SVGLength, SVGNumber, SVGAn gle, SVGColor, ...), relayout and rerendering.
5374
5375 In short: SVG primitive datatype -> string -> number + unit animation -> string -> SVG primitive datatype.
5376
5377 This patch does not attempt to change the string transformations, but ad dresses the parsing of the string back to a number and unit in the
5378 SVG animation code. There's no need to write a new parser in SVGAnimateE lement to parse SVG primitive datatypes, we can instead reuse the existing ones.
5379 Also the current parser of SVGAnimateElement does not handle most unit t ypes, nor is it possible to animate lists like SVGLengthList with the
5380 parsed content. An animation of values with different unit types is not possible:
5381
5382 <rect width="20" height="20">
5383 <animate animateAttribute="width" from="20px" to="10%" dur="4s"/>
5384 </rect>
5385
5386 For the example above we would animate the rect width from 20px to 10px in 4 seconds and jump to the 10% of the viewport at the end of the
5387 animation.
5388 With using the parsers of SVG primitive datatypes we will also use the S VG primitive datatypes in the animation code itself. And that makes
5389 it possible to do such animations.
5390
5391 In short: SVG primitive datatype -> string -> SVG primitive datatype ani mation -> string -> SVG primitive datatype.
5392
5393 It will be easier to avoid the string transformation once all SVG primit ive datatypes are supported.
5394
5395 To hide the complexity of the animation code, the actual calculations of SVG animation specific values was moved to the corresponding
5396 SVGAnimated* files (SVGAnimatedLength.cpp for SVGLength). SVGAnimateElem ent itself just works with the new added generic datatype SVGAnimationType.
5397 SVGAnimatorFactory creates the SVG primitive datatype specific animators . This makes the main animation code a lot more readable and
5398 maintainable.
5399
5400 With this patch I add the SVGAnimatorFactory and convert SVGLength anima tion to the new concept.
5401
5402 Tests: svg/animations/svglength-animation-LengthModeHeight.html
5403 svg/animations/svglength-animation-LengthModeOther.html
5404 svg/animations/svglength-animation-LengthModeWidth.html
5405 svg/animations/svglength-animation-invalid-value-1.html
5406 svg/animations/svglength-animation-invalid-value-2.html
5407 svg/animations/svglength-animation-invalid-value-3.html
5408 svg/animations/svglength-animation-number-to-number.html
5409 svg/animations/svglength-animation-px-to-cm.html
5410 svg/animations/svglength-animation-px-to-ems.html
5411 svg/animations/svglength-animation-px-to-exs.html
5412 svg/animations/svglength-animation-px-to-in.html
5413 svg/animations/svglength-animation-px-to-number.html
5414 svg/animations/svglength-animation-px-to-pc.html
5415 svg/animations/svglength-animation-px-to-percentage.html
5416 svg/animations/svglength-animation-px-to-pt.html
5417 svg/animations/svglength-animation-px-to-px.html
5418 svg/animations/svglength-animation-values.html
5419
5420 * CMakeLists.txt: Added new files to build system.
5421 * GNUmakefile.list.am: Ditto.
5422 * WebCore.gypi: Ditto.
5423 * WebCore.pro: Ditto.
5424 * WebCore.vcproj/WebCore.vcproj: Ditto.
5425 * WebCore.xcodeproj/project.pbxproj: Ditto.
5426 * svg/SVGAllInOne.cpp: Added SVGAnimatedLength.cpp for Win and other bui ld systems.
5427 * svg/SVGAnimateElement.cpp:
5428 (WebCore::parseNumberValueAndUnit): Remove parsing code for SVGLength. U se SVGLength parser directly.
5429 (WebCore::SVGAnimateElement::adjustForCurrentColor): Made adjustForCurre ntColor public as preperation for SVGAnimatedColor.
5430 (WebCore::getPropertyValue): Inline function to get computedStyle of CSS property.
5431 (WebCore::SVGAnimateElement::adjustForInheritance): Made adjustForInheri tance as preperation for SVGAnimated* files.
5432 (WebCore::SVGAnimateElement::determineAnimatedAttributeType): SVGLength need special handling via SVGAnimator now.
5433 (WebCore::SVGAnimateElement::calculateAnimatedValue): Cleanup. Make use of SVGAnimator for SVGLength.
5434 (WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto.
5435 (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto.
5436 (WebCore::SVGAnimateElement::resetToBaseValue): Ditto.
5437 (WebCore::SVGAnimateElement::applyResultsToTarget): Ditto.
5438 (WebCore::SVGAnimateElement::calculateDistance): Ditto.
5439 * svg/SVGAnimateElement.h:
5440 * svg/SVGAnimatedLength.cpp: Added.
5441 (WebCore::SVGAnimatedLengthAnimator::SVGAnimatedLengthAnimator):
5442 (WebCore::sharedSVGLength):
5443 (WebCore::SVGAnimatedLengthAnimator::constructFromString):
5444 (WebCore::SVGAnimatedLengthAnimator::calculateFromAndToValues):
5445 (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues):
5446 (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
5447 (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
5448 * svg/SVGAnimatedLength.h: Added new class SVGAnimatedLengthAnimator whi ch is responsible for the actual animation.
5449 (WebCore::SVGAnimatedLengthAnimator::~SVGAnimatedLengthAnimator):
5450 * svg/SVGAnimatedType.h: Added. Generic SVG unit type for animations in SVGAnimateElement.
5451 (WebCore::SVGAnimatedType::createLength):
5452 (WebCore::SVGAnimatedType::~SVGAnimatedType):
5453 (WebCore::SVGAnimatedType::type):
5454 (WebCore::SVGAnimatedType::length):
5455 (WebCore::SVGAnimatedType::SVGAnimatedType):
5456 * svg/SVGAnimatedTypeAnimator.h: Added. Base class for SVGAnimatedLength Animator and future SVG unit animators.
5457 (WebCore::SVGAnimatedTypeAnimator::~SVGAnimatedTypeAnimator):
5458 (WebCore::SVGAnimatedTypeAnimator::setContextElement):
5459 (WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
5460 * svg/SVGAnimationElement.cpp:
5461 (WebCore::SVGAnimationElement::parseMappedAttribute): We do not use pars eNumberValueAndUnit for SVGLength now. Have to strip white spaces here. Whitespa ces shouldn't
5462 be stripped on the following attributes: 'from', 'to' and 'by'. This i s not the case for SVGLength anymore. Added new tests to check this behavior.
5463 (WebCore::SVGAnimationElement::animationMode): Enum is accessible in Web Core namespace now.
5464 (WebCore::SVGAnimationElement::calcMode): Ditto.
5465 * svg/SVGAnimationElement.h:
5466 * svg/SVGAnimatorFactory.h: Added.
5467 (WebCore::SVGAnimatorFactory::create):
5468 * svg/SVGLength.cpp:
5469 (WebCore::SVGLength::setValueAsString): New setter with string and SVGLe ngthMode.
5470 (WebCore::SVGLength::lengthModeForAnimatedLengthAttribute): Get LengthMo de for SVGLength depending on the attribute name.
5471 * svg/SVGLength.h:
5472
5473 2011-06-13 Adam Barth <abarth@webkit.org>
5474
5475 Reviewed by Darin Adler.
5476
5477 r87539 broke HTMLMediaElement url logging
5478 https://bugs.webkit.org/show_bug.cgi?id=62551
5479
5480 Returning pointers to temporaries is bad times!
5481
5482 * html/HTMLMediaElement.cpp:
5483 (WebCore::urlForLogging):
5484 (WebCore::HTMLMediaElement::loadResource):
5485 (WebCore::HTMLMediaElement::isSafeToLoadURL):
5486 (WebCore::HTMLMediaElement::selectNextSourceChild):
5487 (WebCore::HTMLMediaElement::sourceWasAdded):
5488 (WebCore::HTMLMediaElement::sourceWillBeRemoved):
5489
5490 2011-06-13 Tony Chang <tony@chromium.org>
5491
5492 Reviewed by Dimitri Glazkov.
5493
5494 rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
5495 https://bugs.webkit.org/show_bug.cgi?id=62578
5496
5497 * Configurations/FeatureDefines.xcconfig:
5498
5499 2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
5500
5501 Reviewed by Tony Chang.
5502
5503 IndexedDB: setVersion() version argument is required
5504 https://bugs.webkit.org/show_bug.cgi?id=62401
5505
5506 Test: storage/indexeddb/setVersion-undefined.html
5507
5508 * storage/IDBDatabase.cpp:
5509 (WebCore::IDBDatabase::setVersion): check for null version
5510 * storage/IDBDatabase.idl: add IDL magic to force undefined to null so w e can handle both missing and null arguments
5511
5512 2011-06-13 Simon Fraser <simon.fraser@apple.com>
5513
5514 Reviewed by Adele Peterson.
5515
5516 Print out bounds origin in layer dump
5517 https://bugs.webkit.org/show_bug.cgi?id=62583
5518
5519 Include m_boundsOrigin in the layer dump, which is used by layerTreeAsTe xt().
5520
5521 * platform/graphics/GraphicsLayer.cpp:
5522 (WebCore::GraphicsLayer::dumpProperties):
5523
5524 2011-06-13 Simon Fraser <simon.fraser@apple.com>
5525
5526 Reviewed by Adele Peterson.
5527
5528 Add utility method to report whether a RenderLayer has any scrollbars
5529 https://bugs.webkit.org/show_bug.cgi?id=62579
5530
5531 New method that returns true with either scrollbar is present.
5532
5533 * rendering/RenderLayer.h:
5534 (WebCore::RenderLayer::hasScrollbars):
5535
5536 2011-06-11 Jer Noble <jer.noble@apple.com>
5537
5538 Reviewed by Anders Carlsson.
5539
5540 Avoid flashing when exiting full-screen mode.
5541 https://bugs.webkit.org/show_bug.cgi?id=62338
5542
5543 No new tests; covered by the existing full-screen tests.
5544
5545 Now that we are forcing a repaint inside of setRootFullScreenLayer() ins tead of during
5546 the next run loop, make sure that we have disabled animation before call ing
5547 setRootFullScreenLayer() so that the RenderFullScreen renderer and its c ontents are
5548 painted.
5549
5550 * dom/Document.cpp:
5551 (WebCore::Document::webkitDidEnterFullScreenForElement):
5552
5553 2011-06-10 Jer Noble <jer.noble@apple.com>
5554
5555 Reviewed by Darin Adler.
5556
5557 Flash of white on left and right edges of screen when showing fullscreen controller when movie doesn't fill the entire screen
5558 https://bugs.webkit.org/show_bug.cgi?id=62491
5559 <rdar://problem/9584427>
5560
5561 No new tests; should be covered by existing fullscreen pixel tests.
5562
5563 On certain displays, when a RenderFullScreen renderer is created, it is large enough to trigger the
5564 creation of a tiled CALayer (instead of a normal CALayer). Painting in these layers necessarily
5565 happens asynchronously, so the flash is occurring because of the async p ainting of the RenderFullScreen
5566 renderer's background color. Since we know the RenderFullScreen does no t otherwise paint its contents,
5567 we can add a special case in the RenderLayerBacking to set the GraphicsL ayer contents to be the
5568 renderer's background color. Fill in support for creating a contentLaye r to contain the background
5569 color inside GraphicsLayerCA.
5570
5571 * platform/graphics/GraphicsLayer.h:
5572 (WebCore::GraphicsLayer::setContentsToBackgroundColor): Renamed from set ContentsBackgroundColor to match
5573 the other setContentsTo... functions.
5574 * platform/graphics/ca/GraphicsLayerCA.cpp:
5575 (WebCore::GraphicsLayerCA::setContentsToBackgroundColor): Added. Creates a contentsLayer to host the
5576 background color.
5577 (WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Removed a commen t only.
5578 * platform/graphics/ca/GraphicsLayerCA.h:
5579 * rendering/RenderLayerBacking.cpp:
5580 (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Special case the RenderFullScreen
5581 renderer to call updateBackgroundColor.
5582 (WebCore::RenderLayerBacking::updateBackgroundColor): Added.
5583 (WebCore::RenderLayerBacking::containsPaintedContent): Tell the backing that the RenderFullScreen
5584 renderer does not paint its contents.
5585 * rendering/RenderLayerBacking.h:
5586
5587 2011-06-13 Tim Horton <timothy_horton@apple.com>
5588
5589 Reviewed by Simon Fraser.
5590
5591 REGRESSION(87152): Crash on page with svg fonts
5592 https://bugs.webkit.org/show_bug.cgi?id=61556
5593
5594 We can't assume that the parent of a SVG-font-styled
5595 text node won't be an anonymous block.
5596
5597 Test: svg/text/text-font-anonymous-parent.xhtml
5598
5599 * rendering/svg/SVGTextRunRenderingContext.cpp:
5600 (WebCore::firstParentRendererForNonTextNode):
5601 (WebCore::SVGTextRunWalker::walk):
5602 (WebCore::floatWidthOfSubStringUsingSVGFont):
5603 (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont):
5604
5605 2011-06-13 Tony Chang <tony@chromium.org>
5606
5607 Reviewed by Adam Barth.
5608
5609 rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
5610 https://bugs.webkit.org/show_bug.cgi?id=62545
5611
5612 * Configurations/FeatureDefines.xcconfig:
5613
5614 2011-06-13 Xan Lopez <xlopez@igalia.com>
5615
5616 Reviewed by Martin Robinson.
5617
5618 Some distcheck fixes. Still broken, but this is moves us closer to
5619 the target.
5620
5621 * GNUmakefile.am: fix vpath syntax and add missing files to
5622 EXTRA_DIST.
5623 * GNUmakefile.list.am: add missing files and remove dead files.
5624 * bindings/gobject/GNUmakefile.am: fix comment.
5625
5626 2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>
5627
5628 Reviewed by Kenneth Rohde Christiansen.
5629
5630 Add layer factory to GraphicsLayer for creating non-default layer type.
5631 https://bugs.webkit.org/show_bug.cgi?id=61925
5632
5633 Use the new factory function in TextureMapper.
5634
5635 No new functionality so no new tests.
5636
5637 * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
5638 (WebCore::GraphicsLayer::create):
5639
5640 2011-06-13 Young Han Lee <joybro@company100.net>
5641
5642 Reviewed by Kenneth Rohde Christiansen.
5643
5644 [Texmap][Qt] Accelerated animation is repeating as if its direction prop erty is always 'alternate'.
5645 https://bugs.webkit.org/show_bug.cgi?id=62281
5646
5647 syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.
5648
5649 Test: animations/animation-direction-normal.html
5650
5651 * platform/graphics/texmap/TextureMapperNode.cpp:
5652 (WebCore::TextureMapperNode::syncAnimations):
5653
5654 2011-06-13 Dirk Schulze <krit@webkit.org>
5655
5656 Reviewed by Rob Buis.
5657
5658 SVG patternTransform not animatable
5659 https://bugs.webkit.org/show_bug.cgi?id=62538
5660
5661 SVG animation did not take attribute 'patternTransform' into account. Ad ded support for combination of
5662 SVGPatternElement and attribute 'patternTransform' to SVGAnimateTransfor mElement.
5663
5664 Tests: svg/animations/animateTransform-pattern-transform.html
5665 svg/animations/animateTransform-transformable-transform.html
5666
5667 * svg/SVGAnimateTransformElement.cpp:
5668 (WebCore::transformListFor):
5669 (WebCore::SVGAnimateTransformElement::resetToBaseValue):
5670 (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
5671
5672 2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
5673
5674 Reviewed by Andreas Kling.
5675
5676 [Qt] JSC Bridge: convert QtConnectionObject to use JSC API
5677 https://bugs.webkit.org/show_bug.cgi?id=62330
5678
5679 This patch is based on the draft patch by Noam Rosenthal in bug 60842.
5680 Qt API autotests cover the bridge behavior and pass after this patch.
5681
5682 * bridge/qt/qt_runtime.h: Change QtConnectionObject to use JSC API types . In
5683 particular, we got rid of Strong<JSObject> members. Renamed some members and
5684 arguments to follow existing naming in QObject::connect().
5685
5686 * bridge/qt/qt_runtime.cpp:
5687 (JSC::Bindings::QtRuntimeConnectionMethod::call): Use a new helper funct ion
5688 to create a connection, passing the ExecState* that will be used when th e
5689 connection is activated (signal emitted). Use JSC API types when looking up
5690 the matching signal to disconnect.
5691
5692 (JSC::Bindings::QtConnectionObject::QtConnectionObject): Use JSC API to
5693 protect the receiver and receiverFunction from being garbage
5694 collected. Removed the ASSERT() since we don't hold ProtectedPtrs (in cu rrent
5695 code were Strong<>) anymore.
5696
5697 (JSC::Bindings::QtConnectionObject::~QtConnectionObject): Explain why is safe
5698 to use m_originalSender here. Unprotect values that we protected in cons tructor.
5699
5700 (JSC::Bindings::isJavaScriptFunction): Helper function to identify wheth er a
5701 JSObjectRef is a JS function (in contrast to a native function exposed t o JS).
5702
5703 (JSC::Bindings::QtConnectionObject::execute):
5704 (JSC::Bindings::QtConnectionObject::match):
5705 Both updated to use JSC API when appliable. Note that convertQVariantToV alue
5706 still returns JSC internal types, will be handled in a different patch.
5707
5708 (JSC::Bindings::QtConnectionObject::createWithInternalJSC):
5709 Convenince for the existing caller until it is converted to JSC as well.
5710
5711 2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
5712
5713 Reviewed by Martin Robinson.
5714
5715 [GTK] Add context menu support for Webkit2
5716 https://bugs.webkit.org/show_bug.cgi?id=54827
5717
5718 * platform/ContextMenuItem.h: Add gtkAction().
5719 * platform/gtk/ContextMenuGtk.cpp:
5720 (WebCore::ContextMenu::ContextMenu): Implement constructor that
5721 receives a platform menu.
5722 (WebCore::ContextMenu::setPlatformDescription): Make sure we don't
5723 destroy the menu if the new context menu is the current one.
5724 (WebCore::contextMenuItemVector): Implement this method to return
5725 the list of menu items in the given context menu, required by WebKit2.
5726 (WebCore::platformMenuDescription): Implement this method to
5727 return a platform menu for the given menu items.
5728 * platform/gtk/ContextMenuItemGtk.cpp:
5729 (WebCore::createPlatformMenuItemDescription): Helper function to
5730 create a platform context menu item.
5731 (WebCore::ContextMenuItem::ContextMenuItem): Use
5732 createPlatformMenuItemDescription().
5733 (WebCore::ContextMenuItem::title): Convert the title from UTF-8.
5734 (WebCore::ContextMenuItem::setTitle): Use gtkAction().
5735 (WebCore::ContextMenuItem::setSubMenu): Implement setSubMenu()
5736 that receives a list of items.
5737 (WebCore::ContextMenuItem::setChecked): Use gtkAction().
5738 (WebCore::ContextMenuItem::checked): Implement this, required by WebKit2 .
5739 (WebCore::ContextMenuItem::enabled): Ditto.
5740 (WebCore::ContextMenuItem::setEnabled): Use gtkAction().
5741 (WebCore::ContextMenuItem::gtkAction): Return the GtkAction
5742 associated to the context menu item.
5743
5744 2011-06-13 Keishi Hattori <keishi@webkit.org>
5745
5746 Sort WebCore.xcodeproj
5747
5748 Accomplished using sort-Xcode-project-file.
5749
5750 * WebCore.xcodeproj/project.pbxproj:
5751
5752 2011-06-12 Jer Noble <jer.noble@apple.com>
5753
5754 Reviewed by Darin Adler.
5755
5756 REGRESSION (full screen video): Watch Again button is obscured after ful l screen playback ends at Apple trailers page
5757 https://bugs.webkit.org/show_bug.cgi?id=62507
5758
5759 No new tests; DRT would have to be modified to delay between receiving e xitFullScreenForElement() and calling
5760 webkitWillExitFullScreenForElement() to be able to test this.
5761
5762 If the full-screen element is removed, and webkitWillExitFullScreenForEl ement() is not called before
5763 fullScreenElementRemoved() returns, then ancestors of the full-screen el ement will not have their
5764 containsFullScreenElement property removed. To protect against this, re set the property by calling
5765 setContainsFullScreenElementRecursively() from within fullScreenElementR emoved().
5766
5767 * dom/Document.cpp:
5768 (WebCore::Document::fullScreenElementRemoved): Added call to setContains FullScreenElementRecursively.
5769
5770 2011-06-12 Adam Barth <abarth@webkit.org>
5771
5772 Reviewed by Alexey Proskuryakov.
5773
5774 Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
5775 https://bugs.webkit.org/show_bug.cgi?id=62516
5776
5777 As requested by Alexey in https://bugs.webkit.org/show_bug.cgi?id=62510.
5778
5779 * loader/EmptyClients.h:
5780 (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError):
5781 * loader/FrameLoaderClient.h:
5782 * loader/MainResourceLoader.cpp:
5783 (WebCore::MainResourceLoader::interruptedForPolicyChangeError):
5784 (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
5785 (WebCore::MainResourceLoader::continueAfterContentPolicy):
5786 * loader/MainResourceLoader.h:
5787
5788 2011-06-12 Hironori Bono <hbono@chromium.org>
5789
5790 Reviewed by Hajime Morita.
5791
5792 Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
5793 https://bugs.webkit.org/show_bug.cgi?id=62526
5794
5795 This change adds null checks to the following function to prevent crashe s
5796 when calling removeSpellcheckRange() with null:
5797 HTMLTextAreaElement::removeSpellcheckRange(),
5798 HTMLInputElement::removeSpellcheckRange(), and
5799 HTMLDivElement::removeSpellcheckRange().
5800
5801 Test: editing/spelling/spellcheck-api-crash.html
5802
5803 * html/HTMLDivElement.cpp:
5804 (WebCore::HTMLDivElement::removeSpellcheckRange):
5805 * html/HTMLInputElement.cpp:
5806 (WebCore::HTMLInputElement::removeSpellcheckRange):
5807 * html/HTMLTextAreaElement.cpp:
5808 (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
5809
5810 2011-06-12 Adam Barth <abarth@webkit.org>
5811
5812 Reviewed by Darin Adler.
5813
5814 DocumentParser::appendBytes should use size_t for length instead of int
5815 https://bugs.webkit.org/show_bug.cgi?id=62508
5816
5817 size_t is the proper type for distances in memory, especially on 64 bit
5818 machines.
5819
5820 * dom/DecodedDataDocumentParser.cpp:
5821 (WebCore::DecodedDataDocumentParser::appendBytes):
5822 * dom/DecodedDataDocumentParser.h:
5823 * dom/DocumentParser.h:
5824 * html/ImageDocument.cpp:
5825 (WebCore::ImageDocumentParser::appendBytes):
5826 * html/MediaDocument.cpp:
5827 (WebCore::MediaDocumentParser::appendBytes):
5828 * html/PluginDocument.cpp:
5829 (WebCore::PluginDocumentParser::appendBytes):
5830 * loader/SinkDocument.cpp:
5831 (WebCore::SinkDocumentParser::appendBytes):
5832
5833 2011-06-12 Adam Barth <abarth@webkit.org>
5834
5835 Reviewed by Eric Seidel.
5836
5837 Remove FrameLoader::isProcessingUserGesture
5838 https://bugs.webkit.org/show_bug.cgi?id=62519
5839
5840 This function is a remnant of the old user gesture design, which
5841 involved per-frame state stored on FrameLoader. Now that we're using
5842 static state, we don't need this function anymore.
5843
5844 This function used to check whether JavaScript was enabled for the
5845 top-level frame, but that check doesn't make any sense (like much of
5846 the old user gesture code).
5847
5848 * WebCore.exp.in:
5849 * html/HTMLMediaElement.cpp:
5850 (WebCore::HTMLMediaElement::processingUserGesture):
5851 * loader/FrameLoader.cpp:
5852 (WebCore::FrameLoader::submitForm):
5853 * loader/FrameLoader.h:
5854 * rendering/RenderFileUploadControl.cpp:
5855 (WebCore::RenderFileUploadControl::click):
5856
5857 2011-06-12 Adam Barth <abarth@webkit.org>
5858
5859 Fix fullscreen/full-screen-iframe-legacy.html.
5860
5861 * html/HTMLVideoElement.idl:
5862
5863 2011-06-12 Adam Barth <abarth@webkit.org>
5864
5865 Reviewed by Alexey Proskuryakov.
5866
5867 Remove trival "forward-to-client" member functions from FrameLoader
5868 https://bugs.webkit.org/show_bug.cgi?id=62510
5869
5870 Originally, FrameLoader was supposed to abstract FrameLoaderClient, but
5871 we lost that battle log ago. Nowadays, it's easier if folks just call
5872 into FrameLoaderClient directly. Many of these functions have direct
5873 callers already anyway.
5874
5875 * WebCore.exp.in:
5876 * html/HTMLMediaElement.cpp:
5877 (WebCore::HTMLMediaElement::createRenderer):
5878 (WebCore::HTMLMediaElement::attach):
5879 * loader/DocumentLoader.cpp:
5880 (WebCore::DocumentLoader::setRequest):
5881 (WebCore::DocumentLoader::setMainDocumentError):
5882 (WebCore::DocumentLoader::setupForReplaceByMIMEType):
5883 * loader/FrameLoader.cpp:
5884 (WebCore::FrameLoader::didFirstLayout):
5885 * loader/FrameLoader.h:
5886 - cancelledError is slightly more delicate, so I'm going to move it in
5887 a separate patch.
5888 * loader/MainResourceLoader.cpp:
5889 (WebCore::MainResourceLoader::interruptForPolicyChangeError):
5890 (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
5891 (WebCore::MainResourceLoader::continueAfterContentPolicy):
5892 (WebCore::MainResourceLoader::handleEmptyLoad):
5893 (WebCore::MainResourceLoader::loadNow):
5894 * loader/MainResourceLoader.h:
5895 * loader/NetscapePlugInStreamLoader.cpp:
5896 (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
5897 * loader/PingLoader.cpp:
5898 (WebCore::PingLoader::PingLoader):
5899 * loader/PolicyChecker.cpp:
5900 (WebCore::PolicyChecker::continueAfterNavigationPolicy):
5901 * loader/ResourceLoader.cpp:
5902 (WebCore::ResourceLoader::blockedError):
5903 (WebCore::ResourceLoader::cannotShowURLError):
5904 (WebCore::ResourceLoader::shouldUseCredentialStorage):
5905 (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
5906 * page/ContextMenuController.cpp:
5907 (WebCore::ContextMenuController::populate):
5908
5909 2011-06-12 Dan Bernstein <mitz@apple.com>
5910
5911 Reviewed by Darin Adler.
5912
5913 <rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:in line to display:none transition has complexity N^2 where N is the number of chil d Text nodes
5914 https://bugs.webkit.org/show_bug.cgi?id=61557
5915
5916 Replaced the fix for bug 58500 with a refined version.
5917
5918 * rendering/RenderText.cpp:
5919 (WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is
5920 across a layer boundary.
5921
5922 2011-06-12 Adam Barth <abarth@webkit.org>
5923
5924 Reviewed by Andreas Kling.
5925
5926 Minor user-gesture related cleanup
5927 https://bugs.webkit.org/show_bug.cgi?id=62511
5928
5929 In reading the user gesture code, I noticed that these lines of code
5930 should be deleted because they don't do anything.
5931
5932 * bindings/v8/NPV8Object.cpp:
5933 * html/HTMLAnchorElement.cpp:
5934 * html/HTMLVideoElement.idl:
5935
5936 2011-06-11 Nikolas Zimmermann <nzimmermann@rim.com>
5937
5938 Reviewed by Dirk Schulze.
5939
5940 Add TextRun charactersLength member
5941 https://bugs.webkit.org/show_bug.cgi?id=62501
5942
5943 Preparation patch 2: Propagate the maximum length of the characters buff er the TextRun operates on, even when we're only measuring a substring.
5944 For example: In RenderText when we're measuring 'len' characters startin g from "text()->characters() + start", there's a portion
5945 of "textLength() - start" characters that we're not processing. In order to support ligatures when integrating SVG Fonts
5946 within the GlyphPage concept, we need this extra information, to lookup ligatures even when single chars are measured.
5947 If a font defines an eg "ffl" ligature, and we're measuring the "f" of " ffl", it shall looukp the "ffl" glyph from the font,
5948 and skip the next two characters (this will be done in WidthIterator).
5949
5950 This doesn't yet affect any test, the new SVG Fonts code is not merged y et, this is the preparaion patch 2.
5951
5952 * platform/graphics/Font.h: Add yet-unused "const TextRun&" parameter to drawGlyphBuffer/drawEmphasisMarks.
5953 * platform/graphics/FontFastPath.cpp: Ditto. This parameter will be used to looukp the TextRunRenderingContext in a follow-up patch.
5954 (WebCore::Font::drawSimpleText):
5955 (WebCore::Font::drawEmphasisMarksForSimpleText):
5956 (WebCore::Font::drawGlyphBuffer):
5957 (WebCore::Font::drawEmphasisMarks):
5958 * platform/graphics/TextRun.h: Add "int m_charactersLength", similar to "int m_len". It denotes the maximum length of the characters buffer
5959 that we're holding. It defaults to the pa ssed "len" value, but is overriden by explicit setCharactersLength calls.
5960 (WebCore::TextRun::TextRun):
5961 (WebCore::TextRun::charactersLength):
5962 (WebCore::TextRun::setCharactersLength):
5963 * platform/graphics/mac/FontComplexTextMac.cpp: Pass TextRun do drawGlyp hBuffer/drawEmphasisMarks.
5964 (WebCore::Font::drawComplexText):
5965 (WebCore::Font::drawEmphasisMarksForComplexText):
5966 * platform/graphics/win/FontWin.cpp: Ditto.
5967 (WebCore::Font::drawComplexText):
5968 (WebCore::Font::drawEmphasisMarksForComplexText):
5969 * platform/graphics/wx/FontWx.cpp: Ditto.
5970 (WebCore::Font::drawComplexText):
5971 (WebCore::Font::drawEmphasisMarksForComplexText):
5972 * rendering/InlineTextBox.cpp: Call setCharactersLength on the processed TextRun.
5973 (WebCore::InlineTextBox::constructTextRun):
5974 * rendering/RenderBlockLineLayout.cpp: Ditto.
5975 (WebCore::textWidth):
5976 (WebCore::tryHyphenating):
5977 * rendering/RenderText.cpp: Ditto.
5978 (WebCore::RenderText::widthFromCache):
5979 (WebCore::RenderText::computePreferredLogicalWidths):
5980 (WebCore::RenderText::width):
5981 * rendering/svg/SVGInlineTextBox.cpp: Ditto.
5982 (WebCore::SVGInlineTextBox::constructTextRun):
5983
5984 2011-06-12 Robert Hogan <robert@webkit.org>
5985
5986 Reviewed by Andreas Kling.
5987
5988 [Qt] Fix methods.html and methods-lower-case.html
5989 https://bugs.webkit.org/show_bug.cgi?id=62221
5990
5991 * platform/network/qt/QNetworkReplyHandler.cpp:
5992 (WebCore::QNetworkReplyHandler::clearContentsHeaders): Refactor code fro m sendNetworkRequest
5993 (WebCore::QNetworkReplyHandler::getIODevice): ditto
5994 (WebCore::QNetworkReplyHandler::sendNetworkRequest):
5995 - Remove ContentType and ContentLength headers from GET, DELETE and HEAD requests since
5996 we do not send data with any of these requests.
5997 - If a custom HTTP operation contains data, send it.
5998 * platform/network/qt/QNetworkReplyHandler.h:
5999
6000 2011-06-11 Michael Saboff <msaboff@apple.com>
6001
6002 Reviewed by James Robinson.
6003
6004 REGRESSION(88260): 10-50% performance regression across many page cycler s
6005 https://bugs.webkit.org/show_bug.cgi?id=62349
6006
6007 Made CHROMIUM platform specific values for cMaxInactiveFontData and
6008 cTargetInactiveFontData to mitigate the current performance issue on Chr omium
6009 page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based
6010 on recommendation from James Robinson. Changed cTargetInactiveFontData to 200
6011 so that 50 inactive fonts will be cleaned up at a time.
6012
6013 Change made to address existing Chromium performance test regression.
6014
6015 * platform/graphics/FontCache.cpp:
6016
6017 2011-06-11 Adam Barth <abarth@webkit.org>
6018
6019 Reviewed by Darin Adler.
6020
6021 Remove unnecessary strlen from DocumentWriter
6022 https://bugs.webkit.org/show_bug.cgi?id=62505
6023
6024 This ugly piece of code appears not to be needed. Rejoice.
6025
6026 * WebCore.exp.in:
6027 * loader/DocumentLoader.cpp:
6028 (WebCore::DocumentLoader::commitData):
6029 * loader/DocumentLoader.h:
6030 * loader/DocumentWriter.cpp:
6031 (WebCore::DocumentWriter::addData):
6032 * loader/DocumentWriter.h:
6033
6034 2011-06-11 Adam Barth <abarth@webkit.org>
6035
6036 Reviewed by Darin Adler.
6037
6038 DocumentParser::appendBytes shouldn't have a "flush" boolean parameter
6039 https://bugs.webkit.org/show_bug.cgi?id=62499
6040
6041 This patch removes the "flush" Boolean parameter from
6042 DocumentParser::appendBytes in favor of a new flush method. This makes
6043 some code in DocumentWriter look less ridiculous.
6044
6045 There's still lots of on contorting to do here, but it's a start.
6046
6047 * dom/DecodedDataDocumentParser.cpp:
6048 (WebCore::DecodedDataDocumentParser::appendBytes):
6049 (WebCore::DecodedDataDocumentParser::flush):
6050 * dom/DecodedDataDocumentParser.h:
6051 * dom/DocumentParser.h:
6052 * dom/RawDataDocumentParser.h:
6053 (WebCore::RawDataDocumentParser::flush):
6054 * html/ImageDocument.cpp:
6055 (WebCore::ImageDocumentParser::appendBytes):
6056 * html/MediaDocument.cpp:
6057 (WebCore::MediaDocumentParser::appendBytes):
6058 * html/PluginDocument.cpp:
6059 (WebCore::PluginDocumentParser::appendBytes):
6060 * loader/DocumentWriter.cpp:
6061 (WebCore::DocumentWriter::reportDataReceived):
6062 (WebCore::DocumentWriter::addData):
6063 (WebCore::DocumentWriter::endIfNotLoadingMainResource):
6064 * loader/DocumentWriter.h:
6065 * loader/SinkDocument.cpp:
6066 (WebCore::SinkDocumentParser::appendBytes):
6067
6068 2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>
6069
6070 Unreviewed, rolling out r88569.
6071 http://trac.webkit.org/changeset/88569
6072 https://bugs.webkit.org/show_bug.cgi?id=62398
6073
6074 Broke Chromium browser test:
6075 IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest
6076
6077 * storage/IDBFactory.idl:
6078
6079 2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>
6080
6081 Unreviewed, rolling out r88565.
6082 http://trac.webkit.org/changeset/88565
6083 https://bugs.webkit.org/show_bug.cgi?id=62401
6084
6085 Broke Chromium browser test:
6086 IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest
6087
6088 * storage/IDBDatabase.cpp:
6089 (WebCore::IDBDatabase::setVersion):
6090 * storage/IDBDatabase.idl:
6091
6092 2011-06-10 Abhishek Arya <inferno@chromium.org>
6093
6094 Reviewed by Simon Fraser.
6095
6096 Null parent element sheet pointers in CSSMutableStyleDeclaration consume rs
6097 when removed from document, set them when reinserted into document.
6098 https://bugs.webkit.org/show_bug.cgi?id=62230
6099
6100 When a HTMLBodyElement, StyledElement are removed from document,
6101 we didn't clear out the parent pointers from their link, style declarati ons.
6102 These parent pointers pointed to the document's element sheet which will
6103 get removed when document is getting destroyed. It does make sense to
6104 clear out parent pointers when we are getting removed from document and
6105 readd them when we get inserted again.
6106
6107 Tests: fast/dom/body-link-decl-parent-crash.html
6108 fast/dom/styled-inline-style-decl-parent-crash.html
6109
6110 * dom/StyledElement.cpp:
6111 (WebCore::StyledElement::insertedIntoDocument):
6112 (WebCore::StyledElement::removedFromDocument):
6113 * dom/StyledElement.h:
6114 * html/HTMLBodyElement.cpp:
6115 (WebCore::HTMLBodyElement::parseMappedAttribute):
6116 (WebCore::HTMLBodyElement::insertedIntoDocument):
6117 (WebCore::HTMLBodyElement::removedFromDocument):
6118 (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):
6119 * html/HTMLBodyElement.h:
6120
6121 2011-06-10 Adam Barth <abarth@webkit.org>
6122
6123 Remove bogus ASSERTs. These ASSERTs used to be correct before I
6124 changed DocumentWriter to put the onus for ignoring empty writes onto
6125 the parser.
6126
6127 This patch should stop these test from triggering ASSERTs:
6128
6129 plugins/plugin-document-back-forward.html
6130 plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
6131 userscripts/user-script-plugin-document.html
6132
6133 * html/MediaDocument.cpp:
6134 (WebCore::MediaDocumentParser::appendBytes):
6135 * html/PluginDocument.cpp:
6136 (WebCore::PluginDocumentParser::appendBytes):
6137
6138 2011-06-09 Jer Noble <jer.noble@apple.com>
6139
6140 Reviewed by Darin Adler.
6141
6142 REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
6143 https://bugs.webkit.org/show_bug.cgi?id=62411
6144
6145 Test: fullscreen/full-screen-remove-ancestor-after.html
6146
6147 The placeholder for RenderFullScreen was being created as a non-anonymou s object, which led
6148 to the document's renderer being set to 0 when the placeholder was remov ed due to its parent
6149 being removed. Setting the placeholder to be anonymous, however, means t hat it will be
6150 coalesced with sibling anonymous blocks, so added the RenderFullScreenPl aceholder to the
6151 list of anonymous objects that are not considered anonymous blocks, to a void the placeholder
6152 being so coalesced. To do so, made the placeholder object a true subclas s, and add and
6153 override its destroy() function to notify the RenderFullScreen object th at it has been
6154 destroyed.
6155
6156 * rendering/RenderFullScreen.cpp:
6157 (RenderFullScreenPlaceholder::RenderFullScreenPlaceholder): Added.
6158 (RenderFullScreenPlaceholder::~RenderFullScreenPlaceholder): Added.
6159 (RenderFullScreenPlaceholder::isRenderFullScreenPlaceholder): Added.
6160 (RenderFullScreenPlaceholder::destroy): Notify the owner renderer that i ts placeholder
6161 has been destroyed.
6162 (RenderFullScreen::destroy): Assert that the m_placeholder ivar is 0 aft er destroying it.
6163 (RenderFullScreen::setPlaceholder): Added.
6164 (RenderFullScreen::createPlaceholder): Do not make the placeholder anony mous.
6165 * rendering/RenderFullScreen.h:
6166 * rendering/RenderObject.h:
6167 (WebCore::RenderObject::isRenderFullScreenPlaceholder): Added.
6168 (WebCore::RenderObject::isAnonymousBlock): Added the placeholder class t o the list of
6169 objects which are not anonymous blocks.
6170
6171 2011-06-10 Gavin Barraclough <barraclough@apple.com>
6172
6173 Reviewed by Sam Weinig.
6174
6175 https://bugs.webkit.org/show_bug.cgi?id=16777
6176 Eliminate JSC::NaN and JSC::Inf
6177
6178 There's no good reason for -K-J-S- JSC to have its own NAN and infinity constants.
6179 The ones in std::numeric_limits are perfectly good.
6180 Remove JSC::Inf, JSC::NaN, switch some cases of (isnan || isinf) to !isf inite.
6181
6182 * bindings/js/JSDataViewCustom.cpp:
6183 (WebCore::getDataViewMember):
6184
6185 2011-06-10 James Simonsen <simonjam@chromium.org>
6186
6187 Reviewed by Eric Seidel.
6188
6189 <script> inside <svg> should be executed
6190 https://bugs.webkit.org/show_bug.cgi?id=62412
6191
6192 Tests: svg/in-html/script-external.html
6193 svg/in-html/script-nested.html
6194 svg/in-html/script-write.html
6195 svg/in-html/script.html
6196
6197 * html/parser/HTMLTreeBuilder.cpp:
6198 (WebCore::HTMLTreeBuilder::processEndTag):
6199
6200 2011-06-10 Adam Barth <abarth@webkit.org>
6201
6202 Reviewed by Darin Adler.
6203
6204 Script-created parsers should ignore data from the network
6205 https://bugs.webkit.org/show_bug.cgi?id=62336
6206
6207 If the network packet boundaries line up just right, we can end up
6208 feeding network data to a parser created by document.write (or
6209 document.open). That's incorrect.
6210
6211 This patch causes DocumentWriter to grab hold of the original parser
6212 and direct all input to that parser.
6213
6214 Test: fast/parser/document-write-ignores-later-network-bytes.html
6215
6216 * dom/Document.cpp:
6217 (WebCore::Document::explicitClose):
6218 * loader/DocumentWriter.cpp:
6219 (WebCore::DocumentWriter::begin):
6220 (WebCore::DocumentWriter::addData):
6221 (WebCore::DocumentWriter::endIfNotLoadingMainResource):
6222 (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
6223 * loader/DocumentWriter.h:
6224
6225 2011-06-10 Simon Fraser <simon.fraser@apple.com>
6226
6227 Reviewed by Dan Bernstein.
6228
6229 Keep overlap testing logic until real 3d transforms are being used
6230 https://bugs.webkit.org/show_bug.cgi?id=49857
6231
6232 For pages that use the translateZ(0) hack to force compositing layers, i t's
6233 advantageous to keep overlap testing, to avoid putting too many other
6234 elements into layers.
6235
6236 Only turn off overlap testing if non-identity 3D transforms are used.
6237
6238 Tests: compositing/layer-creation/rotate3d-overlap.html
6239 compositing/layer-creation/translatez-overlap.html
6240
6241 * rendering/RenderLayerCompositor.cpp:
6242 (WebCore::RenderLayerCompositor::updateBacking):
6243 (WebCore::RenderLayerCompositor::hasNonIdentity3DTransform):
6244 * rendering/RenderLayerCompositor.h:
6245
6246 2011-06-10 David Levin <levin@chromium.org>
6247
6248 Reviewed by Dmitry Titov.
6249
6250 Web Worker fails to fire error event when a resource fetch fails.
6251 https://bugs.webkit.org/show_bug.cgi?id=62475
6252
6253 Test: http/tests/workers/worker-workerScriptNotThere.html
6254
6255 * workers/WorkerScriptLoader.cpp:
6256 (WebCore::WorkerScriptLoader::didFinishLoading): Ensure that
6257 the client is notified of the error when it happens during loading.
6258
6259 2011-06-10 David Levin <levin@chromium.org>
6260
6261 Reviewed by Dmitry Titov.
6262
6263 Fetching a Worker with url that isn't allowed from a file based test cau ses DRT to crash.
6264 https://bugs.webkit.org/show_bug.cgi?id=62469
6265
6266 Test: fast/workers/worker-crash-with-invalid-location.html
6267
6268 * workers/DefaultSharedWorkerRepository.cpp:
6269 (WebCore::SharedWorkerScriptLoader::load): Changed to using the RefCount ed version of WorkerScriptLoader.
6270 * workers/Worker.cpp:
6271 (WebCore::Worker::create): Ditto.
6272 * workers/Worker.h: Ditto.
6273 * workers/WorkerContext.cpp:
6274 (WebCore::WorkerContext::importScripts): Ditto.
6275 * workers/WorkerScriptLoader.cpp:
6276 (WebCore::WorkerScriptLoader::~WorkerScriptLoader): Created to
6277 allow removing some header includes in WorkerScriptLoader.h.
6278 (WebCore::WorkerScriptLoader::loadAsynchronously): Fix the ordering
6279 of setPendingActivity and keep WorkerScriptLoader alive during a
6280 potential callback.
6281 * workers/WorkerScriptLoader.h: Made this RefCounted to allow for
6282 keeping it alive during callbacks. Also, removed unnecessary header
6283 inclusions (and added a destructor to facilitate that).
6284 (WebCore::WorkerScriptLoader::create):
6285
6286 2011-06-10 Alok Priyadarshi <alokp@chromium.org>
6287
6288 Reviewed by James Robinson.
6289
6290 [chromium] Top portion of page is rendered messed up with accelerated dr awing
6291 https://bugs.webkit.org/show_bug.cgi?id=62484
6292
6293 Fixed the math in flipping the texture from bottom-up to top-down.
6294 Test: compositing/repaint/shrink-layer.html (existing)
6295
6296 * platform/graphics/chromium/LayerTilerChromium.cpp:
6297 (WebCore::LayerTilerChromium::draw):
6298
6299 2011-06-10 Tony Chang <tony@chromium.org>
6300
6301 Reviewed by Ojan Vafai.
6302
6303 add a compile guard ENABLE(FLEXBOX)
6304 https://bugs.webkit.org/show_bug.cgi?id=62049
6305
6306 * Configurations/FeatureDefines.xcconfig:
6307
6308 2011-06-10 Sam Weinig <sam@webkit.org>
6309
6310 Roll out r88568. It is not the right fix for the problem.
6311
6312 * loader/appcache/ApplicationCacheHost.cpp:
6313 (WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
6314
6315 2011-06-10 Mark Rowe <mrowe@apple.com>
6316
6317 Reviewed by Dimitri Glazkov.
6318
6319 <rdar://problem/9562114> Fix DumpRenderTree build for production configu ration.
6320
6321 Rename the built WebCoreTestSupport dylib to libWebCoreTestSupport.dylib so
6322 that it can be found via the library search path rather than requiring a n
6323 absolute path be passed to the linker.
6324
6325 Install the library and its associated header file in a more appropriate location
6326 for the production configuration.
6327
6328 * Configurations/WebCoreTestSupport.xcconfig:
6329
6330 2011-06-10 Simon Fraser <simon.fraser@apple.com>
6331
6332 Reviewed by Dave Hyatt.
6333
6334 Add a scheduleSetNeedsStyleRecalc() method to ContainerNode for use by R enderLayerCompositor
6335 https://bugs.webkit.org/show_bug.cgi?id=62471
6336
6337 RenderLayerCompositor had some code that did a setNeedsStyleRecalc(), bu t
6338 in a way that was safe to call during existing style recalc or layout.
6339
6340 Move this code to ContainerElement so it can be called elsewhere.
6341 Also add a param to the node callback so we can pass the style change ty pe.
6342
6343 * dom/ContainerNode.cpp:
6344 (WebCore::ContainerNode::queuePostAttachCallback):
6345 (WebCore::ContainerNode::dispatchPostAttachCallbacks):
6346 (WebCore::needsStyleRecalcCallback):
6347 (WebCore::ContainerNode::scheduleSetNeedsStyleRecalc):
6348 * dom/ContainerNode.h:
6349 * dom/Node.h:
6350 (WebCore::Node::scheduleSetNeedsStyleRecalc):
6351 * html/HTMLFormControlElement.cpp:
6352 (WebCore::focusPostAttach):
6353 (WebCore::updateFromElementCallback):
6354 * html/HTMLPlugInImageElement.cpp:
6355 (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
6356 * html/HTMLPlugInImageElement.h:
6357 * rendering/RenderLayerCompositor.cpp:
6358 (WebCore::RenderLayerCompositor::attachRootPlatformLayer):
6359 (WebCore::RenderLayerCompositor::detachRootPlatformLayer):
6360 (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
6361 * rendering/RenderLayerCompositor.h:
6362 * svg/SVGUseElement.cpp:
6363 (WebCore::updateFromElementCallback):
6364
6365 2011-06-10 Mark Pilgrim <pilgrim@chromium.org>
6366
6367 Reviewed by Tony Chang.
6368
6369 IndexedDB: indexedDB.open() name argument is required
6370 https://bugs.webkit.org/show_bug.cgi?id=62398
6371
6372 Test: storage/indexeddb/database-name-undefined.html
6373
6374 * storage/IDBFactory.idl: use appropriate IDL magic to force undefined v alues to null, so we handle missing arguments as well as null arguments
6375
6376 2011-06-10 Sam Weinig <sam@webkit.org>
6377
6378 Reviewed by Beth Dakin.
6379
6380 Common crash in ApplicationCacheHost::isApplicationCacheEnabled
6381 <rdar://problem/9328684>
6382
6383 * loader/appcache/ApplicationCacheHost.cpp:
6384 (WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
6385 Speculative fix for a null frame on ApplicationCacheHost's DocumentLoade r.
6386
6387 2011-06-10 Adam Barth <abarth@webkit.org>
6388
6389 Reviewed by Eric Seidel.
6390
6391 Remove Document::finishParsing
6392 https://bugs.webkit.org/show_bug.cgi?id=62474
6393
6394 This function appears to exist only to confuse and befuddle us. This
6395 patch prepares for DocumentWriter to grab hold of the parser.
6396
6397 This patch removes one of the print statements from
6398 INSTRUMENT_LAYOUT_SCHEDULING, but I'm not sure
6399 INSTRUMENT_LAYOUT_SCHEDULING works anymore anyway.
6400
6401 * dom/Document.cpp:
6402 * dom/Document.h:
6403 * dom/XMLDocumentParser.cpp:
6404 (WebCore::XMLDocumentParser::finish):
6405 * html/parser/HTMLDocumentParser.cpp:
6406 (WebCore::HTMLDocumentParser::finish):
6407 * loader/DocumentWriter.cpp:
6408 (WebCore::DocumentWriter::addData):
6409 (WebCore::DocumentWriter::endIfNotLoadingMainResource):
6410 * loader/FrameLoader.cpp:
6411 (WebCore::FrameLoader::stop):
6412
6413 2011-06-10 Mark Pilgrim <pilgrim@chromium.org>
6414
6415 Reviewed by Tony Chang.
6416
6417 IndexedDB: setVersion() version argument is required
6418 https://bugs.webkit.org/show_bug.cgi?id=62401
6419
6420 Test: storage/indexeddb/setVersion-undefined.html
6421
6422 * storage/IDBDatabase.cpp:
6423 (WebCore::IDBDatabase::setVersion): check for null version
6424 * storage/IDBDatabase.idl: add IDL magic to force undefined to null so w e can handle both missing and null arguments
6425
6426 2011-06-10 Simon Fraser <simon.fraser@apple.com>
6427
6428 Reviewed by Dan Bernstein.
6429
6430 Null-check the layer owner again when painting layers
6431 https://bugs.webkit.org/show_bug.cgi?id=62473
6432
6433 Speculative fix for a crash that occurs when the layer's owner
6434 gets destroyed during painting.
6435
6436 * platform/graphics/mac/WebLayer.mm:
6437 (drawLayerContents):
6438
6439 2011-06-08 Robert Hogan <robert@webkit.org>
6440
6441 Reviewed by Andreas Kling.
6442
6443 [Qt] Lighten the --no-svg build a little
6444 https://bugs.webkit.org/show_bug.cgi?id=62314
6445
6446 Only generate source from SVG*.idl if the build is svg-enabled.
6447
6448 * CodeGenerators.pri:
6449
6450 2011-06-10 Nikolas Zimmermann <nzimmermann@rim.com>
6451
6452 Reviewed by Rob Buis.
6453
6454 Integrate SVG Fonts within GlyphPage concept, removing the special SVG c ode paths from Font, making it possible to reuse the simple text code path for S VG Fonts
6455 https://bugs.webkit.org/show_bug.cgi?id=59085
6456
6457 Add glyph table to SVGFontElement mapping between SVGGlyph <-> Glyph
6458 https://bugs.webkit.org/show_bug.cgi?id=62441
6459
6460 Preparation patch 1: Introduce the internal glyph table in SVGGlyphMap t hat will be used to identify each
6461 SVGGlyph identifier with a Glyph (which is just an ushort). It will be u sed by follow-up patches.
6462
6463 Doesn't affect any test so far.
6464
6465 * platform/graphics/SVGGlyph.h:
6466 (WebCore::SVGGlyph::SVGGlyph):
6467 (WebCore::SVGGlyph::operator==):
6468 * rendering/svg/SVGTextRunRenderingContext.cpp:
6469 (WebCore::SVGTextRunWalker::walk):
6470 * svg/SVGFontData.cpp:
6471 (WebCore::SVGFontData::initializeFontData):
6472 * svg/SVGFontElement.cpp:
6473 (WebCore::SVGFontElement::SVGFontElement):
6474 (WebCore::SVGFontElement::registerLigaturesInGlyphCache):
6475 (WebCore::SVGFontElement::ensureGlyphCache):
6476 (WebCore::kerningForPairOfStringsAndGlyphs):
6477 (WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs):
6478 (WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):
6479 (WebCore::SVGFontElement::collectGlyphsForString):
6480 (WebCore::SVGFontElement::collectGlyphsForGlyphName):
6481 (WebCore::SVGFontElement::svgGlyphForGlyph):
6482 (WebCore::SVGFontElement::missingGlyph):
6483 * svg/SVGFontElement.h:
6484 (WebCore::SVGKerningPair::SVGKerningPair):
6485 * svg/SVGGlyphMap.h:
6486 (WebCore::SVGGlyphMap::addGlyphByUnicodeString):
6487 (WebCore::SVGGlyphMap::addGlyphByName):
6488 (WebCore::SVGGlyphMap::appendToGlyphTable):
6489 (WebCore::SVGGlyphMap::collectGlyphsForString):
6490 (WebCore::SVGGlyphMap::clear):
6491 (WebCore::SVGGlyphMap::svgGlyphForGlyph):
6492 (WebCore::SVGGlyphMap::glyphIdentifierForGlyphName):
6493
6494 2011-06-10 Emil A Eklund <eae@chromium.org>
6495
6496 Reviewed by Eric Seidel.
6497
6498 Regression r85573: Blank pages appear at the end of some wikipedia docum ents.
6499 https://bugs.webkit.org/show_bug.cgi?id=62343
6500
6501 Fix regression caused by r85573. Cached document size not updated after layout.
6502
6503 Test: printing/page-count-relayout-shrink.html
6504
6505 * page/FrameView.cpp:
6506 (WebCore::FrameView::forceLayoutForPagination):
6507
6508 2011-06-10 Rob Buis <rbuis@rim.com>
6509
6510 Reviewed by Nikolas Zimmermann.
6511
6512 amation event handling broken: focusin
6513 https://bugs.webkit.org/show_bug.cgi?id=12894
6514
6515 focusin, focusout, activate not implemented in SVG
6516 https://bugs.webkit.org/show_bug.cgi?id=40545
6517
6518 Make elements that should support GraphicalEventAttribute handle focussi ng, since focusin, focusout is part of that:
6519
6520 http://www.w3.org/TR/SVG11/intro.html#TermGraphicalEventAttribute
6521
6522 Match Opera behaviour ; elements that support GraphicalEventAttribute ca n receive visual mouse focus when having either a focusin or focusout event hand ler. Elements that support GraphicalEventAttribute can receive visual keyboard f ocus when having either a focusin or focusout event handler. Keyboard focus does not advance to SVG elements that are not focusable at the time.
6523
6524 Tests: svg/custom/focus-event-handling-keyboard.xhtml
6525 svg/custom/focus-event-handling.xhtml
6526
6527 * rendering/svg/SVGRenderSupport.cpp:
6528 (WebCore::SVGRenderSupport::computeRectForRepaint):
6529 * svg/SVGCircleElement.h:
6530 (WebCore::SVGCircleElement::supportsFocus):
6531 * svg/SVGEllipseElement.h:
6532 (WebCore::SVGEllipseElement::supportsFocus):
6533 * svg/SVGGElement.h:
6534 (WebCore::SVGGElement::supportsFocus):
6535 * svg/SVGImageElement.h:
6536 (WebCore::SVGImageElement::supportsFocus):
6537 * svg/SVGLineElement.h:
6538 (WebCore::SVGLineElement::supportsFocus):
6539 * svg/SVGPathElement.h:
6540 (WebCore::SVGPathElement::supportsFocus):
6541 * svg/SVGPolyElement.h:
6542 (WebCore::SVGPolyElement::supportsFocus):
6543 * svg/SVGRectElement.h:
6544 (WebCore::SVGRectElement::supportsFocus):
6545 * svg/SVGSVGElement.h:
6546 (WebCore::SVGSVGElement::supportsFocus):
6547 * svg/SVGStyledElement.cpp:
6548 (WebCore::SVGStyledElement::isMouseFocusable):
6549 (WebCore::SVGStyledElement::isKeyboardFocusable):
6550 * svg/SVGStyledElement.h:
6551 * svg/SVGSwitchElement.h:
6552 (WebCore::SVGSwitchElement::supportsFocus):
6553 * svg/SVGSymbolElement.h:
6554 (WebCore::SVGSymbolElement::supportsFocus):
6555 * svg/SVGTextElement.h:
6556 (WebCore::SVGTextElement::supportsFocus):
6557 * svg/SVGUseElement.h:
6558 (WebCore::SVGUseElement::supportsFocus):
6559
6560 2011-06-10 Luke Macpherson <macpherson@chromium.org>
6561
6562 Reviewed by Eric Seidel.
6563
6564 Clean up CSSPrimitiveValue::computeLength*
6565 https://bugs.webkit.org/show_bug.cgi?id=61612
6566
6567 No new tests as no functionality changed.
6568
6569 * css/CSSGradientValue.cpp:
6570 Use new computeLength functions.
6571 * css/CSSPrimitiveValue.cpp:
6572 (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
6573 Reduce to a single function using default parameter values.
6574 (WebCore::CSSPrimitiveValue::computeLength):
6575 Redefine existing functions with separate names as a single function usi ng templated function specialization.
6576 * css/CSSPrimitiveValue.h:
6577 Prototypes for computeLengthIntForLength and computeLength.
6578 * css/CSSStyleApplyProperty.cpp:
6579 Use new computeLength functions.
6580 * css/CSSStyleSelector.cpp:
6581 Use new computeLength functions.
6582 * css/MediaQueryEvaluator.cpp:
6583 Use new computeLength functions.
6584 * css/SVGCSSStyleSelector.cpp:
6585 Use new computeLength functions.
6586
6587 2011-06-10 Simon Fraser <simon.fraser@apple.com>
6588
6589 Reviewed by Beth Dakin.
6590
6591 Add utility to RenderLayer to determine if the layer is scrollable
6592 https://bugs.webkit.org/show_bug.cgi?id=62467
6593
6594 New method that returns true if either scrollbar is present and enabled.
6595 Not called anywhere yet.
6596
6597 * rendering/RenderLayer.cpp:
6598 (WebCore::RenderLayer::allowsScrolling):
6599 * rendering/RenderLayer.h:
6600
6601 2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
6602
6603 Reviewed by Tony Chang.
6604
6605 REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enume rate spellCheckRanges
6606 https://bugs.webkit.org/show_bug.cgi?id=62460
6607
6608 Test: fast/dom/prototype-inheritance-2.html
6609
6610 * dom/DocumentMarkerController.cpp:
6611 (WebCore::DocumentMarkerController::userSpellingMarkersForNode): Added a n extra 0-check.
6612
6613 2011-06-10 James Simonsen <simonjam@chromium.org>
6614
6615 Reviewed by Tony Gentilcore.
6616
6617 Don't execute scripts in shadow SVG.
6618 https://bugs.webkit.org/show_bug.cgi?id=62225
6619
6620 Test: svg/dom/use-style-recalc-script-execute-crash.html
6621
6622 * dom/ScriptElement.cpp:
6623 (WebCore::ScriptElement::prepareScript):
6624
6625 2011-06-10 Konstantin Tokarev <ktokarev@smartlabs.tv>
6626
6627 Reviewed by Joseph Pecoraro.
6628
6629 Fixed build with enabled workers and disabled inspector
6630 https://bugs.webkit.org/show_bug.cgi?id=62461
6631
6632 * inspector/InspectorWorkerAgent.cpp: Added inspector guard
6633
6634 2011-06-10 Darin Adler <darin@apple.com>
6635
6636 Reviewed by Eric Carlson.
6637
6638 REGRESSION: Fullscreen video controller can't be dragged
6639 https://bugs.webkit.org/show_bug.cgi?id=62462
6640
6641 No regression test because we don't have machinery for testing the fulls creen
6642 mode. We may find a way to add this in the future.
6643
6644 * html/shadow/MediaControlElements.cpp:
6645 (WebCore::MediaControlPanelElement::MediaControlPanelElement): Initializ e new
6646 booleans related to dragging.
6647 (WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dr agging
6648 is allowed and a drag isn't already in progress.
6649 (WebCore::MediaControlPanelElement::continueDrag): Added. Moves the wind ow if
6650 dragging is already in progress.
6651 (WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture th at is
6652 done during the dragging process.
6653 (WebCore::MediaControlPanelElement::setPosition): Added. Positions the p anel
6654 using explicit top/left.
6655 (WebCore::MediaControlPanelElement::resetPosition): Added. Removes the p ositioning
6656 done by setPosition.
6657 (WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls s tartDrag,
6658 continueDrag, and endDrag in response to mouse events.
6659 (WebCore::MediaControlPanelElement::setCanBeDragged): Added.
6660 * html/shadow/MediaControlElements.h: Added new function and data member s
6661 as mentioned above.
6662
6663 * html/shadow/MediaControlRootElement.cpp:
6664 (WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDrag ged(true)
6665 so you can drag the panel while in fullscreen.
6666 (WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragg ed(false)
6667 so you can't drag the panel while not in fullscreen. Also call resetPosi tion so
6668 position changes from dragging don't affect the panel in other contexts.
6669
6670 2011-06-10 Darin Adler <darin@apple.com>
6671
6672 Reviewed by Eric Carlson.
6673
6674 REGRESSION: Full screen video HUD is positioned too low for standalone v ideo documents
6675 https://bugs.webkit.org/show_bug.cgi?id=62463
6676
6677 No test because we don't currently have machinery for testing fullscreen .
6678
6679 * css/fullscreen.css: Removed rule that said bottom: 0px for the control panel
6680 for full page media in full screen mode. This is not needed because the control
6681 panel for full screen mode already has style rules to set its vertical p osition.
6682 (:-webkit-full-screen-ancestor:not(iframe)): Fixed typo where it said
6683 -webkit-tranform. This will fix a potential problem where fullscreen wou ld
6684 malfunction on a page that had a media element inside a transform.
6685
6686 2011-06-10 Sergio Villar Senin <svillar@igalia.com>
6687
6688 Reviewed by Gustavo Noronha Silva.
6689
6690 [GTK] Add support for non-ASCII filenames in Content-Disposition header
6691 https://bugs.webkit.org/show_bug.cgi?id=62454
6692
6693 Try latin1 as fallback for header parameter values as some servers
6694 do not follow RFC 2045 for example with filename parameter in
6695 Content-Disposition.
6696
6697 No new tests required as no functionality changed.
6698
6699 * platform/network/soup/ResourceResponseSoup.cpp:
6700 (WebCore::ResourceResponse::updateFromSoupMessage):
6701
6702 2011-06-10 No'am Rosenthal <noam.rosenthal@nokia.com> and Viatcheslav Ostapenk o <ostapenko.viatcheslav@nokia.com>
6703
6704 Reviewed by Kenneth Rohde Christiansen.
6705
6706 Add layer factory to GraphicsLayer for creating non-default layer type.
6707 https://bugs.webkit.org/show_bug.cgi?id=61925
6708
6709 Added a static factory protected member to GraphicsLayer, which should b e accessed from
6710 a port-specific implementation of GraphicsLayer::create. For now this is enabled for Qt only.
6711
6712 This is needed for accelerated compositing across processes in WebKit2, since WebCore
6713 doesn't know in compile time whether it's in WebKit or WebKit2, which ma kes having two
6714 different implementations of GraphicsLayer coexist impossible without so me runtime
6715 factory that can be overridden by the web process.
6716
6717 Note that the use of the factory would be optional, and the port-specifi c GraphicsLayer::create
6718 would have to explicitly call it, in order to be unintrusive with curren t implementations.
6719
6720 No new functionality, so no new tests.
6721
6722 * platform/graphics/GraphicsLayer.cpp:
6723 (WebCore::GraphicsLayer::setGraphicsLayerFactory):
6724 * platform/graphics/GraphicsLayer.h:
6725
6726 2011-06-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>
6727
6728 Reviewed by Kenneth Rohde Christiansen.
6729
6730 [CMAKE] Add generic support for building with WebGL
6731 https://bugs.webkit.org/show_bug.cgi?id=62376
6732
6733 Set new THIRDPARTY_DIR variable to compile sources under ThirdParty.
6734
6735 No change in functionality so no new tests.
6736
6737 * CMakeLists.txt:
6738
6739 2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>
6740
6741 Reviewed by Andreas Kling.
6742
6743 [GTK][EFL] m_imageInterpolationQuality is not initialized in PlatformCon textCairo::PlatformContextCairo.
6744 https://bugs.webkit.org/show_bug.cgi?id=62435
6745
6746 No new tests required as just fixed warning.
6747
6748 * platform/graphics/cairo/PlatformContextCairo.cpp:
6749 (WebCore::PlatformContextCairo::PlatformContextCairo):
6750
6751 2011-06-11-06-09 Ilya Tikhonovsky <loislo@chromium.org>
6752
6753 Reviewed by Yury Semikhatsky.
6754
6755 Web Inspector: protocol: json: Whitespace can be inserted between any pa ir of tokens.
6756 https://bugs.webkit.org/show_bug.cgi?id=62377
6757
6758 * inspector/InspectorValues.cpp:
6759
6760 2011-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
6761
6762 Unreviewed, rolling out r88530.
6763 http://trac.webkit.org/changeset/88530
6764 https://bugs.webkit.org/show_bug.cgi?id=62440
6765
6766 qt build was broken (Requested by loislo on #webkit).
6767
6768 * inspector/InspectorValues.cpp:
6769
6770 2011-06-09 Ilya Tikhonovsky <loislo@chromium.org>
6771
6772 Reviewed by Yury Semikhatsky.
6773
6774 Web Inspector: protocol: json: Whitespace can be inserted between any pa ir of tokens.
6775 https://bugs.webkit.org/show_bug.cgi?id=62377
6776
6777 * inspector/InspectorValues.cpp:
6778
6779 2011-06-09 Jer Noble <jer.noble@apple.com>
6780
6781 Reviewed by Darin Adler.
6782
6783 REGRESSION: Vertical scroll bar appears when taking videos into full scr een at jerryseinfeld.com
6784 https://bugs.webkit.org/show_bug.cgi?id=62402
6785
6786 Sites are able to override the "overflow:hidden" rule for root full-scre en nodes
6787 simply by adding a "html {}" rule. Make this rule !important, and also make it apply
6788 to root nodes who are merely ancestors of full-screen elements, to cover the case of
6789 a root node containing an <iframe> whose contents have gone full-screen.
6790
6791 * css/fullscreen.css:
6792 (:root:-webkit-full-screen-document:not(:-webkit-full-screen),
6793 :root:-webkit-full-screen-ancestor): Apply the overflow rule to root elements
6794 who are full-screen ancestors, and make them !important.
6795
6796 2011-06-09 Luke Macpherson <macpherson@chromium.org>
6797
6798 Reviewed by Eric Seidel.
6799
6800 Rename RenderStyle visuallyOrdered property and use an enum instead of a bool.
6801 https://bugs.webkit.org/show_bug.cgi?id=61495
6802
6803 No new tests required as no functionality changed.
6804
6805 * css/CSSPrimitiveValueMappings.h:
6806 Support cast to/from Order
6807 * css/CSSStyleSelector.cpp:
6808 (WebCore::CSSStyleSelector::styleForDocument):
6809 Convert from bool to enum type.
6810 (WebCore::CSSStyleSelector::applyProperty):
6811 Convert to macro that uses the cast defined in CSSPrimitiveValueMappings .
6812 * dom/Document.cpp:
6813 (WebCore::Document::setVisuallyOrdered):
6814 Change call to RenderStyle::setRTLOrdering using enum parameter.
6815 * rendering/style/RenderStyle.h:
6816 rename visuallyOrdered proerties rtlOrdering and use appropriate enum ty pes.
6817 * rendering/style/RenderStyleConstants.h:
6818 Define enum type.
6819
6820 2011-06-09 Luke Macpherson <macpherson@chromium.org>
6821
6822 Reviewed by Eric Seidel.
6823
6824 Implement CSSPropertyOutlineStyle handler in CSSStyleApplyProperty
6825 https://bugs.webkit.org/show_bug.cgi?id=61601
6826
6827 No new tests. No new functionality added / covered by existing tests.
6828
6829 * css/CSSPrimitiveValueMappings.h:
6830 (WebCore::CSSPrimitiveValue::operator EBorderStyle):
6831 Support CSSValueAuto as required by outline-style property.
6832 (WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
6833 Add cast to new OutlineIsAuto enum.
6834 * css/CSSStyleApplyProperty.cpp:
6835 (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
6836 Initialize handler for CSSPropertyOutlineStyle.
6837 * css/CSSStyleSelector.cpp:
6838 (WebCore::CSSStyleSelector::applyProperty):
6839 Remove old handler for CSSPropertyOutlineStyle.
6840 * rendering/style/OutlineValue.h:
6841 Use new OutlineIsAuto enum instead of bool.
6842 * rendering/style/RenderStyle.h:
6843 Split existing two-parameter setter setOutlineStyle into separate setter s for style and auto properties.
6844 Use new OutlineIsAuto enum type.
6845 * rendering/style/RenderStyleConstants.h:
6846 Define new enum OutlineIsAuto.
6847
6848 2011-06-09 Luke Macpherson <macpherson@chromium.org>
6849
6850 Reviewed by Eric Seidel.
6851
6852 Code cleanup - add wrappers for function pointer dereferences to improve readability in ApplyPropertyDefaultBase and derived classes.
6853 https://bugs.webkit.org/show_bug.cgi?id=62418
6854
6855 No new tests / cleanup only.
6856
6857 * css/CSSStyleApplyProperty.cpp:
6858 (WebCore::ApplyPropertyDefaultBase::applyInheritValue):
6859 Use new wrapper functions.
6860 (WebCore::ApplyPropertyDefaultBase::applyInitialValue):
6861 Use new wrapper functions.
6862 (WebCore::ApplyPropertyDefaultBase::setValue):
6863 Wrapper for calling m_setter function pointer.
6864 (WebCore::ApplyPropertyDefaultBase::value):
6865 Wrapper for calling m_getter function pointer.
6866 (WebCore::ApplyPropertyDefaultBase::initial):
6867 Wrapper for calling m_initial function pointer.
6868 (WebCore::ApplyPropertyDefault::applyValue):
6869 Use new setValue function.
6870 (WebCore::ApplyPropertyLength::applyValue):
6871 Use new setValue function.
6872 (WebCore::ApplyPropertyWidth::applyValue):
6873 Use new setValue function.
6874
6875 2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>
6876
6877 Reviewed by Antonio Gomes.
6878
6879 [EFL] Make accelerated compositing build in Webkit-EFL
6880 https://bugs.webkit.org/show_bug.cgi?id=62361
6881
6882 Add a new class, GraphicsLayerEfl - not yet implemented.
6883 Add ACCELERATED_COMPOSITING related files to CMakeLists.
6884
6885 * CMakeLists.txt:
6886 * CMakeListsEfl.txt:
6887 * platform/graphics/efl/GraphicsLayerEfl.cpp: Added.
6888 (WebCore::GraphicsLayer::create):
6889 (WebCore::GraphicsLayerEfl::GraphicsLayerEfl):
6890 (WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):
6891 (WebCore::GraphicsLayerEfl::setNeedsDisplay):
6892 (WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):
6893 * platform/graphics/efl/GraphicsLayerEfl.h: Added.
6894
6895 2011-06-09 Jian Li <jianli@chromium.org>
6896
6897 Reviewed by David Levin.
6898
6899 Calling WebKitBlobBuilder.append with null argument should not crash
6900 https://bugs.webkit.org/show_bug.cgi?id=62419
6901
6902 Test: fast/files/blob-builder-crash.html
6903
6904 * fileapi/WebKitBlobBuilder.cpp:
6905 (WebCore::WebKitBlobBuilder::append):
6906
6907 2011-06-09 Jer Noble <jer.noble@apple.com>
6908
6909 Reviewed by David Hyatt.
6910
6911 Roll out r88468, and fix bug #61911 without making Element::offset funct ions virtual.
6912 https://bugs.webkit.org/show_bug.cgi?id=62400
6913
6914 No new tests; covered by existing fullscreen/full-screen-video-offset.ht ml test.
6915
6916 * rendering/RenderVideo.cpp:
6917 (WebCore::rendererPlaceholder): Added; returns the placeholder block, if it exists.
6918 (WebCore::RenderVideo::offsetLeft): Pass the offset request to the place holder block.
6919 (WebCore::RenderVideo::offsetTop): Ditto.
6920 (WebCore::RenderVideo::offsetWidth): Ditto.
6921 (WebCore::RenderVideo::offsetHeight): Ditto.
6922 * rendering/RenderVideo.h: Added virtual overrides for the offset functi ons.
6923
6924 2011-06-09 James Robinson <jamesr@chromium.org>
6925
6926 Reviewed by Kenneth Russell.
6927
6928 [chromium] Scissor rect not set for clipping layers set offscreen
6929 https://bugs.webkit.org/show_bug.cgi?id=62339
6930
6931 We set a scissorRect on each layer, but only layers with masksToBounds a nd their descendants should actually set
6932 a scissor. Layers that didn't need to scissor had empty scissorRects. Unfortunately layers with masksToBounds
6933 and their descendants that are scrolled offscreen also end up with an em pty clipped scissor rect.
6934
6935 This patch sets an explicit bit on each layer that should scissor and th en checks that bit instead of checking
6936 for an empty scissor rect at draw time. RenderSurfaceChromiums have dif ferent requirements for
6937 setScissorToRect, so the old behavior is still available with a flag. T his can probably be cleaned up more.
6938
6939 Test: platform/chromium/compositing/scissor-out-of-viewport.html
6940
6941 * platform/graphics/chromium/LayerRendererChromium.cpp:
6942 (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
6943 (WebCore::LayerRendererChromium::drawLayer):
6944 (WebCore::LayerRendererChromium::setScissorToRect):
6945 * platform/graphics/chromium/LayerRendererChromium.h:
6946 * platform/graphics/chromium/RenderSurfaceChromium.cpp:
6947 (WebCore::RenderSurfaceChromium::draw):
6948 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
6949 (WebCore::CCLayerImpl::CCLayerImpl):
6950 * platform/graphics/chromium/cc/CCLayerImpl.h:
6951 (WebCore::CCLayerImpl::setUsesLayerScissor):
6952 (WebCore::CCLayerImpl::usesLayerScissor):
6953
6954 2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
6955
6956 Unreviewed, rolling out r88468.
6957 http://trac.webkit.org/changeset/88468
6958 https://bugs.webkit.org/show_bug.cgi?id=62408
6959
6960 It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
6961 on #webkit).
6962
6963 * dom/Element.cpp:
6964 (WebCore::adjustForLocalZoom):
6965 * dom/Element.h:
6966 * html/HTMLMediaElement.cpp:
6967 * html/HTMLMediaElement.h:
6968
6969 2011-06-09 Kenneth Russell <kbr@google.com>
6970
6971 Reviewed by Adam Barth.
6972
6973 Disallow use of cross-domain media (images, video) in WebGL
6974 https://bugs.webkit.org/show_bug.cgi?id=62257
6975
6976 Updated WebGL implementation to track recent spec updates in this area.
6977
6978 Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-c redentials.html
6979 http/tests/security/webgl-remote-read-remote-image-allowed.html
6980 http/tests/security/webgl-remote-read-remote-image-blocked-no-cro ssorigin.html
6981
6982 * html/canvas/CanvasRenderingContext.cpp:
6983 (WebCore::CanvasRenderingContext::wouldTaintOrigin):
6984 (WebCore::CanvasRenderingContext::checkOrigin):
6985 * html/canvas/CanvasRenderingContext.h:
6986 (WebCore::CanvasRenderingContext::checkOrigin):
6987 * html/canvas/WebGLRenderingContext.cpp:
6988 (WebCore::WebGLRenderingContext::readPixels):
6989 (WebCore::WebGLRenderingContext::texImage2D):
6990 (WebCore::WebGLRenderingContext::videoFrameToImage):
6991 (WebCore::WebGLRenderingContext::texSubImage2D):
6992 * html/canvas/WebGLRenderingContext.h:
6993
6994 2011-06-09 Adam Barth <abarth@webkit.org>
6995
6996 Reviewed by Eric Seidel.
6997
6998 Add an ASSERT to HTMLTreeBuilder
6999 https://bugs.webkit.org/show_bug.cgi?id=62403
7000
7001 This ASSERT was useful in investigating a re-entrancy bug. We should
7002 keep it.
7003
7004 * html/parser/HTMLTreeBuilder.cpp:
7005 (WebCore::HTMLTreeBuilder::processEndOfFile):
7006
7007 2011-06-09 Dan Bernstein <mitz@apple.com>
7008
7009 Reviewed by Darin Adler.
7010
7011 Fix a regression from r88478.
7012
7013 * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
7014 (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCore Text): Add the runs
7015 in reverse order in the RTL case here, since the whole vector is reverse d by collectComplexTextRuns()
7016 afterwards.
7017
7018 2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
7019
7020 Reviewed by Antti Koivisto.
7021
7022 REGRESSION(84329): Stylesheets on some pages do not load
7023 https://bugs.webkit.org/show_bug.cgi?id=61400
7024
7025 Test: fast/css/link-disabled-attr.html
7026
7027 Fixed r84329: the change did not take into account the fact
7028 that HTMLLinkElement did already contain the disabled information
7029 and the 2 information were not linked as they should have!
7030
7031 The new logic pushes the information to the stylesheet as this
7032 is what the spec mandates and what FF is doing. Also it keeps
7033 one bit of information (that JS enabled the stylesheet) as it
7034 is needed for the recalcStyleSelector logic.
7035
7036 * dom/Document.cpp:
7037 (WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.
7038
7039 * html/HTMLLinkElement.cpp:
7040 (WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState,
7041 replaced by m_isEnabledViaScript.
7042 (WebCore::HTMLLinkElement::setDisabled): Updated the logic after
7043 m_disabledState removal. It also matches the spec by forwarding
7044 the disabled state to our stylesheet if we have one.
7045 (WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful
7046 handling of the disabledAttr.
7047 (WebCore::HTMLLinkElement::process): Updated after m_disabledState remov al.
7048 * html/HTMLLinkElement.h:
7049 (WebCore::HTMLLinkElement::isEnabledViaScript): Ditto.
7050 (WebCore::HTMLLinkElement::isAlternate): Ditto.
7051
7052 2011-06-09 Dan Bernstein <mitz@apple.com>
7053
7054 Reviewed by Darin Adler.
7055
7056 Simplify ComplexTextController::collectComplexTextRuns()
7057 https://bugs.webkit.org/show_bug.cgi?id=62387
7058
7059 No new test, since functionality is unchanged.
7060
7061 * platform/graphics/mac/ComplexTextController.cpp:
7062 (WebCore::ComplexTextController::collectComplexTextRuns): Always iterate characters in logical order,
7063 then reverse the run vector for RTL.
7064
7065 2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>
7066
7067 Reviewed by Kent Tamura.
7068
7069 Fold isShadowBoundary into isShadowRoot.
7070 https://bugs.webkit.org/show_bug.cgi?id=62317
7071
7072 Since there are no longer cases where Node::isShadowBoundary() != Node:: isShadowRoot, we can remove this function.
7073
7074 In one case where isShadowBoundary was also tested to find ShadowContent Elemnt, added a new isContentElement function.
7075
7076 Refactoring, covered by existing tests.
7077
7078 * css/CSSStyleSelector.cpp:
7079 (WebCore::isAtShadowBoundary): Changed to use isShadowRoot.
7080 * dom/Element.cpp:
7081 (WebCore::Element::isSpellCheckingEnabled): Ditto.
7082 * dom/Node.cpp:
7083 (WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
7084 (WebCore::Node::nonShadowBoundaryParentNode): Ditto.
7085 * dom/Node.h:
7086 (WebCore::Node::isContentElement): Added.
7087 * dom/NodeRenderingContext.cpp:
7088 (WebCore::NodeRenderingContext::NodeRenderingContext): Changed to use is ShadowRoot.
7089 * dom/Position.cpp:
7090 (WebCore::Position::Position): Ditto.
7091 * dom/ShadowContentElement.h:
7092 (WebCore::ShadowContentElement::isContentElement): Added.
7093 * dom/ShadowRoot.cpp:
7094 (WebCore::ShadowRoot::hasContentElement): Changed to use isContentElemen t.
7095 * editing/CompositeEditCommand.cpp:
7096 (WebCore::CompositeEditCommand::insertNodeAfter): Changed to use isShado wRoot.
7097 * editing/htmlediting.cpp:
7098 (WebCore::visiblePositionBeforeNode): Ditto.
7099 (WebCore::visiblePositionAfterNode): Ditto.
7100 * page/DragController.cpp:
7101 (WebCore::asFileInput): Ditto.
7102 * rendering/RenderTreeAsText.cpp:
7103 (WebCore::nodePosition): Ditto.
7104
7105 2011-06-09 Simon Fraser <simon.fraser@apple.com>
7106
7107 Reviewed by Darin Adler.
7108
7109 Crashes in RenderLayerBacking::paintingGoesToWindow
7110 https://bugs.webkit.org/show_bug.cgi?id=61159
7111
7112 Speculative fix for unreproducible crash that can occur when RenderObjec t::repaintUsingContainer()
7113 finds a repaintContainer that is not the RenderView, but that is also no t
7114 composited (for unknown reasons), by checking to see if the layer is
7115 compositing before using backing(). An assertion remains to try to catch
7116 this in debug builds.
7117
7118 * rendering/RenderLayer.cpp:
7119 (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
7120
7121 2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>
7122
7123 Reviewed by Darin Adler.
7124
7125 WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
7126 https://bugs.webkit.org/show_bug.cgi?id=62384
7127
7128 Test: fast/css/webkit-keyframes-crash.html
7129
7130 * css/WebKitCSSKeyframesRule.cpp:
7131 (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garant eed
7132 to return a non-null pointer. Thus null-check here like the rest of the code.
7133
7134 2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
7135
7136 Reviewed by David Hyatt.
7137
7138 chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
7139 https://bugs.webkit.org/show_bug.cgi?id=57756
7140
7141 Tests: fast/css/fontMetric-border-radius-null-crash.html
7142 fast/css/fontMetric-webkit-border-end-width-null-crash.html
7143
7144 * css/CSSStyleSelector.cpp:
7145 (WebCore::CSSStyleSelector::styleForElement): Added a call to Font::upda te
7146 so that our FontFallbackList is allocated if we ever need it when applyi ng our
7147 style rules.
7148
7149 2011-06-09 Cary Clark <caryclark@google.com>
7150
7151 Reviewed by Eric Seidel.
7152
7153 Create local CG context for Mac UI elements when Skia is renderer
7154 https://bugs.webkit.org/show_bug.cgi?id=62213
7155
7156 When building Mac Chrome using Skia as the WebKit renderer,
7157 add state to LocalCurrentGraphicsContext to convert the SkCanvas
7158 context passed by WebKit into the CGContext needed by UI
7159 rendering.
7160
7161 No new tests. The define typo in question is
7162 not yet enabled, so this change has no functional
7163 impact.
7164
7165 * platform/mac/LocalCurrentGraphicsContext.h:
7166 Add SkiaBitLocker to create and release the converted CGContext.
7167 Add ContextContainer, a class for Skia to create and release
7168 the converted CGContext. If Skia is not used, the class has no effect.
7169
7170 * platform/mac/LocalCurrentGraphicsContext.mm:
7171 (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
7172 When building with Skia, create the CGContext before passing it on.
7173
7174 (WebCore::LocalCurrentGraphicsContext::cgContext):
7175 Get the CGContext from the SkiaBitLocker, or the saved context,
7176 as appropriate.
7177
7178 * rendering/RenderThemeMac.mm:
7179 Get the CGContext from Skia conversion or native, as appropriate.
7180 Use the LocalCurrentGraphicsContext if there is one. Otherwise,
7181 add a ContextContainer to house the SkCanvas to CGContext conversion.
7182
7183 (WebCore::RenderThemeMac::paintCapsLockIndicator):
7184 (WebCore::RenderThemeMac::paintProgressBar):
7185 (WebCore::RenderThemeMac::paintMenuListButtonGradients):
7186 (WebCore::RenderThemeMac::paintSliderTrack):
7187 (WebCore::RenderThemeMac::paintMediaFullscreenButton):
7188 (WebCore::RenderThemeMac::paintMediaMuteButton):
7189 (WebCore::RenderThemeMac::paintMediaPlayButton):
7190 (WebCore::RenderThemeMac::paintMediaSeekBackButton):
7191 (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
7192 (WebCore::RenderThemeMac::paintMediaSliderTrack):
7193 (WebCore::RenderThemeMac::paintMediaSliderThumb):
7194 (WebCore::RenderThemeMac::paintMediaRewindButton):
7195 (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
7196 (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
7197 (WebCore::RenderThemeMac::paintMediaControlsBackground):
7198 (WebCore::RenderThemeMac::paintMediaCurrentTime):
7199 (WebCore::RenderThemeMac::paintMediaTimeRemaining):
7200 (WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
7201 (WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
7202 (WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
7203
7204 2011-06-02 Jer Noble <jer.noble@apple.com>
7205
7206 Reviewed by Maciej Stachowiak.
7207
7208 REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
7209 https://bugs.webkit.org/show_bug.cgi?id=61911
7210 <rdar://problem/9523017>
7211
7212 Test: fullscreen/full-screen-video-offset.html
7213
7214 When the video element is taken full-screen in the new element full-scre en API, return the
7215 offset width and height of the placeholder renderer which is filling in for the full-screen
7216 element. To do so, override offsetWidth, Height, Left, and Top from Ele ment. These are
7217 non-virtual functions, so make them virtual.
7218
7219 * dom/Element.cpp:
7220 (WebCore::Element::adjustForLocalZoom): Made into a class-static functio n.
7221 * dom/Element.h: Made offset functions virtual.
7222 * html/HTMLMediaElement.cpp:
7223 (WebCore::elementPlaceholder): Added; utility function.
7224 (WebCore::HTMLMediaElement::offsetLeft): Added; virtual override of the
7225 Element function. Will be called directly via javascript.
7226 (WebCore::HTMLMediaElement::offsetTop): Ditto.
7227 (WebCore::HTMLMediaElement::offsetWidth): Ditto.
7228 (WebCore::HTMLMediaElement::offsetHeight): Ditto.
7229 * html/HTMLMediaElement.h:
7230
7231 2011-06-09 Dave Tapuska <dtapuska@rim.com>
7232
7233 Reviewed by Daniel Bates.
7234
7235 PingLoader destructor could dereference 0 if the Resource
7236 Handle creation failed.
7237
7238 https://bugs.webkit.org/show_bug.cgi?id=62304
7239
7240 * loader/PingLoader.cpp:
7241 (WebCore::PingLoader::~PingLoader):
7242
7243 2011-06-08 Abhishek Arya <inferno@chromium.org>
7244
7245 Reviewed by Ryosuke Niwa.
7246
7247 Make indexForVisiblePosition and isSelectableElement static.
7248 https://bugs.webkit.org/show_bug.cgi?id=62329
7249
7250 This protects us when converting frame->selection->start() or end()
7251 to VisiblePosition which blows away the RenderTextControl from
7252 underneath (due to layout update).
7253
7254 Test: fast/forms/text-control-selection-crash.html
7255
7256 * accessibility/AccessibilityRenderObject.cpp:
7257 (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
7258 * rendering/RenderTextControl.cpp:
7259 (WebCore::RenderTextControl::selectionStart):
7260 (WebCore::RenderTextControl::selectionEnd):
7261 (WebCore::RenderTextControl::isSelectableElement):
7262 (WebCore::RenderTextControl::indexForVisiblePosition):
7263 * rendering/RenderTextControl.h:
7264
7265 2011-06-09 Ben Murdoch <benm@google.com>
7266
7267 Reviewed by Yury Semikhatsky.
7268
7269 Build break in ScriptProfile.cpp and inspector disabled.
7270 https://bugs.webkit.org/show_bug.cgi?id=62373
7271
7272 No new tests - build fix only.
7273
7274 * bindings/v8/ScriptProfile.cpp: Add necessary guards.
7275 * bindings/v8/ScriptProfile.h: ditto.
7276
7277 2011-06-09 Vsevolod Vlasov <vsevik@chromium.org>
7278
7279 Reviewed by Yury Semikhatsky.
7280
7281 Web Inspector: Network panel preview tab does not reattach SourceFrame w hen switching between preview and response tabs.
7282 https://bugs.webkit.org/show_bug.cgi?id=62298
7283
7284 * inspector/front-end/ResourcePreviewView.js:
7285 (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callba ck):
7286 (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
7287
7288 2011-06-09 Csaba Osztrogonác <ossy@webkit.org>
7289
7290 [Qt][Mac] Speculative buildfix after r88286.
7291
7292 * platform/graphics/IntPoint.h:
7293
7294 2011-06-09 Mike Lawther <mikelawther@chromium.org>
7295
7296 Reviewed by Kent Tamura.
7297
7298 Parsing issue with -webkit-calc
7299 https://bugs.webkit.org/show_bug.cgi?id=62276
7300
7301 Set the CSSParserString for the calc functions.
7302
7303 Test: css3/calc/regression-62276.html
7304
7305 * css/CSSParser.cpp:
7306 (WebCore::CSSParser::lex):
7307
7308 2011-06-09 Robert Hogan <robert@webkit.org>
7309
7310 Reviewed by Andreas Kling.
7311
7312 Teach Qt about window.internals
7313 https://bugs.webkit.org/show_bug.cgi?id=61074
7314
7315 A weakness of the Qt DRT setup is that things like JSContextRef are abst racted
7316 away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
7317 Since the window.internals object requires JSContextRef we need to imple ment it in DumpRenderTreeSupportQt
7318 where we can access it. DumpRenderTreeSupportQt cannot be compiled outsi de Qt's WebCore and as it
7319 is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
7320 Likewise we can't put the accessor in WebCoreTestSupport because it woul d then need to know about QWebFrame
7321 and others. The only alternative seems like a compile time guard which w e would have to teach the bots about.
7322
7323 * CodeGenerators.pri:
7324 * WebCore.pri:
7325 * WebCore.pro:
7326
7327 2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>
7328
7329 Reviewed by Pavel Feldman.
7330
7331 Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
7332 https://bugs.webkit.org/show_bug.cgi?id=52791
7333
7334 No new tests. The problem can be reproduced by trying to create Inspecto rValue
7335 from 1.0e-100 and call ->toJSONString() on this.
7336
7337 * inspector/InspectorValues.cpp:
7338 (WebCore::InspectorBasicValue::writeJSON):
7339 Added checking the predicted buffer size and choosing exponential format , or
7340 eventually "NaN" if the buffer is too small for decimal format.
7341
7342 2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
7343
7344 Unreviewed, rolling out r88387.
7345 http://trac.webkit.org/changeset/88387
7346 https://bugs.webkit.org/show_bug.cgi?id=62368
7347
7348 New tests introduced in 88387 fail on Leopard,GTK,Qt bots
7349 (Requested by Ossy on #webkit).
7350
7351 * html/canvas/CanvasRenderingContext.cpp:
7352 (WebCore::CanvasRenderingContext::checkOrigin):
7353 * html/canvas/CanvasRenderingContext.h:
7354 * html/canvas/WebGLRenderingContext.cpp:
7355 (WebCore::WebGLRenderingContext::readPixels):
7356 (WebCore::WebGLRenderingContext::texImage2D):
7357 (WebCore::WebGLRenderingContext::videoFrameToImage):
7358 (WebCore::WebGLRenderingContext::texSubImage2D):
7359 * html/canvas/WebGLRenderingContext.h:
7360
7361 2011-06-09 Adam Barth <abarth@webkit.org>
7362
7363 Reviewed by Eric Seidel.
7364
7365 Running script from attach can remove elements from the stack of open el ements
7366 https://bugs.webkit.org/show_bug.cgi?id=62160
7367
7368 When the tree build runs script synchronously, that script can remove
7369 arbitrary elements from the stack of open elements. We need to hold a
7370 reference to |parent| in attach instead of rely upon the reference in
7371 the stack of open elements.
7372
7373 Test: fast/parser/document-write-onload-clear.html
7374
7375 * html/parser/HTMLConstructionSite.cpp:
7376 (WebCore::HTMLConstructionSite::attach):
7377
7378 2011-06-08 Luke Macpherson <macpherson@chromium.org>
7379
7380 Reviewed by Eric Seidel.
7381
7382 Make CSSPrimitiveValue support cast to EVerticalAlign.
7383 https://bugs.webkit.org/show_bug.cgi?id=62356
7384
7385 No new tests / refactoring only.
7386
7387 * css/CSSPrimitiveValueMappings.h:
7388 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
7389 (WebCore::CSSPrimitiveValue::operator EVerticalAlign):
7390 * css/CSSStyleSelector.cpp:
7391 (WebCore::CSSStyleSelector::applyProperty):
7392
7393 2011-06-08 Justin Novosad <junov@chromium.org>
7394
7395 Reviewed by James Robinson.
7396
7397 [Chromium] Crash when closing a tab with accelerated 2d canvas
7398 https://bugs.webkit.org/show_bug.cgi?id=62324
7399 Upon graphics context destruction, it is important to signal skia
7400 to abandon all of its resource handles. This prevents a crash caused
7401 by skia attempting to release resources that were in the destroyed
7402 graphics context.
7403
7404 * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
7405 (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
7406
7407 2011-06-08 James Robinson <jamesr@chromium.org>
7408
7409 Reviewed by Darin Fisher.
7410
7411 REGRESSION(88260): 10-50% performance regression across many page cycler s
7412 https://bugs.webkit.org/show_bug.cgi?id=62349
7413
7414 r88260 fixed a font cache resource leak and lowered the inactive font ca che threshold. The latter caused a
7415 significant performance regression across many chromium page cyclers, fo r example
7416 http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/mo z/report.html?history=50&rev=88279.
7417
7418 This restores the previous inactive font size thresholds to their previo us values, but retains the font cleanup
7419 logic.
7420
7421 * platform/graphics/FontCache.cpp:
7422
7423 2011-06-08 Hayato Ito <hayato@chromium.org>
7424
7425 Reviewed by Dimitri Glazkov.
7426
7427 A forward/backward tab traversal now visits focusable elements in a shad ow root.
7428 https://bugs.webkit.org/show_bug.cgi?id=61410
7429
7430 Test: fast/dom/shadow/tab-order-iframe-and-shadow.html
7431
7432 Like a iframe element, a shadow host becomes a scope of
7433 tabindex. That means all descendant elements in a shadow root are
7434 skipped if the host node of the shadow root is not focusable.
7435
7436 The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
7437 which uses a shadow root and do extra works in their focus()
7438 method.
7439
7440 A shadow root's <content> is not considered in this patch.
7441 That will be addressed in a following patch.
7442
7443 * page/FocusController.cpp:
7444 (WebCore::shadowRoot):
7445 (WebCore::isTreeScopeOwner):
7446 (WebCore::FocusController::deepFocusableNode):
7447 (WebCore::FocusController::advanceFocusInDocumentOrder):
7448 (WebCore::FocusController::findFocusableNodeAcrossTreeScope):
7449 (WebCore::FocusController::findFocusableNode):
7450 (WebCore::FocusController::nextFocusableNode):
7451 (WebCore::FocusController::previousFocusableNode):
7452 (WebCore::FocusController::ownerOfTreeScope):
7453 * page/FocusController.h:
7454
7455 2011-06-08 Hayato Ito <hayato@chromium.org>
7456
7457 Reviewed by Hajime Morita.
7458
7459 Makes sure that document.activeElement won't be an element in shadow roo t.
7460
7461 https://bugs.webkit.org/show_bug.cgi?id=61413
7462
7463 Test: fast/dom/shadow/activeelement-should-be-shadowhost.html
7464
7465 * html/HTMLDocument.cpp:
7466 (WebCore::focusedFrameOwnerElement):
7467 (WebCore::HTMLDocument::activeElement):
7468
7469 2011-06-08 Kent Tamura <tkent@chromium.org>
7470
7471 Reviewed by Dimitri Glazkov.
7472
7473 Allow drawing a slider thumb for any nodes.
7474 https://bugs.webkit.org/show_bug.cgi?id=62196
7475
7476 RenderObject::node() should provide various information which is
7477 necessary for rendering. We don't need to refer the parent renderer.
7478
7479 * dom/Node.cpp:
7480 (WebCore::Node::focusDe1egate): Added.
7481 * dom/Node.h: Added a declaration.
7482 * html/shadow/MediaControlElements.cpp:
7483 (WebCore::toParentMediaElement):
7484 Added an overload of toParentMediaElement() with Node* parameter.
7485 * html/shadow/MediaControlElements.h:
7486 (WebCore::toParentMediaElement): ditto.
7487 * html/shadow/SliderThumbElement.cpp:
7488 (WebCore::SliderThumbElement::isEnabledFormControl):
7489 Returns the status of the host node.
7490 (WebCore::SliderThumbElement::isReadOnlyFormControl): ditto.
7491 (WebCore::SliderThumbElement::focusDe1egate):
7492 Returns the host node so that RenderTheme::isFocused() returns true.
7493 (WebCore::SliderThumbElement::detach): Style nit.
7494 (WebCore::SliderThumbElement::hostInput):
7495 Make it const because it is called by const functions.
7496 * html/shadow/SliderThumbElement.h:
7497 - Remove inDragMode()
7498 - Update declarations
7499 * platform/qt/RenderThemeQt.cpp:
7500 (WebCore::RenderThemeQt::paintMediaSliderThumb):
7501 Use Node::shadowAncestorNode() instead of RenderObject::parent() to
7502 support deeper thumb nodes.
7503 * rendering/RenderMediaControlsChromium.cpp:
7504 (WebCore::paintMediaSliderThumb): ditto.
7505 (WebCore::paintMediaVolumeSliderThumb): Remove isSlider() check.
7506 * rendering/RenderSlider.cpp:
7507 (WebCore::RenderSlider::inDragMode):
7508 SliderThumbElement::inDragMode() was removed, and Node::active() has
7509 the same information.
7510 * rendering/RenderTheme.cpp:
7511 (WebCore::RenderTheme::paint): Remove isSlider() checks.
7512 (WebCore::RenderTheme::isFocused): Apply Node::focusDelegate().
7513 * rendering/RenderThemeChromiumLinux.cpp:
7514 (WebCore::RenderThemeChromiumLinux::paintSliderThumb):
7515 isPressed() is enough.
7516 * rendering/RenderThemeChromiumWin.cpp:
7517 isEnabled(), isFocused(), and isPressed() are enough.
7518 (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
7519 (WebCore::RenderThemeChromiumWin::determineClassicState):
7520 * rendering/RenderThemeMac.mm:
7521 (WebCore::RenderThemeMac::paintSliderThumb):
7522 - Remove isSlider() check.
7523 - Passing 'o' to udpateFooState functions is enough.
7524 - isPressed() is enough.
7525 * rendering/RenderThemeSafari.cpp:
7526 (WebCore::RenderThemeSafari::paintSliderThumb):
7527 We don't need special handling anymore.
7528 * rendering/RenderThemeWin.cpp:
7529 (WebCore::RenderThemeWin::determineSliderThumbState):
7530 isEnabled(), isFocused(), and isPressed() are enough.
7531
7532 2011-06-08 Adam Barth <abarth@webkit.org>
7533
7534 Reviewed by Eric Seidel.
7535
7536 constructTreeFromToken can re-enter parser, causing ASSERTs
7537 https://bugs.webkit.org/show_bug.cgi?id=62160
7538
7539 This patch clears the HTMLToken before constructing the tree from the
7540 token, putting the HTMLDocumentParser in a good state to be re-entered.
7541
7542 Tests: fast/parser/document-write-onload-nesting.html
7543 fast/parser/document-write-onload-ordering.html
7544
7545 * html/parser/HTMLDocumentParser.cpp:
7546 (WebCore::HTMLDocumentParser::pumpTokenizer):
7547 * html/parser/HTMLToken.h:
7548 (WebCore::HTMLToken::isUninitialized):
7549 * html/parser/HTMLTreeBuilder.cpp:
7550 (WebCore::HTMLTreeBuilder::constructTreeFromToken):
7551
7552 2011-06-08 Kent Tamura <tkent@chromium.org>
7553
7554 Fix Qt build for r88405.
7555 https://bugs.webkit.org/show_bug.cgi?id=62208
7556
7557 * platform/qt/RenderThemeQt.h:
7558
7559 2011-06-08 Kent Tamura <tkent@chromium.org>
7560
7561 Reviewed by Dimitri Glazkov.
7562
7563 Change the argument of RenderTheme::adjustSliderThumbSize(): RenderObjec t* -> RenderStyle*
7564 https://bugs.webkit.org/show_bug.cgi?id=62208
7565
7566 Change the argument type of RenderTheme::adjustSliderThumbSize() and
7567 RenderMediaControls::adjustMediaSliderThumbSize() from RenderObject* to RenderStyle*.
7568
7569 Also, each of adjustSliderThumbStyle() overrides calls RenderTheme::
7570 adjustSliderThumbStyle() for future changes.
7571
7572 No new tests. This is a refactoring and should not change any behavior.
7573
7574 * html/shadow/SliderThumbElement.cpp:
7575 (WebCore::RenderSliderThumb::layout): Passing RenderStyle* and remove a FIXME comment.
7576 * platform/efl/RenderThemeEfl.cpp:
7577 (WebCore::RenderThemeEfl::adjustSliderThumbStyle): Calls RenderTheme::ad justSliderThumbStyle().
7578 * platform/gtk/RenderThemeGtk.cpp:
7579 (WebCore::RenderThemeGtk::adjustSliderThumbStyle): ditto.
7580 (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
7581 * platform/gtk/RenderThemeGtk.h:
7582 * platform/gtk/RenderThemeGtk2.cpp:
7583 (WebCore::RenderThemeGtk::adjustSliderThumbSize):
7584 * platform/gtk/RenderThemeGtk3.cpp:
7585 (WebCore::RenderThemeGtk::adjustSliderThumbSize):
7586 * platform/qt/RenderThemeQt.cpp:
7587 (WebCore::RenderThemeQt::adjustSliderThumbStyle): ditto.
7588 (WebCore::RenderThemeQt::adjustSliderThumbSize):
7589 * rendering/RenderMediaControls.cpp:
7590 (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
7591 * rendering/RenderMediaControls.h:
7592 * rendering/RenderMediaControlsChromium.cpp:
7593 (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
7594 * rendering/RenderMediaControlsChromium.h:
7595 * rendering/RenderSlider.cpp:
7596 (WebCore::RenderSlider::layout): Passing RenderStyle* and remove a FIXME comment.
7597 * rendering/RenderTheme.cpp:
7598 (WebCore::RenderTheme::adjustSliderThumbStyle): Add a comment.
7599 (WebCore::RenderTheme::adjustSliderThumbSize):
7600 * rendering/RenderTheme.h:
7601 * rendering/RenderThemeChromiumLinux.cpp:
7602 (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
7603 * rendering/RenderThemeChromiumLinux.h:
7604 * rendering/RenderThemeChromiumMac.h:
7605 * rendering/RenderThemeChromiumMac.mm:
7606 (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize):
7607 * rendering/RenderThemeChromiumSkia.cpp:
7608 (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
7609 * rendering/RenderThemeChromiumSkia.h:
7610 * rendering/RenderThemeChromiumWin.cpp:
7611 (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
7612 * rendering/RenderThemeChromiumWin.h:
7613 * rendering/RenderThemeMac.h:
7614 * rendering/RenderThemeMac.mm:
7615 (WebCore::RenderThemeMac::adjustSliderThumbStyle): Calls RenderTheme::ad justSliderThumbStyle().
7616 (WebCore::RenderThemeMac::adjustSliderThumbSize):
7617 (WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
7618 * rendering/RenderThemeSafari.cpp:
7619 (WebCore::RenderThemeSafari::adjustSliderThumbStyle): Calls RenderTheme: :adjustSliderThumbStyle().
7620 (WebCore::RenderThemeSafari::adjustSliderThumbSize):
7621 * rendering/RenderThemeSafari.h:
7622 * rendering/RenderThemeWin.cpp:
7623 (WebCore::RenderThemeWin::adjustSliderThumbSize):
7624 * rendering/RenderThemeWin.h:
7625 * rendering/RenderThemeWinCE.cpp:
7626 (WebCore::RenderThemeWinCE::adjustSliderThumbSize):
7627 * rendering/RenderThemeWinCE.h:
7628
7629 2011-06-08 Brian Salomon <bsalomon@google.com>
7630
7631 Reviewed by James Robinson.
7632
7633 Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO.
7634 https://bugs.webkit.org/show_bug.cgi?id=62318
7635
7636 Chromium-only crash
7637 Failures takes multiple seconds to occur, relying on JS garbage-collecti on to occur
7638 http://www.hotbazooka.com/privatejoe-large
7639
7640 * platform/graphics/gpu/DrawingBuffer.cpp:
7641 (WebCore::DrawingBuffer::clear):
7642
7643 2011-06-08 Emil A Eklund <eae@chromium.org>
7644
7645 Reviewed by Eric Seidel.
7646
7647 RenderEmbeddedObject::getReplacementTextGeometry
7648 https://bugs.webkit.org/show_bug.cgi?id=62313
7649
7650 Replace the last use of tx, ty with IntPoint.
7651
7652 Covered by existing tests.
7653
7654 * platform/graphics/FloatRect.h:
7655 (WebCore::FloatRect::move):
7656 (WebCore::FloatRect::moveBy):
7657 * rendering/RenderEmbeddedObject.cpp:
7658 (WebCore::RenderEmbeddedObject::paintReplaced):
7659 (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
7660 (WebCore::RenderEmbeddedObject::isInMissingPluginIndicator):
7661 * rendering/RenderEmbeddedObject.h:
7662
7663 2011-06-08 Tim Horton <timothy_horton@apple.com>
7664
7665 Reviewed by Ryosuke Niwa.
7666
7667 Use correct CFURLStorageSessionRef definition on Leopard, as
7668 we created an inconsistency in const-ness between
7669 WebCoreSystemInterface.h and these two files in the case
7670 of Leopard only.
7671 https://bugs.webkit.org/show_bug.cgi?id=62223
7672
7673 * platform/network/ResourceHandle.h:
7674 * platform/network/cf/ResourceRequest.h:
7675
7676 2011-06-08 Sailesh Agrawal <sail@chromium.org>
7677
7678 Reviewed by Mihai Parparita.
7679
7680 Chromium Mac: Enable overlay scrollbars
7681 https://bugs.webkit.org/show_bug.cgi?id=59756
7682
7683 Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick u p support for overlay scrollbars. The only changes are renaming ScrollbarThemeMa c to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's.
7684
7685 No new tests, since this code is only enabled on future versions of Mac OS X.
7686
7687 * platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this fi le except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime ch ecks.
7688 (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
7689 (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
7690 (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged):
7691 (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
7692 (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
7693 (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
7694 (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
7695 (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
7696 (WebCore::ScrollAnimatorChromiumMac::contentsResized):
7697 (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
7698 (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
7699 (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
7700 (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
7701 (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
7702 (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
7703 (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
7704 (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
7705 (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
7706 (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
7707 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
7708 (preferredScrollerStyle): Disabled overlay scrollbar styles due to trail ing artifacts.
7709 (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track was n't being drawn.
7710 (wkScrollbarPainterKnobRect): Implemented a previously unimplemented fun ction.
7711 (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supp orted by the latest Mac OS X seeds.
7712 (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code.
7713 * platform/chromium/ScrollbarThemeChromiumMac.h:
7714 * platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThe meMac.mm.
7715 (WebCore::scrollbarMap):
7716 (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
7717 (WebCore::updateArrowPlacement):
7718 (WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
7719 (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar):
7720 (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
7721 (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar):
7722 (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness):
7723 (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars):
7724 (WebCore::ScrollbarThemeChromiumMac::hasButtons):
7725 (WebCore::ScrollbarThemeChromiumMac::hasThumb):
7726 (WebCore::buttonRepaintRect):
7727 (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength):
7728 (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb):
7729 (WebCore::toScrollbarPainterKnobStyle):
7730 (WebCore::ScrollbarThemeChromiumMac::paint):
7731
7732 2011-06-06 Nate Chapin <japhet@chromium.org>
7733
7734 Reviewed by Adam Barth.
7735
7736 Remove all knowledge of CachedResourceRequests from
7737 CachedResourceLoader. This puts the full burden of
7738 canceling these requests on DocumentLoader (via
7739 SubresourceLoader), and makes a CachedResourceRequest
7740 an OwnPtr in CachedResource.
7741
7742 https://bugs.webkit.org/show_bug.cgi?id=62308
7743
7744 * loader/FrameLoader.cpp:
7745 (WebCore::FrameLoader::stopLoading):
7746 * loader/cache/CachedResource.cpp:
7747 (WebCore::CachedResource::CachedResource):
7748 (WebCore::CachedResource::load):
7749 (WebCore::CachedResource::stopLoading):
7750 * loader/cache/CachedResource.h:
7751 * loader/cache/CachedResourceLoader.cpp:
7752 (WebCore::CachedResourceLoader::~CachedResourceLoader):
7753 (WebCore::CachedResourceLoader::loadDone):
7754 * loader/cache/CachedResourceLoader.h:
7755 * loader/cache/CachedResourceRequest.cpp:
7756 (WebCore::CachedResourceRequest::CachedResourceRequest):
7757 (WebCore::CachedResourceRequest::~CachedResourceRequest):
7758 (WebCore::CachedResourceRequest::load):
7759 (WebCore::CachedResourceRequest::didFinishLoading):
7760 (WebCore::CachedResourceRequest::didFail):
7761 (WebCore::CachedResourceRequest::didReceiveResponse):
7762 (WebCore::CachedResourceRequest::end):
7763 * loader/cache/CachedResourceRequest.h:
7764
7765 2011-06-08 Mike Reed <reed@google.com>
7766
7767 Reviewed by James Robinson.
7768
7769 [Skia] check for null-shader from gradient factory
7770 https://bugs.webkit.org/show_bug.cgi?id=62319
7771
7772 * platform/graphics/skia/GradientSkia.cpp:
7773 (WebCore::Gradient::platformDestroy):
7774 (WebCore::Gradient::platformGradient):
7775
7776 2011-06-08 Kenneth Russell <kbr@google.com>
7777
7778 Reviewed by Adam Barth.
7779
7780 Disallow use of cross-domain media (images, video) in WebGL
7781 https://bugs.webkit.org/show_bug.cgi?id=62257
7782
7783 Updated WebGL implementation to track recent spec updates in this area.
7784
7785 Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-c redentials.html
7786 http/tests/security/webgl-remote-read-remote-image-allowed.html
7787 http/tests/security/webgl-remote-read-remote-image-blocked-no-cro ssorigin.html
7788
7789 * html/canvas/CanvasRenderingContext.cpp:
7790 (WebCore::CanvasRenderingContext::wouldTaintOrigin):
7791 (WebCore::CanvasRenderingContext::checkOrigin):
7792 * html/canvas/CanvasRenderingContext.h:
7793 (WebCore::CanvasRenderingContext::checkOrigin):
7794 * html/canvas/WebGLRenderingContext.cpp:
7795 (WebCore::WebGLRenderingContext::readPixels):
7796 (WebCore::WebGLRenderingContext::texImage2D):
7797 (WebCore::WebGLRenderingContext::videoFrameToImage):
7798 (WebCore::WebGLRenderingContext::texSubImage2D):
7799 * html/canvas/WebGLRenderingContext.h:
7800
7801 2011-06-08 John Bauman <jbauman@chromium.org> 1 2011-06-08 John Bauman <jbauman@chromium.org>
7802 2
7803 Reviewed by James Robinson. 3 Reviewed by James Robinson.
7804 4
7805 Only draw portions of tiles in contentRect 5 Only draw portions of tiles in contentRect
7806 https://bugs.webkit.org/show_bug.cgi?id=62243 6 https://bugs.webkit.org/show_bug.cgi?id=62243
7807 7
7808 Old garbage data can remain in tiles, so make sure to draw only those 8 Old garbage data can remain in tiles, so make sure to draw only those
7809 portions that are supposed to be drawn. 9 portions that are supposed to be drawn.
7810 10
(...skipping 2645 matching lines...) Expand 10 before | Expand all | Expand 10 after
10456 fast/viewport/viewport-45.html fails in GTK+/Qt 2656 fast/viewport/viewport-45.html fails in GTK+/Qt
10457 https://bugs.webkit.org/show_bug.cgi?id=47481 2657 https://bugs.webkit.org/show_bug.cgi?id=47481
10458 2658
10459 computeViewportAttributes does many math operations with float point ari thmetic 2659 computeViewportAttributes does many math operations with float point ari thmetic
10460 and in some cases there is loss of precision making tests have incorrect values. 2660 and in some cases there is loss of precision making tests have incorrect values.
10461 2661
10462 * dom/ViewportArguments.cpp: 2662 * dom/ViewportArguments.cpp:
10463 (WebCore::computeViewportAttributes): 2663 (WebCore::computeViewportAttributes):
10464 2664
10465 == Rolled over to ChangeLog-2011-06-04 == 2665 == Rolled over to ChangeLog-2011-06-04 ==
OLDNEW
« no previous file with comments | « LayoutTests/platform/chromium/test_expectations.txt ('k') | Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698