Added about:flags entries for --enable-accelerated-drawing flag.

Added about:flags entries for --enable-accelerated-drawing flag.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89835

[vangelis, 2011-06-20 18:06:51]

http://codereview.chromium.org/7210021/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7210021/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:4164: Enable GPU accelerated drawing of
composited render layers.
Since essentially all rendering in the page (including the root layer) will be
going through the GPU should the be phrased as:

"Enable GPU accelerated drawing of page contents"

or something like that?  Also, what happens if accelerated drawing is enabled
without force compositing mode?  Should one trigger the other? If not, we should
probably put a brief blurb here that it also requires the force compositing flag
to be enabled.

[alokp, 2011-06-20 19:01:18]

http://codereview.chromium.org/7210021/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7210021/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:4164: Enable GPU accelerated drawing of
composited render layers.
On 2011/06/20 18:06:51, vangelis wrote:
> Since essentially all rendering in the page (including the root layer) will be
> going through the GPU should the be phrased as:
> 
> "Enable GPU accelerated drawing of page contents"

Isn't root layer a composited render layer? I think "composited render layers"
is more appropriate than "page contents" because it only comes into effect when
compositing is active.

> or something like that?  Also, what happens if accelerated drawing is enabled
> without force compositing mode?  Should one trigger the other? If not, we
should
> probably put a brief blurb here that it also requires the force compositing
flag
> to be enabled.

DONE.

[vangelis, 2011-06-20 19:27:47]

http://codereview.chromium.org/7210021/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7210021/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:4164: Enable GPU accelerated drawing of
composited render layers.
On 2011/06/20 19:01:18, Alok Priyadarshi wrote:
> On 2011/06/20 18:06:51, vangelis wrote:
> > Since essentially all rendering in the page (including the root layer) will
be
> > going through the GPU should the be phrased as:
> > 
> > "Enable GPU accelerated drawing of page contents"
> 
> Isn't root layer a composited render layer? I think "composited render layers"
> is more appropriate than "page contents" because it only comes into effect
when
> compositing is active.
> 

The root is currently a special case and not treated like the rest of the
content layers.  In any case though, since this is a user facing message that
distinction would be lost.

You are right that we need to somehow indicate that this only affects pages that
go through the compositor. I think it could be clearer if we say that this does
accelerated drawing for the contents of the layer (as opposed to an accelerated
compositing operation).

"Enable GPU accelerated drawing of page contents when compositing is enabled."

?



> > or something like that?  Also, what happens if accelerated drawing is
enabled
> > without force compositing mode?  Should one trigger the other? If not, we
> should
> > probably put a brief blurb here that it also requires the force compositing
> flag
> > to be enabled.
> 
> DONE.

[alokp, 2011-06-20 19:33:38]

http://codereview.chromium.org/7210021/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7210021/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:4164: Enable GPU accelerated drawing of
composited render layers.
> 
> "Enable GPU accelerated drawing of page contents when compositing is enabled."
> 

perfect! DONE.

[vangelis, 2011-06-20 19:37:43]

Looks good, thanks.  You'll need OWNERS' blessing too.

[alokp, 2011-06-20 21:19:13]

On 2011/06/20 19:37:43, vangelis wrote:
> Looks good, thanks.  You'll need OWNERS' blessing too.

I did not find OWNERS file in any of these directories. Could you lgtm?
Presubmit script insists on lgtm.

[vangelis, 2011-06-20 21:27:56]

Strange...

LGTM from me.


On 2011/06/20 21:19:13, Alok Priyadarshi wrote:
> On 2011/06/20 19:37:43, vangelis wrote:
> > Looks good, thanks.  You'll need OWNERS' blessing too.
> 
> I did not find OWNERS file in any of these directories. Could you lgtm?
> Presubmit script insists on lgtm.