Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 7210016: Prepare push to trunk. Now working on V8 version 3.4.6. Revision 8324, which also claims this, ... (Closed)

Created:
9 years, 6 months ago by William Hesse
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on V8 version 3.4.6. Revision 8324, which also claims this, has been superseded by this one. Committed: http://code.google.com/p/v8/source/detail?r=8336

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ChangeLog View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
9 years, 6 months ago (2011-06-20 15:02:42 UTC) #1
Mads Ager (chromium)
LGTM
9 years, 6 months ago (2011-06-20 15:06:25 UTC) #2
Mads Ager (chromium)
9 years, 6 months ago (2011-06-20 15:07:05 UTC) #3
http://codereview.chromium.org/7210016/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/7210016/diff/1/ChangeLog#newcode18
ChangeLog:18: Fixed build error in webkit builds due to missing i18n extension.
We should remove this. The previous version did not have this problem so it is
not relevant for the ChangeLog.

Powered by Google App Engine
This is Rietveld 408576698