AppCaches which belong to hosted apps are not protected from deletion

content/browser/appcache/chrome_appcache_service.cc

Index: content/browser/appcache/chrome_appcache_service.cc
diff --git a/content/browser/appcache/chrome_appcache_service.cc b/content/browser/appcache/chrome_appcache_service.cc
index dd593efdea1343aa50d5ad7b691f8e30195ca85a..b6eb5c64be5769d02a54a515b9d52c204dc1e68c 100644
--- a/content/browser/appcache/chrome_appcache_service.cc
+++ b/content/browser/appcache/chrome_appcache_service.cc
@@ -14,33 +14,26 @@
 
 static bool has_initialized_thread_ids;
 
-namespace {
-
-// Used to defer deleting of local storage until the destructor has finished.
-void DeleteLocalStateOnIOThread(FilePath cache_path) {
-  // Post the actual deletion to the DB thread to ensure it happens after the
-  // database file has been closed.
-  BrowserThread::PostTask(
-      BrowserThread::DB, FROM_HERE,
-      NewRunnableFunction<bool(*)(const FilePath&, bool), FilePath, bool>(
-          &file_util::Delete, cache_path, true));
-}
-
-}  // namespace
-
 // ----------------------------------------------------------------------------
 
 ChromeAppCacheService::ChromeAppCacheService(
     quota::QuotaManagerProxy* quota_manager_proxy)
     : AppCacheService(quota_manager_proxy),
-      resource_context_(NULL), clear_local_state_on_exit_(false) {
+      resource_context_(NULL),
+      ALLOW_THIS_IN_INITIALIZER_LIST(appcache_got_info_callback_(
+          this, &ChromeAppCacheService::OnGotAppCacheInfo)),
+      ALLOW_THIS_IN_INITIALIZER_LIST(origin_deleted_callback_(
+          this, &ChromeAppCacheService::OnOriginDeleted)),
+      origins_to_be_deleted_count_(0),
+      appcaches_cleared_event_(new base::WaitableEvent(true, false)),
+      appcaches_cleared_callback_(NULL),
+      waiting_for_clear_appcaches_(false) {
 }
 
 void ChromeAppCacheService::InitializeOnIOThread(
     const FilePath& cache_path,
     const content::ResourceContext* resource_context,
-    scoped_refptr<quota::SpecialStoragePolicy> special_storage_policy,
-    bool clear_local_state_on_exit) {
+    scoped_refptr<quota::SpecialStoragePolicy> special_storage_policy) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   if (!has_initialized_thread_ids) {
@@ -53,7 +46,6 @@ void ChromeAppCacheService::InitializeOnIOThread(
   registrar_.Add(
       this, content::NOTIFICATION_PURGE_MEMORY,
       NotificationService::AllSources());
-  SetClearLocalStateOnExit(clear_local_state_on_exit);
 
   // Init our base class.
   Initialize(cache_path_,
@@ -63,26 +55,72 @@ void ChromeAppCacheService::InitializeOnIOThread(
 }
 
 ChromeAppCacheService::~ChromeAppCacheService() {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+}
 
-  if (clear_local_state_on_exit_ && !cache_path_.empty()) {
+base::WaitableEvent* ChromeAppCacheService::ClearAppCache(
+    net::CompletionCallback* callback)
+{
+  if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
     BrowserThread::PostTask(
-        BrowserThread::IO, FROM_HERE,
-        NewRunnableFunction(DeleteLocalStateOnIOThread, cache_path_));
+      BrowserThread::IO, FROM_HERE,
+      NewRunnableMethod(this,
+                        &ChromeAppCacheService::ClearAppCache,
+                        callback));
+    return appcaches_cleared_event_.get();
   }
+
+  // Only one appcache deletion should be in progress at any given time.
+  DCHECK(waiting_for_clear_appcaches_ == false);
+  waiting_for_clear_appcaches_ = true;
+  appcaches_cleared_callback_ = callback;
+  appcaches_cleared_event_->Reset();
+
+  // Keep the ChromeAppCacheService instance alive until the deletion has
+  // finished.
+  AddRef();
+
+  appcache_info_ = new appcache::AppCacheInfoCollection;
+  GetAllAppCacheInfo(
+      appcache_info_, &appcache_got_info_callback_);
+  // Continues in OnGotAppCacheInfo.
+
+  return appcaches_cleared_event_.get();
 }
 
-void ChromeAppCacheService::SetClearLocalStateOnExit(bool clear_local_state) {
-  // TODO(michaeln): How is 'protected' status granted to apps in this case?
-  if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
-    BrowserThread::PostTask(
-        BrowserThread::IO, FROM_HERE,
-        NewRunnableMethod(this,
-                          &ChromeAppCacheService::SetClearLocalStateOnExit,
-                          clear_local_state));
-    return;
+void ChromeAppCacheService::OnGotAppCacheInfo(int rv) {
+  using appcache::AppCacheInfoVector;
+  typedef std::map<GURL, AppCacheInfoVector> InfoByOrigin;
+
+  origins_to_be_deleted_count_ = 0;
+  for (InfoByOrigin::const_iterator origin =
+           appcache_info_->infos_by_origin.begin();
+       origin != appcache_info_->infos_by_origin.end(); ++origin) {
+
+    if (special_storage_policy_->IsStorageProtected(origin->first))
+      continue;
+
+    ++origins_to_be_deleted_count_;
+    DeleteAppCachesForOrigin(origin->first, &origin_deleted_callback_);
+  }
+
+  if (origins_to_be_deleted_count_ == 0)
+    OnClearedAppCache();
+  // Else continues in OnOriginDeleted.
+}
+
+void ChromeAppCacheService::OnOriginDeleted(int rv) {
+  --origins_to_be_deleted_count_;
+  if (origins_to_be_deleted_count_ == 0)
+    OnClearedAppCache();
+}
+
+void ChromeAppCacheService::OnClearedAppCache() {

[michaeln, 2011/07/12 18:45:38]

Fyi, at the time this callback is invoked, the responses may have not (likely
have not) actually been removed from the DiskCache. The responses are lazily
scavenged after the Group/Cache/Entry records have been deleted, this completion
callback occurs when those records have been deleted by prior to the scavenging
having taken place. 

+  appcaches_cleared_event_->Signal();
+  if (appcaches_cleared_callback_) {
+    appcaches_cleared_callback_->Run(0);
   }
-  clear_local_state_on_exit_ = clear_local_state;
+  waiting_for_clear_appcaches_ = false;
+  Release();
 }
 
 bool ChromeAppCacheService::CanLoadAppCache(const GURL& manifest_url) {