AppCaches which belong to hosted apps are not protected from deletion

chrome/browser/profiles/profile_impl.cc

Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
index 619ff135c7e3f9db05e51ec4498cf5c896e395bf..d5b3a9283e04bed92573f1469342c21cb27bf37f 100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -590,6 +590,9 @@ ProfileImpl::~ProfileImpl() {
       Source<Profile>(this),
       NotificationService::NoDetails());
 
+  if (appcache_service_ && prefs_->GetBoolean(prefs::kClearSiteDataOnExit))
+    appcache_service_->SyncClearAppCacheOnIOThread();

[michaeln, 2011/07/14 00:42:34]

Just post a task to set the service's clear_on_exit_ flag. In most other places
the clear_local_state_on_exit_ data member is used to test for that pref
setting.

[marja(google), 2011/07/14 10:31:59]

Done.

+
   StopCreateSessionServiceTimer();
 
   // Remove pref observers
@@ -1337,8 +1340,7 @@ void ProfileImpl::CreateQuotaManagerAndClients() {
           IsOffTheRecord()
               ? FilePath() : GetPath().Append(chrome::kAppCacheDirname),
           &GetResourceContext(),
-          make_scoped_refptr(GetExtensionSpecialStoragePolicy()),
-          clear_local_state_on_exit_));
+          make_scoped_refptr(GetExtensionSpecialStoragePolicy())));
 }
 
 WebKitContext* ProfileImpl::GetWebKitContext() {
@@ -1393,10 +1395,6 @@ void ProfileImpl::Observe(int type,
           webkit_context_->set_clear_local_state_on_exit(
               clear_local_state_on_exit_);
         }
-        if (appcache_service_) {
-          appcache_service_->SetClearLocalStateOnExit(
-              clear_local_state_on_exit_);
-        }
         if (db_tracker_) {
           db_tracker_->SetClearLocalStateOnExit(
               clear_local_state_on_exit_);