Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: webkit/appcache/appcache_service.h

Issue 7210006: AppCaches which belong to hosted apps are not protected from deletion (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixing the merge. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_service.h
diff --git a/webkit/appcache/appcache_service.h b/webkit/appcache/appcache_service.h
index 4952c941270c17ab87b63d78ae5d273c53652229..a0d9abe672b93a987f9bda2a207176a887b9efce 100644
--- a/webkit/appcache/appcache_service.h
+++ b/webkit/appcache/appcache_service.h
@@ -73,9 +73,9 @@ class AppCacheService {
// Populates 'collection' with info about all of the appcaches stored
// within the service, 'callback' is invoked upon completion. The service
// acquires a reference to the 'collection' until until completion.
- // This method always completes asynchronously.
- void GetAllAppCacheInfo(AppCacheInfoCollection* collection,
- net::CompletionCallback* callback);
+ // This method always completes asynchronously. (virtual for unittesting)
+ virtual void GetAllAppCacheInfo(AppCacheInfoCollection* collection,
+ net::CompletionCallback* callback);
// Deletes the group identified by 'manifest_url', 'callback' is
// invoked upon completion. Upon completion, the cache group and

Powered by Google App Engine
This is Rietveld 408576698