AppCaches which belong to hosted apps are not protected from deletion

webkit/appcache/appcache_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_APPCACHE_APPCACHE_SERVICE_H_
 #define WEBKIT_APPCACHE_APPCACHE_SERVICE_H_
 
 #include <map>
 #include <set>
 
@@ skipping 55 matching lines @@
   }
 
   // Determines if a request for 'url' can be satisfied while offline.
   // This method always completes asynchronously.
   void CanHandleMainResourceOffline(const GURL& url,
                                     net::CompletionCallback* callback);
 
   // Populates 'collection' with info about all of the appcaches stored
   // within the service, 'callback' is invoked upon completion. The service
   // acquires a reference to the 'collection' until until completion.
-  // This method always completes asynchronously.
-  void GetAllAppCacheInfo(AppCacheInfoCollection* collection,
-                          net::CompletionCallback* callback);
+  // This method always completes asynchronously. (virtual for unittesting)
+  virtual void GetAllAppCacheInfo(AppCacheInfoCollection* collection,
+                                  net::CompletionCallback* callback);
 
-  // Deletes the group identified by 'manifest_url', 'callback' is
-  // invoked upon completion. Upon completion, the cache group and
-  // any resources within the group are no longer loadable and all
-  // subresource loads for pages associated with a deleted group
-  // will fail. This method always completes asynchronously.
-  void DeleteAppCacheGroup(const GURL& manifest_url,
+  // Deletes the group identified by 'manifest_url', 'callback' is invoked upon
+  // completion. Upon completion, the cache group and any resources within the
+  // group are no longer loadable and all subresource loads for pages associated
+  // with a deleted group will fail. This method always completes
+  // asynchronously. (virtual for unittesting)
+  virtual void DeleteAppCacheGroup(const GURL& manifest_url,
                            net::CompletionCallback* callback);
 
   // Deletes all appcaches for the origin, 'callback' is invoked upon
   // completion. This method always completes asynchronously.
   // (virtual for unittesting)
   virtual void DeleteAppCachesForOrigin(const GURL& origin,
                                         net::CompletionCallback* callback);
 
   // Context for use during cache updates, should only be accessed
   // on the IO thread. We do NOT add a reference to the request context,
@@ skipping 29 matching lines @@
   // See chrome/browser/AppCacheDispatcherHost.
   void RegisterBackend(AppCacheBackendImpl* backend_impl);
   void UnregisterBackend(AppCacheBackendImpl* backend_impl);
   AppCacheBackendImpl* GetBackend(int id) const {
     BackendMap::const_iterator it = backends_.find(id);
     return (it != backends_.end()) ? it->second : NULL;
   }
 
   AppCacheStorage* storage() const { return storage_.get(); }
 
+  bool clear_local_state_on_exit() const { return clear_local_state_on_exit_; }
+  void set_clear_local_state_on_exit(bool clear_local_state_on_exit) {
+    clear_local_state_on_exit_ = clear_local_state_on_exit; }
+
  protected:
   friend class AppCacheStorageImplTest;
   friend class AppCacheServiceTest;
 
   class AsyncHelper;
   class CanHandleOfflineHelper;
   class DeleteHelper;
   class DeleteOriginHelper;
   class GetInfoHelper;
 
   typedef std::set<AsyncHelper*> PendingAsyncHelpers;
   typedef std::map<int, AppCacheBackendImpl*> BackendMap;
 
   AppCachePolicy* appcache_policy_;
   AppCacheQuotaClient* quota_client_;
+  // special_storage_policy_ must outlive storage_; ~AppCacheStorageImpl
+  // accesses special_storage_policy_.

[michaeln, 2011/07/14 22:53:16]

right... that's pretty subtle... commenting the data member ordering helps, not
sure but it may be better to explicit invoke storage_.reset() in
~AppCacheService() so we're not dependent on the order of the data members

[marja(google), 2011/07/15 11:03:42]

Done.

+  scoped_refptr<quota::SpecialStoragePolicy> special_storage_policy_;
   scoped_ptr<AppCacheStorage> storage_;
-  scoped_refptr<quota::SpecialStoragePolicy> special_storage_policy_;
   scoped_refptr<quota::QuotaManagerProxy> quota_manager_proxy_;
   PendingAsyncHelpers pending_helpers_;
   BackendMap backends_;  // One 'backend' per child process.
   // Context for use during cache updates.
   net::URLRequestContext* request_context_;
+  bool clear_local_state_on_exit_;
 
   DISALLOW_COPY_AND_ASSIGN(AppCacheService);
 };
 
 }  // namespace appcache
 
 #endif  // WEBKIT_APPCACHE_APPCACHE_SERVICE_H_