AppCaches which belong to hosted apps are not protected from deletion

webkit/appcache/appcache_storage.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_APPCACHE_APPCACHE_STORAGE_H_
 #define WEBKIT_APPCACHE_APPCACHE_STORAGE_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 58 matching lines @@
         bool was_blocked_by_policy) {}
   };
 
   explicit AppCacheStorage(AppCacheService* service);
   virtual ~AppCacheStorage();
 
   // Schedules a task to retrieve basic info about all groups and caches
   // stored in the system. Upon completion the delegate will be called
   // with the results.
   virtual void GetAllInfo(Delegate* delegate) = 0;
+  // The same as GetAllInfo but completes synchronously (delegate will be called
+  // within the method).
+  virtual void SyncGetAllInfo(Delegate* delegate) = 0;

[michaeln, 2011/07/14 00:42:34]

Please remove all of these Sync prefixed methods from this class and its
derivatives.

[marja(google), 2011/07/14 10:31:59]

Done.

 
   // Schedules a cache to be loaded from storage. Upon load completion
   // the delegate will be called back. If the cache already resides in
   // memory, the delegate will be called back immediately without returning
   // to the message loop. If the load fails, the delegate will be called
   // back with a NULL cache pointer.
   virtual void LoadCache(int64 id, Delegate* delegate) = 0;
 
   // Schedules a group and its newest cache, if any, to be loaded from storage.
   // Upon load completion the delegate will be called back. If the group
   // and newest cache already reside in memory, the delegate will be called
   // back immediately without returning to the message loop. If the load fails,
   // the delegate will be called back with a NULL group pointer.
   virtual void LoadOrCreateGroup(
       const GURL& manifest_url, Delegate* delegate) = 0;
+  // The same as SyncLoadOrCreateGroup but completes synchronously (delegate
+  // will be called within the method).
+  virtual void SyncLoadOrCreateGroup(
+      const GURL& manifest_url, Delegate* delegate) = 0;
 
   // Schedules response info to be loaded from storage.
   // Upon load completion the delegate will be called back. If the data
   // already resides in memory, the delegate will be called back
   // immediately without returning to the message loop. If the load fails,
   // the delegate will be called back with a NULL pointer.
   virtual void LoadResponseInfo(
       const GURL& manifest_url, int64 response_id, Delegate* delegate);
 
   // Schedules a group and its newest complete cache to be initially stored or
@@ skipping 26 matching lines @@
   // and schedules a task to update persistent storage. If the cache is
   // already scheduled to be loaded, upon loading completion the entry
   // will be marked. There is no delegate completion callback.
   virtual void MarkEntryAsForeign(const GURL& entry_url, int64 cache_id) = 0;
 
   // Schedules a task to update persistent storage and doom the group and all
   // related caches and responses for deletion. Upon completion the in-memory
   // instance is marked as obsolete and the delegate callback is called.
   virtual void MakeGroupObsolete(
       AppCacheGroup* group, Delegate* delegate) = 0;
+  // The same as MakeGroupObsolete but completes synchronously (delegate will be
+  // called within the method).
+  virtual void SyncMakeGroupObsolete(
+      AppCacheGroup* group, Delegate* delegate) = 0;
 
   // Cancels all pending callbacks for the delegate. The delegate callbacks
   // will not be invoked after, however any scheduled operations will still
   // take place. The callbacks for subsequently scheduled operations are
   // unaffected.
   void CancelDelegateCallbacks(Delegate* delegate) {
     DelegateReference* delegate_reference = GetDelegateReference(delegate);
     if (delegate_reference)
       delegate_reference->CancelReference();
   }
@@ skipping 156 matching lines @@
 
   FRIEND_TEST_ALL_PREFIXES(AppCacheStorageTest, DelegateReferences);
   FRIEND_TEST_ALL_PREFIXES(AppCacheStorageTest, UsageMap);
 
   DISALLOW_COPY_AND_ASSIGN(AppCacheStorage);
 };
 
 }  // namespace appcache
 
 #endif  // WEBKIT_APPCACHE_APPCACHE_STORAGE_H_
-