 Chromium Code Reviews
 Chromium Code Reviews Issue 7207007:
  Proper handling of future reserved words in strict and normal mode.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 7207007:
  Proper handling of future reserved words in strict and normal mode.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| Index: src/scanner-base.cc | 
| diff --git a/src/scanner-base.cc b/src/scanner-base.cc | 
| index 1564e9876ae30ebe1df9d8770a5f4a34428428fc..c0b4f342bf0eaa0d580b4569c26a58b62c88e6c7 100644 | 
| --- a/src/scanner-base.cc | 
| +++ b/src/scanner-base.cc | 
| @@ -799,7 +799,7 @@ KeywordMatcher::FirstState KeywordMatcher::first_states_[] = { | 
| { NULL, I, Token::ILLEGAL }, | 
| { NULL, UNMATCHABLE, Token::ILLEGAL }, | 
| { NULL, UNMATCHABLE, Token::ILLEGAL }, | 
| - { "let", KEYWORD_PREFIX, Token::FUTURE_RESERVED_WORD }, | 
| + { "let", KEYWORD_PREFIX, Token::FUTURE_STRICT_RESERVED_WORD }, | 
| { NULL, UNMATCHABLE, Token::ILLEGAL }, | 
| { NULL, N, Token::ILLEGAL }, | 
| { NULL, UNMATCHABLE, Token::ILLEGAL }, | 
| @@ -812,7 +812,7 @@ KeywordMatcher::FirstState KeywordMatcher::first_states_[] = { | 
| { NULL, V, Token::ILLEGAL }, | 
| { NULL, W, Token::ILLEGAL }, | 
| { NULL, UNMATCHABLE, Token::ILLEGAL }, | 
| - { "yield", KEYWORD_PREFIX, Token::FUTURE_RESERVED_WORD } | 
| + { "yield", KEYWORD_PREFIX, Token::FUTURE_STRICT_RESERVED_WORD } | 
| }; | 
| @@ -900,14 +900,14 @@ void KeywordMatcher::Step(unibrow::uchar input) { | 
| break; | 
| case IMP: | 
| if (MatchKeywordStart(input, "implements", 3, | 
| - Token::FUTURE_RESERVED_WORD )) return; | 
| + Token::FUTURE_STRICT_RESERVED_WORD )) return; | 
| 
Lasse Reichstein
2011/06/22 20:29:33
Indent to align with "input". Ditto for other case
 
Steven
2011/06/24 11:34:59
Done.
 | 
| if (MatchKeywordStart(input, "import", 3, | 
| Token::FUTURE_RESERVED_WORD)) return; | 
| break; | 
| case IN: | 
| token_ = Token::IDENTIFIER; | 
| if (MatchKeywordStart(input, "interface", 2, | 
| - Token::FUTURE_RESERVED_WORD)) return; | 
| + Token::FUTURE_STRICT_RESERVED_WORD)) return; | 
| if (MatchKeywordStart(input, "instanceof", 2, Token::INSTANCEOF)) return; | 
| break; | 
| case N: | 
| @@ -916,20 +916,20 @@ void KeywordMatcher::Step(unibrow::uchar input) { | 
| break; | 
| case P: | 
| if (MatchKeywordStart(input, "package", 1, | 
| - Token::FUTURE_RESERVED_WORD)) return; | 
| + Token::FUTURE_STRICT_RESERVED_WORD)) return; | 
| if (MatchState(input, 'r', PR)) return; | 
| if (MatchKeywordStart(input, "public", 1, | 
| - Token::FUTURE_RESERVED_WORD)) return; | 
| + Token::FUTURE_STRICT_RESERVED_WORD)) return; | 
| break; | 
| case PR: | 
| if (MatchKeywordStart(input, "private", 2, | 
| - Token::FUTURE_RESERVED_WORD)) return; | 
| + Token::FUTURE_STRICT_RESERVED_WORD)) return; | 
| if (MatchKeywordStart(input, "protected", 2, | 
| - Token::FUTURE_RESERVED_WORD)) return; | 
| + Token::FUTURE_STRICT_RESERVED_WORD)) return; | 
| break; | 
| case S: | 
| if (MatchKeywordStart(input, "static", 1, | 
| - Token::FUTURE_RESERVED_WORD)) return; | 
| + Token::FUTURE_STRICT_RESERVED_WORD)) return; | 
| if (MatchKeywordStart(input, "super", 1, | 
| Token::FUTURE_RESERVED_WORD)) return; | 
| if (MatchKeywordStart(input, "switch", 1, |