src/x64/ic-x64.cc - Issue 7207006: Add missing write barrier for arguments store ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/ic-x64.cc

Issue 7207006: Add missing write barrier for arguments store ICs. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/ic-x64.cc

===================================================================

--- src/x64/ic-x64.cc (revision 8365)

+++ src/x64/ic-x64.cc (working copy)

@@ -1308,12 +1308,18 @@

Operand mapped_location = GenerateMappedArgumentsLookup(

masm, rdx, rcx, rbx, rdi, r8, &notin, &slow);

__ movq(mapped_location, rax);

+ __ lea(r9, mapped_location);

+ __ movq(r8, rax);

+ __ RecordWrite(rbx, r9, r8);

__ Ret();

__ bind(&notin);

// The unmapped lookup expects that the parameter map is in rbx.

Operand unmapped_location =

GenerateUnmappedArgumentsLookup(masm, rcx, rbx, rdi, &slow);

__ movq(unmapped_location, rax);

+ __ lea(r9, unmapped_location);

+ __ movq(r8, rax);

+ __ RecordWrite(rbx, r9, r8);

__ Ret();

__ bind(&slow);

GenerateMiss(masm, false);

« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | test/mjsunit/arguments-escape.js » ('j') | no next file with comments »