Add an option to run Chrome in the views desktop.

Add an option to run Chrome in the views desktop.
- Add a BrowserFrameViews stub.
- Add a NativeTabContentsViewViews stub.
- Allow the omnibox to run in pure-views mode on Windows too.
- Make the RenderWidgetHostViewViews build on Windows.

chrome --use-pure-views --views-desktop runs, shows a browser window, but doesn't really do anything else.

BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90242

[Ben Goodger (Google), 2011-06-21 21:00:35]

sadrul: render_widget_host_view_views*
sky/oshima: everything else

[sky, 2011-06-21 21:52:11]

I think you need to add views_desktop_lib to browser.gyp some how.

  -Scott

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/renderer_host...
File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/renderer_host...
chrome/browser/renderer_host/render_widget_host_view_views.cc:81: #if
defined(TOUCH_UI)
oi, ifdef heaven. Any chance of making this code a little easier to read?

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/loca...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/location_bar_view.cc:673: if
(suggested_text_view_ && !UseViewsOmnibox()) {
Do we need a NOTIMPLEMENTED for the UseViewsOmnibox case?

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/location_bar_view.cc:1249: // Returns true
if the views-based omnibox should be used. When false,
remove comment as its in the header.

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/tab_...
File chrome/browser/ui/views/tab_contents/native_tab_contents_view_views.cc
(right):

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_views.cc:55: 
nit: remove this line.

[oshima, 2011-06-21 22:36:07]

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/loca...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/location_bar_view.cc:1244: OmniboxViewWin*
LocationBarView::GetOmniboxViewWin() {
Looks like this shouldn't return NULL.

maybe CHECK/DCHECK(UseViewsOmnibox()) is better?

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/loca...
File chrome/browser/ui/views/location_bar/location_bar_view.h (right):

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/location_bar_view.h:349: #if
defined(OS_WIN)
we can get rid of if/def?

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/tab_...
File chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc
(right):

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc:267: return
new NativeTabContentsViewGtk(delegate);
I thought we dont have native gtk widget between RWHVViews and toplevel
NativeWidgetGtk. Do we still need NativeTabContetnsViewGtk? >> sadrul

http://codereview.chromium.org/7206055/diff/5024/views/views.gyp
File views/views.gyp (right):

http://codereview.chromium.org/7206055/diff/5024/views/views.gyp#newcode644
views/views.gyp:644: '..',
Don't we have to update this as well? (not 100% sure)

[Ben Goodger (Google), 2011-06-21 22:54:48]

Am currently building on Linux and will update this with build fixes + updates
to address these comments, but for now:

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/tab_...
File chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc
(right):

http://codereview.chromium.org/7206055/diff/5024/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc:267: return
new NativeTabContentsViewGtk(delegate);
On 2011/06/21 22:36:07, oshima wrote:
> I thought we dont have native gtk widget between RWHVViews and toplevel
> NativeWidgetGtk. Do we still need NativeTabContetnsViewGtk? >> sadrul

This class is used by the linux_view and linux_chromeos builds. For symmetry
with Windows the TabContents is a Widget, with a corresponding NativeWidget that
overrides some native event handling to receive certain events. 

linux_touch is still using TabContentsViewTouch, but I imagine it'll migrate
over to using TabContentsViewViews and NativeTabContentsViewViews at some point.

http://codereview.chromium.org/7206055/diff/5024/views/views.gyp
File views/views.gyp (right):

http://codereview.chromium.org/7206055/diff/5024/views/views.gyp#newcode644
views/views.gyp:644: '..',
On 2011/06/21 22:36:07, oshima wrote:
> Don't we have to update this as well? (not 100% sure)

Don't think so... it's the same for the other targets in this file...

[sky, 2011-06-21 23:19:50]

LGTM once you straighten out the gyp files.

[Ben Goodger (Google), 2011-06-21 23:26:25]

Updated.

[oshima, 2011-06-21 23:40:50]

LGTM with nits.

http://codereview.chromium.org/7206055/diff/1048/chrome/browser/ui/views/tab_...
File chrome/browser/ui/views/tab_contents/native_tab_contents_view_views.cc
(right):

http://codereview.chromium.org/7206055/diff/1048/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_views.cc:68: const
gfx::Point& image_offset) {
NOTIMPLEMENTED()

http://codereview.chromium.org/7206055/diff/1048/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_views.cc:79:
WebKit::WebDragOperation operation) {
ditto

[sadrul, 2011-06-22 01:49:05]

> sadrul: render_widget_host_view_views*

render_widget_host_view_views_gtk.cc scared me at first, but once I look at it
and ponder, it makes good sense. LGTM.

> sky/oshima: everything else