Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1988)

Unified Diff: chrome/chrome_exe.gypi

Issue 7206052: Trying to make the -pie stick for x64 on the main waterfall... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
===================================================================
--- chrome/chrome_exe.gypi (revision 89797)
+++ chrome/chrome_exe.gypi (working copy)
@@ -194,11 +194,21 @@
],
},
],
- # TODO(rkc): Remove this once we have a fix for remote gdb
- # and are able to correctly get section header offsets for
- # pie executables. Currently -pie breaks remote debugging.
+ # TODO(rkc): Remove disable_pie (and instead always use
+ # -pie) once we have a fix for remote gdb and are able to
+ # correctly get section header offsets for pie
+ # executables. Currently -pie breaks remote debugging.
['disable_pie==1', {
- 'ldflags' : ['-nopie'],
+ 'ldflags': ['-nopie'],
+ }, {
+ # Building with -fPIE fails on ARM and ia32 bots.
+ # http://code.google.com/p/chromium/issues/detail?id=57908
+ # Until that is fixed, at least use it on Linux 64-bit.
+ 'conditions': [
+ ['target_arch=="x64"', {
+ 'ldflags': ['-pie'],
+ }],
+ ],
}],
['use_system_xdg_utils==0', {
'copies': [
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698