Issue 7206040: Remove redundant hydrogen- and lithium instruction for symbol comparison.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7206040: Remove redundant hydrogen- and lithium instruction for symbol comparison. (Closed)

Created:
9 years, 6 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove redundant hydrogen- and lithium instruction for symbol comparison. We had two instructions HCompareJsObjectEq and HCompareSymbolEq that behave exactly the same. I removed one and renamed the remaining instruction into HCompareObjectEq. Committed: http://code.google.com/p/v8/source/detail?r=8349

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -285 lines)			Patch
M	src/arm/lithium-arm.h	View	2 chunks	+9 lines, -33 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	2 chunks	+5 lines, -19 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	3 chunks	+2 lines, -24 lines	0 comments	Download
M	src/hydrogen.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+6 lines, -8 lines	1 comment	Download
M	src/hydrogen-instructions.h	View	3 chunks	+4 lines, -39 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	3 chunks	+2 lines, -27 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	2 chunks	+9 lines, -33 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	2 chunks	+5 lines, -19 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	3 chunks	+2 lines, -27 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	2 chunks	+9 lines, -33 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	2 chunks	+5 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

9 years, 6 months ago (2011-06-21 10:41:19 UTC) #2

LGTM.

http://codereview.chromium.org/7206040/diff/1/src/hydrogen.cc
File src/hydrogen.cc (left):

http://codereview.chromium.org/7206040/diff/1/src/hydrogen.cc#oldcode5606
src/hydrogen.cc:5606: instr = BuildSymbolCompare(left, right, op);
Why is this factored out into a separate function, and the exact same four
lines, ten lines above, is not factored out?
Could these share code, except for the CheckInstanceType?

Expand Messages | Collapse Messages