Issue 7206023: Fix DoHasInstanceType on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7206023: Fix DoHasInstanceType on ARM (Closed)

Created:
9 years, 6 months ago by Jakob Kummerow

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, William Hesse, Do not use this email for V8

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix DoHasInstanceType on ARM Was broken by the recent JumpIfSmi() cleanup. TEST=es5conform Committed: http://code.google.com/p/v8/source/detail?r=8331

Patch Set 2 : Better fix that actually fixes the problem. #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/arm/lithium-codegen-arm.cc	View	1	1 chunk	+4 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

So far I fail to see why the first patch set didn't fix the issue... ...

9 years, 6 months ago (2011-06-20 12:32:40 UTC) #1

Do not use this email for V8

LGTM with comment removed. http://codereview.chromium.org/7206023/diff/2001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/7206023/diff/2001/src/arm/lithium-codegen-arm.cc#newcode1960 src/arm/lithium-codegen-arm.cc:1960: __ tst(input, Operand(kSmiTagMask)); The comment ...

9 years, 6 months ago (2011-06-20 12:41:46 UTC) #2

Søren Thygesen Gjesse

9 years, 6 months ago (2011-06-21 10:03:01 UTC) #3

Drive by

http://codereview.chromium.org/7206023/diff/2001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/7206023/diff/2001/src/arm/lithium-codegen-arm....
src/arm/lithium-codegen-arm.cc:1960: __ tst(input, Operand(kSmiTagMask));
Can't we just have a macro assembler instruction TestIfSmi for use in places
where the  condition code is used several times?

Expand Messages | Collapse Messages

Issue 7206023: Fix DoHasInstanceType on ARM (Closed)

Description

Patch Set 1 #

Patch Set 2 : Better fix that actually fixes the problem. #

Messages