Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 7206022: Made parser not accept unicode escapes inside "native" when used as a keyword. (Closed)

Created:
9 years, 6 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Made parser not accept unicode escapes inside "native" when used as a keyword. This is a regression relative to the original behavior, when "native" was a keyword, since keywords cannot contain esacpes. Added tests for escapes and for not allowing line-terminators betwen "native" and "function". Committed: http://code.google.com/p/v8/source/detail?r=8327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M src/parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
I remembered that identifiers can contain escapes, so we suddently accepted "nativ\u0065" where we didn't ...
9 years, 6 months ago (2011-06-20 11:11:25 UTC) #1
Mads Ager (chromium)
9 years, 6 months ago (2011-06-20 11:28:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698