Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 7206020: Make "native" not a keyword. (Closed)

Created:
9 years, 6 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make "native" not a keyword. We now only recognize "native function" when it occurs in extension scripts (parsing with a non-NULL extension), and only if there is no line-terminator between "native" and "function" (so that it would otherwise be a Syntax Error). Preparsing never recognizes native functions, which is acceptable since we never preparse extension scripts (because we don't allow lazy functions anyway). BUG=v8:1097 Committed: http://code.google.com/p/v8/source/detail?r=8326

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -60 lines) Patch
M src/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 5 chunks +15 lines, -11 lines 0 comments Download
M src/preparser.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/preparser.cc View 4 chunks +6 lines, -28 lines 0 comments Download
M src/preparser-api.cc View 1 chunk +0 lines, -1 line 2 comments Download
M src/scanner-base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/token.h View 2 chunks +1 line, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/object-literal.js View 3 chunks +2 lines, -3 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +0 lines, -4 lines 0 comments Download
M test/sputnik/sputnik.status View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 6 months ago (2011-06-20 07:58:37 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/7206020/diff/1/src/preparser-api.cc File src/preparser-api.cc (left): http://codereview.chromium.org/7206020/diff/1/src/preparser-api.cc#oldcode191 src/preparser-api.cc:191: Accidental edit?
9 years, 6 months ago (2011-06-20 09:24:13 UTC) #2
Lasse Reichstein
9 years, 6 months ago (2011-06-20 10:18:02 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698