src/v8natives.js - Issue 7206019: Fix "illegal access" when calling parseInt with a radix that is not a smi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 7206019: Fix "illegal access" when calling parseInt with a radix that is not a smi. (Closed) Base URL: https://v8.googlecode.com/svn/trunk

Patch Set: Rewrote tests and addressed comments. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/v8natives.js

diff --git a/src/v8natives.js b/src/v8natives.js

index 6ad4a0c75bdb1648492c56ced8170c61faa7749c..4710dc799b095c206dbcae4a11145af3494c86c3 100644

--- a/src/v8natives.js

+++ b/src/v8natives.js

@@ -106,11 +106,12 @@ function GlobalParseInt(string, radix) {

// Truncate number.

return string | 0;

}

- if (IS_UNDEFINED(radix)) radix = 0;

+ radix = radix || 0;

} else {

radix = TO_INT32(radix);

- if (!(radix == 0 || (2 <= radix && radix <= 36)))

+ if (!(radix == 0 || (2 <= radix && radix <= 36))) {

return $NaN;

+ }

}

string = TO_STRING_INLINE(string);

if (%_HasCachedArrayIndex(string) &&

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1246.js » ('j') | no next file with comments »