Fix "illegal access" when calling parseInt with a radix that is not a smi.

test/mjsunit/regress/regress-1246.js

Index: test/mjsunit/regress/regress-1246.js
diff --git a/test/mjsunit/regress/regress-1246.js b/test/mjsunit/regress/regress-1246.js
new file mode 100644
index 0000000000000000000000000000000000000000..0d5ef61d695ac07dc6b6bf2603c78fd4f7681df7
--- /dev/null
+++ b/test/mjsunit/regress/regress-1246.js
@@ -0,0 +1,49 @@
+// Copyright 2011 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//     * Redistributions of source code must retain the above copyright
+//       notice, this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above
+//       copyright notice, this list of conditions and the following
+//       disclaimer in the documentation and/or other materials provided
+//       with the distribution.
+//     * Neither the name of Google Inc. nor the names of its
+//       contributors may be used to endorse or promote products derived
+//       from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// This regression tests the behaviour of the parseInt function when
+// the given radix is not a SMI.
+
+assertEquals(NaN, parseInt("", -0));
+assertEquals(23, parseInt("23", -0));
+assertEquals(0xaf, parseInt("0xaf", -0));
+assertEquals(NaN, parseInt("z", -0));
+
+assertEquals(NaN, parseInt("", -2));
+assertEquals(NaN, parseInt("23", -2));
+assertEquals(NaN, parseInt("0xaf", -2));
+assertEquals(NaN, parseInt("z", -2));
+
+assertEquals(NaN, parseInt("", 10.1));
+assertEquals(23, parseInt("23", 10.1));
+assertEquals(0, parseInt("0xaf", 10.1));
+assertEquals(NaN, parseInt("z", 10.1));
+
+assertEquals(NaN, parseInt("", "a"));
+assertEquals(23, parseInt("23", "a"));
+assertEquals(0xaf, parseInt("0xaf", "a"));
+assertEquals(NaN, parseInt("z", "a"));

[Lasse Reichstein, 2011/06/28 08:32:21]

Good tests.
How about also trying a string with a number (e.g. "10") as radix. 
And NaN and Infinity as radix (they should convert to 0 using ToInt32, so it
shoud work as base-10, but especially NaN can be tricky in comparisons).

[Steven, 2011/06/28 10:10:35]

I've included those cases and rewrote the tests by classifying the radix
argument values by which "radix mode" they will result in.
On 2011/06/28 08:32:21, Lasse Reichstein wrote: