Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: test/mjsunit/regress/regress-1246.js

Issue 7206019: Fix "illegal access" when calling parseInt with a radix that is not a smi. (Closed) Base URL: https://v8.googlecode.com/svn/trunk
Patch Set: Rewrote tests and addressed comments. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/v8natives.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are
4 // met:
5 //
6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission.
15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27
28 // This regression tests the behaviour of the parseInt function when
29 // the given radix is not a SMI.
30
31
32 // Giving these values as the radix argument triggers radix detection.
33 var radix_detect = [0, -0, NaN, Infinity, -Infinity, undefined, null,
34 "0", "-0", "a"];
35
36 // These values will result in an integer radix outside of the valid range.
37 var radix_invalid = [1, 37, -2, "-2", "37"];
38
39 // These values will trigger decimal parsing.
40 var radix10 = [10, 10.1, "10", "10.1"];
41
42 // These values will trigger hexadecimal parsing.
43 var radix16 = [16, 16.1, 0x10, "0X10"];
44
45 for (var i = 0; i < radix_detect.length; i++) {
46 var radix = radix_detect[i];
47 assertEquals(NaN, parseInt("", radix));
48 assertEquals(23, parseInt("23", radix));
49 assertEquals(0xaf, parseInt("0xaf", radix));
50 assertEquals(NaN, parseInt("af", radix));
51 }
52
53 for (var i = 0; i < radix_invalid.length; i++) {
54 var radix = radix_invalid[i];
55 assertEquals(NaN, parseInt("", radix));
56 assertEquals(NaN, parseInt("23", radix));
57 assertEquals(NaN, parseInt("0xaf", radix));
58 assertEquals(NaN, parseInt("af", radix));
59 }
60
61 for (var i = 0; i < radix10.length; i++) {
62 var radix = radix10[i];
63 assertEquals(NaN, parseInt("", radix));
64 assertEquals(23, parseInt("23", radix));
65 assertEquals(0, parseInt("0xaf", radix));
66 assertEquals(NaN, parseInt("af", radix));
67 }
68
69 for (var i = 0; i < radix16.length; i++) {
70 var radix = radix16[i];
71 assertEquals(NaN, parseInt("", radix));
72 assertEquals(0x23, parseInt("23", radix));
73 assertEquals(0xaf, parseInt("0xaf", radix));
74 assertEquals(0xaf, parseInt("af", radix));
75 }
OLDNEW
« no previous file with comments | « src/v8natives.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698