Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 7205030: Restore accidentally deleted src/extensions/experimental/i18n.js (Closed)

Created:
9 years, 6 months ago by William Hesse
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Restore accidentally deleted src/extensions/experimental/i18n.js Committed: http://code.google.com/p/v8/source/detail?r=8335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -0 lines) Patch
A src/extensions/experimental/i18n.js View 1 chunk +273 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
William Hesse
9 years, 6 months ago (2011-06-20 14:13:19 UTC) #1
Søren Thygesen Gjesse
LGTM
9 years, 6 months ago (2011-06-20 14:13:46 UTC) #2
Nebojša Ćirić
Why not just revert the change that deleted the file? This approach created a new ...
9 years, 6 months ago (2011-06-23 00:44:54 UTC) #3
William Hesse
9 years, 6 months ago (2011-06-23 10:25:08 UTC) #4
On 2011/06/23 00:44:54, Nebojša Ćirić wrote:
> Why not just revert the change that deleted the file?

The change that deleted this file was a massive merge from an experimental
branch, touching many files.  The merge to trunk already happened, and the
i18n.js file from trunk was untouched.  So the file has its full history in
trunk, in branches 3.3, 3.2, etc.  In bleeding edge, the new file has no
history, and the history of the old version exists if you revert bleeding-edge
to a version before 8315.

Powered by Google App Engine
This is Rietveld 408576698