Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4772)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser_list.cc

Issue 7205026: Don't rely on user gestures for deciding when to dismiss infobars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_init.cc ('k') | chrome/browser/ui/cocoa/keystone_infobar.mm » ('j') | content/browser/tab_contents/navigation_details.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_list.cc
===================================================================
--- chrome/browser/ui/browser_list.cc (revision 89628)
+++ chrome/browser/ui/browser_list.cc (working copy)
@@ -52,7 +52,7 @@
DCHECK(type == NotificationType::NAV_ENTRY_COMMITTED);
const content::LoadCommittedDetails& load =
*Details<content::LoadCommittedDetails>(details).ptr();
- if (!load.is_main_frame || load.is_auto || load.is_in_page)
+ if (!load.is_navigation_to_different_page())
return; // Don't log for subframes or other trivial types.
LogRenderProcessHostCount();
« no previous file with comments | « chrome/browser/ui/browser_init.cc ('k') | chrome/browser/ui/cocoa/keystone_infobar.mm » ('j') | content/browser/tab_contents/navigation_details.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698