Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8281)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/translate/translate_infobar_delegate.cc

Issue 7205026: Don't rely on user gestures for deciding when to dismiss infobars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/infobar_delegate.cc ('k') | chrome/browser/ui/browser_init.cc » ('j') | content/browser/tab_contents/navigation_details.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_infobar_delegate.cc
===================================================================
--- chrome/browser/translate/translate_infobar_delegate.cc (revision 89628)
+++ chrome/browser/translate/translate_infobar_delegate.cc (working copy)
@@ -358,7 +358,7 @@
const content::LoadCommittedDetails& details) const {
// Note: we allow closing this infobar even if the main frame navigation
// was programmatic and not initiated by the user - crbug.com/70261 .
- if (!details.is_user_initiated_main_frame_load() && !details.is_main_frame)
+ if (!details.is_navigation_to_different_page() && !details.is_main_frame)
return false;
return InfoBarDelegate::ShouldExpireInternal(details);
« no previous file with comments | « chrome/browser/tab_contents/infobar_delegate.cc ('k') | chrome/browser/ui/browser_init.cc » ('j') | content/browser/tab_contents/navigation_details.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698