Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 7205023: (draft) Random fixes to D8 (Closed)

Created:
9 years, 6 months ago by Peter Rybin
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

(draft) Random fixes to D8

Patch Set 1 #

Patch Set 2 : clean #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/d8.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/d8-debug.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Rybin
Hi Soren D8 seems to be broken. At least I failed to run it as: ...
9 years, 6 months ago (2011-06-19 22:02:17 UTC) #1
Peter Rybin
[now to a chromium address] Hi Soren D8 seems to be broken. At least I ...
9 years, 6 months ago (2011-06-21 19:17:07 UTC) #2
Søren Thygesen Gjesse
LGTM
9 years, 6 months ago (2011-06-21 19:48:33 UTC) #3
Peter Rybin
On 2011/06/21 19:48:33, Søren Gjesse wrote: > LGTM I just wanted to double check that ...
9 years, 6 months ago (2011-06-22 00:29:07 UTC) #4
Yang
On 2011/06/22 00:29:07, Peter Rybin wrote: > On 2011/06/21 19:48:33, Søren Gjesse wrote: > > ...
9 years, 6 months ago (2011-06-22 17:03:47 UTC) #5
Peter Rybin
Thanks you, Yang. On 2011/06/22 17:03:47, yangguo wrote: > On 2011/06/22 00:29:07, Peter Rybin wrote: ...
9 years, 6 months ago (2011-06-22 17:25:01 UTC) #6
Yang
9 years, 6 months ago (2011-06-26 18:14:52 UTC) #7
Included this in issue 7219003.

On 2011/06/22 17:25:01, Peter Rybin wrote:
> Thanks you, Yang.
> 
> On 2011/06/22 17:03:47, yangguo wrote:
> > On 2011/06/22 00:29:07, Peter Rybin wrote:
> > > On 2011/06/21 19:48:33, Søren Gjesse wrote:
> > > > LGTM
> > > 
> > > I just wanted to double check that this CL is pretty much random -- I
> contains
> > > only those fixes I had to do to make D8 working, i.e. I haven't analyzed
> code
> > > much.
> > 
> > I have exactly those changes already in my CL as I found those issues
> yesterday
> > too. I'll commit those together with my CL.

Powered by Google App Engine
This is Rietveld 408576698