Issue 7205011: Revert 89532 - Not allow compression when requesting multimedia

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7205011: Revert 89532 - Not allow compression when requesting multimedia (Closed)

Created:
9 years, 6 months ago by akalin

Modified:
9 years, 6 months ago

Reviewers:
enal

CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 89532 - Not allow compression when requesting multimedia because ffmpeg does not expect compressed files. (It does not make sense to compress audio/video anyways...) http://codereview.chromium.org/7044092 BUG=47381 TEST=http://www.deafmac.org/html5/grinchsample.mp4 (Please clear browser cache, otherwise it can contain original GZIP-ed file requested by old browser) Review URL: http://codereview.chromium.org/7044092 TBR=enal@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89546

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -124 lines)			Patch
M	media/filters/ffmpeg_demuxer.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	net/url_request/url_request_http_job.cc	View	1 chunk	+45 lines, -55 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	webkit/glue/media/buffered_resource_loader.cc	View	2 chunks	+4 lines, -10 lines	0 comments	Download
M	webkit/glue/media/buffered_resource_loader_unittest.cc	View	4 chunks	+1 line, -14 lines	0 comments	Download
M	webkit/glue/media/simple_data_source.cc	View	2 chunks	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages