Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: base/platform_file_unittest.cc

Issue 7205001: Mark TouchGetInfoPlatformFile as Flaky on Mac OS X. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/platform_file_unittest.cc
diff --git a/base/platform_file_unittest.cc b/base/platform_file_unittest.cc
index 35afdf843afb5560e00969927f53d4f6d013edc9..6ce0d1c675979ea8a733588c8dc6b4cff2dd479e 100644
--- a/base/platform_file_unittest.cc
+++ b/base/platform_file_unittest.cc
@@ -249,6 +249,11 @@ TEST(PlatformFile, TruncatePlatformFile) {
base::ClosePlatformFile(file);
}
+#if defined(OS_MACOSX)
+// Flakily fails: http://crbug.com/86494
+#define MAYBE_TouchGetInfoPlatformFile \
+ FLAKY_TouchGetInfoPlatformFile
joth 2011/06/17 14:08:27 this will go on one line
Leandro Gracia Gil 2011/06/17 14:12:44 Done.
+#endif
joth 2011/06/17 14:08:27 and a default else clause mapping MAYBE_TouchGetIn
Leandro Gracia Gil 2011/06/17 14:12:44 Done.
TEST(PlatformFile, TouchGetInfoPlatformFile) {
joth 2011/06/17 14:08:27 rename the test to MAYBE_TouchGetInfoPlatformFile
Leandro Gracia Gil 2011/06/17 14:12:44 Done.
ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698