Mark TouchGetInfoPlatformFile as Flaky on Mac OS X.

Mark TouchGetInfoPlatformFile as Flaky on Mac OS X.


BUG=86494
TEST=PlatformFile.TouchGetInfoPlatformFile

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89479

[joth, 2011-06-17 14:08:27]

Almost :-)

http://codereview.chromium.org/7205001/diff/1/base/platform_file_unittest.cc
File base/platform_file_unittest.cc (right):

http://codereview.chromium.org/7205001/diff/1/base/platform_file_unittest.cc#...
base/platform_file_unittest.cc:255: FLAKY_TouchGetInfoPlatformFile
this will go on one line

http://codereview.chromium.org/7205001/diff/1/base/platform_file_unittest.cc#...
base/platform_file_unittest.cc:256: #endif
and a default else clause mapping MAYBE_TouchGetInfoPlatformFile =>
TouchGetInfoPlatformFile

http://codereview.chromium.org/7205001/diff/1/base/platform_file_unittest.cc#...
base/platform_file_unittest.cc:257: TEST(PlatformFile, TouchGetInfoPlatformFile)
{
rename the test to MAYBE_TouchGetInfoPlatformFile for the above defines to work

[Leandro Gracia Gil, 2011-06-17 14:12:44]

http://codereview.chromium.org/7205001/diff/1/base/platform_file_unittest.cc
File base/platform_file_unittest.cc (right):

http://codereview.chromium.org/7205001/diff/1/base/platform_file_unittest.cc#...
base/platform_file_unittest.cc:255: FLAKY_TouchGetInfoPlatformFile
On 2011/06/17 14:08:27, joth wrote:
> this will go on one line

Done.

http://codereview.chromium.org/7205001/diff/1/base/platform_file_unittest.cc#...
base/platform_file_unittest.cc:256: #endif
On 2011/06/17 14:08:27, joth wrote:
> and a default else clause mapping MAYBE_TouchGetInfoPlatformFile =>
> TouchGetInfoPlatformFile

Done.

http://codereview.chromium.org/7205001/diff/1/base/platform_file_unittest.cc#...
base/platform_file_unittest.cc:257: TEST(PlatformFile, TouchGetInfoPlatformFile)
{
On 2011/06/17 14:08:27, joth wrote:
> rename the test to MAYBE_TouchGetInfoPlatformFile for the above defines to
work

Done.

[joth, 2011-06-17 14:14:20]

LGTM

feel free to use commit queue or land manually as you prefer