Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 7204054: Minor change to Doxyfile and removefiles (added one file to remove). (Closed)

Created:
9 years, 6 months ago by jond
Modified:
9 years, 5 months ago
Reviewers:
Matt Ball
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Minor change to Doxyfile (updated to 1.7.4) and removefiles (added one file to remove). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90784

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -30 lines) Patch
M ppapi/c/documentation/Doxyfile View 1 2 19 chunks +84 lines, -25 lines 2 comments Download
M ppapi/c/documentation/removefilesC.sh View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jond
9 years, 6 months ago (2011-06-23 19:18:49 UTC) #1
Matt Ball
http://codereview.chromium.org/7204054/diff/4001/ppapi/c/documentation/Doxyfile File ppapi/c/documentation/Doxyfile (right): http://codereview.chromium.org/7204054/diff/4001/ppapi/c/documentation/Doxyfile#newcode1673 ppapi/c/documentation/Doxyfile:1673: DOT_PATH = /usr/local/graphviz-2.14/bin If possible, I'd prefer that this ...
9 years, 6 months ago (2011-06-23 19:21:50 UTC) #2
jond
http://codereview.chromium.org/7204054/diff/4001/ppapi/c/documentation/Doxyfile File ppapi/c/documentation/Doxyfile (right): http://codereview.chromium.org/7204054/diff/4001/ppapi/c/documentation/Doxyfile#newcode1673 ppapi/c/documentation/Doxyfile:1673: DOT_PATH = /usr/local/graphviz-2.14/bin On 2011/06/23 19:21:50, Matt Ball wrote: ...
9 years, 5 months ago (2011-06-28 15:36:42 UTC) #3
Matt Ball
9 years, 5 months ago (2011-06-28 16:44:40 UTC) #4
LGTM

I don't like it, but if it's easier for the default setup for the docs folks
then I won't complain... :)

Cheers,
-Matt

On Tue, Jun 28, 2011 at 9:36 AM, <jond@google.com> wrote:

>
> http://codereview.chromium.**org/7204054/diff/4001/ppapi/c/**
>
documentation/Doxyfile<http://codereview.chromium.org/7204054/diff/4001/ppapi/c/documentation/Doxyfile>
> File ppapi/c/documentation/Doxyfile (right):
>
> http://codereview.chromium.**org/7204054/diff/4001/ppapi/c/**
>
documentation/Doxyfile#**newcode1673<http://codereview.chromium.org/7204054/diff/4001/ppapi/c/documentation/Doxyfile#newcode1673>
> ppapi/c/documentation/**Doxyfile:1673: DOT_PATH               =
> /usr/local/graphviz-2.14/bin
> On 2011/06/23 19:21:50, Matt Ball wrote:
>
>> If possible, I'd prefer that this hard-coded path not be checked-in.
>>
>
> I talked to Josie about this one. She wants the default path in there so
> any documentation folks who come along and take this over will likely
> have success on first try.
>
>
>
http://codereview.chromium.**org/7204054/<http://codereview.chromium.org/7204...
>

Powered by Google App Engine
This is Rietveld 408576698