Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Issue 7204047: Fix HandleDocumentLoad for nexes that get their content that way. (Closed)

Created:
9 years, 6 months ago by elijahtaylor (use chromium)
Modified:
9 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge with HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/trusted/plugin/ppapi/plugin_ppapi.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
elijahtaylor (use chromium)
9 years, 6 months ago (2011-06-20 23:41:44 UTC) #1
Erik does not do reviews
9 years, 6 months ago (2011-06-21 18:39:16 UTC) #2
LGTM

Per offline discussion, please follow-up to understand how/when this
resource will get cleaned up.

Erik


On Mon, Jun 20, 2011 at 4:41 PM, <elijahtaylor@google.com> wrote:

> Reviewers: Erik Kay,
>
> Description:
> Fix HandleDocumentLoad for nexes that get their content that way.
>
> BUG=
> http://code.google.com/p/**nativeclient/issues/detail?id=**
>
1926,http://code.google.com/p/**nativeclient/issues/detail?id=**1931<http://code.google.com/p/nativeclient/issues/detail?id=1926,http://code.google.com/p/nativeclient/issues/detail?id=1931>
> TEST= manual
>
>
> Please review this at
http://codereview.chromium.**org/7204047/<http://codereview.chromium.org/7204...
>
> SVN Base:
svn://svn.chromium.org/native_**client/trunk/src/native_client<http://svn.chromium.org/native_client/trunk/src/native_client>
>
> Affected files:
>  M src/trusted/plugin/ppapi/**plugin_ppapi.cc
>
>
> Index: src/trusted/plugin/ppapi/**plugin_ppapi.cc
> diff --git a/src/trusted/plugin/ppapi/**plugin_ppapi.cc
> b/src/trusted/plugin/ppapi/**plugin_ppapi.cc
> index 8e54d9f4d6dbb6310d503c63f21dbc**a15b79c62f..**
> 5fc8507985f8eb76d88b36338b15b7**c44692ebd5 100644
> --- a/src/trusted/plugin/ppapi/**plugin_ppapi.cc
> +++ b/src/trusted/plugin/ppapi/**plugin_ppapi.cc
> @@ -642,9 +642,9 @@ bool PluginPpapi::**HandleDocumentLoad(const
> pp::URLLoader& url_loader) {
>     // Store this event and replay it when the proxy becomes available.
>     replayHandleDocumentLoad = true;
>     replayHandleDocumentLoadURLLoa**der = url_loader;
> -    // Returning false allows the caller release its reference to the
> -    // URL loader.
> -    return false;
> +    // Return true so that the browser keeps servicing this loader so we
> can
> +    // perform requests on it later.
> +    return true;
>   } else {
>     return pp::PPBoolToBool(
>         ppapi_proxy_->ppp_instance_**interface()->**HandleDocumentLoad(
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

Powered by Google App Engine
This is Rietveld 408576698