Issue 7203005: Cleanup extra initialization of TickSample fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7203005: Cleanup extra initialization of TickSample fields. (Closed)

Created:
9 years, 6 months ago by mnaganov (inactive)

Modified:
9 years, 6 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Cleanup extra initialization of TickSample fields. R=vitalyr@chromium.org BUG=1293 Committed: http://code.google.com/p/v8/source/detail?r=8368

Patch Set 1 #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -24 lines)			Patch
M	src/cpu-profiler.h	View	2 chunks	+1 line, -3 lines	2 comments	Download
M	src/cpu-profiler.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/cpu-profiler-inl.h	View	2 chunks	+2 lines, -14 lines	0 comments	Download
M	src/log.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

LGTM http://codereview.chromium.org/7203005/diff/1/src/cpu-profiler.h File src/cpu-profiler.h (right): http://codereview.chromium.org/7203005/diff/1/src/cpu-profiler.h#newcode111 src/cpu-profiler.h:111: TickSampleEventRecord() Should it take order as a parameter?

9 years, 6 months ago (2011-06-22 12:58:06 UTC) #2

mnaganov (inactive)

9 years, 6 months ago (2011-06-22 13:33:14 UTC) #3

http://codereview.chromium.org/7203005/diff/1/src/cpu-profiler.h
File src/cpu-profiler.h (right):

http://codereview.chromium.org/7203005/diff/1/src/cpu-profiler.h#newcode111
src/cpu-profiler.h:111: TickSampleEventRecord()
On 2011/06/22 12:58:07, Vitaly Repeshko wrote:
> Should it take order as a parameter?

Done.

Expand Messages | Collapse Messages