Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 7203005: Cleanup extra initialization of TickSample fields. (Closed)

Created:
9 years, 6 months ago by mnaganov (inactive)
Modified:
9 years, 6 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Cleanup extra initialization of TickSample fields. R=vitalyr@chromium.org BUG=1293 Committed: http://code.google.com/p/v8/source/detail?r=8368

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M src/cpu-profiler.h View 2 chunks +1 line, -3 lines 2 comments Download
M src/cpu-profiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/cpu-profiler-inl.h View 2 chunks +2 lines, -14 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mnaganov (inactive)
9 years, 6 months ago (2011-06-17 20:21:00 UTC) #1
Vitaly Repeshko
LGTM http://codereview.chromium.org/7203005/diff/1/src/cpu-profiler.h File src/cpu-profiler.h (right): http://codereview.chromium.org/7203005/diff/1/src/cpu-profiler.h#newcode111 src/cpu-profiler.h:111: TickSampleEventRecord() Should it take order as a parameter?
9 years, 6 months ago (2011-06-22 12:58:06 UTC) #2
mnaganov (inactive)
9 years, 6 months ago (2011-06-22 13:33:14 UTC) #3
http://codereview.chromium.org/7203005/diff/1/src/cpu-profiler.h
File src/cpu-profiler.h (right):

http://codereview.chromium.org/7203005/diff/1/src/cpu-profiler.h#newcode111
src/cpu-profiler.h:111: TickSampleEventRecord()
On 2011/06/22 12:58:07, Vitaly Repeshko wrote:
> Should it take order as a parameter?

Done.

Powered by Google App Engine
This is Rietveld 408576698