chrome/renderer/print_web_view_helper.cc - Issue 7202012: Print Preview: Display a throbber when the user requests the system print

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper.cc

Issue 7202012: Print Preview: Display a throbber when the user requests the system print (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review fix. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/print_web_view_helper.cc

diff --git a/chrome/renderer/print_web_view_helper.cc b/chrome/renderer/print_web_view_helper.cc

index 408d48046b0a33a4c6af8d96dc9c3f18d2ec2743..5e8355bce9b48756fe6daf8dd246cc805d2b6137 100644

--- a/chrome/renderer/print_web_view_helper.cc

+++ b/chrome/renderer/print_web_view_helper.cc

@@ -670,6 +670,8 @@ bool PrintWebViewHelper::GetPrintSettingsFromUser(WebKit::WebFrame* frame,

params.expected_pages_count = expected_pages_count;

params.use_overlays = use_browser_overlays;

+ Send(new PrintHostMsg_DidShowPrintDialog(routing_id()));

print_pages_params_.reset();

IPC::SyncMessage* msg =

new PrintHostMsg_ScriptedPrint(routing_id(), params, &print_settings);

« no previous file with comments | « chrome/renderer/print_web_view_helper.h ('k') | no next file » | no next file with comments »