Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3901)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/print_preview/print_preview.html

Issue 7202012: Print Preview: Display a throbber when the user requests the system print (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/print_preview/print_preview.css ('k') | chrome/browser/resources/print_preview/print_preview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/print_preview.html
diff --git a/chrome/browser/resources/print_preview/print_preview.html b/chrome/browser/resources/print_preview/print_preview.html
index abecd7c4ed00752e5a8a5da6b9143cc8fe2298db..8f06c8c925a206c07a5f0e27747e434b97287fa2 100644
--- a/chrome/browser/resources/print_preview/print_preview.html
+++ b/chrome/browser/resources/print_preview/print_preview.html
@@ -5,6 +5,7 @@
<title i18n-content="title"></title>
<link rel="icon" href="../../../app/theme/print_preview_favicon.png">
<link rel="stylesheet" href="../webui.css">
+<link rel="stylesheet" href="chrome://resources/css/throbber.css">
<link rel="stylesheet" href="print_preview.css">
<script src="chrome://resources/js/local_strings.js"></script>
<script src="chrome://resources/js/cr.js"></script>
@@ -14,13 +15,13 @@
<script src="print_preview_utils.js"></script>
</head>
<body>
- <div class="sidebar">
+ <div id="sidebar">
<header>
<h1 i18n-content="title"></h1>
<div id="print-header">
<span id="print-summary"></span>
- <button id="print-button" i18n-content="printButton" class="default"
- autofocus></button>
+ <button id="print-button" i18n-content="printButton" class="default">
+ </button>
<button id="cancel-button" i18n-content="cancelButton"></button>
</div>
</header>
@@ -105,8 +106,10 @@
</div>
<hr>
<div id="system-dialog-div">
- <a id="system-dialog-link" href="#"
- i18n-content="systemDialogOption"></a>
+ <button id="system-dialog-link" class="link-button"
+ i18n-content="systemDialogOption"></button>
+ <!-- TODO(dpapad): Investigate whey hidden attribute does not work. -->
+ <div id="system-dialog-throbber" class="throbber hidden"></div>
</div>
</div>
</div>
@@ -118,13 +121,15 @@
<span><span>.</span><span>.</span><span>.</span></span>
</div>
<div id="error-text" class="hidden"></div>
- <br>
- <button id="error-button" class="hidden"></button>
+ <div id="error-action-area">
+ <button id="error-button" class="hidden"></button>
+ <div id="native-print-dialog-throbber" class="throbber hidden"></div>
+ </div>
</div>
</div>
</div>
<object id="dummy-viewer"
type="application/x-google-chrome-print-preview-pdf"
- src="chrome://print/dummy.pdf"/>
+ src="chrome://print/dummy.pdf"></object>
</body>
</html>
« no previous file with comments | « chrome/browser/resources/print_preview/print_preview.css ('k') | chrome/browser/resources/print_preview/print_preview.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698