Chromium Code Reviews| Index: content/common/gpu/gpu_channel.cc |
| diff --git a/content/common/gpu/gpu_channel.cc b/content/common/gpu/gpu_channel.cc |
| index 003160203f2713c604d2e0f15f3f85771de83613..595e8dd16dc3c00e4f68dc11c1940630998820f6 100644 |
| --- a/content/common/gpu/gpu_channel.cc |
| +++ b/content/common/gpu/gpu_channel.cc |
| @@ -212,7 +212,7 @@ bool GpuChannel::OnControlMessageReceived(const IPC::Message& msg) { |
| OnAssignTexturesToVideoDecoder) |
| IPC_MESSAGE_UNHANDLED(handled = false) |
| IPC_END_MESSAGE_MAP() |
| - DCHECK(handled); |
| + DCHECK(handled) << msg.type(); |
| return handled; |
| } |
| @@ -325,6 +325,12 @@ void GpuChannel::OnCreateVideoDecoder(int32 decoder_host_id, |
| int32 decoder_id = GenerateRouteID(); |
| + // TODO(fischman): this is a BUG. We hand off stub->scheduler()->decoder() |
| + // to be baked into the resulting GpuVideoDecodeAccelerator, but we don't own |
| + // that GVDA, and we make no attempt to tear it down if/when |
| + // stub->scheduler()->decoder() is destroyed. GpuVideoService should be |
| + // subsumed into this class and GpuVideoDecodeAccelerator should be owned by |
| + // the GpuCommandBufferStub that owns the commandbuffer GVDA is using. |
|
vrk (LEFT CHROMIUM)
2011/06/20 22:22:17
Yes, this makes a lot more sense to me!
|
| bool ret = service->CreateVideoDecoder( |
| this, &router_, decoder_host_id, decoder_id, stub->scheduler()->decoder(), |
| configs); |