Issue 7200024: Issue 1418: Debug: extends setBreakpoint API to accept partial script name as a parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7200024: Issue 1418: Debug: extends setBreakpoint API to accept partial script name as a parameter (Closed)

Created:
9 years, 6 months ago by Peter Rybin

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Issue 1418: Debug: extends setBreakpoint API to accept partial script name as a parameter Committed: http://code.google.com/p/v8/source/detail?r=8355

Patch Set 3 : write 'object' #

Patch Set 4 : actual location, d8 command #

Patch Set 5 : drop v8-debug.cc #

Patch Set 7 : follow codereview #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -18 lines)			Patch
	M	src/d8.js	View	1 2 3	2 chunks	+9 lines, -1 line	0 comments	Download
	M	src/debug-debugger.js	View	1 2 3 4 5 6	11 chunks	+59 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGMT http://codereview.chromium.org/7200024/diff/1005/src/debug-debugger.js File src/debug-debugger.js (right): http://codereview.chromium.org/7200024/diff/1005/src/debug-debugger.js#newcode1663 src/debug-debugger.js:1663: throw new Error("Unexpected breakpoint type: " + break_point.type()); ...

9 years, 6 months ago (2011-06-21 08:04:40 UTC) #2

Peter Rybin

9 years, 6 months ago (2011-06-21 19:18:30 UTC) #3

http://codereview.chromium.org/7200024/diff/1005/src/debug-debugger.js
File src/debug-debugger.js (right):

http://codereview.chromium.org/7200024/diff/1005/src/debug-debugger.js#newcod...
src/debug-debugger.js:1663: throw new Error("Unexpected breakpoint type: " +
break_point.type());
On 2011/06/21 08:04:40, Søren Gjesse wrote:
> Maybe this message should start with "Internal error", as it is not related to
a
> bad request.

Good point.
Done.

http://codereview.chromium.org/7200024/diff/1005/src/debug-debugger.js#newcod...
src/debug-debugger.js:1800: throw new Error("Unexpected breakpoint type: " +
break_point.type());
On 2011/06/21 08:04:40, Søren Gjesse wrote:
> Ditto.

Done.