Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 720001: Correct handling of adding a string and a smal integer... (Closed)

Created:
10 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Correct handling of adding a string and a smal integer The fast case of looking up the string convertion of the smi did not handle the case where left/reghe operands could be in eax/edx instead of edx/eax which is the default. Also got rid of creating an internal frame for calling string and instead patched the argument on the stack and performed a tail call. BUG=http://code.google.com/p/v8/issues/detail?id=636 TEST=test/mjsunit/regress/regress-636.js Committed: http://code.google.com/p/v8/source/detail?r=4061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -24 lines) Patch
M src/ia32/codegen-ia32.cc View 2 chunks +25 lines, -24 lines 0 comments Download
A test/mjsunit/regress/regress-636.js View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-09 08:53:52 UTC) #1
Erik Corry
10 years, 9 months ago (2010-03-09 09:07:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698