Issue 7198030: app: Trim down the dependency list of app_base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7198030: app: Trim down the dependency list of app_base. (Closed)

Created:
9 years, 5 months ago by tfarina

Modified:
9 years, 5 months ago

Reviewers:
cmp, tony

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

app: Trim down the dependency list of app_base. BUG=72317 TEST=app_unittests R=cmp@chromium.org, tony@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91385

Patch Set 2 : speculative fix for win_shared #

Patch Set 3 : include base_static instead of app_base #

Total comments: 2

Patch Set 4 : tony review #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -13 lines)			Patch
M	app/app_base.gypi	View	1 2 3	1 chunk	+3 lines, -12 lines	0 comments	Download
M	ui/ui_base.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

cmp win_shared compiled. Tony, I need this to reland http://codereview.chromium.org/7294007/ Please, take a look. Sending ...

9 years, 5 months ago (2011-07-01 20:18:46 UTC) #1

tony

http://codereview.chromium.org/7198030/diff/1002/app/app_base.gypi File app/app_base.gypi (right): http://codereview.chromium.org/7198030/diff/1002/app/app_base.gypi#newcode33 app/app_base.gypi:33: # Local Variables: Please don't add this. I'm going ...

9 years, 5 months ago (2011-07-01 20:58:37 UTC) #2