Issue 7198025: Adds --enable-sync-oauth, enabling INFO logging of oauth_token cookies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7198025: Adds --enable-sync-oauth, enabling INFO logging of oauth_token cookies (Closed)

Created:
9 years, 6 months ago by Rick Campbell

Modified:
9 years, 6 months ago

Reviewers:
Andrew T Wilson (Slow), akalin, tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Adds --enable-sync-oauth, enabling INFO logging of oauth_token cookies BUG=87404 TEST=Run with --enable-sync-oauth, grep log for COOKIE_CHANGED Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90421 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90440

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -0 lines)			Patch
M	chrome/browser/sync/profile_sync_service.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1	5 chunks	+65 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

tim (not reviewing)

On 2011/06/24 15:53:12, Rick Campbell wrote: > Please take a look Only one comment - ...

9 years, 6 months ago (2011-06-24 16:33:58 UTC) #2

tim (not reviewing)

LGTM (as we discussed offline, most of this won't be permanent)

9 years, 6 months ago (2011-06-24 19:43:48 UTC) #3

Rick Campbell

Please take another look. The previous submit added a header to profile_sync_service.h which caused a ...

9 years, 6 months ago (2011-06-24 21:08:25 UTC) #4

LGTM