Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/conversions.cc

Issue 7193045: Make preparser detect duplicate parameters and object literal properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed review comments. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/conversions.h ('k') | src/dtoa.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include <stdarg.h> 28 #include <stdarg.h>
29 #include <math.h>
29 #include <limits.h> 30 #include <limits.h>
30 31
31 #include "conversions-inl.h" 32 #include "conversions-inl.h"
32 #include "dtoa.h" 33 #include "dtoa.h"
33 #include "scanner-base.h" 34 #include "scanner-base.h"
34 #include "strtod.h" 35 #include "strtod.h"
35 #include "utils.h" 36 #include "utils.h"
36 37
37 namespace v8 { 38 namespace v8 {
38 namespace internal { 39 namespace internal {
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 384
384 // Get the integer part and the decimal part. 385 // Get the integer part and the decimal part.
385 double integer_part = floor(value); 386 double integer_part = floor(value);
386 double decimal_part = value - integer_part; 387 double decimal_part = value - integer_part;
387 388
388 // Convert the integer part starting from the back. Always generate 389 // Convert the integer part starting from the back. Always generate
389 // at least one digit. 390 // at least one digit.
390 int integer_pos = kBufferSize - 2; 391 int integer_pos = kBufferSize - 2;
391 do { 392 do {
392 integer_buffer[integer_pos--] = 393 integer_buffer[integer_pos--] =
393 chars[static_cast<int>(modulo(integer_part, radix))]; 394 chars[static_cast<int>(fmod(integer_part, radix))];
394 integer_part /= radix; 395 integer_part /= radix;
395 } while (integer_part >= 1.0); 396 } while (integer_part >= 1.0);
396 // Sanity check. 397 // Sanity check.
397 ASSERT(integer_pos > 0); 398 ASSERT(integer_pos > 0);
398 // Add sign if needed. 399 // Add sign if needed.
399 if (is_negative) integer_buffer[integer_pos--] = '-'; 400 if (is_negative) integer_buffer[integer_pos--] = '-';
400 401
401 // Convert the decimal part. Repeatedly multiply by the radix to 402 // Convert the decimal part. Repeatedly multiply by the radix to
402 // generate the next char. Never generate more than kBufferSize - 1 403 // generate the next char. Never generate more than kBufferSize - 1
403 // chars. 404 // chars.
(...skipping 19 matching lines...) Expand all
423 // If the number has a decimal part, leave room for the period. 424 // If the number has a decimal part, leave room for the period.
424 if (decimal_pos > 0) result_size++; 425 if (decimal_pos > 0) result_size++;
425 // Allocate result and fill in the parts. 426 // Allocate result and fill in the parts.
426 SimpleStringBuilder builder(result_size + 1); 427 SimpleStringBuilder builder(result_size + 1);
427 builder.AddSubstring(integer_buffer + integer_pos + 1, integer_part_size); 428 builder.AddSubstring(integer_buffer + integer_pos + 1, integer_part_size);
428 if (decimal_pos > 0) builder.AddCharacter('.'); 429 if (decimal_pos > 0) builder.AddCharacter('.');
429 builder.AddSubstring(decimal_buffer, decimal_pos); 430 builder.AddSubstring(decimal_buffer, decimal_pos);
430 return builder.Finalize(); 431 return builder.Finalize();
431 } 432 }
432 433
433
434 static Mutex* dtoa_lock_one = OS::CreateMutex();
435 static Mutex* dtoa_lock_zero = OS::CreateMutex();
436
437
438 } } // namespace v8::internal 434 } } // namespace v8::internal
439
440
441 extern "C" {
442 void ACQUIRE_DTOA_LOCK(int n) {
443 ASSERT(n == 0 || n == 1);
444 (n == 0 ? v8::internal::dtoa_lock_zero : v8::internal::dtoa_lock_one)->Lock();
445 }
446
447
448 void FREE_DTOA_LOCK(int n) {
449 ASSERT(n == 0 || n == 1);
450 (n == 0 ? v8::internal::dtoa_lock_zero : v8::internal::dtoa_lock_one)->
451 Unlock();
452 }
453 }
OLDNEW
« no previous file with comments | « src/conversions.h ('k') | src/dtoa.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698