Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 7193041: [v8-dev] ARM: Fix a typo in KeyedStoreIC, restore Kraken performance. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4121 matching lines...) Expand 10 before | Expand all | Expand 10 after
4132 Register value_reg = r0; 4132 Register value_reg = r0;
4133 Register key_reg = r1; 4133 Register key_reg = r1;
4134 Register receiver_reg = r2; 4134 Register receiver_reg = r2;
4135 Register scratch = r3; 4135 Register scratch = r3;
4136 Register elements_reg = r4; 4136 Register elements_reg = r4;
4137 4137
4138 // This stub is meant to be tail-jumped to, the receiver must already 4138 // This stub is meant to be tail-jumped to, the receiver must already
4139 // have been verified by the caller to not be a smi. 4139 // have been verified by the caller to not be a smi.
4140 4140
4141 // Check that the key is a smi. 4141 // Check that the key is a smi.
4142 __ JumpIfNotSmi(r0, &miss_force_generic); 4142 __ JumpIfNotSmi(key_reg, &miss_force_generic);
4143 4143
4144 // Get the elements array and make sure it is a fast element array, not 'cow'. 4144 // Get the elements array and make sure it is a fast element array, not 'cow'.
4145 __ ldr(elements_reg, 4145 __ ldr(elements_reg,
4146 FieldMemOperand(receiver_reg, JSObject::kElementsOffset)); 4146 FieldMemOperand(receiver_reg, JSObject::kElementsOffset));
4147 __ CheckMap(elements_reg, 4147 __ CheckMap(elements_reg,
4148 scratch, 4148 scratch,
4149 Heap::kFixedArrayMapRootIndex, 4149 Heap::kFixedArrayMapRootIndex,
4150 &miss_force_generic, 4150 &miss_force_generic,
4151 DONT_DO_SMI_CHECK); 4151 DONT_DO_SMI_CHECK);
4152 4152
(...skipping 25 matching lines...) Expand all
4178 masm->isolate()->builtins()->KeyedStoreIC_MissForceGeneric(); 4178 masm->isolate()->builtins()->KeyedStoreIC_MissForceGeneric();
4179 __ Jump(ic, RelocInfo::CODE_TARGET); 4179 __ Jump(ic, RelocInfo::CODE_TARGET);
4180 } 4180 }
4181 4181
4182 4182
4183 #undef __ 4183 #undef __
4184 4184
4185 } } // namespace v8::internal 4185 } } // namespace v8::internal
4186 4186
4187 #endif // V8_TARGET_ARCH_ARM 4187 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698