Move UI specific implementation from ProfileSyncService to SyncSetupFlowHandler.

chrome/browser/ui/webui/options/sync_setup_handler.cc

Index: chrome/browser/ui/webui/options/sync_setup_handler.cc
diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.cc b/chrome/browser/ui/webui/options/sync_setup_handler.cc
index d4c0352233c9e8df78f7865dc2c17a72c2f75be7..3bb20f82054b96c493f2eb838ae39005cf64b1d9 100644
--- a/chrome/browser/ui/webui/options/sync_setup_handler.cc
+++ b/chrome/browser/ui/webui/options/sync_setup_handler.cc
@@ -11,6 +11,7 @@
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/sync_setup_flow.h"
+#include "chrome/browser/ui/browser_list.h"
 #include "chrome/common/url_constants.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "grit/chromium_strings.h"
@@ -332,6 +333,11 @@ void SyncSetupHandler::Focus() {
   static_cast<RenderViewHostDelegate*>(web_ui_->tab_contents())->Activate();
 }
 
+void SyncSetupHandler::ShowSyncSetup(Profile* profile) {

[Andrew T Wilson (Slow), 2011/07/11 18:12:51]

When you get rid of the Profile* parameter, you can get the profile from
web_ui_->GetProfile().

+  BrowserList::GetLastActiveWithProfile(profile)->ShowOptionsTab(
+      chrome::kSyncSetupSubPage);

[Andrew T Wilson (Slow), 2011/07/11 18:12:51]

csilv: Do we need to do anything else here to avoid the jank problem you ran
into, or is the code in SyncSetupWizard::ShowSyncSetup() that just calls Focus()
if the UI is already visible sufficient?

[qsr (NOT THE RIGHT qsr), 2011/07/12 07:01:37]

 Right now, I'm pretty sure I didn't change the behavior of anything. So it
should do exactly the same as before. If/When we start refactoring the flow,
then it would be necessary to review this.

+}
+
 void SyncSetupHandler::OnDidClosePage(const ListValue* args) {
   if (flow_) {
     flow_->OnDialogClosed(std::string());