Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 7193030: Revert 89453 - Support automatic javascript test registry in gtest when creating WebUI tests. (Closed)

Created:
9 years, 6 months ago by joth
Modified:
9 years, 6 months ago
Reviewers:
Sheridan Rawlins
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 89453 - Support automatic javascript test registry in gtest when creating WebUI tests. - gypv8sh.py is breaking on Mac http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20%281%29/builds/8563/steps/update/logs/stdio File "/b/build/slave/Mac10_5_Tests__1_/build/src/tools/gyp/pylib/gyp/input.py", line 1017, in ProcessVariablesAndConditionsInList expanded = ExpandVariables(item, is_late, variables, build_file) File "/b/build/slave/Mac10_5_Tests__1_/build/src/tools/gyp/pylib/gyp/input.py", line 684, in ExpandVariables (contents, p.returncode)) Exception: Call to 'python ../tools/gypv8sh.py -i' returned exit status 1. while loading dependencies of src/chrome/browser/sync/tools/sync_tools.gyp while loading dependencies of src/build/all.gyp while trying to load src/build/all.gyp Error: /System/Library/Frameworks/Python.framework/Versions/2.5/Resources/Python.app/Contents/MacOS/Python src/build/gyp_chromium in /b/build/slave/Mac10_5_Tests__1_/build returned 1 The goal was to support something as simple as the following, where the tests in the javascript files would be 1st class GTESTs, supporting FLAKY_, DISABLED_, etc, and registered at linker_initialization time. WEB_UI_BROWSER_TEST_JS(WebUIBrowserTest, TestJSPass, FILE_PATH_LITERAL("sample_passing.js")) { ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL)); } WEB_UI_BROWSER_TEST_JS_FALSE(WebUIBrowserTest, TestJSFail, FILE_PATH_LITERAL("sample_failing.js")) { ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL)); } http://www.chromium.org/Home/domui-testing In order to support linker init time, I had to modify path_service to support Unregistration, and chrome_paths to allow multiple invocations. BUG=82437 R=estade@chromium.org,jhawkins@chromium.org TEST=browser_tests --gtest_filter=WebUIBrowserTest* Review URL: http://codereview.chromium.org/7087014 TBR=scr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -161 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 3 chunks +3 lines, -45 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -21 lines 0 comments Download
D chrome/test/data/webui/sample_pass.js View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gypv8sh.py View 1 chunk +0 lines, -74 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
joth
9 years, 6 months ago (2011-06-17 08:34:23 UTC) #1
joth
9 years, 6 months ago (2011-06-17 08:34:44 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698