Issue 7193011: d8 drops into a shell if no files are passed on command line

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7193011: d8 drops into a shell if no files are passed on command line (Closed)

Created:
9 years, 6 months ago by wingo

Modified:
9 years, 6 months ago

Reviewers:
Yang, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

d8 drops into a shell if no files are passed on command line Fixes regression introduced in r8241. BUG= TEST=Run ./d8 --print_code -- should drop into shell. Committed: http://code.google.com/p/v8/source/detail?r=8378

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	src/d8.cc	View		3 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

Changing CC from chromium-reviews to v8-dev.

9 years, 6 months ago (2011-06-21 14:20:49 UTC) #2

Yang

On 2011/06/21 14:20:49, Mads Ager wrote: > Changing CC from chromium-reviews to v8-dev. Can't we ...

9 years, 6 months ago (2011-06-21 16:12:25 UTC) #3

wingo

9 years, 6 months ago (2011-06-22 08:20:04 UTC) #4

On 2011/06/21 16:12:25, yangguo wrote:
> Can't we use one flag (FLAG_run_shell) instead of having two flags indicating
> basically the same thing? I suggest getting rid of run_shell altogether and
just
> keep using FLAG_run_shell.
> 
> Other than that, LGTM.

Well, you need to check for --shell *or* for lack of non-option arguments. 
Hence the two variables.

I agree that it's not the best situation, but d8.cc has gotten quite crufty. 
I'm happy to poke at it, but a larger refactor would take more feedback, and
fixing the shell probably takes priority, no?

In any case I am not a committer, so the next step is not up to me :)

Thanks for the review,

Andy

Expand Messages | Collapse Messages