Issue 7193003: Revert 89298 - Update BuiltinProvider to provide chrome:// URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7193003: Revert 89298 - Update BuiltinProvider to provide chrome:// URLs. (Closed)

Created:
9 years, 6 months ago by msw

Modified:
9 years, 6 months ago

Reviewers:
msw

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 89298 - Update BuiltinProvider to provide chrome:// URLs. Provide common URLs as users start typing "about://" or "chrome://". Highlight matching input (including "chrome://" for "about:" input). Support settings sub-pages/paths, e.g. "chrome://settings/foo". Add BuiltinProviderTest unit test. Additional hosts will be added when I fix crbug.com/73926. BUG=55771 TEST=Get chrome:// AutocompleteProvider URLs in the omnibox dropdown. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89073 Review URL: http://codereview.chromium.org/6995096 TBR=msw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89299

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -335 lines)			Patch
M	chrome/browser/autocomplete/builtin_provider.h	View	3 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/autocomplete/builtin_provider.cc	View	3 chunks	+18 lines, -89 lines	0 comments	Download
D	chrome/browser/autocomplete/builtin_provider_unittest.cc	View	1 chunk	+0 lines, -231 lines	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/url_constants.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/url_constants.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/canvas.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)