content/renderer/media/webrtc_external_renderer.h - Issue 7193001: Move rtc_video_decoder* from media/filter/ to content/renderer/media/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/media/webrtc_external_renderer.h

Issue 7193001: Move rtc_video_decoder* from media/filter/ to content/renderer/media/. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_RENDERER_MEDIA_WEBRTC_EXTERNAL_RENDERER_H_

	6 #define CONTENT_RENDERER_MEDIA_WEBRTC_EXTERNAL_RENDERER_H_

	7

	8 // TODO(ronghuawu) ExternalRenderer should be replaced by

	9 // cricket::VideoRenderer from libjingle

	10 class ExternalRenderer {
	scherkus (not reviewing) 2011/06/29 00:39:28 filename should match class name, so either: 1) filename should match class name, so either: 1) Rename class to WebRTCExternalRenderer 2) Rename file to external_renderer.h Ronghua 2011/06/29 20:36:39 Done. Show quoted text On 2011/06/29 00:39:28, scherkus wrote: > filename should match class name, so either: > 1) Rename class to WebRTCExternalRenderer > 2) Rename file to external_renderer.h Done.
	11 public:

	12 virtual int FrameSizeChange(unsigned int width,

	13 unsigned int height,

	14 unsigned int number_of_streams) = 0;

	15 virtual int DeliverFrame(unsigned char* buffer, int buffer_size) = 0;

	16

	17 protected:

	18 virtual ~ExternalRenderer() {}

	19 };

	20

	21 #endif // CONTENT_RENDERER_MEDIA_WEBRTC_EXTERNAL_RENDERER_H_

	22
	scherkus (not reviewing) 2011/06/29 00:39:28 nit: blank line nit: blank line Ronghua 2011/06/29 20:36:39 Done. Show quoted text On 2011/06/29 00:39:28, scherkus wrote: > nit: blank line Done.
OLD	NEW