Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: chrome/browser/download/download_history.h

Issue 7192016: chrome.experimental.downloads (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: merged db_handle, id; onCreated, onErased Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_file_manager.cc ('k') | chrome/browser/download/download_history.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_history.h
diff --git a/chrome/browser/download/download_history.h b/chrome/browser/download/download_history.h
index f4b48812137e7d34848e623cb39fb957f81e3e1d..8455f4b574985df96280f1e5e46b7b1b646d381b 100644
--- a/chrome/browser/download/download_history.h
+++ b/chrome/browser/download/download_history.h
@@ -24,10 +24,6 @@ class DownloadHistory {
public:
typedef Callback2<int32, bool>::Type VisitedBeforeDoneCallback;
- // A fake download table ID which represents a download that has started,
- // but is not yet in the table.
- static const int kUninitializedHandle;
-
explicit DownloadHistory(Profile* profile);
~DownloadHistory();
@@ -58,9 +54,6 @@ class DownloadHistory {
void RemoveEntriesBetween(const base::Time remove_begin,
const base::Time remove_end);
- // Returns a new unique database handle which will not collide with real ones.
- int64 GetNextFakeDbHandle();
-
private:
typedef std::map<HistoryService::Handle,
std::pair<int32, VisitedBeforeDoneCallback*> >
@@ -73,12 +66,6 @@ class DownloadHistory {
Profile* profile_;
- // In case we don't have a valid db_handle, we use |fake_db_handle_| instead.
- // This is useful for incognito mode or when the history database is offline.
- // Downloads are expected to have unique handles, so we decrement the next
- // fake handle value on every use.
- int64 next_fake_db_handle_;
-
CancelableRequestConsumer history_consumer_;
// The outstanding requests made by CheckVisitedReferrerBefore().
« no previous file with comments | « chrome/browser/download/download_file_manager.cc ('k') | chrome/browser/download/download_history.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698