Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 7191025: Fixed warning from Core Graphics related to zero-width or zero-height (Closed)

Created:
9 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, Mark Mentovai, Satish
Visibility:
Public.

Description

Fixed warning from Core Graphics related to zero-width or zero-height IOSurfaces and textures by forcing the IOSurface and its associated texture to have a minimum width and height of 1. Lie to callers about this fact since such accelerated surfaces' contents will never be displayed to the screen. Tested with Gmail; no more warnings. Also tested YouTube with both Flash and HTML5 videos. BUG=86326 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M ui/gfx/surface/accelerated_surface_mac.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/gfx/surface/accelerated_surface_mac.cc View 10 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
9 years, 6 months ago (2011-06-16 20:57:16 UTC) #1
Nico
9 years, 6 months ago (2011-06-16 21:01:03 UTC) #2
LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698