src/arm/macro-assembler-arm.cc - Issue 7191007: Cleanup: use JumpIf[Not]Smi() whenever we can

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/macro-assembler-arm.cc

Issue 7191007: Cleanup: use JumpIf[Not]Smi() whenever we can (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/macro-assembler-arm.cc

diff --git a/src/arm/macro-assembler-arm.cc b/src/arm/macro-assembler-arm.cc

index ea498128974160055667a98828388cbaaaad195b..a44f862c66c2ed3bbd2c2c1c625e6086df20cf6b 100644

--- a/src/arm/macro-assembler-arm.cc

+++ b/src/arm/macro-assembler-arm.cc

@@ -2692,8 +2692,7 @@ void MacroAssembler::JumpIfNotBothSequentialAsciiStrings(Register first,

// Check that neither is a smi.

STATIC_ASSERT(kSmiTag == 0);

and_(scratch1, first, Operand(second));

- tst(scratch1, Operand(kSmiTagMask));

- b(eq, failure);

+ JumpIfSmi(scratch1, failure);

JumpIfNonSmisNotBothSequentialAsciiStrings(first,

second,

scratch1,