Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3041)

Unified Diff: base/linux_util.h

Issue 7190019: Always search TIDs for the crashing processes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/linux_util.cc » ('j') | base/linux_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/linux_util.h
===================================================================
--- base/linux_util.h (revision 88621)
+++ base/linux_util.h (working copy)
@@ -37,9 +37,11 @@
// For a given process |pid|, look through all its threads and find the first
// thread with /proc/[pid]/task/[thread_id]/syscall whose first N bytes matches
// |expected_data|, where N is the length of |expected_data|.
-// Returns the thread id or -1 on error.
+// Returns the thread id or -1 on error. If |syscall_supported| is
+// set to false the kernel does not support syscall in procfs.
Mark Mentovai 2011/06/21 00:11:24 You should comment that syscall_supported must be
kmixter1 2011/06/21 00:55:33 Done. Handling when it's NULL.
BASE_API pid_t FindThreadIDWithSyscall(pid_t pid,
- const std::string& expected_data);
+ const std::string& expected_data,
+ bool* syscall_supported);
} // namespace base
« no previous file with comments | « no previous file | base/linux_util.cc » ('j') | base/linux_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698