chrome/browser/sync/engine/process_updates_command.cc - Issue 7190001: [Sync] Split DirectoryChangeListener for thread-safety

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/process_updates_command.cc

Issue 7190001: [Sync] Split DirectoryChangeListener for thread-safety (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix copyright Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/engine/process_updates_command.cc

diff --git a/chrome/browser/sync/engine/process_updates_command.cc b/chrome/browser/sync/engine/process_updates_command.cc

index 5cae263764a4a1838dcef5fce87c3dd3d2f5391b..f11db79d374bdfd9969b078501ecc7b76af8dd1a 100644

--- a/chrome/browser/sync/engine/process_updates_command.cc

+++ b/chrome/browser/sync/engine/process_updates_command.cc

@@ -7,6 +7,7 @@

#include <vector>

#include "base/basictypes.h"

+#include "base/tracked.h"

#include "chrome/browser/sync/engine/syncer.h"

#include "chrome/browser/sync/engine/syncer_proto_util.h"

#include "chrome/browser/sync/engine/syncer_util.h"

@@ -97,7 +98,7 @@ ServerUpdateProcessingResult ProcessUpdatesCommand::ProcessUpdate(

syncable::Id server_id = update.id();

const std::string name = SyncerProtoUtil::NameFromSyncEntity(update);

- syncable::WriteTransaction trans(dir, syncable::SYNCER, __FILE__, __LINE__);

+ syncable::WriteTransaction trans(dir, syncable::SYNCER, FROM_HERE);

// Look to see if there's a local item that should recieve this update,

// maybe due to a duplicate client tag or a lost commit response.