chrome/browser/sync/engine/apply_updates_command.cc - Issue 7190001: [Sync] Split DirectoryChangeListener for thread-safety

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/apply_updates_command.cc

Issue 7190001: [Sync] Split DirectoryChangeListener for thread-safety (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix copyright Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/engine/apply_updates_command.cc

diff --git a/chrome/browser/sync/engine/apply_updates_command.cc b/chrome/browser/sync/engine/apply_updates_command.cc

index 5f98a67b007fbd01f7baa07d883d2466d94b1a59..670e171959dc7f144accebd6a212e8754fc2404d 100644

--- a/chrome/browser/sync/engine/apply_updates_command.cc

+++ b/chrome/browser/sync/engine/apply_updates_command.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/sync/engine/apply_updates_command.h"

+#include "base/tracked.h"

#include "chrome/browser/sync/engine/update_applicator.h"

#include "chrome/browser/sync/sessions/sync_session.h"

#include "chrome/browser/sync/syncable/directory_manager.h"

@@ -23,7 +24,7 @@ void ApplyUpdatesCommand::ModelChangingExecuteImpl(SyncSession* session) {

LOG(ERROR) << "Scoped dir lookup failed!";

return;

}

- syncable::WriteTransaction trans(dir, syncable::SYNCER, __FILE__, __LINE__);

+ syncable::WriteTransaction trans(dir, syncable::SYNCER, FROM_HERE);

syncable::Directory::UnappliedUpdateMetaHandles handles;

dir->GetUnappliedUpdateMetaHandles(&trans, &handles);