Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host.h

Issue 7189074: Send the referral URL with the client-side phishing detection request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Brian's comments. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/client_side_detection_host.h
diff --git a/chrome/browser/safe_browsing/client_side_detection_host.h b/chrome/browser/safe_browsing/client_side_detection_host.h
index fbe1cd60721ba81d0f23fe91d7c7bf51fa57fab8..2c70eb421e71742f43fec34e070ff21c1113fb83 100644
--- a/chrome/browser/safe_browsing/client_side_detection_host.h
+++ b/chrome/browser/safe_browsing/client_side_detection_host.h
@@ -10,6 +10,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_callback_factory.h"
#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/safe_browsing/browser_feature_extractor.h"
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
#include "content/browser/tab_contents/tab_contents_observer.h"
#include "googleurl/src/gurl.h"
@@ -17,7 +18,6 @@
class TabContents;
namespace safe_browsing {
-class BrowserFeatureExtractor;
class ClientPhishingRequest;
class ClientSideDetectionService;
@@ -84,6 +84,11 @@ class ClientSideDetectionHost : public TabContentsObserver {
scoped_refptr<ShouldClassifyUrlRequest> classification_request_;
// Browser-side feature extractor.
scoped_ptr<BrowserFeatureExtractor> feature_extractor_;
+ // Keeps some info about the current page visit while the renderer
+ // classification is going on. Since we cancel classification on
+ // every page load we can simply keep this data around as a member
+ // variable. This information will be passed on to the feature extractor.
+ scoped_ptr<BrowseInfo> browse_info_;
base::ScopedCallbackFactory<ClientSideDetectionHost> cb_factory_;

Powered by Google App Engine
This is Rietveld 408576698